Re: Review Request 14360: Make getName() match the constant names for Network Capability, and Service

2013-09-28 Thread Darren Shepherd
> On Sept. 27, 2013, 8:21 p.m., Alena Prokharchyk wrote: > > Darren, changes in Network.java are going to break API compatibility as > > capabilities parameters are used in createNetworkOffering API call > > (serviceCapabilitystList param). CS UI and third party UI will get impacted > > as wel

Re: Review Request 14360: Make getName() match the constant names for Network Capability, and Service

2013-09-28 Thread Alena Prokharchyk
> On Sept. 27, 2013, 8:21 p.m., Alena Prokharchyk wrote: > > Darren, changes in Network.java are going to break API compatibility as > > capabilities parameters are used in createNetworkOffering API call > > (serviceCapabilitystList param). CS UI and third party UI will get impacted > > as wel

Re: Review Request 14360: Make getName() match the constant names for Network Capability, and Service

2013-09-28 Thread Darren Shepherd
I discarded the patch. The purpose of throwing it up on review board was so that people could comment on the impact. And the impact is bad. Darren > On Sep 28, 2013, at 4:43 AM, "daan Hoogland" wrote: > > > This is an automatically generated e-mail. To reply, visit: > https://reviews.apa

Re: Review Request 14360: Make getName() match the constant names for Network Capability, and Service

2013-09-28 Thread daan Hoogland
> On Sept. 27, 2013, 8:21 p.m., Alena Prokharchyk wrote: > > Darren, changes in Network.java are going to break API compatibility as > > capabilities parameters are used in createNetworkOffering API call > > (serviceCapabilitystList param). CS UI and third party UI will get impacted > > as wel

Re: Review Request 14360: Make getName() match the constant names for Network Capability, and Service

2013-09-27 Thread Alena Prokharchyk
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14360/#review26447 --- Darren, changes in Network.java are going to break API compatibility

Review Request 14360: Make getName() match the constant names for Network Capability, and Service

2013-09-27 Thread Darren Shepherd
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14360/ --- Review request for cloudstack, Alena Prokharchyk and Chiradeep Vittal. Reposito