Re: Review Request 14976: [SSL Termination support] Part2 : Assign certificates to LBs

2013-11-08 Thread Murali Reddy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14976/#review28533 --- Ship it! commit 0076307863e9155273d9e4c14282de429388c9e9 Author: Sy

Re: Review Request 14976: [SSL Termination support] Part2 : Assign certificates to LBs

2013-11-06 Thread Syed Ahmed
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14976/ --- (Updated Nov. 6, 2013, 8:15 p.m.) Review request for cloudstack, Darren Shepher

Re: Review Request 14976: [SSL Termination support] Part2 : Assign certificates to LBs

2013-11-06 Thread Syed Ahmed
On 13-11-06 12:18 PM, Murali Reddy wrote: On 06/11/13 12:40 AM, "Syed Ahmed" wrote: On Nov. 5, 2013, 9:43 a.m., Murali Reddy wrote: api/src/com/cloud/network/lb/LoadBalancingRule.java, lines 42-43 can you plea

Re: Review Request 14976: [SSL Termination support] Part2 : Assign certificates to LBs

2013-11-06 Thread Murali Reddy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14976/#review28273 --- patch does not apply on master. please rebase with latest master and

Re: Review Request 14976: [SSL Termination support] Part2 : Assign certificates to LBs

2013-11-06 Thread Murali Reddy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14976/#review28272 --- patch does not apply on master. please rebase with latest master and

Re: Review Request 14976: [SSL Termination support] Part2 : Assign certificates to LBs

2013-11-06 Thread Murali Reddy
On 06/11/13 12:40 AM, "Syed Ahmed" wrote: > > >> On Nov. 5, 2013, 9:43 a.m., Murali Reddy wrote: >> > api/src/com/cloud/network/lb/LoadBalancingRule.java, lines 42-43 >> > >> >> > >> > can you please add new constructor

Re: Review Request 14976: [SSL Termination support] Part2 : Assign certificates to LBs

2013-11-05 Thread Syed Ahmed
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14976/ --- (Updated Nov. 6, 2013, 12:54 a.m.) Review request for cloudstack, Darren Shephe

Re: Review Request 14976: [SSL Termination support] Part2 : Assign certificates to LBs

2013-11-05 Thread Syed Ahmed
> On Nov. 5, 2013, 9:43 a.m., Murali Reddy wrote: > > api/src/com/cloud/network/lb/LoadBalancingRule.java, lines 42-43 > > > > > > can you please add new constructors which takes ssl cert and protocol. > > If we extend

Re: Review Request 14976: [SSL Termination support] Part2 : Assign certificates to LBs

2013-11-05 Thread Syed Ahmed
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14976/ --- (Updated Nov. 5, 2013, 7:10 p.m.) Review request for cloudstack, Darren Shepher

Re: Review Request 14976: [SSL Termination support] Part2 : Assign certificates to LBs

2013-11-05 Thread Murali Reddy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14976/#review28176 --- api/src/com/cloud/event/EventTypes.java

Re: Review Request 14976: [SSL Termination support] Part2 : Assign certificates to LBs

2013-10-30 Thread Syed Ahmed
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14976/ --- (Updated Oct. 30, 2013, 8:34 p.m.) Review request for cloudstack, Darren Shephe

Review Request 14976: [SSL Termination support] Part2 : Assign certificates to LBs

2013-10-30 Thread Syed Ahmed
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14976/ --- Review request for cloudstack, Darren Shepherd, Murali Reddy, and Sheng Yang. B