Re: Review Request 15832: enable custom offering support for scalevm

2013-11-29 Thread Koushik Das
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15832/#review29557 --- Ship it! master - 68406ba29d7dc31dcfd9ef2cefc673ff32cfa514 -

Re: Review Request 15832: enable custom offering support for scalevm

2013-11-29 Thread bharat kumar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15832/ --- (Updated Nov. 29, 2013, 12:35 p.m.) Review request for cloudstack and Koushik

Re: Review Request 15832: enable custom offering support for scalevm

2013-11-29 Thread Koushik Das
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15832/#review29558 --- Ship it! 4.3 - 72e03546619f50fa24abc372eb35438ef02713f8 - Koushik

Re: Review Request 15832: enable custom offering support for scalevm

2013-11-28 Thread bharat kumar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15832/ --- (Updated Nov. 28, 2013, 10:29 a.m.) Review request for cloudstack and Koushik

Re: Review Request 15832: enable custom offering support for scalevm

2013-11-28 Thread bharat kumar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15832/ --- (Updated Nov. 29, 2013, 5:09 a.m.) Review request for cloudstack and Koushik

Re: Review Request 15832: enable custom offering support for scalevm

2013-11-28 Thread bharat kumar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15832/ --- (Updated Nov. 29, 2013, 7:46 a.m.) Review request for cloudstack and Koushik

Re: Review Request 15832: enable custom offering support for scalevm

2013-11-27 Thread bharat kumar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15832/ --- (Updated Nov. 27, 2013, 9:33 a.m.) Review request for cloudstack and Koushik

Re: Review Request 15832: enable custom offering support for scalevm

2013-11-27 Thread bharat kumar
On Nov. 26, 2013, 6:27 p.m., Nitin Mehta wrote: api/src/org/apache/cloudstack/api/command/admin/systemvm/UpgradeSystemVMCmd.java, line 63 https://reviews.apache.org/r/15832/diff/3/?file=391144#file391144line63 All this is boilerplate code. Have an abstract class and make all

Re: Review Request 15832: enable custom offering support for scalevm

2013-11-27 Thread Koushik Das
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15832/#review29479 --- engine/schema/src/com/cloud/usage/UsageVMInstanceVO.java

Re: Review Request 15832: enable custom offering support for scalevm

2013-11-27 Thread bharat kumar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15832/ --- (Updated Nov. 28, 2013, 2:04 a.m.) Review request for cloudstack and Koushik

Re: Review Request 15832: enable custom offering support for scalevm

2013-11-27 Thread bharat kumar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15832/ --- (Updated Nov. 28, 2013, 2:26 a.m.) Review request for cloudstack and Koushik

Re: Review Request 15832: enable custom offering support for scalevm

2013-11-27 Thread bharat kumar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15832/ --- (Updated Nov. 28, 2013, 6:18 a.m.) Review request for cloudstack and Koushik

Re: Review Request 15832: enable custom offering support for scalevm

2013-11-26 Thread bharat kumar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15832/ --- (Updated Nov. 26, 2013, 11:37 a.m.) Review request for cloudstack and Koushik

Re: Review Request 15832: enable custom offering support for scalevm

2013-11-26 Thread bharat kumar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15832/ --- (Updated Nov. 26, 2013, 11:38 a.m.) Review request for cloudstack and Koushik

Re: Review Request 15832: enable custom offering support for scalevm

2013-11-26 Thread Nitin Mehta
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15832/#review29445 ---

Review Request 15832: enable custom offering support for scalevm

2013-11-25 Thread bharat kumar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15832/ --- Review request for cloudstack and Koushik Das. Bugs: CLOUDSTACK-5161