---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17888/
---
(Updated March 7, 2014, 3:38 p.m.)
Review request for cloudstack, Alena
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17888/
---
(Updated March 7, 2014, 3:41 p.m.)
Review request for cloudstack, Alena
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17888/
---
(Updated March 7, 2014, 3:45 p.m.)
Review request for cloudstack, Alena
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17888/
---
(Updated March 7, 2014, 3:59 p.m.)
Review request for cloudstack, Alena
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17888/
---
(Updated March 6, 2014, 4:36 p.m.)
Review request for cloudstack, Alena
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17888/
---
(Updated March 5, 2014, 10:29 a.m.)
Review request for cloudstack, Alena
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17888/
---
(Updated March 5, 2014, 10:35 a.m.)
Review request for cloudstack, Alena
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17888/#review36300
---
Fails to apply on the latest master :(
alena@Alenas-MacBook-Air:
Alena, I saw it, at first I thought it would be a problem in a certain cmd
and then I saw it's the same for all of them. Actually Cmd#getCommandName()
should give us what we want here, the command name, right? Why are we
returning the cmdNameResponse instead?
On top of that, if we continue this
Antonio, I don¹t have a history about why we return cmdNameResponse
instead of returning actual command name. We might change the method name
in the future.
And yes, please go ahead and create a new method in BaseCmd.
-Alena.
On 3/4/14, 1:02 AM, Antonio Fornié Casarrubios
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17888/
---
(Updated March 3, 2014, 9:01 a.m.)
Review request for cloudstack, Alena
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17888/#review36049
---
Dario, the patch fails to apply on the latest master, again some
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17888/
---
(Updated March 3, 2014, 11:26 p.m.)
Review request for cloudstack, Alena
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17888/#review36052
---
Getting compilation error after applying the latest:
[ERROR]
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17888/
---
(Updated March 4, 2014, 12:18 a.m.)
Review request for cloudstack, Alena
Fixed. Applied and mvn build works completely
2014-03-04 0:37 GMT+01:00 Alena Prokharchyk alena.prokharc...@citrix.com:
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17888/
Getting compilation error after applying the latest:
[ERROR] Failed to
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17888/#review36068
---
Antonio, when you log the WARN about incorrect param name, can you
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17888/
---
(Updated Feb. 28, 2014, 9:29 a.m.)
Review request for cloudstack, Alena
: dev@cloudstack.apache.org dev@cloudstack.apache.org, daan
Hoogland daan.hoogl...@gmail.com, Hugo Trippaers
htrippa...@schubergphilis.com
Subject: Re: Review Request 17888: Dispatcher corrections, refactoring
and tests. Corrects problems from previous attempt
Hi Alena,
Answer inline
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17888/
---
(Updated Feb. 28, 2014, 11 a.m.)
Review request for cloudstack, Alena
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17888/#review35808
---
Antonio, tested the patch, saw this warning for Async command:
Trippaers
htrippa...@schubergphilis.com
Subject: Re: Review Request 17888: Dispatcher corrections, refactoring
and tests. Corrects problems from previous attempt
Hi Alena,
Answer inline:
2014-02-26 22:24 GMT+01:00 Alena Prokharchyk
alena.prokharc...@citrix.com
:
Antonio, please see my 2
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17888/
---
(Updated Feb. 26, 2014, 9:12 a.m.)
Review request for cloudstack, Alena
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17888/#review35542
---
Antonio, in general looks good to me. There are some minor fixes
Hi Alena,
I answer to your comments inline:
2014-02-26 19:08 GMT+01:00 Alena Prokharchyk alena.prokharc...@citrix.com:
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17888/
Antonio, in general looks good to me. There are some minor fixes that
Antonio, please see my 2 comments inline.
-Alena.
On 2/26/14, 1:17 PM, Antonio Fornié Casarrubios
antonio.for...@gmail.com wrote:
Hi Alena,
I answer to your comments inline:
2014-02-26 19:08 GMT+01:00 Alena Prokharchyk
alena.prokharc...@citrix.com:
This is an automatically generated
Request 17888: Dispatcher corrections, refactoring and
tests. Corrects problems from previous attempt
Hi Alena,
Answer inline:
2014-02-26 22:24 GMT+01:00 Alena Prokharchyk
alena.prokharc...@citrix.commailto:alena.prokharc...@citrix.com:
Antonio, please see my 2 comments inline.
-Alena.
On 2/26
Prokharchyk alena.prokharc...@citrix.com
Cc: dev@cloudstack.apache.org dev@cloudstack.apache.org, daan
Hoogland daan.hoogl...@gmail.com, Hugo Trippaers
htrippa...@schubergphilis.com
Subject: Re: Review Request 17888: Dispatcher corrections, refactoring
and tests. Corrects problems from previous
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17888/#review35466
---
Also please change the level of the log from WARN to DEBUG. When
Hi Alena,
Thanks for the review and comments.
We expect two kinds of parameters:
1. Generic parameters as you mention. I include several already (command,
sessionKey, domain...), but I assumed I could be missing some. I will add
the ones you mention and I will appreciate if other people can also
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17888/
---
(Updated Feb. 25, 2014, 12:11 p.m.)
Review request for cloudstack, Alena
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17888/#review35465
---
Antonio, I see a lot of following statements in the log:
WARN
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17888/
---
(Updated Feb. 18, 2014, 9:04 a.m.)
Review request for cloudstack, Alena
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17888/
---
(Updated Feb. 17, 2014, 11:45 p.m.)
Review request for cloudstack, Alena
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17888/
---
(Updated Feb. 11, 2014, 2:44 p.m.)
Review request for cloudstack, Alena
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17888/
---
Review request for cloudstack, daan Hoogland and Hugo Trippaers.
Repository:
36 matches
Mail list logo
