Re: Review Request 28049: CLOUDSTACK-7917: Load Balancer Rule is not validated when updating LB

2014-11-25 Thread Rajani Karuturi
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28049/#review62950 --- Ship it! Ship It! - Rajani Karuturi On Nov. 24, 2014, 4:23

Re: Review Request 28049: CLOUDSTACK-7917: Load Balancer Rule is not validated when updating LB

2014-11-25 Thread Rajani Karuturi
On Nov. 25, 2014, 8:14 a.m., Rajani Karuturi wrote: Ship It! Thanks for adding tests. pushed to 4.5 c919ff83d81528b89017b5f5731b2e46350e3dfa will merge to master as well. - Rajani --- This is an automatically generated e-mail. To

Re: Review Request 28049: CLOUDSTACK-7917: Load Balancer Rule is not validated when updating LB

2014-11-25 Thread Rajani Karuturi
On Nov. 25, 2014, 8:14 a.m., Rajani Karuturi wrote: Ship It! Rajani Karuturi wrote: Thanks for adding tests. pushed to 4.5 c919ff83d81528b89017b5f5731b2e46350e3dfa will merge to master as well. master 02ca6f2e5b7d8ffdc917ed09d8600c38e668ea17 - Rajani

Re: Review Request 28049: CLOUDSTACK-7917: Load Balancer Rule is not validated when updating LB

2014-11-25 Thread Daniel Vega Simoes
On Nov. 25, 2014, 8:14 a.m., Rajani Karuturi wrote: Ship It! Rajani Karuturi wrote: Thanks for adding tests. pushed to 4.5 c919ff83d81528b89017b5f5731b2e46350e3dfa will merge to master as well. Rajani Karuturi wrote: master 02ca6f2e5b7d8ffdc917ed09d8600c38e668ea17

Re: Review Request 28049: CLOUDSTACK-7917: Load Balancer Rule is not validated when updating LB

2014-11-24 Thread Daniel Vega Simoes
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28049/ --- (Updated Nov. 24, 2014, 4:23 p.m.) Review request for cloudstack. Changes

Review Request 28049: CLOUDSTACK-7917: Load Balancer Rule is not validated when updating LB

2014-11-14 Thread Daniel Vega Simoes
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28049/ --- Review request for cloudstack. Repository: cloudstack-git Description

Re: Review Request 28049: CLOUDSTACK-7917: Load Balancer Rule is not validated when updating LB

2014-11-14 Thread Daniel Vega Simoes
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28049/ --- (Updated Nov. 14, 2014, 7:42 p.m.) Review request for cloudstack.

Re: Review Request 28049: CLOUDSTACK-7917: Load Balancer Rule is not validated when updating LB

2014-11-14 Thread Rajani Karuturi
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28049/#review61631 --- Can you please update the testing section? probably a new test case