Re: JXTG: invoke macro by name from expression

2004-12-09 Thread Leszek Gawron
Antonio Gallardo wrote: On Mie, 8 de Diciembre de 2004, 15:17, Conal Tuohy dijo: Leszek Gawron wrote: Though I would suggest jx:call-macro name=fooBar/ which would make it clear that the attribute is the NAME of the macro to be invoked, rather than the macro itself. +1 here. But please keep in

Re: JXTG: invoke macro by name from expression

2004-12-09 Thread Daniel Fagerstrom
Leszek Gawron wrote: snip/ That's good. If noone objects I will start tomorrow and hopefully commit tomorrow. I have not had time to evalute your proposal in detail, but from a first look it seem good, so please go ahead. The syntax you proposed for invocation: jx:invoke

Re: JXTG: invoke macro by name from expression

2004-12-09 Thread Leszek Gawron
Daniel Fagerstrom wrote: Leszek Gawron wrote: snip/ That's good. If noone objects I will start tomorrow and hopefully commit tomorrow. I have not had time to evalute your proposal in detail, but from a first look it seem good, so please go ahead. The syntax you proposed for invocation:

Re: JXTG: invoke macro by name from expression

2004-12-09 Thread Leszek Gawron
Leszek Gawron wrote: Daniel Fagerstrom wrote: Leszek Gawron wrote: snip/ That's good. If noone objects I will start tomorrow and hopefully commit tomorrow. I have not had time to evalute your proposal in detail, but from a first look it seem good, so please go ahead. The syntax you proposed

Re: JXTG: invoke macro by name from expression

2004-12-09 Thread Antonio Gallardo
On Jue, 9 de Diciembre de 2004, 3:01, Leszek Gawron dijo: If you already have something I should not commit - maybe I would send you the source via email so you could use it if you wanted? http://www.apache.org/~lgawron/jxtg-20041209.zip Wasn't that hard with eclipse. Still took 4 hours so

Re: JXTG: invoke macro by name from expression

2004-12-09 Thread Leszek Gawron
Antonio Gallardo wrote: On Jue, 9 de Diciembre de 2004, 3:01, Leszek Gawron dijo: If you already have something I should not commit - maybe I would send you the source via email so you could use it if you wanted? http://www.apache.org/~lgawron/jxtg-20041209.zip Wasn't that hard with eclipse. Still

[RFC] JXTG Refactoring (was: JXTG: invoke macro by name from expression)

2004-12-09 Thread Daniel Fagerstrom
Leszek and I have started refactoring JXTG, by breaking it up in its subclasses. Later we will work on creating more detailed interfaces between the different parts and all the other stuff that has been discussed on the list. Now the question is: where should this work take place? For the

Re: JXTG: invoke macro by name from expression

2004-12-09 Thread Daniel Fagerstrom
Leszek Gawron wrote: Daniel Fagerstrom wrote: snip/ syntax instead. So that it can work together with common XML tools, if people want to use such. That would be good but looks like a bigger change while current macro call is done via macroName param1=value param2=value/ so I would reuse

JXTG: invoke macro by name from expression

2004-12-08 Thread Leszek Gawron
I would like to add one feature to JXTG that would allow not to promote hacks like [1]. Example: jx:macro name=fooBar somecontent/some /jx:macro you can only invoke it by fooBar/ If I were able to do jx:invoke macro=fooBar/ I would be able to pass macro name as a parameter to other macro

RE: JXTG: invoke macro by name from expression

2004-12-08 Thread Conal Tuohy
Leszek Gawron wrote: I would like to add one feature to JXTG that would allow not to promote hacks like [1]. Example: jx:macro name=fooBar somecontent/some /jx:macro you can only invoke it by fooBar/ If I were able to do jx:invoke macro=fooBar/ I would be able to pass macro

Re: JXTG: invoke macro by name from expression

2004-12-08 Thread Leszek Gawron
Conal Tuohy wrote: Leszek Gawron wrote: I would like to add one feature to JXTG that would allow not to promote hacks like [1]. Example: jx:macro name=fooBar somecontent/some /jx:macro you can only invoke it by fooBar/ If I were able to do jx:invoke macro=fooBar/ I would be able to pass

RE: JXTG: invoke macro by name from expression

2004-12-08 Thread Antonio Gallardo
On Mie, 8 de Diciembre de 2004, 15:17, Conal Tuohy dijo: Leszek Gawron wrote: Though I would suggest jx:call-macro name=fooBar/ which would make it clear that the attribute is the NAME of the macro to be invoked, rather than the macro itself. +1 here. But please keep in mind we need still

Re: JXTG: invoke macro by name from expression

2004-12-08 Thread Glen Ezkovich
On Dec 8, 2004, at 3:04 PM, Leszek Gawron wrote: I would like to add one feature to JXTG that would allow not to promote hacks like [1]. Example: jx:macro name=fooBar somecontent/some /jx:macro you can only invoke it by fooBar/ If I were able to do jx:invoke macro=fooBar/ I would be able to