Patch for review

Hi, Can someone please take a look at the patch uploaded for https://issues.apache.org/jira/browse/LANG-1061 I made the changes as discussed on the jira and updated the unit tests. Thanks, Shweta

Jenkins build is still unstable: Commons Math #29

See - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org

Re: [MATH] Jenkins unit test failure

I did several tests by adding additional console output. The build was always running on H11 and sometimes it was working, while in other cases not. Inspecting the byte code did not show anything unusual, it looks correct. Maybe it is related to jacoco, as it adds a javaagent which manipulates byt

Re: [MATH] Jenkins unit test failure

jacoco is not the cause as the tests still fail when it is disabled. Thomas On Tue, Jan 13, 2015 at 10:52 AM, Thomas Neidhart wrote: > I did several tests by adding additional console output. > The build was always running on H11 and sometimes it was working, while in > other cases not. > > Ins

[LANG] Re: Patch for review

Sebb, you have worked on the issue. Do you have time to take a look? Benedikt 2015-01-13 10:06 GMT+01:00 Shweta Turakhia : > Hi, > Can someone please take a look at the patch uploaded for > https://issues.apache.org/jira/browse/LANG-1061 > > I made the changes as discussed on the jira a

Re: [Math] Maven profile for running the examples?

On Thu, 8 Jan 2015 15:49:31 +, sebb wrote: On 8 January 2015 at 11:59, Gilles wrote: On Thu, 8 Jan 2015 01:20:20 +, sebb wrote: On 8 January 2015 at 00:25, Gilles wrote: On Wed, 7 Jan 2015 17:21:33 +, sebb wrote: On 7 January 2015 at 17:12, Thomas Neidhart wrote: On 01/

Jenkins build is back to stable : Commons Math #31

See - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org

Re: Jenkins build is still unstable: Commons Math #28

ububtu-1 On 13 January 2015 at 02:17, Apache Jenkins Server wrote: > See > > > - > To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org > For additional commands, e-mai

Re: Jenkins build is back to stable : Commons Math #31

ubuntu3 On 13 January 2015 at 15:12, Apache Jenkins Server wrote: > See > > > - > To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org > For additional commands, e-mail: de

Re: Jenkins build is still unstable: Commons Math #29

H11 On 13 January 2015 at 09:15, Apache Jenkins Server wrote: > See > > > - > To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org > For additional commands, e-mail: de

Re: [Math] Maven profile for running the examples?

On 13 January 2015 at 12:44, Gilles wrote: > On Thu, 8 Jan 2015 15:49:31 +, sebb wrote: >> >> On 8 January 2015 at 11:59, Gilles wrote: >>> >>> On Thu, 8 Jan 2015 01:20:20 +, sebb wrote: On 8 January 2015 at 00:25, Gilles wrote: > > > On Wed, 7 Jan 2015 17:21:3

Re: [Math] Maven profile for running the examples?

On 1/13/15 10:48 AM, sebb wrote: > On 13 January 2015 at 12:44, Gilles wrote: >> On Thu, 8 Jan 2015 15:49:31 +, sebb wrote: >>> On 8 January 2015 at 11:59, Gilles wrote: On Thu, 8 Jan 2015 01:20:20 +, sebb wrote: > > On 8 January 2015 at 00:25, Gilles wrote: >> >> On

Re: [Math] Maven profile for running the examples?

On Tue, 13 Jan 2015 11:03:42 -0700, Phil Steitz wrote: On 1/13/15 10:48 AM, sebb wrote: On 13 January 2015 at 12:44, Gilles wrote: On Thu, 8 Jan 2015 15:49:31 +, sebb wrote: On 8 January 2015 at 11:59, Gilles wrote: On Thu, 8 Jan 2015 01:20:20 +, sebb wrote: On 8 January 2015 at 0

Re: [VOTE] Release Aoache Commons Validator 1.4.1 based on RC3

2015-01-10 19:51 GMT+01:00 Benedikt Ritter : > Hi all, > > we have fixed the issues which where found in RC2 (and a lot more ;-)) so > I'd like to call a new vote to release Apache Commons Validator 1.4.1 based > on RC3. > > Changes between RC2 and RC3: > - Removed dependency to methods > Java 1.4

Re: [Math] Maven profile for running the examples?

On 13 January 2015 at 18:40, Gilles wrote: > On Tue, 13 Jan 2015 11:03:42 -0700, Phil Steitz wrote: >> >> On 1/13/15 10:48 AM, sebb wrote: >>> >>> On 13 January 2015 at 12:44, Gilles wrote: On Thu, 8 Jan 2015 15:49:31 +, sebb wrote: > > On 8 January 2015 at 11:59, Gilles >>

[RESULT][VOTE] Release Apache Commons Validator 1.4.1 based on RC3

2015-01-10 19:51 GMT+01:00 Benedikt Ritter : > Hi all, > > we have fixed the issues which where found in RC2 (and a lot more ;-)) so > I'd like to call a new vote to release Apache Commons Validator 1.4.1 based > on RC3. > > Changes between RC2 and RC3: > - Removed dependency to methods > Java 1.4

Re: [MATH] Jenkins unit test failure

On 1/12/15 3:21 PM, Thomas Neidhart wrote: > On 01/12/2015 11:17 PM, Phil Steitz wrote: >> On 1/12/15 2:30 PM, Thomas Neidhart wrote: >>> On 01/12/2015 10:26 PM, Thomas Neidhart wrote: On 01/12/2015 08:09 PM, Phil Steitz wrote: > On 1/12/15 11:37 AM, sebb wrote: >> On 12 January 2015 a

[continuum] BUILD FAILURE: Apache Commons Validator - Apache Commons (Test if can build / test with Java 1.5)

Online report : https://continuum-ci.apache.org/continuum/buildResult.action?buildId=39209&projectId=106 Build statistics: State: Failed Previous State: Ok Started at: Tue 13 Jan 2015 21:20:37 + Finished at: Tue 13 Jan 2015 21:20:47 + Total time: 9s Build Trigger: Schedule B

Re: [MATH] Jenkins unit test failure

On 01/13/2015 09:01 PM, Phil Steitz wrote: > On 1/12/15 3:21 PM, Thomas Neidhart wrote: >> On 01/12/2015 11:17 PM, Phil Steitz wrote: >>> On 1/12/15 2:30 PM, Thomas Neidhart wrote: On 01/12/2015 10:26 PM, Thomas Neidhart wrote: > On 01/12/2015 08:09 PM, Phil Steitz wrote: >> On 1/12/15

[continuum] BUILD FAILURE: Apache Commons Validator - Apache Commons (Group (shared) Maven 3 Build Definition (Java 1.6))

Online report : https://continuum-ci.apache.org/continuum/buildResult.action?buildId=39210&projectId=106 Build statistics: State: Failed Previous State: Ok Started at: Tue 13 Jan 2015 21:36:03 + Finished at: Tue 13 Jan 2015 21:36:31 + Total time: 27s Build Trigger: Forced Bu

Re: [MATH] Jenkins unit test failure

On 13 January 2015 at 21:26, Thomas Neidhart wrote: > On 01/13/2015 09:01 PM, Phil Steitz wrote: >> On 1/12/15 3:21 PM, Thomas Neidhart wrote: >>> On 01/12/2015 11:17 PM, Phil Steitz wrote: On 1/12/15 2:30 PM, Thomas Neidhart wrote: > On 01/12/2015 10:26 PM, Thomas Neidhart wrote: >>

Re: [math] Enable jacoco again.

On 13 January 2015 at 10:04, wrote: > Repository: commons-math > Updated Branches: > refs/heads/master 3923fc10f -> 4e1958256 > > > Enable jacoco again. > > > Project: http://git-wip-us.apache.org/repos/asf/commons-math/repo > Commit: http://git-wip-us.apache.org/repos/asf/commons-math/commit/4

Fwd: [continuum] BUILD FAILURE: Apache Commons Validator - Apache Commons (Group (shared) Maven 3 Build Definition (Java 1.6))

Is anyone else getting: commons-validator org.apache.commons.validator.routines.UrlValidatorTest testIsValid(org.apache.commons.validator.routines.UrlValidatorTest) junit.framework.AssertionFailedError: http://1.2.3.4./test1?action=view expected: but was: at junit.framework.Assert.fail(Assert

Re: [continuum] BUILD FAILURE: Apache Commons Validator - Apache Commons (Group (shared) Maven 3 Build Definition (Java 1.6))

Yes. Just updated my workspace and ran test and it failed. I've also updated Continuum to 1.6 and that failed too On 13 January 2015 at 21:41, Gary Gregory wrote: > Is anyone else getting: > > commons-validator > org.apache.commons.validator.routines.UrlValidatorTest > testIsValid(org.apache.com

Re: [continuum] BUILD FAILURE: Apache Commons Validator - Apache Commons (Group (shared) Maven 3 Build Definition (Java 1.6))

Rats! Looks like a bug here: final String authorityASCII = DomainValidator.unicodeToASCII(authority); This is supposed to leave the input string along if it cannot convert punycode, but it appears to have dropped the final "." when converting "www.cnn.com.." Don't know why that was not noticed b

Re: [continuum] BUILD FAILURE: Apache Commons Validator - Apache Commons (Group (shared) Maven 3 Build Definition (Java 1.6))

On 13 January 2015 at 22:02, sebb wrote: > Rats! Looks like a bug here: > > final String authorityASCII = DomainValidator.unicodeToASCII(authority); > > This is supposed to leave the input string along if it cannot convert > punycode, but it appears to have dropped the final "." when converting >

Re: svn commit: r1651525 - /commons/proper/validator/trunk/src/main/java/org/apache/commons/validator/routines/DomainValidator.java

This reverts back to the 1.4 code (except for the reflection part) and fixes the test failures. However it is not a permanent solution. On 13 January 2015 at 22:30, wrote: > Author: sebb > Date: Tue Jan 13 22:30:28 2015 > New Revision: 1651525 > > URL: http://svn.apache.org/r1651525 > Log: > Ad

[MATH] results on H11 using 1.5/6/7

https://builds.apache.org/job/Commons%20Math%20H10/38/console H11 - java6 - OK https://builds.apache.org/job/Commons%20Math%20H10/39/console H11 - java7 - OK https://builds.apache.org/job/Commons%20Math%20H10/40/console H11 - java5 - failed https://builds.apache.org/job/Commons%20Math%20H10/41/c

[ALL] Commons Parent - include Animal Sniffer?

I've been experimenting with Animal Sniffer in NET as a basic check that the code does not try to use method etc which are not present in the target Java version. [For example, java.net.IDN requires Java 1.6+] Although the plugin is not fool-proof, it should help to check basic errors and allow de

Re: [MATH] results on H11 using 1.5/6/7

Why only sometimes? > On Jan 13, 2015, at 4:36 PM, sebb wrote: > > https://builds.apache.org/job/Commons%20Math%20H10/38/console > H11 - java6 - OK > > https://builds.apache.org/job/Commons%20Math%20H10/39/console > H11 - java7 - OK > > https://builds.apache.org/job/Commons%20Math%20H10/40/c

Re: [MATH] Jenkins unit test failure

Hi. [...] Everytime I added more debug output to FastMath.exp(), the tests succeeded. Did you try using Math.exp or StrictMath.exp in place of FastMath.exp? I also setup a jenkins instance with the same maven / jdk version to build commons-math, but could never reproduce an error so far.

Re: [Math] Maven profile for running the examples?

[...] It uses a separate minimal POM, see the JIRA. The suggested POM is optional, and assumes the examples jar has been released to Maven. -1 to release examples jar It was not meant to be the current discussion (cf. earlier posts). [It might become relevant when the examples are more tha

[Math] Creating reports to be included in the user guide

Hello. Now that we can run the code located in the "src/userguide" directory, I'd propose that some examples be written that produce various reports for inclusion in the user guide. A good starting point would be to move o.a.c.m.util.FastMathTestPerformance from the "src/test" directory to "sr

Re: [Math] Java version

Raising this issue once again. Are we going to upgrade the requirement for the next major release? [ ] Java 5 [ ] Java 6 [ ] Java 7 [ ] Java 8 [ ] Java 9 Counts up to now: Java 7 -> 2 Java 7 or 8 -> 2 Java 8 -> 2 Any more opionions? Gilles ---

Re: [Math] Java version

I would love to see Java 8. Ole On 01/13/2015 07:31 PM, Gilles wrote: Raising this issue once again. Are we going to upgrade the requirement for the next major release? [ ] Java 5 [ ] Java 6 [ ] Java 7 [ ] Java 8 [ ] Java 9 Counts up to now: Java 7 -> 2 Java 7 or 8 -> 2 Java 8

Re: [ALL] Commons Parent - include Animal Sniffer?

On Tue, Jan 13, 2015 at 6:57 PM, sebb wrote: > I've been experimenting with Animal Sniffer in NET as a basic check > that the code does not try to use method etc which are not present in > the target Java version. > [For example, java.net.IDN requires Java 1.6+] > > Although the plugin is not foo

Re: [Math] Java version

Java 7 or 8. Gary On Tue, Jan 13, 2015 at 8:31 PM, Gilles wrote: > Raising this issue once again. >>> Are we going to upgrade the requirement for the next major release? >>> >>> [ ] Java 5 >>> [ ] Java 6 >>> [ ] Java 7 >>> [ ] Java 8 >>> [ ] Java 9 >>> >> > Counts up to now: > > Java 7

Re: [Math] Creating reports to be included in the user guide

On 1/13/15 6:24 PM, Gilles wrote: > Hello. > > Now that we can run the code located in the "src/userguide" > directory, I'd propose that some examples be written that > produce various reports for inclusion in the user guide. > > A good starting point would be to move > o.a.c.m.util.FastMathTestP

Re: [MATH] Jenkins unit test failure

On 1/13/15 2:33 PM, sebb wrote: > On 13 January 2015 at 21:26, Thomas Neidhart > wrote: >> On 01/13/2015 09:01 PM, Phil Steitz wrote: >>> On 1/12/15 3:21 PM, Thomas Neidhart wrote: On 01/12/2015 11:17 PM, Phil Steitz wrote: > On 1/12/15 2:30 PM, Thomas Neidhart wrote: >> On 01/12/201

Re: [continuum] BUILD FAILURE: Apache Commons Validator - Apache Commons (Group (shared) Maven 3 Build Definition (Java 1.6))

2015-01-13 23:11 GMT+01:00 sebb : > On 13 January 2015 at 22:02, sebb wrote: > > Rats! Looks like a bug here: > > > > final String authorityASCII = DomainValidator.unicodeToASCII(authority); > > > > This is supposed to leave the input string along if it cannot convert > > punycode, but it appears