Re: [text] Deprecation of StrMatcher/StrBuilder/StrTokenizer classes

2018-02-12 Thread Gary Gregory
On Mon, Feb 12, 2018 at 6:54 PM, sebb wrote: > On 12 February 2018 at 20:29, Gary Gregory wrote: > > On Mon, Feb 12, 2018 at 12:53 PM, Pascal Schumacher < > > pascalschumac...@gmx.net> wrote: > > > >> Hello everybody, > >> > >> after further consideration I'm not sure if it is a good idea to > d

Re: [text] Deprecation of StrMatcher/StrBuilder/StrTokenizer classes

2018-02-12 Thread sebb
On 12 February 2018 at 20:29, Gary Gregory wrote: > On Mon, Feb 12, 2018 at 12:53 PM, Pascal Schumacher < > pascalschumac...@gmx.net> wrote: > >> Hello everybody, >> >> after further consideration I'm not sure if it is a good idea to deprecate >> StrMatcher (to convert it to an interface and make

Re: [CSV][POLL] How to provide mutable records

2018-02-12 Thread Gary Gregory
On Fri, Feb 9, 2018 at 10:05 AM, Stian Soiland-Reyes wrote: > On Fri, 25 Aug 2017 19:19:58 +0100, Stian Soiland-Reyes > wrote: > > This came up also for commons rdf where we also have everything > immutable, > > which I think is a good principle to keep for modern Java 8 programming. > > > > So

[GitHub] commons-rdf issue #43: COMMONSRDF-49: Make AbstractRDFParser serializable

2018-02-12 Thread stain
Github user stain commented on the issue: https://github.com/apache/commons-rdf/pull/43 Picking up this - @ajs6f do you still think we should proceed along those lines? I am also reluctant to making the abstract factory (builder) serializable, but I can see the reasoning, particularly

[GitHub] commons-rdf pull request #48: Cleanup in commons-rdf-rdf4j to close PMD and ...

2018-02-12 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/commons-rdf/pull/48 --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org

[GitHub] commons-rdf pull request #50: Cleanup for PMD warnings in -rdf-api

2018-02-12 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/commons-rdf/pull/50 --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org

[GitHub] commons-rdf pull request #49: Cleanup for FindBugs and PMD warnings in -simp...

2018-02-12 Thread stain
Github user stain commented on a diff in the pull request: https://github.com/apache/commons-rdf/pull/49#discussion_r167732171 --- Diff: commons-rdf-simple/src/main/java/org/apache/commons/rdf/simple/experimental/AbstractRDFParser.java --- @@ -58,8 +60,12 @@ */ public a

[GitHub] commons-rdf pull request #52: Adding convenient Dataset and DatasetGraph con...

2018-02-12 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/commons-rdf/pull/52 --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org

Re: [All] Convention for "courtesy" codes?

2018-02-12 Thread Gilles
On Sat, 10 Feb 2018 20:50:26 +0100, Stefan Bodewig wrote: On 2018-02-10, Gilles wrote: On Sat, 10 Feb 2018 08:08:12 -0700, Gary Gregory wrote: If a Java package and artifact ID contain "internal" or "private" in the name, that would be pretty clear. Do you suggest that, say, the benchmarki

Re: [text] Adapt the Log4j 2 Interpolator to [text]

2018-02-12 Thread Gary Gregory
On Mon, Feb 12, 2018 at 12:53 PM, Gary Gregory wrote: > > > On Mon, Feb 12, 2018 at 12:30 PM, Pascal Schumacher < > pascalschumac...@gmx.net> wrote: > >> Am 12.02.2018 um 18:52 schrieb Gary Gregory: >> >>> I agree 100% and will proceed. I thought about it overnight and it does >>> not >>> make se

Re: [text] Deprecation of StrMatcher/StrBuilder/StrTokenizer classes

2018-02-12 Thread Gary Gregory
On Mon, Feb 12, 2018 at 12:53 PM, Pascal Schumacher < pascalschumac...@gmx.net> wrote: > Hello everybody, > > after further consideration I'm not sure if it is a good idea to deprecate > StrMatcher (to convert it to an interface and make the naming match > *StringLookup), as this means that StrBui

Re: [text] Update from Java 7 to Java 8?

2018-02-12 Thread Pascal Schumacher
What about now? :-) Am 12.02.2018 um 20:53 schrieb Gary Gregory: When? Gary - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org

[text] Update from Java 7 to Java 8?

2018-02-12 Thread Gary Gregory
When? Gary

Re: [text] Adapt the Log4j 2 Interpolator to [text]

2018-02-12 Thread Gary Gregory
On Mon, Feb 12, 2018 at 12:30 PM, Pascal Schumacher < pascalschumac...@gmx.net> wrote: > Am 12.02.2018 um 18:52 schrieb Gary Gregory: > >> I agree 100% and will proceed. I thought about it overnight and it does >> not >> make sense to leave a mix of abstract classes and interfaces in >> StrSubstit

[text] Deprecation of StrMatcher/StrBuilder/StrTokenizer classes

2018-02-12 Thread Pascal Schumacher
Hello everybody, after further consideration I'm not sure if it is a good idea to deprecate StrMatcher (to convert it to an interface and make the naming match *StringLookup), as this means that StrBuilder and StrTokenizer also have to be deprecated. Not long ago we told users of these class

Re: [text] Adapt the Log4j 2 Interpolator to [text]

2018-02-12 Thread Pascal Schumacher
Am 12.02.2018 um 18:52 schrieb Gary Gregory: I agree 100% and will proceed. I thought about it overnight and it does not make sense to leave a mix of abstract classes and interfaces in StrSubstitutor. +1, but please revert "Update actual Checkstyle from 6.19 to 8.8.", as Checkstyle 7+ requrie

Re: [text] Adapt the Log4j 2 Interpolator to [text]

2018-02-12 Thread Gary Gregory
On Sun, Feb 11, 2018 at 8:12 PM, Chas Honton wrote: > Definitely create interfaces. > I agree 100% and will proceed. I thought about it overnight and it does not make sense to leave a mix of abstract classes and interfaces in StrSubstitutor. Gary > > Chas > > > On Feb 11, 2018, at 1:57 PM, Ga