Re: [configuration] Java 8 types

2018-03-29 Thread Gary Gregory
Done. Gary On Wed, Mar 28, 2018 at 2:21 PM, Jochen Wiedmann wrote: > +1 > > > On Wed, Mar 28, 2018 at 9:06 PM, Gary Gregory > wrote: > > Hi All: > > > > I say it is time to update Commons Configuration to Java 8 and support > the > > types in java.time. > > > > Thoughts? > > > > Gary > > -

[collections] breaking changes

2018-03-29 Thread Gary Gregory
Hi All: Updating Commons Collections' commons-parent from version 43 to 45 causes the build to fail due to the use of japicmp which reports: [ERROR] Failed to execute goal org.apache.maven.plugins:maven-site-plugin:3.7:site (default-site) on project commons-collections4: Error generating japicmp-

Re: [collections] breaking changes

2018-03-29 Thread Claude Warren
if we are using semantic numbering would this not cause a major revision change as older code will no longer function? Claude On Thu, Mar 29, 2018 at 3:51 PM, Gary Gregory wrote: > Hi All: > > Updating Commons Collections' commons-parent from version 43 to 45 causes > the build to fail due to t

Re: [collections] breaking changes

2018-03-29 Thread Gary Gregory
Can you show how older code would not function. Aside from using reflection. Gary On Thu, Mar 29, 2018, 09:03 Claude Warren wrote: > if we are using semantic numbering would this not cause a major revision > change as older code will no longer function? > > Claude > > On Thu, Mar 29, 2018 at 3:

Re: [collections] breaking changes

2018-03-29 Thread Paul King
I haven't looked into the IteratorUtils class at all but it's easy to show binary incompatibility when changing the return type. Compile this "library" class: import java.util.ArrayList; import java.util.List; public class Lib { List getMyList() { return new ArrayList(); } } Now

Re: [collections] breaking changes

2018-03-29 Thread Gary Gregory
Yep, that's no good. I'll revert. Gary On Thu, Mar 29, 2018 at 10:16 AM, Paul King wrote: > I haven't looked into the IteratorUtils class at all but it's easy to > show binary incompatibility when changing the return type. > Compile this "library" class: > > import java.util.ArrayList; > import

[parent] release 46

2018-03-29 Thread Gary Gregory
Hi All, It would be nice to release commons-parent 46 in order to pick up the new version of Surefire which let's us test on Java 10. Any volunteers? Gary

Re: [parent] release 46

2018-03-29 Thread Rob Tompkins
I’ll do it. I want to do another release of the release-plugin. Will try to get an RC out before Saturday. > On Mar 29, 2018, at 1:57 PM, Gary Gregory wrote: > > Hi All, > > It would be nice to release commons-parent 46 in order to pick up the new > version of Surefire which let's us test on

Re: [configuration] Java 8 types

2018-03-29 Thread Oliver Heger
Am 29.03.2018 um 15:54 schrieb Gary Gregory: > Done. > > Gary > > On Wed, Mar 28, 2018 at 2:21 PM, Jochen Wiedmann > wrote: > >> +1 >> >> >> On Wed, Mar 28, 2018 at 9:06 PM, Gary Gregory >> wrote: >>> Hi All: >>> >>> I say it is time to update Commons Configuration to Java 8 and support >> t

Re: [parent] release 46

2018-03-29 Thread Gary Gregory
On Thu, Mar 29, 2018 at 11:59 AM, Rob Tompkins wrote: > I’ll do it. I want to do another release of the release-plugin. Will try > to get an RC out before Saturday. > Awesome :-) Also note that Sebb updated commons-build-plugin and that might need a release first. Gary > > On Mar 29, 2018, a

Re: [configuration] Java 8 types

2018-03-29 Thread Gary Gregory
Hi, We are talking dead Java 7 here, Android or not, Java 10 just came out. It looks like Android supports some Java 8 at least: https://developer.android.com/studio/write/java8-support.html If someone has a burning desire to maintain a Java 7 branch, go for it. I do think that in 2018, we need t

Re: [parent] release 46

2018-03-29 Thread Rob Tompkins
> On Mar 29, 2018, at 2:27 PM, Gary Gregory wrote: > >> On Thu, Mar 29, 2018 at 11:59 AM, Rob Tompkins wrote: >> >> I’ll do it. I want to do another release of the release-plugin. Will try >> to get an RC out before Saturday. >> > > Awesome :-) > > Also note that Sebb updated commons-build

Re: [collections] breaking changes

2018-03-29 Thread sebb
The return type is part of the method signature that Java uses to find resolve references. Even changing from void to non-void will cause binary incompatibility. (Source-wise, that's fine) On 29 March 2018 at 18:20, Gary Gregory wrote: > Yep, that's no good. I'll revert. > > Gary > > On Thu, Mar

[httpclient] Better user agent header?

2018-03-29 Thread Gary Gregory
Hi All: Right now, the HttpClient is of the form: User-Agent: Apache-HttpClient/4.5.5 (Java/1.8.0_162) With the stack I am working with, it would be handy if the header reflected: - The Java vendor - Operating system name and version. For example: User-Agent: Apache-HttpClient/4.5.5 (Oracle C

Re: [collections] breaking changes

2018-03-29 Thread Peter Burka
This could be solved if it were possible to force javac to generate bridge methods. There's an extension which would allow that here: https://github.com/infradna/bridge-method-injector, but I suspect it would complicate the build process quite a bit. On Thu, Mar 29, 2018 at 4:48 PM sebb wrote: >

Re: [collections] breaking changes

2018-03-29 Thread Paul King
In the Groovy build we do this using Bridger (https://github.com/dmlloyd/bridger). It's built with gradle (and uses Ant). They have a Maven plugin but I haven't used it. In our build we have this: compileJava { doLast { ant.java(classname:'org.jboss.bridger.Bridger', classpath: rootPr

Re: [collections] breaking changes

2018-03-29 Thread Paul King
Just to clarify, when I said "It's built with gradle and uses Ant", I mean our build is gradle based and our call of Bridger uses Ant. Bridger itself is built with Maven. On Fri, Mar 30, 2018 at 12:20 PM, Paul King wrote: > In the Groovy build we do this using Bridger > (https://github.com/dmlloy

[GitHub] commons-pool issue #4: POOL-337: EvictionTimer does not remove cancelled tas...

2018-03-29 Thread cdeneux
Github user cdeneux commented on the issue: https://github.com/apache/commons-pool/pull/4 Hi @garydgregory, To be able to release our product [Petals ESB](http://petals.ow2.org/), we wish embed this fix. We can use the official released artefact, or our own forked artefact.