Re: [VOTE] Release Apache Commons Lang 3.9 based on RC2

[x] +1 Release these artifacts Built from tag with `mvn clean test site install` with no issues on Apache Maven 3.5.2 (138edd61fd100ec658bfa2d307c43b76940a5d7d; 2017-10-18T20:58:13+13:00) Maven home: /opt/apache-maven-3.5.2 Java version: 1.8.0_172, vendor: Oracle Corporation Java home:

Re: [VOTE] Release Apache Commons Pool 2.6.2 based on RC1

[x] +1 Release these artifacts Building passing with `mvn clean install`, then `mvn site` (failed when put together, as site couldn't find the SNAPSHOT jar I think. Apache Maven 3.5.2 (138edd61fd100ec658bfa2d307c43b76940a5d7d; 2017-10-18T20:58:13+13:00) Maven home: /opt/apache-maven-3.5.2

[VOTE] Release Apache Commons Lang 3.9 based on RC2

We have fixed quite a few bugs and added some significant enhancements since Apache Commons Lang 3.8.1 was released, so I would like to release Apache Commons Lang 3.9. Apache Commons Lang 3.9 RC2 is available for review here: https://dist.apache.org/repos/dist/dev/commons/lang/3.9-RC2 (svn

Re: [BCEL] Console warning

+1 for dropping or improving. [imaging] will go out in 1.0 with j.u.l if I recall correctly. Maybe a similar approach would work here, if we decide to keep the logs. CheersBruno On Thursday, 11 April 2019, 11:58:40 am NZST, Rob Tompkins wrote: > On Apr 10, 2019, at 7:46 PM, Gary

Re: [BCEL] Console warning

> On Apr 10, 2019, at 7:46 PM, Gary Gregory wrote: > >> On Wed, Apr 10, 2019 at 7:44 PM Rob Tompkins wrote: >> >> >> >>> On Apr 10, 2019, at 7:20 PM, Gary Gregory >> wrote: >>> >>> Hi All: >>> >>> In BCEL, we log a warning to the console: >>> >>> >>

Re: [BCEL] Console warning

On Wed, Apr 10, 2019 at 7:44 PM Rob Tompkins wrote: > > > > On Apr 10, 2019, at 7:20 PM, Gary Gregory > wrote: > > > > Hi All: > > > > In BCEL, we log a warning to the console: > > > > >

Re: [BCEL] Console warning

The problem is really that BCEL is used in many places and that when you see 30 lines of this warning when you are running a Maven build, you go "What the heck this? Panic?!" especially when your project does not depend on BCEL but BCEL comes in from transitive deps. Gary On Wed, Apr 10, 2019 at

Re: [BCEL] Console warning

> On Apr 10, 2019, at 7:20 PM, Gary Gregory wrote: > > Hi All: > > In BCEL, we log a warning to the console: > > https://github.com/apache/commons-bcel/blob/master/src/main/java/org/apache/bcel/classfile/Attribute.java#L240 > > Which you can't really do anything about since it does not

RE: [BCEL] Console warning

I added that warning while working on the StackMap support for Java7 (and beyond). We were testing (daikon and randoop) on several very large test suites and found a large number of class files compiled with an obsolete version of Java that generated bogus StackMap entries. I don't feel too

Re: [VOTE] Release Apache Commons Pool 2.6.2 based on RC1

Pretty please for more reviews? Gary On Tue, Apr 9, 2019 at 9:36 AM Gary Gregory wrote: > May I get more reviews please? > > Thank you, > Gary > > On Mon, Apr 8, 2019 at 10:15 AM Gary Gregory > wrote: > >> Looking for VOTEs... >> >> Gary >> >> On Sat, Apr 6, 2019 at 12:24 PM Gary Gregory >>

[BCEL] Console warning

Hi All: In BCEL, we log a warning to the console: https://github.com/apache/commons-bcel/blob/master/src/main/java/org/apache/bcel/classfile/Attribute.java#L240 Which you can't really do anything about since it does not tell you what class file it is complaining about. 1) Should remove the

Re: [rng] Split and Jump functions

> On 10 Apr 2019, at 18:52, Gilles Sadowski wrote: > > Hi. > >> >> On 10/04/2019 18:58, Gilles Sadowski wrote: >>> Hi. >>> [... long quote skipped where I think we largely agree on the conclusions ...] So do we have a working idea to: - Add interface

Re: [rng] nextInt(int) and nextLong(long) can be improved

Le mer. 10 avr. 2019 à 18:26, Alex Herbert a écrit : > > > On 10/04/2019 15:59, Gilles Sadowski wrote: > > Hello. > > > > Le mer. 10 avr. 2019 à 15:22, Alex Herbert a > > écrit : > >> On 10/04/2019 13:46, Alex Herbert wrote: > >>> The code for nextInt(int) checks the range number n is a power

Re: [commons-lang] branch master updated: LANG-1447: java 12 final modifier is no longer mutable

> On Apr 10, 2019, at 2:49 PM, Gary Gregory wrote: > > The test will fail on Java 14 and above when it comes out. We do not want > to update this method with each new release. We need a "if java is >= 12" > test IMO. +1 > > Gary > > On Wed, Apr 10, 2019, 14:46 wrote: > >> This is an

Re: [commons-lang] branch master updated: LANG-1447: java 12 final modifier is no longer mutable

The test will fail on Java 14 and above when it comes out. We do not want to update this method with each new release. We need a "if java is >= 12" test IMO. Gary On Wed, Apr 10, 2019, 14:46 wrote: > This is an automated email from the ASF dual-hosted git repository. > > chtompki pushed a

Re: [VOTE] Release Apache Commons Lang 3.9 based on RC1

> On Apr 10, 2019, at 12:25 PM, Gary Gregory wrote: > > On Wed, Apr 10, 2019 at 12:13 PM Rob Tompkins > wrote: > >> >> >>> On Apr 9, 2019, at 9:16 PM, Gary Gregory >> > wrote: >>> >>> I also see that we are using an old version of

Re: Re: [rng] Split and Jump functions

Hi. > > On 10/04/2019 18:58, Gilles Sadowski wrote: > > Hi. > > > >> [... long quote skipped where I think we largely agree on the > >> conclusions ...] > >> So do we have a working idea to: > >> > >> - Add interface 'JumpableUniformRandomProvider' > > Do we need to add "createJumpable" factory

Fwd: Re: [rng] Split and Jump functions

Resending to list. Forwarded Message Subject:Re: [rng] Split and Jump functions Date: Wed, 10 Apr 2019 18:00:54 +0100 From: Alex Herbert To: Gilles Sadowski On 10/04/2019 18:58, Gilles Sadowski wrote: Hi. [... long quote skipped where I think we largely

Re: [rng] nextInt(int) and nextLong(long) can be improved

On 10/04/2019 15:59, Gilles Sadowski wrote: Hello. Le mer. 10 avr. 2019 à 15:22, Alex Herbert a écrit : On 10/04/2019 13:46, Alex Herbert wrote: The code for nextInt(int) checks the range number n is a power of two and if so it computes a fast solution: return (int) ((n * (long)

Re: [VOTE] Release Apache Commons Lang 3.9 based on RC1

On Wed, Apr 10, 2019 at 12:13 PM Rob Tompkins wrote: > > > > On Apr 9, 2019, at 9:16 PM, Gary Gregory wrote: > > > > I also see that we are using an old version of jacoco and surefire, that > > probably matters… > > Maven surefire is 3.0.0-M3. Are we willing to consume a non-release > version

Re: [VOTE] Release Apache Commons Lang 3.9 based on RC1

> On Apr 9, 2019, at 9:16 PM, Gary Gregory wrote: > > I also see that we are using an old version of jacoco and surefire, that > probably matters… Maven surefire is 3.0.0-M3. Are we willing to consume a non-release version of the plugin? I ask this because I regard "-Mx”, where x is a

Re: [rng] Split and Jump functions

Hi. > [... long quote skipped where I think we largely agree on the conclusions ...] > So do we have a working idea to: > > - Add interface 'JumpableUniformRandomProvider' Do we need to add "createJumpable" factory methods in "RandomSource" methods or is there a way to avoid the duplication?

Re: [rng] nextInt(int) and nextLong(long) can be improved

Hello. Le mer. 10 avr. 2019 à 15:22, Alex Herbert a écrit : > > On 10/04/2019 13:46, Alex Herbert wrote: > > The code for nextInt(int) checks the range number n is a power of two > > and if so it computes a fast solution: > > > > return (int) ((n * (long) (nextInt() >>> 1)) >> 31); > > > >

Re: [lang] Remove final modifier behaviour in java 12+ (was: Re: [VOTE] Release Apache Commons Lang 3.9 based on RC1)

I like that. I’ll get that sorted out. -Rob > On Apr 10, 2019, at 10:28 AM, Gary Gregory wrote: > > I think UnsupportedOperationException with a Java 12 comment, but we should > also add @Deprecated with a comment about it not working at all on Java 12. > > Gary > > On Wed, Apr 10, 2019 at

Re: [lang] Remove final modifier behaviour in java 12+ (was: Re: [VOTE] Release Apache Commons Lang 3.9 based on RC1)

I think UnsupportedOperationException with a Java 12 comment, but we should also add @Deprecated with a comment about it not working at all on Java 12. Gary On Wed, Apr 10, 2019 at 8:55 AM Rob Tompkins wrote: > Looks like we get an exception because the final modifier isn’t removable > in java

[CANCEL][VOTE] Release Apache Commons Lang 3.9 based on RC1

I’m going to cancel this [VOTE] so that we can button up those java 12 problems and upversion jacoco and surefire. -Rob > On Apr 9, 2019, at 3:37 PM, Rob Tompkins wrote: > > We have fixed quite a few bugs and added some significant enhancements since > Apache Commons Lang 3.8.1 was released,

Re: [rng] nextInt(int) and nextLong(long) can be improved

On 10/04/2019 13:46, Alex Herbert wrote: The code for nextInt(int) checks the range number n is a power of two and if so it computes a fast solution:     return (int) ((n * (long) (nextInt() >>> 1)) >> 31); This scales a 31 bit positive number by a power of 2 (i.e. n) then discards bits. So

[lang] Remove final modifier behaviour in java 12+ (was: Re: [VOTE] Release Apache Commons Lang 3.9 based on RC1)

Looks like we get an exception because the final modifier isn’t removable in java 12+ and for good reason [1]. So, we probably should throw an exception, but both of the exceptions that arise out of the jvm here

[rng] nextInt(int) and nextLong(long) can be improved

The code for nextInt(int) checks the range number n is a power of two and if so it computes a fast solution:     return (int) ((n * (long) (nextInt() >>> 1)) >> 31); This scales a 31 bit positive number by a power of 2 (i.e. n) then discards bits. So this is effectively just a left shift

Re: [RNG] Re: [commons-rng] 02/02: Disable redundant JMH benchmarks and mark as deprecated.

On 10/04/2019 13:02, Gilles Sadowski wrote: Hello Alex. [...] commit 431a51b8211a40e5e8d9df0406563d4873eb4eb6 Author: aherbert AuthorDate: Wed Apr 10 11:01:05 2019 +0100 Disable redundant JMH benchmarks and mark as deprecated. Is there and advantage to keeping disabled code? [Usually,

[RNG] Re: [commons-rng] 02/02: Disable redundant JMH benchmarks and mark as deprecated.

Hello Alex. > [...] > > commit 431a51b8211a40e5e8d9df0406563d4873eb4eb6 > Author: aherbert > AuthorDate: Wed Apr 10 11:01:05 2019 +0100 > > Disable redundant JMH benchmarks and mark as deprecated. Is there and advantage to keeping disabled code? [Usually, it rots silently until nobody knows

Re: [VOTE] Release Apache Commons Lang 3.9 based on RC1

Hi B, do you have time to review the [pool] vote? Gary On Wed, Apr 10, 2019, 05:09 Benedikt Ritter wrote: > Damn it, I had it on my list to fix those. Sorry, Rob! > > Am Mi., 10. Apr. 2019 um 03:33 Uhr schrieb Rob Tompkins < > chtom...@gmail.com > >: > > > > > > > > On Apr 9, 2019, at 9:15 PM,

Re: [VOTE] Release Apache Commons Lang 3.9 based on RC1

Damn it, I had it on my list to fix those. Sorry, Rob! Am Mi., 10. Apr. 2019 um 03:33 Uhr schrieb Rob Tompkins : > > > > On Apr 9, 2019, at 9:15 PM, Gary Gregory wrote: > > > > +0... see Java 12 testing below. > > That +0 is almost worth cancelling for in my opinion. I’ll wait until > tomorrow