[x] +1 Release these artifacts
Building from tag, with `mvn clean test install` working fine on:
Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe;
2018-06-18T06:33:14+12:00)
Maven home: /opt/apache-maven-3.5.4
Java version: 1.8.0_265, vendor: Private Build, runtime:
/usr/lib/jvm/j
Hi.
Smoke test seems failed.
https://github.com/XenoAmess/smoke-test-commons-io
could some guy run this locally and see why it be wrong?
the plugin's source is at
https://github.com/XenoAmess/add-from-repo-maven-plugin , if anything I
wrote uncorrect, please tell me.
Bruno P. Kinoshita 于2020年9月6
The file src/assembly/src.xml still refers to the FindBugs config instead
of the SpotBugs config. This means you can't build a zip or tar distro.
I will cancel this VOTE respin for RC2.
Thank you!
Gary
On Sun, Sep 6, 2020 at 2:16 AM Rob Tompkins wrote:
> (undecided) -1 ??
>
> [INFO]
>
See below.
On Sun, Sep 6, 2020 at 9:30 AM Gary Gregory wrote:
> The file src/assembly/src.xml still refers to the FindBugs config instead
> of the SpotBugs config. This means you can't build a zip or tar distro.
>
> I will cancel this VOTE respin for RC2.
>
> Thank you!
> Gary
>
> On Sun, Sep 6,
On Sun, Sep 6, 2020 at 5:39 AM Xeno Amess wrote:
> Hi.
> Smoke test seems failed.
> https://github.com/XenoAmess/smoke-test-commons-io
> could some guy run this locally and see why it be wrong?
>
I'm not sure what you are asking, a brief glance at
https://github.com/XenoAmess/smoke-test-commons-
https://github.com/XenoAmess/smoke-test-commons-io/actions/runs/241547041
see this
Gary Gregory 于2020年9月6日周日 下午9:33写道：
> On Sun, Sep 6, 2020 at 5:39 AM Xeno Amess wrote:
>
> > Hi.
> > Smoke test seems failed.
> > https://github.com/XenoAmess/smoke-test-commons-io
> > could some guy run this loc
The idea behind making *Util constructors private is that it does not make
sense to instantiate a class that only has static methods.
Gary
On Sun, Sep 6, 2020 at 12:49 AM Xeno Amess wrote:
> for example: can we make its constructor public instead of private?
>
Oh I see why it will fail.
It read the source codes in main folder when running test...
However I did not clone the main folder, so it can read nothing.
Well it is not illegal but, is it necessary...?
I think it weird, and maybe it is better to change those tests to use
test-resources to do such t
The idea behind not making *Util constructors private is that it makes
people be able to extend that class.
for example:
https://github.com/apache/commons-lang/blob/master/src/main/java/org/apache/commons/lang3/StringUtils.java#L9627
Gary Gregory 于2020年9月6日周日 下午9:39写道：
> The idea behind making *
On Sun, Sep 6, 2020 at 9:36 AM Xeno Amess wrote:
> https://github.com/XenoAmess/smoke-test-commons-io/actions/runs/241547041
see this
>
I can't immediately tell why your build is failing and I don't want to take
the time today to debug your project.
Gary
>
> Gary Gregory 于2020年9月6日周日 下午9:33
Got it, maybe I will put a pr for the issue I found.
After all codes are more clear than words :)
Gary Gregory 于2020年9月6日周日 下午9:44写道：
> On Sun, Sep 6, 2020 at 9:36 AM Xeno Amess wrote:
>
> >
> https://github.com/XenoAmess/smoke-test-commons-io/actions/runs/241547041
>
> see this
> >
>
> I can'
On Sun, Sep 6, 2020 at 9:44 AM Xeno Amess wrote:
> The idea behind not making *Util constructors private is that it makes
> people be able to extend that class.
> for example:
>
> https://github.com/apache/commons-lang/blob/master/src/main/java/org/apache/commons/lang3/StringUtils.java#L9627
I
> Inheritance in Java on the static side is
not the same as on the instance side
Yep, I know it. It will not override but just, hiding.
I admit it might confuse people sometimes.
> subclassing a class that only
provides static methods is no help.
Well actually I personally use it for a shortcut
But I agree that only very few people/usecase would write codes which
extending the *Util classes.
Xeno Amess 于2020年9月6日周日 下午9:53写道：
> > Inheritance in Java on the static side is
> not the same as on the instance side
>
> Yep, I know it. It will not override but just, hiding.
> I admit it might
That is why I love Lombok's @UtilityClass.
https://projectlombok.org/features/experimental/UtilityClass
It enforces a static class is truly static by making the constructor
private and throwing an exception, making sure all methods are static,
marking the class as Final etc.
On 9/6/2020 9:5
Well sometimes we want to extend(or modify) some behaviors of one Util
Class.That is why I don't want the constructor be private.
For example, there be a AUtil:
public class AUtil{
public static String getStringA(){
return "A";
}
}
then some people need a function that returns "
class AUtil {
public static String getStringA() {
return "A";
}
}
class ExtendedAUtil extends AUtil {
public static String getStringABCDE() {
return "ABCDE";
}
}
public class Main {
public static void main(String[] args) {
System.out.println(ExtendedAUt
* The difference from RC1 to RC2 is the update to src/assembly/src.xml *
We have fixed quite a few bugs and added some significant enhancements
since Apache Commons IO 2.7 was released, so I would like to release Apache
Commons IO 2.8.0.
Apache Commons IO 2.8.0 RC2 is available for review here:
I am not a big fan of extending Static Utility classes. And Joshua
Bloch is not either from his book "Effective Java"...
See: https://www.informit.com/articles/article.aspx?p=1216151&seqNum=4
On 9/6/2020 10:06 AM, Xeno Amess wrote:
class AUtil {
public static String getStringA() {
> I am not a big fan of extending Static Utility classes. And Joshua
Bloch is not either from his book "Effective Java"...
Yep I'm sure he will never like this lol.
Melloware 于2020年9月6日周日 下午10:18写道：
> I am not a big fan of extending Static Utility classes. And Joshua
> Bloch is not either fro
I’ve seen a different approach in libraries like Mockito and Hamcrest that
split up utility classes by category, then they use a tool to copy all the
static stuff to generated aggregate classes.
On Sun, Sep 6, 2020 at 09:23 Xeno Amess wrote:
> > I am not a big fan of extending Static Utility cla
+1
Tested on:
Darwin musigma.local 19.6.0 Darwin Kernel Version 19.6.0: Thu Jun 18
20:49:00 PDT 2020; root:xnu-6153.141.1~1/RELEASE_X86_64 x86_64
Apache Maven 3.6.3 (cecedd343002696d0abb50b32b541b8a6ba2883f)
Maven home: /usr/local/Cellar/maven/3.6.3_1/libexec
Java version: 1.8.0_242, vendor: Adopt
[x] +1 Release these artifacts
Build passing on JVM 8 + Ubuntu LTS. Reports OK.
Cheers
Bruno
On Monday, 7 September 2020, 2:13:41 am NZST, Gary Gregory
wrote:
* The difference from RC1 to RC2 is the update to src/assembly/src.xml *
We have fixed quite a few bugs and added some sign
23 matches
Mail list logo
