Re: [Graph] Build fails (unit tests)

2020-06-13 Thread Amey Jadiye
On Sat, Jun 13, 2020 at 8:50 PM Gilles Sadowski wrote: > Hi. > > 2020-06-13 16:57 UTC+02:00, Amey Jadiye : > > Hello Gilles, > > > > On Sat, Jun 13, 2020 at 6:36 PM Gilles Sadowski > > wrote: > > > >> Hello. > >> > >> After the migration from SVN to "gitbox", we noticed that the > >> _first_

Re: [Graph] Build fails (unit tests)

2020-06-13 Thread Gilles Sadowski
Hi. 2020-06-13 16:57 UTC+02:00, Amey Jadiye : > Hello Gilles, > > On Sat, Jun 13, 2020 at 6:36 PM Gilles Sadowski > wrote: > >> Hello. >> >> After the migration from SVN to "gitbox", we noticed that the >> _first_ build failed due to 3 unit tests not passing (see e.g. the >> Travis report

Re: [Graph] Build fails (unit tests)

2020-06-13 Thread Amey Jadiye
On Sat, Jun 13, 2020 at 8:27 PM Amey Jadiye wrote: > Hello Gilles, > > On Sat, Jun 13, 2020 at 6:36 PM Gilles Sadowski > wrote: > >> Hello. >> >> After the migration from SVN to "gitbox", we noticed that the >> _first_ build failed due to 3 unit tests not passing (see e.g. the >> Travis report

Re: [Graph] Build fails (unit tests)

2020-06-13 Thread Amey Jadiye
Hello Gilles, On Sat, Jun 13, 2020 at 6:36 PM Gilles Sadowski wrote: > Hello. > > After the migration from SVN to "gitbox", we noticed that the > _first_ build failed due to 3 unit tests not passing (see e.g. the > Travis report referred to the JIRA report[1]). > > The move to "git" was

Re: [Graph] Build fails (unit tests)

2020-06-13 Thread Xeno Amess
Hi. > You are welcome to implement your suggestion I want to, but this repo is out of my ability. Although I do have some experiences in ICPC, the graph part is handled by my team mates, and I personally nearly know nothing about any complex graph algorithms. Gilles Sadowski 于2020年6月13日周六

Re: [Graph] Build fails (unit tests)

2020-06-13 Thread Gilles Sadowski
Hi. 2020-06-13 15:11 UTC+02:00, Xeno Amess : >> IMO, the top priority is now to fix the failing unit tests; >> personally, I'm not going to merge any PR before that is >> achieved (and please refer to the JIRA identifier[1] in the >> corresponding commit/PR). > > agreed. > > And I still suggest

Re: [Graph] Build fails (unit tests)

2020-06-13 Thread Xeno Amess
> IMO, the top priority is now to fix the failing unit tests; > personally, I'm not going to merge any PR before that is > achieved (and please refer to the JIRA identifier[1] in the > corresponding commit/PR). agreed. And I still suggest revert back to the last version which can build, and

[Graph] Build fails (unit tests)

2020-06-13 Thread Gilles Sadowski
Hello. After the migration from SVN to "gitbox", we noticed that the _first_ build failed due to 3 unit tests not passing (see e.g. the Travis report referred to the JIRA report[1]). The move to "git" was intended to make it easier for people willing to revive the [Graph] project. IMO, the top