Hi.
On Fri, 30 Nov 2018 14:00:52 +, Sukant Kumar wrote:
Hello Everyone,
I am Shukant Pal, look at my PR for Commons Imaging
https://github.com/apache/commons-imaging/pull/38. I want to get it
merged, how to do that?
A committer has to do it.
IIRC the main committer of [Imaging] (Bruno) is
Hello Everyone,
I am Shukant Pal, look at my PR for Commons Imaging
https://github.com/apache/commons-imaging/pull/38. I want to get it
merged, how to do that?
Regards,
ShukantPal
GitHub user SukantPal opened a pull request:
https://github.com/apache/commons-imaging/pull/38
Cleaned up PNG component.
Following changes were made (overview): PngWriter.ImageHeader removed
(replaced by making PngChunkIhdr mutable); divided PngWriter.writeImage (by
creating pixel
Github user asfgit closed the pull request at:
https://github.com/apache/commons-imaging/pull/35
---
-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org
Github user kinow commented on a diff in the pull request:
https://github.com/apache/commons-imaging/pull/35#discussion_r210549560
--- Diff:
src/main/java/org/apache/commons/imaging/formats/bmp/BmpImageParser.java ---
@@ -327,7 +331,7 @@ private BmpImageContents readImageContents(f
Github user kinow commented on a diff in the pull request:
https://github.com/apache/commons-imaging/pull/35#discussion_r210546814
--- Diff:
src/main/java/org/apache/commons/imaging/formats/bmp/BmpImageParser.java ---
@@ -327,7 +331,7 @@ private BmpImageContents readImageContents(f
Github user kinow commented on a diff in the pull request:
https://github.com/apache/commons-imaging/pull/35#discussion_r210524716
--- Diff: src/main/java/org/apache/commons/imaging/icc/IccTag.java ---
@@ -73,11 +76,12 @@ private IccTagDataType getIccTagDataType(final int
quad) {
Github user kinow commented on a diff in the pull request:
https://github.com/apache/commons-imaging/pull/35#discussion_r210523866
--- Diff:
src/main/java/org/apache/commons/imaging/formats/psd/PsdHeaderInfo.java ---
@@ -45,9 +50,14 @@ public PsdHeaderInfo(final int version, final
Github user kinow commented on a diff in the pull request:
https://github.com/apache/commons-imaging/pull/35#discussion_r210521304
--- Diff:
src/main/java/org/apache/commons/imaging/formats/bmp/BmpImageParser.java ---
@@ -327,7 +331,7 @@ private BmpImageContents readImageContents(f
Github user kinow commented on a diff in the pull request:
https://github.com/apache/commons-imaging/pull/35#discussion_r210519489
--- Diff:
src/main/java/org/apache/commons/imaging/formats/png/chunks/PngChunkText.java
---
@@ -42,9 +47,9 @@ public PngChunkText(final int length, fi
Github user sebbASF commented on a diff in the pull request:
https://github.com/apache/commons-imaging/pull/35#discussion_r210327438
--- Diff:
src/main/java/org/apache/commons/imaging/formats/bmp/BmpImageParser.java ---
@@ -327,7 +331,7 @@ private BmpImageContents readImageContents
Github user garydgregory commented on a diff in the pull request:
https://github.com/apache/commons-imaging/pull/35#discussion_r210287763
--- Diff:
src/test/java/org/apache/commons/imaging/formats/jpeg/exif/WriteExifMetadataExampleTest.java
---
@@ -27,7 +27,7 @@
import org.ap
Github user garydgregory commented on a diff in the pull request:
https://github.com/apache/commons-imaging/pull/35#discussion_r210287591
--- Diff: src/main/java/org/apache/commons/imaging/icc/IccTag.java ---
@@ -73,11 +76,12 @@ private IccTagDataType getIccTagDataType(final int
qu
Github user garydgregory commented on a diff in the pull request:
https://github.com/apache/commons-imaging/pull/35#discussion_r210287298
--- Diff:
src/main/java/org/apache/commons/imaging/formats/tiff/TiffField.java ---
@@ -355,9 +360,14 @@ private String getValueDescription(final
Github user garydgregory commented on a diff in the pull request:
https://github.com/apache/commons-imaging/pull/35#discussion_r210287176
--- Diff:
src/main/java/org/apache/commons/imaging/formats/psd/PsdImageContents.java ---
@@ -40,9 +45,14 @@ public PsdImageContents(final PsdHea
Github user garydgregory commented on a diff in the pull request:
https://github.com/apache/commons-imaging/pull/35#discussion_r210287038
--- Diff:
src/main/java/org/apache/commons/imaging/formats/psd/PsdHeaderInfo.java ---
@@ -45,9 +50,14 @@ public PsdHeaderInfo(final int version,
Github user garydgregory commented on a diff in the pull request:
https://github.com/apache/commons-imaging/pull/35#discussion_r210286764
--- Diff:
src/main/java/org/apache/commons/imaging/formats/png/chunks/PngChunkText.java
---
@@ -42,9 +47,9 @@ public PngChunkText(final int len
Github user garydgregory commented on a diff in the pull request:
https://github.com/apache/commons-imaging/pull/35#discussion_r210286324
--- Diff:
src/main/java/org/apache/commons/imaging/formats/bmp/BmpImageParser.java ---
@@ -327,7 +331,7 @@ private BmpImageContents readImageCon
Github user kinow commented on a diff in the pull request:
https://github.com/apache/commons-imaging/pull/36#discussion_r204226858
--- Diff:
src/main/java/org/apache/commons/imaging/formats/jpeg/JpegImageParser.java ---
@@ -312,7 +312,12 @@ private void dumpSegments(final List v) {
Github user kinow commented on a diff in the pull request:
https://github.com/apache/commons-imaging/pull/34#discussion_r204226800
--- Diff: pom.xml ---
@@ -209,6 +209,12 @@
2.6
test
+
+
+ com.github.jai-imageio
+ jai
GitHub user gregsh opened a pull request:
https://github.com/apache/commons-imaging/pull/37
add size guard against corrupted icns files
The problematic incs file: groovy-1.7.5/bin/groovy.icns
From https://bintray.com/groovy/maven/groovy/1.7.5#files
You can merge this
GitHub user hyunuck opened a pull request:
https://github.com/apache/commons-imaging/pull/36
Avoid jpeg parse fail due to jfxx and exif
- add jfxx signature when parsing jpeg
- Avoid jpeg parse fail due to exif
You can merge this pull request into a Git repository by running:
GitHub user kinow opened a pull request:
https://github.com/apache/commons-imaging/pull/35
IMAGING-154 Removed Debug class
Removed the `Debug` and `ImageDump` classes. Also removed methods with the
`verbose` parameter, as well as any `System.out.println`'s. Tried to keep the
change
Github user kinow commented on a diff in the pull request:
https://github.com/apache/commons-imaging/pull/15#discussion_r159147397
--- Diff:
src/main/java/org/apache/commons/imaging/formats/jpeg/decoder/JpegDecoder.java
---
@@ -38,7 +41,7 @@
import static org.apache.com
Github user kinow commented on a diff in the pull request:
https://github.com/apache/commons-imaging/pull/15#discussion_r159147391
--- Diff:
src/main/java/org/apache/commons/imaging/common/BinaryFunctions.java ---
@@ -317,4 +317,23 @@ public static void copyStreamToStream(final
In
Github user kinow commented on a diff in the pull request:
https://github.com/apache/commons-imaging/pull/15#discussion_r159147410
--- Diff: src/test/data/specificTests/info.txt ---
@@ -0,0 +1 @@
+Licensed to the Apache Software Foundation (ASF) under one or more
contributor lic
Github user kinow commented on a diff in the pull request:
https://github.com/apache/commons-imaging/pull/15#discussion_r159147413
--- Diff:
src/test/java/org/apache/commons/imaging/formats/jpeg/specific/JpegImageParserTest.java
---
@@ -0,0 +1,48 @@
+/*
+ * Copyright 2015
Github user kinow commented on a diff in the pull request:
https://github.com/apache/commons-imaging/pull/15#discussion_r159147395
--- Diff:
src/main/java/org/apache/commons/imaging/formats/jpeg/JpegConstants.java ---
@@ -125,7 +136,9 @@
SOF5_MARKER, SOF6_M
Github user asfgit closed the pull request at:
https://github.com/apache/commons-imaging/pull/32
---
-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org
Github user asfgit closed the pull request at:
https://github.com/apache/commons-imaging/pull/33
---
-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org
Github user asfgit closed the pull request at:
https://github.com/apache/commons-imaging/pull/31
---
-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org
GitHub user DasBueroAmDraht opened a pull request:
https://github.com/apache/commons-imaging/pull/34
IMAGING-188
https://issues.apache.org/jira/browse/IMAGING-188
commits:
- support for all icns types listed on wikipedia:
https://en.wikipedia.org/wiki/Apple_Icon_Image_
GitHub user aesy opened a pull request:
https://github.com/apache/commons-imaging/pull/33
Imaging-209 PnmImageParser throws ImageWriteException when writing
if PnmImageParser.PARAM_KEY_PNM_RAWBITS is provided.
I fixed the issue and added a test to cover it.
Issue ca
GitHub user testingsavvy opened a pull request:
https://github.com/apache/commons-imaging/pull/32
add test for DataReaderStripsTest::applyPredictor
This PR adds a new test for `DataReaderStripsTest::applyPredictor`, so that
it can be tested in isolation.
You can merge this pull req
Github user TheRealHaui commented on a diff in the pull request:
https://github.com/apache/commons-imaging/pull/30#discussion_r139785201
--- Diff:
src/test/java/org/apache/commons/imaging/formats/jpeg/xmp/JpegXmpParserTest.java
---
@@ -1,3 +1,19 @@
+/*
--- End diff --
GitHub user TheRealHaui opened a pull request:
https://github.com/apache/commons-imaging/pull/31
add-missing-license-headers
Added missing license headers.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/TheRealHaui/commons-imagin
Github user TheRealHaui commented on a diff in the pull request:
https://github.com/apache/commons-imaging/pull/30#discussion_r132311416
--- Diff: pom.xml ---
@@ -209,6 +209,12 @@
2.5
test
+
--- End diff --
Understand your point.
Github user kinow commented on a diff in the pull request:
https://github.com/apache/commons-imaging/pull/30#discussion_r132310660
--- Diff: pom.xml ---
@@ -209,6 +209,12 @@
2.5
test
+
--- End diff --
Indeed, and I may even use it
Github user TheRealHaui commented on a diff in the pull request:
https://github.com/apache/commons-imaging/pull/30#discussion_r132308184
--- Diff: pom.xml ---
@@ -209,6 +209,12 @@
2.5
test
+
--- End diff --
Well, Equalsverifier ch
Github user TheRealHaui commented on a diff in the pull request:
https://github.com/apache/commons-imaging/pull/30#discussion_r132307800
--- Diff:
src/test/java/org/apache/commons/imaging/formats/tiff/taginfos/TagInfoByteOrShortTest.java
---
@@ -0,0 +1,55 @@
+/*
+ * Licens
Github user TheRealHaui commented on a diff in the pull request:
https://github.com/apache/commons-imaging/pull/30#discussion_r132306981
--- Diff:
src/test/java/org/apache/commons/imaging/formats/pnm/PgmFileInfoTest.java ---
@@ -0,0 +1,49 @@
+/*
+ * Licensed to the Apache S
Github user TheRealHaui commented on a diff in the pull request:
https://github.com/apache/commons-imaging/pull/30#discussion_r132306138
--- Diff:
src/test/java/org/apache/commons/imaging/formats/pnm/PgmFileInfoTest.java ---
@@ -0,0 +1,49 @@
+/*
+ * Licensed to the Apache S
Github user kinow commented on a diff in the pull request:
https://github.com/apache/commons-imaging/pull/18#discussion_r131540224
--- Diff:
src/main/java/org/apache/commons/imaging/formats/jpeg/iptc/IptcParser.java ---
@@ -248,6 +258,35 @@ public PhotoshopApp13Data parsePhotoshopS
Github user kinow commented on a diff in the pull request:
https://github.com/apache/commons-imaging/pull/18#discussion_r131540245
--- Diff:
src/main/java/org/apache/commons/imaging/formats/jpeg/iptc/IptcRecord.java ---
@@ -50,6 +50,10 @@ public IptcRecord(final IptcType iptcType,
Github user kinow commented on a diff in the pull request:
https://github.com/apache/commons-imaging/pull/30#discussion_r131538892
--- Diff:
src/test/java/org/apache/commons/imaging/formats/pnm/PgmFileInfoTest.java ---
@@ -0,0 +1,49 @@
+/*
+ * Licensed to the Apache Softwar
Github user kinow commented on a diff in the pull request:
https://github.com/apache/commons-imaging/pull/30#discussion_r131538887
--- Diff:
src/test/java/org/apache/commons/imaging/formats/pnm/PgmFileInfoTest.java ---
@@ -0,0 +1,49 @@
+/*
+ * Licensed to the Apache Softwar
Github user kinow commented on a diff in the pull request:
https://github.com/apache/commons-imaging/pull/30#discussion_r131538792
--- Diff: pom.xml ---
@@ -209,6 +209,12 @@
2.5
test
+
--- End diff --
-0 Looks like it reduces the
Github user kinow commented on a diff in the pull request:
https://github.com/apache/commons-imaging/pull/30#discussion_r131538871
--- Diff:
src/test/java/org/apache/commons/imaging/formats/jpeg/xmp/JpegXmpParserTest.java
---
@@ -1,3 +1,19 @@
+/*
--- End diff --
G
Github user kinow commented on a diff in the pull request:
https://github.com/apache/commons-imaging/pull/30#discussion_r131538915
--- Diff:
src/test/java/org/apache/commons/imaging/formats/tiff/taginfos/TagInfoByteOrShortTest.java
---
@@ -0,0 +1,55 @@
+/*
+ * Licensed to
GitHub user TheRealHaui opened a pull request:
https://github.com/apache/commons-imaging/pull/30
add-tests
Added new Unit Tests.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/TheRealHaui/commons-imaging add-tests
Alternatively
Github user asfgit closed the pull request at:
https://github.com/apache/commons-imaging/pull/29
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
GitHub user TheRealHaui opened a pull request:
https://github.com/apache/commons-imaging/pull/29
Improve various unit tests style
Code formatting changed as desired in #27 and #28.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/T
Github user TheRealHaui closed the pull request at:
https://github.com/apache/commons-imaging/pull/28
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the fe
Github user TheRealHaui commented on a diff in the pull request:
https://github.com/apache/commons-imaging/pull/27#discussion_r127843760
--- Diff:
src/test/java/org/apache/commons/imaging/formats/tiff/fieldtypes/FieldTypeByteTest.java
---
@@ -0,0 +1,37 @@
+package org.apache.c
Github user jbduncan commented on a diff in the pull request:
https://github.com/apache/commons-imaging/pull/28#discussion_r127780127
--- Diff: src/test/java/org/apache/commons/imaging/ImageDumpTest.java ---
@@ -0,0 +1,44 @@
+package org.apache.commons.imaging;
+
+import
Github user jbduncan commented on a diff in the pull request:
https://github.com/apache/commons-imaging/pull/28#discussion_r127782716
--- Diff:
src/test/java/org/apache/commons/imaging/common/bytesource/ByteSourceTest.java
---
@@ -17,24 +17,22 @@
package org.apache.comm
Github user jbduncan commented on a diff in the pull request:
https://github.com/apache/commons-imaging/pull/28#discussion_r127781644
--- Diff: src/test/java/org/apache/commons/imaging/ImageDumpTest.java ---
@@ -0,0 +1,44 @@
+package org.apache.commons.imaging;
+
+import
Github user jbduncan commented on a diff in the pull request:
https://github.com/apache/commons-imaging/pull/28#discussion_r127780455
--- Diff: src/test/java/org/apache/commons/imaging/ImageDumpTest.java ---
@@ -0,0 +1,44 @@
+package org.apache.commons.imaging;
+
+import
Github user jbduncan commented on a diff in the pull request:
https://github.com/apache/commons-imaging/pull/28#discussion_r127782811
--- Diff:
src/test/java/org/apache/commons/imaging/common/bytesource/ByteSourceTest.java
---
@@ -66,6 +64,22 @@ protected File createTempFile(final
Github user jbduncan commented on a diff in the pull request:
https://github.com/apache/commons-imaging/pull/28#discussion_r127782170
--- Diff:
src/test/java/org/apache/commons/imaging/common/RgbBufferedImageFactoryTest.java
---
@@ -0,0 +1,36 @@
+package org.apache.commons.ima
Github user jbduncan commented on a diff in the pull request:
https://github.com/apache/commons-imaging/pull/28#discussion_r127783301
--- Diff:
src/test/java/org/apache/commons/imaging/formats/jpeg/iptc/IptcTypeLookupTest.java
---
@@ -0,0 +1,28 @@
+package org.apache.commons.i
Github user jbduncan commented on a diff in the pull request:
https://github.com/apache/commons-imaging/pull/28#discussion_r127782622
--- Diff:
src/test/java/org/apache/commons/imaging/common/bytesource/ByteSourceTest.java
---
@@ -17,24 +17,22 @@
package org.apache.comm
Github user jbduncan commented on a diff in the pull request:
https://github.com/apache/commons-imaging/pull/28#discussion_r127781095
--- Diff: src/test/java/org/apache/commons/imaging/ImageDumpTest.java ---
@@ -0,0 +1,44 @@
+package org.apache.commons.imaging;
+
+import
Github user jbduncan commented on a diff in the pull request:
https://github.com/apache/commons-imaging/pull/28#discussion_r127781035
--- Diff: src/test/java/org/apache/commons/imaging/ImageDumpTest.java ---
@@ -0,0 +1,44 @@
+package org.apache.commons.imaging;
+
+import
Github user jbduncan commented on a diff in the pull request:
https://github.com/apache/commons-imaging/pull/28#discussion_r127783226
--- Diff:
src/test/java/org/apache/commons/imaging/formats/bmp/BmpWriterRgbTest.java ---
@@ -0,0 +1,35 @@
+package org.apache.commons.imaging.fo
Github user jbduncan commented on a diff in the pull request:
https://github.com/apache/commons-imaging/pull/28#discussion_r127781676
--- Diff:
src/test/java/org/apache/commons/imaging/common/RgbBufferedImageFactoryTest.java
---
@@ -0,0 +1,36 @@
+package org.apache.commons.ima
Github user jbduncan commented on a diff in the pull request:
https://github.com/apache/commons-imaging/pull/28#discussion_r127782199
--- Diff:
src/test/java/org/apache/commons/imaging/common/RgbBufferedImageFactoryTest.java
---
@@ -0,0 +1,36 @@
+package org.apache.commons.ima
Github user jbduncan commented on a diff in the pull request:
https://github.com/apache/commons-imaging/pull/28#discussion_r127781398
--- Diff: src/test/java/org/apache/commons/imaging/ImageDumpTest.java ---
@@ -0,0 +1,44 @@
+package org.apache.commons.imaging;
+
+import
Github user jbduncan commented on a diff in the pull request:
https://github.com/apache/commons-imaging/pull/28#discussion_r127782141
--- Diff:
src/test/java/org/apache/commons/imaging/common/RgbBufferedImageFactoryTest.java
---
@@ -0,0 +1,36 @@
+package org.apache.commons.ima
Github user jbduncan commented on a diff in the pull request:
https://github.com/apache/commons-imaging/pull/28#discussion_r127781871
--- Diff:
src/test/java/org/apache/commons/imaging/common/RgbBufferedImageFactoryTest.java
---
@@ -0,0 +1,36 @@
+package org.apache.commons.ima
Github user jbduncan commented on a diff in the pull request:
https://github.com/apache/commons-imaging/pull/27#discussion_r127778422
--- Diff:
src/test/java/org/apache/commons/imaging/common/bytesource/ByteSourceTest.java
---
@@ -66,6 +64,22 @@ protected File createTempFile(final
GitHub user TheRealHaui opened a pull request:
https://github.com/apache/commons-imaging/pull/28
Increase code coverage one
Added various improvements to selected Unit Tests.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/TheReal
Github user TheRealHaui commented on a diff in the pull request:
https://github.com/apache/commons-imaging/pull/27#discussion_r127775941
--- Diff:
src/test/java/org/apache/commons/imaging/formats/tiff/fieldtypes/FieldTypeByteTest.java
---
@@ -0,0 +1,37 @@
+package org.apache.c
Github user TheRealHaui commented on a diff in the pull request:
https://github.com/apache/commons-imaging/pull/27#discussion_r127770670
--- Diff:
src/test/java/org/apache/commons/imaging/formats/pnm/PbmFileInfoTest.java ---
@@ -0,0 +1,41 @@
+package org.apache.commons.imaging.
Github user TheRealHaui commented on a diff in the pull request:
https://github.com/apache/commons-imaging/pull/27#discussion_r127770520
--- Diff:
src/test/java/org/apache/commons/imaging/formats/pnm/PbmFileInfoTest.java ---
@@ -0,0 +1,41 @@
+package org.apache.commons.imaging.
Github user TheRealHaui commented on a diff in the pull request:
https://github.com/apache/commons-imaging/pull/27#discussion_r127769590
--- Diff:
src/test/java/org/apache/commons/imaging/formats/jpeg/segments/JfifSegmentTest.java
---
@@ -0,0 +1,35 @@
+package org.apache.commo
Github user TheRealHaui commented on a diff in the pull request:
https://github.com/apache/commons-imaging/pull/27#discussion_r127768831
--- Diff:
src/test/java/org/apache/commons/imaging/common/bytesource/ByteSourceTest.java
---
@@ -66,6 +64,22 @@ protected File createTempFile(fi
Github user TheRealHaui commented on a diff in the pull request:
https://github.com/apache/commons-imaging/pull/27#discussion_r127768274
--- Diff:
src/test/java/org/apache/commons/imaging/formats/bmp/BmpWriterRgbTest.java ---
@@ -0,0 +1,35 @@
+package org.apache.commons.imaging
Github user TheRealHaui commented on a diff in the pull request:
https://github.com/apache/commons-imaging/pull/27#discussion_r127761190
--- Diff:
src/test/java/org/apache/commons/imaging/formats/bmp/BmpWriterRgbTest.java ---
@@ -0,0 +1,35 @@
+package org.apache.commons.imaging
Github user onealj commented on a diff in the pull request:
https://github.com/apache/commons-imaging/pull/27#discussion_r127632776
--- Diff:
src/test/java/org/apache/commons/imaging/formats/jpeg/segments/JfifSegmentTest.java
---
@@ -0,0 +1,35 @@
+package org.apache.commons.im
Github user onealj commented on a diff in the pull request:
https://github.com/apache/commons-imaging/pull/27#discussion_r127633319
--- Diff:
src/test/java/org/apache/commons/imaging/formats/tiff/fieldtypes/FieldTypeByteTest.java
---
@@ -0,0 +1,37 @@
+package org.apache.common
Github user onealj commented on a diff in the pull request:
https://github.com/apache/commons-imaging/pull/27#discussion_r127633025
--- Diff:
src/test/java/org/apache/commons/imaging/formats/pnm/PbmFileInfoTest.java ---
@@ -0,0 +1,41 @@
+package org.apache.commons.imaging.forma
Github user onealj commented on a diff in the pull request:
https://github.com/apache/commons-imaging/pull/27#discussion_r127632145
--- Diff:
src/test/java/org/apache/commons/imaging/formats/bmp/BmpWriterRgbTest.java ---
@@ -0,0 +1,35 @@
+package org.apache.commons.imaging.form
Github user onealj commented on a diff in the pull request:
https://github.com/apache/commons-imaging/pull/27#discussion_r127632387
--- Diff:
src/test/java/org/apache/commons/imaging/formats/bmp/BmpWriterRgbTest.java ---
@@ -0,0 +1,35 @@
+package org.apache.commons.imaging.form
Github user onealj commented on a diff in the pull request:
https://github.com/apache/commons-imaging/pull/27#discussion_r127632531
--- Diff:
src/test/java/org/apache/commons/imaging/common/bytesource/ByteSourceTest.java
---
@@ -66,6 +64,22 @@ protected File createTempFile(final b
Github user onealj commented on a diff in the pull request:
https://github.com/apache/commons-imaging/pull/27#discussion_r127632941
--- Diff:
src/test/java/org/apache/commons/imaging/formats/pnm/PbmFileInfoTest.java ---
@@ -0,0 +1,41 @@
+package org.apache.commons.imaging.forma
Github user asfgit closed the pull request at:
https://github.com/apache/commons-imaging/pull/27
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
GitHub user TheRealHaui opened a pull request:
https://github.com/apache/commons-imaging/pull/27
Increase code coverage one
I have created Unit Tests to increase code coverage which I want to
contribute.
You can merge this pull request into a Git repository by running:
$ git p
Github user asfgit closed the pull request at:
https://github.com/apache/commons-imaging/pull/26
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
GitHub user deroneriksson opened a pull request:
https://github.com/apache/commons-imaging/pull/26
(doc) Update sample usage example links from svn to git
This updates the broken example links at src/site/xdoc/sampleusage.xml so
that the generated page at target/site/sampleusage.htm
90 matches
Mail list logo
