[RESULT][VOTE] Release Apache Commons DBCP 2.3.0 based on RC1

2018-05-12 Thread Gary Gregory
This VOTE passes with three (3) binding votes from the following PMC members: - Rob Tompkins (chtompki) - Gary Gregory (ggregory) - Oliver Heger (oheger) I will proceed with the release today... Gary On Tue, May 8, 2018 at 6:08 PM, Gary Gregory wrote: > We have fixed quite a few bugs and adde

Re: [VOTE] Release Apache Commons DBCP 2.3.0 based on RC1

2018-05-12 Thread Oliver Heger
Am 12.05.2018 um 20:16 schrieb Gary Gregory: > On Sat, May 12, 2018 at 10:37 AM, Oliver Heger > wrote: > >> Build works fine with Java 1.7 and 1.8 - even the ant build seems to >> work. Artifacts and site look good. >> >> The only problem I noticed is that the release notes refer to version >> "

Re: [VOTE] Release Apache Commons DBCP 2.3.0 based on RC1

2018-05-12 Thread Gary Gregory
On Sat, May 12, 2018 at 10:37 AM, Oliver Heger wrote: > Build works fine with Java 1.7 and 1.8 - even the ant build seems to > work. Artifacts and site look good. > > The only problem I noticed is that the release notes refer to version > "2.3.0-SNAPSHOT", which is confusing. > > Do you think thi

Re: [VOTE] Release Apache Commons DBCP 2.3.0 based on RC1

2018-05-12 Thread Oliver Heger
Build works fine with Java 1.7 and 1.8 - even the ant build seems to work. Artifacts and site look good. The only problem I noticed is that the release notes refer to version "2.3.0-SNAPSHOT", which is confusing. Do you think this requires a new RC or can we live with that? Oliver Am 09.05.2018

Re: [VOTE] Release Apache Commons DBCP 2.3.0 based on RC1

2018-05-12 Thread Gary Gregory
May I get more reviews please? Gary On Tue, May 8, 2018, 18:08 Gary Gregory wrote: > We have fixed quite a few bugs and added some significant enhancements > since Apache Commons DBCP 2.2.0 was released, so I would like to release > Commons DBCP 2.3.0. > > Commons DBCP 2.3.0 RC1 is available fo

Re: [VOTE] Release Apache Commons DBCP 2.3.0 based on RC1

2018-05-10 Thread Gary Gregory
My +1. Gary On Tue, May 8, 2018 at 6:08 PM, Gary Gregory wrote: > We have fixed quite a few bugs and added some significant enhancements > since Apache Commons DBCP 2.2.0 was released, so I would like to release > Commons DBCP 2.3.0. > > Commons DBCP 2.3.0 RC1 is available for review here: >

Re: [VOTE] Release Apache Commons DBCP 2.3.0 based on RC1

2018-05-09 Thread Rob Tompkins
> On May 9, 2018, at 11:34 AM, Gary Gregory wrote: > >> On Wed, May 9, 2018 at 9:28 AM, Rob Tompkins wrote: >> >> +1 >> >> Signatures Ok, >> Rat OK >> build ok maven 3.5.3: java7, java8, java9, >> >> >> Some nits 1. is the main one that needs to be addressed: >> >> 1. RELEASE-NOTES.txt ha

Re: [VOTE] Release Apache Commons DBCP 2.3.0 based on RC1

2018-05-09 Thread Gary Gregory
On Wed, May 9, 2018 at 9:28 AM, Rob Tompkins wrote: > +1 > > Signatures Ok, > Rat OK > build ok maven 3.5.3: java7, java8, java9, > > > Some nits 1. is the main one that needs to be addressed: > > 1. RELEASE-NOTES.txt has "-SNAPSHOT" in itfixable after the fact. > 2. dist artifact signatures

Re: [VOTE] Release Apache Commons DBCP 2.3.0 based on RC1

2018-05-09 Thread Rob Tompkins
+1 Signatures Ok, Rat OK build ok maven 3.5.3: java7, java8, java9, Some nits 1. is the main one that needs to be addressed: 1. RELEASE-NOTES.txt has "-SNAPSHOT" in itfixable after the fact. 2. dist artifact signatures have carrage return at end of hash (maybe bug in release-plugin) 3. Si

[VOTE] Release Apache Commons DBCP 2.3.0 based on RC1

2018-05-08 Thread Gary Gregory
We have fixed quite a few bugs and added some significant enhancements since Apache Commons DBCP 2.2.0 was released, so I would like to release Commons DBCP 2.3.0. Commons DBCP 2.3.0 RC1 is available for review here: https://dist.apache.org/repos/dist/dev/commons/dbcp/ (svn revision 26776) Th