On 2011-10-26, Gary Gregory wrote:
> Also should be fixed but not show stoppers:
[snip those fixed in trunk now]
> DescriptionResourcePathLocationType
> Unnecessary cast from byte to longDumpArchiveUtil.java
> /commons-compress/src/main/java/org/apache/commons/compress/archi
On 2011-10-26, Gary Gregory wrote:
> I would also remove or add comments as to why these are needed in
> org.apache.commons.compress.archivers.jar.JarArchiveEntry:
> @Override
> public boolean equals(Object o) {
> return super.equals(o);
> }
> @Override
> public int h
On 2011-10-26, Gary Gregory wrote:
> in trunk now, the following have 0% code coverage according to
> Cobertura:
> - Lister
really only a demo-class.
> - DumpArchiveConstants: How can it have 0% when it is used? Does Cobertura
> know how to deal with enums?
It outer class doesn't have any meth
On Wed, Oct 26, 2011 at 10:36 AM, Stefan Bodewig wrote:
> On 2011-10-26, Gary Gregory wrote:
>
> > On Wed, Oct 26, 2011 at 9:18 AM, Gary Gregory >wrote:
>
> >> On Wed, Oct 26, 2011 at 8:55 AM, Simone Tripodi <
> simonetrip...@apache.org>wrote:
>
> >>> Hi Gary!
> >>> OK so it is expected because
On Wed, Oct 26, 2011 at 4:54 AM, Emmanuel Bourg wrote:
> +0
>
> The test coverage of Pack200CompressorInputStream is a bit low, the read
> methods do not seem to be tested.
>
> Also in the matches() method the constant '4' could be replaced by
> CAFE_DOOD.length
>
> Emmanuel Bourg
In the same v
On 2011-10-26, Gary Gregory wrote:
> On Wed, Oct 26, 2011 at 9:18 AM, Gary Gregory wrote:
>> On Wed, Oct 26, 2011 at 8:55 AM, Simone Tripodi
>> wrote:
>>> Hi Gary!
>>> OK so it is expected because revision number neither SCM branch can be
>>> determined since the source code is not under the ve
On Wed, Oct 26, 2011 at 9:18 AM, Gary Gregory wrote:
> On Wed, Oct 26, 2011 at 8:55 AM, Simone Tripodi
> wrote:
>
>> Hi Gary!
>> OK so it is expected because revision number neither SCM branch can be
>> determined since the source code is not under the version control!
>>
>
> Yep, makes sense now
Noting for the record a strange behavior on Oracle Java 1.7.0_01:
[INFO] Generating "JIRA Report" report--- maven-changes-plugin:2.3
Oct 26, 2011 9:41:46 AM org.apache.commons.httpclient.HttpMethodDirector
executeWithRetry
INFO: I/O exception (java.net.SocketException) caught when processing
r
On Wed, Oct 26, 2011 at 9:28 AM, Gary Gregory wrote:
> On Wed, Oct 26, 2011 at 7:02 AM, Stefan Bodewig wrote:
>
>> On 2011-10-26, Stefan Bodewig wrote:
>>
>> > On 2011-10-26, Emmanuel Bourg wrote:
>>
>> >> The test coverage of Pack200CompressorInputStream is a bit low, the
>> >> read methods do no
On Wed, Oct 26, 2011 at 7:02 AM, Stefan Bodewig wrote:
> On 2011-10-26, Stefan Bodewig wrote:
>
> > On 2011-10-26, Emmanuel Bourg wrote:
>
> >> The test coverage of Pack200CompressorInputStream is a bit low, the
> >> read methods do not seem to be tested.
>
> > Only the three-arg version is used,
Hi Gary!
OK so it is expected because revision number neither SCM branch can be
determined since the source code is not under the version control!
HTH, have a nice day!
Simo
>
> Right, I was building from the src zip.
>
> Gary
>
Simo
http://people.apache.org/~simonetripodi/
http://simonetripodi.
On Wed, Oct 26, 2011 at 8:30 AM, Simone Tripodi wrote:
> Hi Gary,
> if I got it right, you tried to build the sources downloaded from the
> zip/tar.gz and not the checked out from svn, right?
> In that case, it is normal because it's not possible to retrieve such
> informations from SVN.
>
Right,
Le 26/10/2011 13:02, Stefan Bodewig a écrit :
82% line coverage and 100% branch coverage in trunk. No code changes in
main, no test failures.
While I was at it I added test for CountingInputStream to make the
statistics look nicer.
Great! You have my +1
Emmanuel Bourg
-
Hi Gary,
if I got it right, you tried to build the sources downloaded from the
zip/tar.gz and not the checked out from svn, right?
In that case, it is normal because it's not possible to retrieve such
informations from SVN.
If not... uhm, something went wrong!
All the best, HTH,
Simo
http://people
Are these warnings normal?
[INFO] --- buildnumber-maven-plugin:1.0:create (default) @ commons-compress
---
[INFO] Change the default 'svn' provider implementation to 'javasvn'.
[INFO] Checking for local modifications: skipped.
[INFO] Updating project files from SCM: skipped.
[WARNING] Cannot get t
On 2011-10-26, Stefan Bodewig wrote:
> On 2011-10-26, Emmanuel Bourg wrote:
>> The test coverage of Pack200CompressorInputStream is a bit low, the
>> read methods do not seem to be tested.
> Only the three-arg version is used, this is true.
> I'll look into getting more coverage in trunk so it
On 2011-10-26, Emmanuel Bourg wrote:
> The test coverage of Pack200CompressorInputStream is a bit low, the
> read methods do not seem to be tested.
Only the three-arg version is used, this is true.
I'll look into getting more coverage in trunk so it will improve with
the next release (or the nex
+0
The test coverage of Pack200CompressorInputStream is a bit low, the read
methods do not seem to be tested.
Also in the matches() method the constant '4' could be replaced by
CAFE_DOOD.length
Emmanuel Bourg
Le 26/10/2011 06:54, Stefan Bodewig a écrit :
Compress 1.3 RC1 is available for
Le 26/10/2011 06:54, Stefan Bodewig a écrit :
> Compress 1.3 RC1 is available for review here:
> http://people.apache.org/~bodewig/commons-compress/
>
> Maven artifacts are here:
>
> https://repository.apache.org/content/repositories/orgapachecommons-101/org/apache/commons/commons-compr
On 2011-10-26, Stefan Bodewig wrote:
> Compress 1.3 RC1 is available for review here:
> http://people.apache.org/~bodewig/commons-compress/
> Maven artifacts are here:
>
> https://repository.apache.org/content/repositories/orgapachecommons-101/org/apache/commons/commons-compress/1.3/
Compress 1.3 RC1 is available for review here:
http://people.apache.org/~bodewig/commons-compress/
Maven artifacts are here:
https://repository.apache.org/content/repositories/orgapachecommons-101/org/apache/commons/commons-compress/1.3/
Details of changes since 1.1 are in the releas
21 matches
Mail list logo
