Re: [compress] Preparations for 1.10

On 2015-01-25, Emmanuel Bourg wrote: > Le 25/01/2015 11:38, Benedikt Ritter a écrit : >> I'm not a compress developer, but IMHO exceptions should be packaged by >> their API and not by their nature. > Thank you for moving the exception Stefan, however I tend to agree with > Benedikt on this, ex

Re: [compress] Preparations for 1.10

On Sun, Jan 25, 2015 at 4:37 PM, Emmanuel Bourg wrote: > Le 25/01/2015 11:38, Benedikt Ritter a écrit : > > > I'm not a compress developer, but IMHO exceptions should be packaged by > their API and not by their nature. > > Thank you for moving the exception Stefan, however I tend to agree with >

Re: [compress] Preparations for 1.10

Le 25/01/2015 11:38, Benedikt Ritter a écrit : > I'm not a compress developer, but IMHO exceptions should be packaged by their > API and not by their nature. Thank you for moving the exception Stefan, however I tend to agree with Benedikt on this, exceptions are better placed in the base package

Re: [compress] Preparations for 1.10

Hi, > Am 24.01.2015 um 13:18 schrieb Stefan Bodewig : > >> On 2015-01-23, Emmanuel Bourg wrote: >> >> Le 22/01/2015 17:30, Stefan Bodewig a écrit : > >>> Please have a look and identify stuff that looks as if I'd have to >>> reroll a new RC should it come to a vote with the current code base.

Re: [compress] Preparations for 1.10

On 2015-01-25, sebb wrote: > On 25 January 2015 at 05:11, Stefan Bodewig wrote: >> On 2015-01-24, Kristian Rosenvold wrote: >>> After an intense few minutes discussing the color of the bike shed >>> with myself (package name) I moved the zip-unspecific parallel stuff >>> to org.apache.commons.co

Re: [compress] Preparations for 1.10

On 25 January 2015 at 05:11, Stefan Bodewig wrote: > On 2015-01-24, Kristian Rosenvold wrote: > >> After an intense few minutes discussing the color of the bike shed >> with myself (package name) I moved the zip-unspecific parallel stuff >> to org.apache.commons.compress.parallel in r1654572. > >

Re: [compress] Preparations for 1.10

On 2015-01-24, Kristian Rosenvold wrote: > After an intense few minutes discussing the color of the bike shed > with myself (package name) I moved the zip-unspecific parallel stuff > to org.apache.commons.compress.parallel in r1654572. Maybe add a package-info.java? I'll need to add one to the e

Re: [compress] Preparations for 1.10

On 2015-01-24, Kristian Rosenvold wrote: > I suppose the "what's new section" on the site also needs to be > updated to 1.10 ? Yes, that would be good. > Anything else I can assist with before the release ? Thanks. I intend to spend a bit of time with BitInputStream and cut the RC tomorrow, at

Re: [compress] Preparations for 1.10

After an intense few minutes discussing the color of the bike shed with myself (package name) I moved the zip-unspecific parallel stuff to org.apache.commons.compress.parallel in r1654572. This concludes the changes Emmanuel suggested. I have already responded to a few of the comments that did not

Re: [compress] Preparations for 1.10

On 2015-01-23, Emmanuel Bourg wrote: > Le 22/01/2015 17:30, Stefan Bodewig a écrit : >> Please have a look and identify stuff that looks as if I'd have to >> reroll a new RC should it come to a vote with the current code base. > I reviewed the API changes, here are my comments: > - PasswordRequ

Re: [compress] Preparations for 1.10

2015-01-23 11:52 GMT+01:00 Emmanuel Bourg : > - PasswordRequiredException: the exception is in the sevenz package, do > we want to move it elsewhere so it can be used later for other formats > like zip (if that makes sense). Makes sense, where should we put that ? > - there are some missing @sin

Re: [compress] Preparations for 1.10

Thanks for lots of great comments ! Just a few comments about some of the items; Regarding the *Supplier interfaces, the basic idea is that once commons-compress reaches jdk 1.8 language level (somewhere in the late 2030's :-) some of such interfaces may be modified to extend java.util.function.Su

Re: [compress] Preparations for 1.10

Le 22/01/2015 17:30, Stefan Bodewig a écrit : > Please have a look and identify stuff that looks as if I'd have to > reroll a new RC should it come to a vote with the current code base. I reviewed the API changes, here are my comments: - PasswordRequiredException: the exception is in the sevenz

Re: [compress] Preparations for 1.10

Here is an easy one: "Avoid unused imports such as 'java.io.InputStream". Gary On Thu, Jan 22, 2015 at 11:30 AM, Stefan Bodewig wrote: > Hi all > > I've had good experience with creating a site build before cutting a > release candidate, so here we go: > >

[compress] Preparations for 1.10

Hi all I've had good experience with creating a site build before cutting a release candidate, so here we go: Please have a look and identify stuff that looks as if I'd have to reroll a new RC should it come to a vote with the current