Re: [cvs] CSVLexer.isEndOfLine(int c) makes assumptions on the line separator of a CSVFormat

2012-03-12 Thread Emmanuel Bourg
Le 12/03/2012 18:51, Benedikt Ritter a écrit : you wrote about the printer ;) Yes, because the line separator of CSVFormat is only used there. Usually you have to be permissive in what your read, but strict on what your write. Emmanuel Bourg smime.p7s Description: S/MIME Cryptographic S

Re: [cvs] CSVLexer.isEndOfLine(int c) makes assumptions on the line separator of a CSVFormat

2012-03-12 Thread Emmanuel Bourg
Le 12/03/2012 18:52, sebb a écrit : The only possible ambiguity is whether the file uses CR, LF, or CRLF. Yes that's what I mean by knowing in advance. The line separator is not obvious when you open the file in an editor. That's not the case for the delimiter. Emmanuel Bourg smime.p7s

Re: [cvs] CSVLexer.isEndOfLine(int c) makes assumptions on the line separator of a CSVFormat

2012-03-12 Thread sebb
On 12 March 2012 17:38, Emmanuel Bourg wrote: > Le 12/03/2012 18:31, Benedikt Ritter a écrit : > > >> I'm not sure if I got you right. You have to pass a CSVFormat if you >> want to construct a CSVLexer(), so we could use the lexer's internal >> CSVformat. > > > Yes that's what I understood, when

Re: [cvs] CSVLexer.isEndOfLine(int c) makes assumptions on the line separator of a CSVFormat

2012-03-12 Thread Benedikt Ritter
Am 12. März 2012 18:38 schrieb Emmanuel Bourg : > Le 12/03/2012 18:31, Benedikt Ritter a écrit : > > >> I'm not sure if I got you right. You have to pass a CSVFormat if you >> want to construct a CSVLexer(), so we could use the lexer's internal >> CSVformat. > > > Yes that's what I understood, when

Re: [cvs] CSVLexer.isEndOfLine(int c) makes assumptions on the line separator of a CSVFormat

2012-03-12 Thread Emmanuel Bourg
Le 12/03/2012 18:31, Benedikt Ritter a écrit : I'm not sure if I got you right. You have to pass a CSVFormat if you want to construct a CSVLexer(), so we could use the lexer's internal CSVformat. Yes that's what I understood, when I mention the parser it includes the lexer as well. I think

Re: [cvs] CSVLexer.isEndOfLine(int c) makes assumptions on the line separator of a CSVFormat

2012-03-12 Thread Benedikt Ritter
Am 12. März 2012 18:24 schrieb Emmanuel Bourg : > Le 12/03/2012 18:17, Benedikt Ritter a écrit : > > >> this method assumes, that a line separator will always be "\r" or >> "\r\n". This is true for the pre-configured CSVFormats EXCEL, TDF and >> MYSQL. I'm not a pro when it comes to file encoding,

Re: [cvs] CSVLexer.isEndOfLine(int c) makes assumptions on the line separator of a CSVFormat

2012-03-12 Thread Emmanuel Bourg
Le 12/03/2012 18:17, Benedikt Ritter a écrit : this method assumes, that a line separator will always be "\r" or "\r\n". This is true for the pre-configured CSVFormats EXCEL, TDF and MYSQL. I'm not a pro when it comes to file encoding, but isn't there the possibility that new encodings will have

[cvs] CSVLexer.isEndOfLine(int c) makes assumptions on the line separator of a CSVFormat

2012-03-12 Thread Benedikt Ritter
Hi, while looking for potential performance optimization I came across CSVLexer.isEndOfLine(int c). Here is the source: private boolean isEndOfLine(int c) throws IOException { // check if we have \r\n... if (c == '\r' && in.lookAhead() == '\n') { // note: does not