Re: Re: Re: [lang] Introduce @NonNull, and @Nullable

, by all means, remove it, although I'm > > probably > > > > > the least one to call for that. > > > > > > > > > > And since we are at it: Are you aware of any explicit mentioning > of a > > > > > dependency policy wrt. commons? >

Re: Re: Re: [lang] Introduce @NonNull, and @Nullable

gt; > > I take that as a no. > > > > > > Thomas > > > > > > > > > > > > Gesendet: Montag, 15. Februar 2021 um 16:59 Uhr > > > Von: "Gary Gregory" > > > An: "Commons Developers List" > >

Re: Re: Re: [lang] Introduce @NonNull, and @Nullable

e sins > > post fact :-) > > > > I take that as a no. > > > > Thomas > > > > > > > > Gesendet: Montag, 15. Februar 2021 um 16:59 Uhr > > Von: "Gary Gregory" > > An: "Commons Developers List" > > Betreff: R

Re: Re: Re: [lang] Introduce @NonNull, and @Nullable

u aware of any explicit mentioning of a > > dependency policy wrt. commons? > > Maybe commons should set up some Wiki page, and start actively managing > > that? > > A convenient place to point to, when discussions about that occur? > > > > Thomas > > > >

Aw: Re: Re: [lang] Introduce @NonNull, and @Nullable

16:59 Uhr Von: "Gary Gregory" An: "Commons Developers List" Betreff: Re: Re: [lang] Introduce @NonNull, and @Nullable I do not think we need a wiki since each project should have a Maven generated page like https://commons.apache.org/proper/commons-lang/dependencies.html G

Re: Re: [lang] Introduce @NonNull, and @Nullable

A convenient place to point to, when discussions about that occur? > > Thomas > > Gesendet: Montag, 15. Februar 2021 um 14:38 Uhr > Von: "Gary Gregory" > An: "Commons Developers List" > Betreff: Re: [lang] Introduce @NonNull, and @Nullable > This is alread

Aw: Re: [lang] Introduce @NonNull, and @Nullable

page, and start actively managing that? A convenient place to point to, when discussions about that occur? Thomas   Gesendet: Montag, 15. Februar 2021 um 14:38 Uhr Von: "Gary Gregory" An: "Commons Developers List" Betreff: Re: [lang] Introduce @NonNull, and @Nullable This is

Re: [lang] Introduce @NonNull, and @Nullable

this > doomed package now. > > > Gesendet: Samstag, 13. Februar 2021 um 21:13 Uhr > Von: "Gary Gregory" > An: "Commons Developers List" > Betreff: Re: Re: [lang] Introduce @NonNull, and @Nullable > So... it is my impression now that we should remove the

Re: [lang] Introduce @NonNull, and @Nullable

out jsr305, don't start introducing this doomed package now. Gesendet: Samstag, 13. Februar 2021 um 21:13 Uhr Von: "Gary Gregory" An: "Commons Developers List" Betreff: Re: Re: [lang] Introduce @NonNull, and @Nullable So... it is my impression now that we should remove thes

Re: Re: [lang] Introduce @NonNull, and @Nullable

e of use. > > > > > > Gesendet: Montag, 08. Februar 2021 um 00:37 Uhr > Von: "Gary Gregory" > An: "Commons Developers List" > Betreff: Re: [lang] Introduce @NonNull, and @Nullable > Isn't the root issue is that all toolchains nee

Aw: Re: [lang] Introduce @NonNull, and @Nullable

indicating nullability and attribute sizes, that might be of use.     Gesendet: Montag, 08. Februar 2021 um 00:37 Uhr Von: "Gary Gregory" An: "Commons Developers List" Betreff: Re: [lang] Introduce @NonNull, and @Nullable Isn't the root issue is that all toolchains

Re: [lang] Introduce @NonNull, and @Nullable

I believe Simon was referring to: https://jspecify.dev/ https://github.com/jspecify/jspecify The table that shows the participants is not being displayed currently (just me?), one can view the source though: https://jspecify.dev/_sources/index.rst.txt Worth checking this related thread too: ht

Re: [lang] Introduce @NonNull, and @Nullable

Isn't the root issue is that all toolchains need to agree on the new annotations? What's that going to be? On Sun, Feb 7, 2021, 17:56 si...@ochsenreither.de wrote: > > Agree on that – adding a dependency on the JSR-305 jar is a really really > bad idea for all the reasons already outlined. I'll

Re: [lang] Introduce @NonNull, and @Nullable

Agree on that – adding a dependency on the JSR-305 jar is a really really bad idea for all the reasons already outlined. I'll add another one: At my place, we have actively been removing any usage of these annotations as you simply can't use these annotations and the "real" javax.annotations pa

Re: [lang] Introduce @NonNull, and @Nullable

Hi, I'd like to point out, that there actually *is* a licensing issue regarding @NonNull and its siblings in javax.annotations : Not with the library, but with the prefix 'javax.'. As you might have noted, Oracle recently closed a deal with the Eclipse Foundation, allowing the Eclipse Foundation t

Re: [lang] Introduce @NonNull, and @Nullable

Provided dependencies typically mean that the dependency is copied into another dependency (think Java EE APIs typically) and doesn't need to be added by a runtime dependency. It's kind of the opposite of the runtime scope which doesn't add it at compile time but does at runtime. On Thu, 4 Feb 202

RE: [lang] Introduce @NonNull, and @Nullable

>> It is also picked up automatically with scope=provided. >Useful to know; the Maven documentation is not explicit on that. >The name makes it sound as though the user has to provide the jar themselves. You're right, the user has to provide the jar themselves. But only if it's _needed_ at runtim

Re: [lang] Introduce @NonNull, and @Nullable

On Thu, 4 Feb 2021 at 20:28, Jochen Wiedmann wrote: > > > > On 2021/02/02 11:34:09, sebb wrote: > > > In which case it should surely be listed as a compile dependency so > > that it is picked up automatically? > > It is also picked up automatically with scope=provided. Useful to know; the Maven

Re: [lang] Introduce @NonNull, and @Nullable

On 2021/02/02 08:10:33, Julian Reschke wrote: > Please see . I may be missing the point here, so help me: My impression is, that the user doesn't need the jsr305 jar in the classpath, if we use it in out sources. If so, how should the Java 9 JRE detect t

Re: [lang] Introduce @NonNull, and @Nullable

On 2021/02/02 11:34:09, sebb wrote: > In which case it should surely be listed as a compile dependency so > that it is picked up automatically? It is also picked up automatically with scope=provided. - To unsubscribe, e-ma

Re: [lang] Introduce @NonNull, and @Nullable

On 2021/02/01 16:45:46, Tomo Suzuki wrote: > I like "javax.annotation namespace" too. > > Would you be willing to share more about why the annotation dependency > should have "provided" scope? If a library (commons-lang) requires a > dependency at runtime, I believe it should declare it as "c

AW: [lang] Introduce @NonNull, and @Nullable

Betreff: Re: [lang] Introduce @NonNull, and @Nullable > You can use the provided scope to make it compile-time only and avoid > requiring it as a runtime dependency. Diese Mail wurde aus Datenschutzgründen verschlüsselt ve

Re: [lang] Introduce @NonNull, and @Nullable

You can use the provided scope to make it compile-time only and avoid requiring it as a runtime dependency. On Tue, 2 Feb 2021 at 05:34, sebb wrote: > > On Mon, 1 Feb 2021 at 22:39, Gary Gregory wrote: > > > > Well, it's in a 3rd party jar, just like JUnit and whatever else is needed > > to comp

Re: [lang] Introduce @NonNull, and @Nullable

On Mon, 1 Feb 2021 at 22:39, Gary Gregory wrote: > > Well, it's in a 3rd party jar, just like JUnit and whatever else is needed > to complete a decent build... In which case it should surely be listed as a compile dependency so that it is picked up automatically? Users don't have to do anything

Re: [lang] Introduce @NonNull, and @Nullable

Am 01.02.2021 um 17:45 schrieb Tomo Suzuki: I like "javax.annotation namespace" too. ... Please see . Best regards, Julian - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For a

Re: [lang] Introduce @NonNull, and @Nullable

Well, it's in a 3rd party jar, just like JUnit and whatever else is needed to complete a decent build... On Mon, Feb 1, 2021, 17:22 sebb wrote: > On Mon, 1 Feb 2021 at 17:56, Matt Sicker wrote: > > > > Compile time annotations would only be necessary to build the commons > > component. > > i.e.

Re: [lang] Introduce @NonNull, and @Nullable

On Mon, 1 Feb 2021 at 17:56, Matt Sicker wrote: > > Compile time annotations would only be necessary to build the commons > component. i.e. consumers of the source code would be required to provide the annotations in some form. This does not sound ideal. > Unless they're runtime scope, but even

Re: [lang] Introduce @NonNull, and @Nullable

Compile time annotations would only be necessary to build the commons component. Unless they're runtime scope, but even that can work without class loader errors provided you're not reflecting on it. On Mon, 1 Feb 2021 at 11:45, sebb wrote: > > On Mon, 1 Feb 2021 at 16:52, Tomo Suzuki wrote: > >

Re: [lang] Introduce @NonNull, and @Nullable

On Mon, 1 Feb 2021 at 16:52, Tomo Suzuki wrote: > > I like "javax.annotation namespace" too. > > Would you be willing to share more about why the annotation dependency > should have "provided" scope? If a library (commons-lang) requires a > dependency at runtime, I believe it should declare it as

Re: [lang] Introduce @NonNull, and @Nullable

I like "javax.annotation namespace" too. Would you be willing to share more about why the annotation dependency should have "provided" scope? If a library (commons-lang) requires a dependency at runtime, I believe it should declare it as "compile" dependency. In past, I did troubleshooting for mis

Re: [lang] Introduce @NonNull, and @Nullable

The ASF releases source. Does the inclusion of these source annotations impose a burden on people who download and compile our source? On Mon, 1 Feb 2021 at 14:31, Julian Reschke wrote: > > Am 01.02.2021 um 15:04 schrieb Gilles Sadowski: > > Le lun. 1 févr. 2021 à 14:49, Jochen Wiedmann > > a é

Re: [lang] Introduce @NonNull, and @Nullable

Am 01.02.2021 um 15:04 schrieb Gilles Sadowski: Le lun. 1 févr. 2021 à 14:49, Jochen Wiedmann a écrit : On Mon, Feb 1, 2021 at 2:34 PM Gary Gregory wrote: 1) Don't add and use custom annotations, this opens the door to each of our 20+ components doing the same thing, so pick a library and s

Re: [lang] Introduce @NonNull, and @Nullable

Le 01/02/2021 à 11:58, Jochen Wiedmann a écrit : > So, assuming that my proposal should be accepted: How do we proceed? I > see two alternatives: > > a) We had com.google.code.findbugs:jsr305:3.0.2 with a scope > "provided" to our dependencies. The scope will guarantee, that users > aren't affect

Re: [lang] Introduce @NonNull, and @Nullable

Le lun. 1 févr. 2021 à 14:49, Jochen Wiedmann a écrit : > > On Mon, Feb 1, 2021 at 2:34 PM Gary Gregory wrote: > > > 1) Don't add and use custom annotations, this opens the door to each of our > > 20+ components doing the same thing, so pick a library and stick with it. > > I suggested starting w

Re: [lang] Introduce @NonNull, and @Nullable

Le lun. 1 févr. 2021 à 14:34, Gary Gregory a écrit : > > My concerns are: > > 1) Don't add and use custom annotations, this opens the door to each of our > 20+ components doing the same thing, so pick a library and stick with it. +1 > 2) Make sure there are no licensing issues with that library.

Re: [lang] Introduce @NonNull, and @Nullable

On Mon, Feb 1, 2021 at 2:34 PM Gary Gregory wrote: > 1) Don't add and use custom annotations, this opens the door to each of our > 20+ components doing the same thing, so pick a library and stick with it. I suggested starting with lang, because that would be the template for most others. (At lea

Re: [lang] Introduce @NonNull, and @Nullable

My concerns are: 1) Don't add and use custom annotations, this opens the door to each of our 20+ components doing the same thing, so pick a library and stick with it. 2) Make sure there are no licensing issues with that library. Gary On Mon, Feb 1, 2021, 05:58 Jochen Wiedmann wrote: > Hi, > >

Re: [lang] Introduce @NonNull, and @Nullable

Thanks for the explanation. Looks like it would be helpful for IDE/static analyzers/etc, without any impact for the users runtime. I think a) makes sense, but b) would be OK too for me. Cheers Bruno On Monday, 1 February 2021, 11:58:23 pm NZDT, Jochen Wiedmann wrote: Hi, as a fol

[lang] Introduce @NonNull, and @Nullable

Hi, as a followup to a discussion, that we had in August 2020, I'd like to propose, that we introduce the @NonNull, and @Nullable annotations into commons-lang. Since that discussion, I began to gradually introduce those annotations into my own code. From that, I have learned three things: