Re: *** GMX Spamverdacht *** Aw: Re: Proposal to introduce JUnit 5 in commons-numbers

2019-06-05 Thread Eitan Adler
On Tue, 4 Jun 2019 at 16:09, Heinrich Bohne wrote: > So, if the migration from JUnit 4 to JUnit 5 has to happen > instantaneously, how about creating a new branch for the migration? It's > a lot of files that have to be refactored, which is going to take some > time, and since the changes will

Re: *** GMX Spamverdacht *** Aw: Re: Proposal to introduce JUnit 5 in commons-numbers

2019-06-04 Thread Heinrich Bohne
cts at work. It was straightforward. I vote for a clean cut, as well. s/Before/BeforeEach/ s/After/AfterEach and you are halfway through. Sven Gesendet: Montag, 27. Mai 2019 um 07:28 Uhr Von: "Eitan Adler" An: "Heinrich Bohne" Cc: "Commons Developers List" Betreff

Re: Proposal to introduce JUnit 5 in commons-numbers

2019-05-28 Thread Karl Heinz Marbaise
Hi, On 29.05.19 00:10, sebb wrote: On Tue, 28 May 2019 at 21:44, Karl Heinz Marbaise wrote: Hi, just a small comment of mine. to get very good support for exceptions etc. I would suggest to use assertj which will work in JUnit 4 and Jupiter (aka 5)... What License does it use?

Re: Proposal to introduce JUnit 5 in commons-numbers

2019-05-28 Thread sebb
On Tue, 28 May 2019 at 21:44, Karl Heinz Marbaise wrote: > > Hi, > > just a small comment of mine. > > to get very good support for exceptions etc. I would suggest to use > assertj which will work in JUnit 4 and Jupiter (aka 5)... What License does it use? > Furthermore I would not rely on a

Re: Proposal to introduce JUnit 5 in commons-numbers

2019-05-28 Thread Karl Heinz Marbaise
Hi, just a small comment of mine. to get very good support for exceptions etc. I would suggest to use assertj which will work in JUnit 4 and Jupiter (aka 5)... Furthermore I would not rely on a unit testing framework for assertions which others can do better like assertj does. Snippets from

Aw: Re: Proposal to introduce JUnit 5 in commons-numbers

2019-05-27 Thread Sven Rathgeber
einrich Bohne" Cc: "Commons Developers List" Betreff: Re: Proposal to introduce JUnit 5 in commons-numbers (please make sure to CC me directly on replies) On Sun, 26 May 2019 at 17:17, Heinrich Bohne wrote: > ... (I didn't subscribe to the list, which I now regret as I am editi

Re: Proposal to introduce JUnit 5 in commons-numbers

2019-05-26 Thread Eitan Adler
(please make sure to CC me directly on replies) On Sun, 26 May 2019 at 17:17, Heinrich Bohne wrote: > ... (I didn't subscribe to the list, which I now regret as I am editing > the header fields of this email manually, hoping that I do it correctly and > that the message will be attributed to

Re: Proposal to introduce JUnit 5 in commons-numbers

2019-05-26 Thread Heinrich Bohne
: Proposal to introduce JUnit 5 in commons-numbers Date    Sat, 25 May 2019 10:11:43 GMT Hi. Le ven. 24 mai 2019 à 06:01, Eitan Adler a écrit : (please make sure to CC me on replies) +1 on this. One thing I'd like for us to avoid a mess of different junit versions making it difficult to know wh

Re: Proposal to introduce JUnit 5 in commons-numbers

2019-05-25 Thread Gilles Sadowski
Hi. Le ven. 24 mai 2019 à 06:01, Eitan Adler a écrit : > > (please make sure to CC me on replies) > > +1 on this. One thing I'd like for us to avoid a mess of different junit > versions making it difficult to know which runner will be executing the > class. It would be great if we did a complete

Re: Proposal to introduce JUnit 5 in commons-numbers

2019-05-23 Thread Eitan Adler
(please make sure to CC me on replies) +1 on this. One thing I'd like for us to avoid a mess of different junit versions making it difficult to know which runner will be executing the class. It would be great if we did a complete conversion and not just introduced new syntax. I've actually done

Re: Proposal to introduce JUnit 5 in commons-numbers

2019-05-22 Thread Eric Barnhill
+1 On Wed, May 22, 2019 at 3:15 PM Gilles Sadowski wrote: > Hi. > > Le mer. 22 mai 2019 à 18:43, Heinrich Bohne a > écrit : > > > > Right now, commons-numbers is using JUnit 4.12, the last stable version > > of JUnit 4. As far as I am aware, there is no explicit syntax in JUnit > > 4.12 for

Re: Proposal to introduce JUnit 5 in commons-numbers

2019-05-22 Thread Bruno P. Kinoshita
Sounds like a good idea. I'm planning on upgrading to Junit 5 in Commons Imaging too as we have another issue to improve the current tests and how they load test files. +1 On Thursday, 23 May 2019, 4:43:59 am NZST, Heinrich Bohne wrote: Right now, commons-numbers is using JUnit

Re: Proposal to introduce JUnit 5 in commons-numbers

2019-05-22 Thread Gilles Sadowski
Hi. Le mer. 22 mai 2019 à 18:43, Heinrich Bohne a écrit : > > Right now, commons-numbers is using JUnit 4.12, the last stable version > of JUnit 4. As far as I am aware, there is no explicit syntax in JUnit > 4.12 for testing whether an exception is thrown apart from either using > the

Proposal to introduce JUnit 5 in commons-numbers

2019-05-22 Thread Heinrich Bohne
Right now, commons-numbers is using JUnit 4.12, the last stable version of JUnit 4. As far as I am aware, there is no explicit syntax in JUnit 4.12 for testing whether an exception is thrown apart from either using the deprecated class ExpectedException or adding the "expected" parameter to the