Re: Standardise on 'main' as the default branch?

2023-04-02 Thread Zili Chen
+1 Sounds good to go. On 2023/04/01 12:10:15 sebb wrote: > All bar one of the 4 comdev Git repos use 'main' as the default branch. > > I think we should standardise on that going forward, and change the > default branch for comdev-site. > > Agreed? > > Sebb > > ---

Re: Standardise on 'main' as the default branch?

2023-04-02 Thread Willem Jiang
+1 for it. Willem Jiang Twitter: willemjiang Weibo: 姜宁willem On Sat, Apr 1, 2023 at 8:11 PM sebb wrote: > > All bar one of the 4 comdev Git repos use 'main' as the default branch. > > I think we should standardise on that going forward, and change the > default branch for comdev-site. > > Agree

Re: Standardise on 'main' as the default branch?

2023-04-02 Thread Christofer Dutz
I would like to make a slightly different proposal. Name the branch, on which development happens "develop" and the one that contains the released versions "releases". With "main" you never really know what it's used for. But I think I brought this up multiple times before, so if be +1 on a chan

Re: Standardise on 'main' as the default branch?

2023-04-02 Thread sebb
On Sun, 2 Apr 2023 at 09:39, Christofer Dutz wrote: > > I would like to make a slightly different proposal. > Name the branch, on which development happens "develop" and the one that > contains the released versions "releases". With "main" you never really know > what it's used for. I agree tha

Re: Standardise on 'main' as the default branch?

2023-04-02 Thread tison
> Name the branch, on which development happens "develop" and the one that contains the released versions "releases". With "main" you never really know what it's used for. To me, "main" is always "develop". Best, tison. sebb 于2023年4月2日周日 19:34写道: > On Sun, 2 Apr 2023 at 09:39, Christofer Dutz

[GitHub] [comdev-site] rlenferink commented on pull request #100: Use pinned version of Hugo

2023-04-02 Thread via GitHub
rlenferink commented on PR #100: URL: https://github.com/apache/comdev-site/pull/100#issuecomment-1493320573 > > But it seems that only works for maven, jdk and gradle: https://www.jenkins.io/doc/book/pipeline/syntax/#supported-tools. > > However https://www.jenkins.io/doc/book/managi

[GitHub] [comdev-site] rlenferink commented on a diff in pull request #100: Use pinned version of Hugo

2023-04-02 Thread via GitHub
rlenferink commented on code in PR #100: URL: https://github.com/apache/comdev-site/pull/100#discussion_r1155303835 ## Jenkinsfile: ## @@ -56,10 +68,13 @@ pipeline { stage('Build') { steps { script { -sh 'for i in $(whic

[GitHub] [comdev-site] rlenferink commented on pull request #100: Use pinned version of Hugo

2023-04-02 Thread via GitHub
rlenferink commented on PR #100: URL: https://github.com/apache/comdev-site/pull/100#issuecomment-1493328882 @sebbASF does this look okay to you to be merged? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abo

Re: Standardise on 'main' as the default branch?

2023-04-02 Thread Craig Russell
Yes, of course change master to main. Craig > On Apr 2, 2023, at 04:33, sebb wrote: > > On Sun, 2 Apr 2023 at 09:39, Christofer Dutz > wrote: >> >> I would like to make a slightly different proposal. >> Name the branch, on which development happens "develop" and the one that >> contains the

AW: Standardise on 'main' as the default branch?

2023-04-02 Thread Christofer Dutz
Hi, There are many projects, where “main” contains the latest released version and „develop“ is for development. Others use “main” for development and something else for releases. That’s why I’m suggesting naming the threads according to what they are used for. “main” for a developer is probab

[GitHub] [comdev-site] sebbASF commented on pull request #100: Use pinned version of Hugo

2023-04-02 Thread via GitHub
sebbASF commented on PR #100: URL: https://github.com/apache/comdev-site/pull/100#issuecomment-1493379962 The env.HUGO and env.PAGEFIND variables are redundant, in my view, given that they are only used once -- This is an automated message from the Apache Git Service. To respond to the me

Re: Standardise on 'main' as the default branch?

2023-04-02 Thread sebb
On Sun, 2 Apr 2023 at 16:06, Christofer Dutz wrote: > > Hi, > > There are many projects, where “main” contains the latest released version > and „develop“ is for development. > Others use “main” for development and something else for releases. > > That’s why I’m suggesting naming the threads acco

Re: Standardise on 'main' as the default branch?

2023-04-02 Thread Gary Gregory
I like release and develop. FWIW, a lot of Apache Commons components use release already. Gary On Sun, Apr 2, 2023, 11:06 Christofer Dutz wrote: > Hi, > > There are many projects, where “main” contains the latest released version > and „develop“ is for development. > Others use “main” for devel

Re: Standardise on 'main' as the default branch?

2023-04-02 Thread Jarek Potiuk
I think it's really a matter of project's choice. Those who use gitflow use main(master)/release/develop - they have all well-defined meaning and it's cool for projects using it. For other projects, main might be the default development choice if their merge/release workflow is simpler (that's air

regarding update common skin bootstrap.

2023-04-02 Thread Rashi arora
hello, i am writing a Gsoc proposal to contribute for update common skin bootstrap. after going through the Jira ticket i came to the conclusion:- 1)the common skin is majorly related to fluido 2)usage of doxia sidetool and jbake can fasten the process 3)Making all relevant changes in a separate

update common skin bootstrap.

2023-04-02 Thread Rashi arora
hello, i am writing a Gsoc proposal to contribute for update common skin bootstrap. after going through the Jira ticket i came to the conclusion:- 1)the common skin is majorly related to fluido 2)usage of doxia sidetool and jbake can fasten the process 3)Making all relevant changes in a separate

[GitHub] [comdev-events-site] sebbASF commented on pull request #4: Obsolete

2023-04-02 Thread via GitHub
sebbASF commented on PR #4: URL: https://github.com/apache/comdev-events-site/pull/4#issuecomment-1493461512 Please see https://community-test.staged.apache.org/ which shows the result of applying PR #4 and PR #3 -- This is an automated message from the Apache Git Service. To respond to t

[GitHub] [comdev-events-site] sebbASF commented on pull request #3: Add pagefind

2023-04-02 Thread via GitHub
sebbASF commented on PR #3: URL: https://github.com/apache/comdev-events-site/pull/3#issuecomment-1493461566 Please see https://community-test.staged.apache.org/ which shows the result of applying PR #4 and PR #3 -- This is an automated message from the Apache Git Service. To respond to t