Re: InAppBrowser - events

2012-11-22 Thread Shazron
Those events sound good to me. On Nov 22, 2012 1:27 PM, "Simon MacDonald" wrote: > Just looking at this again and... > > webview.addEventListener('exit', handleExit); > webview.addEventListener('loadstart', handleLoadStart); > > would seem to map to our: > > onClose > onLocationChanged > > me

Re: InAppBrowser - events

2012-11-22 Thread Shazron
I'd like to, if everyone agrees. I'd like to wipe out ChildBrowser use if I can, and this (events) is the only thing I believe that people are still using ChilBrowser for. Is this required for the 2.3.0 release? Simon Mac Donald http://hi.im/simonmacdonald On Wed, Nov 21, 2012 at 11:30 PM, Shazr

iOS Changes to InAppBrowser

2012-11-22 Thread Andrew Grieve
Just pushed a few. Let me know if you have concerns about any of them. 1. I changed the User-Agent from appending a GUID to appending the VC's memory location I was hoping this would let me get rid of the vc header field in the bridge all together, but it turns out that the User-Agent isn't being

[jira] [Commented] (CB-1856) Offline Event fires twice on Jellybean

2012-11-22 Thread Joe Bowser (JIRA)
[ https://issues.apache.org/jira/browse/CB-1856?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13502974#comment-13502974 ] Joe Bowser commented on CB-1856: After looking at this, it's not coming from the webview at a

Re: InAppBrowser - events

2012-11-22 Thread Tommy-Carlos Williams
At some point Gather used ChildBrowser for Oauth, but I think they might not be anymore. Max left the list shortly after joining, so I could try and ping him on IRC if it would help? On 23/11/2012, at 10:40 AM, Andrew Grieve wrote: > The more events the better! :) Really though, it would be g

Re: InAppBrowser - events

2012-11-22 Thread Andrew Grieve
The more events the better! :) Really though, it would be good if someone knew of an app that used ChildBrowser for the purposes of OAuth. That seems like one of the most important use-cases, so we should make sure to have all of the events that it requires. On Thu, Nov 22, 2012 at 4:26 PM, Simon

[jira] [Updated] (CB-200) FileTransfer should support uploading multiple files in one HTTP request

2012-11-22 Thread Joe Bowser (JIRA)
[ https://issues.apache.org/jira/browse/CB-200?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joe Bowser updated CB-200: -- Fix Version/s: (was: 2.3.0) 2.4.0 Are we going to do this? This issue is almost a year old.

[jira] [Updated] (CB-1478) FileReader vs XHR bench

2012-11-22 Thread Joe Bowser (JIRA)
[ https://issues.apache.org/jira/browse/CB-1478?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joe Bowser updated CB-1478: --- Fix Version/s: (was: 2.3.0) Removing the version from this bug. > FileReader vs XHR bench >

Re: Android WebView

2012-11-22 Thread Andrew Grieve
Yeah, a lot of those changes seem risky. The invalidate for sure, but also making every div in your app hw-accelerated will work only for extremely small DOMs, and in the average case cause more harm than good. That said, carefully selecting which elements to apply that to goes a long way. Upping

Re: Android WebView

2012-11-22 Thread Joe Bowser
I don't think that's necessarily right. Calling invalidate forces the re-render of the canvas with whatever data is sent to it in mPicture as well as whatever the WebView overlays. The fact that you have to call invalidate() after the draw() just to get the up-to-date mPicture is a bug. It would

RE: Android WebView

2012-11-22 Thread Jonathan Bond-Caron
Ya calling invalidate() right after onDraw() is wrong. My experience is only with ICS on JB, but invalidate() will only affect native/java (e.g. an android rectangle EditText on top of an HTML input). It has no impact on the HTML/CSS webkit engine. It's actually the other way around, the webkit

Re: Android WebView

2012-11-22 Thread Joe Bowser
OK, so what's the downside of constantly forcing the view to be redrawn over and over again? That's the thing that I would be most concerned about. On Thu, Nov 22, 2012 at 1:37 PM, Braden Shepherdson wrote: > The first paragraph of his answer is entirely in line with my claim that > Android WebV

Re: Android WebView

2012-11-22 Thread Braden Shepherdson
The first paragraph of his answer is entirely in line with my claim that Android WebView is the new IE6. It's slow, buggy, doesn't follow the standards, and it will be years before we're rid of it. Interesting comments about the invalidation. I haven't seen most of the problems he's been having in

Re: InAppBrowser api questions

2012-11-22 Thread Simon MacDonald
Well, I've got the code mostly implemented there are some things that probably can be thrown away or cleaned up a bit (UI, events). I'll probably push a version later tonight. All of the manual mobile spec tests are working for me. With regards to the back button, if clicked it closes the InAppBro

Re: InAppBrowser - events

2012-11-22 Thread Simon MacDonald
Just looking at this again and... webview.addEventListener('exit', handleExit); webview.addEventListener('loadstart', handleLoadStart); would seem to map to our: onClose onLocationChanged methods from the ChildBrowser. At least on Android I fire location changed event when the page starts t

Re: Type checking in Cordova JS plugins

2012-11-22 Thread Andrew Grieve
I don't mean to push ahead with this without your buy-in. What goes in can easily come out. I do want to give you concrete code to look at though, because I think our back-and-forth on this thread has made this change out to be more than it is. On Thu, Nov 22, 2012 at 4:02 PM, Jesse wrote: > N

Re: Fast edit-refresh cycles

2012-11-22 Thread Andrew Grieve
On Thu, Nov 22, 2012 at 3:36 PM, Gord Tanner wrote: > This also is feeding into some of the work we are doing with ripple. > > Ripple will serve up the app and host it kind of like how we do > debug.phonegap.com for in browser testing. > > Sent from my iPhone > > On 2012-11-22, at 3:15 PM, Filip

Re: Type checking in Cordova JS plugins

2012-11-22 Thread Jesse
Nevermind then, guess it's in ... On Thu, Nov 22, 2012 at 12:51 PM, Andrew Grieve wrote: > I just checked in argscheck.js and refactored all applicable lower-case > plugin/*.js files to use it. > > It trims 4k off of cordova.ios.js and git tells me: > 245 insertions(+), 323 deletions(-) > > I

[jira] [Commented] (CB-1892) Refactor type-checking code in plugins into a helper method

2012-11-22 Thread Andrew Grieve (JIRA)
[ https://issues.apache.org/jira/browse/CB-1892?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13502929#comment-13502929 ] Andrew Grieve commented on CB-1892: --- argscheck module: https://git-wip-us.apache.org/repos/

Re: Type checking in Cordova JS plugins

2012-11-22 Thread Andrew Grieve
I just checked in argscheck.js and refactored all applicable lower-case plugin/*.js files to use it. It trims 4k off of cordova.ios.js and git tells me: 245 insertions(+), 323 deletions(-) I also found that a couple of our tests were passing invalid arg types :P On Thu, Nov 22, 2012 at 3:48 PM,

RE: Attempting to add debug token support for building on PlayBook

2012-11-22 Thread Josh Soref
Gord wrote: > not the best way to do it now ;) > > I should be able to automate this in the playbook.xml so our users don't > have to deal with it. The way I'm told is to just remove those items from the PlayBook.xml file entirely and just rely on the packager/debugtoken to magically set them or

Re: Type checking in Cordova JS plugins

2012-11-22 Thread Andrew Grieve
There's a good amount of code that currently check types on the public API. My goal here is to shrink that code because it seems repetitive. Checking the types passed to exec may be useful in some cases too, but we don't currently do that. Probably, if we wanted to add this in, we'd want something

RE: incubator repos no more - remove the prefix in your git urls

2012-11-22 Thread Josh Soref
Simon wrote: > Do we need to fix the mirrors at: > > https://github.com/apache I'm waiting for this :) > Can we make sure pull requests to the new repo's on GitHub end up in our > mailing list? I was hoping you'd have split the pull-list and jira-list out of the discuss-list :) ---

Re: Fast edit-refresh cycles

2012-11-22 Thread Gord Tanner
This also is feeding into some of the work we are doing with ripple. Ripple will serve up the app and host it kind of like how we do debug.phonegap.com for in browser testing. Sent from my iPhone On 2012-11-22, at 3:15 PM, Filip Maj wrote: > Agree with Jesse. > > Automatically adding the plu

Re: Fast edit-refresh cycles

2012-11-22 Thread Filip Maj
Agree with Jesse. Automatically adding the plugin's .js to html pages inside a www dir can be done by the cordova-client tool anyways. Agree this should go to vote before we proceed. On 11/22/12 12:13 PM, "Jesse" wrote: >I think all the refresh stuff is super cool, I will share how I work, >so

Re: Fast edit-refresh cycles

2012-11-22 Thread Jesse
I think all the refresh stuff is super cool, I will share how I work, so you can get another perspective. 90% of my code is written on localhost, either running directly in a browser to work out UI stuff. When I need access to actual device APIs, I simply put a redirect in my index.html. This gets

Re: Attempting to add debug token support for building on PlayBook

2012-11-22 Thread Gord Tanner
wow, so yeah that works. not the best way to do it now ;) I should be able to automate this in the playbook.xml so our users don't have to deal with it. On Thu, Nov 22, 2012 at 2:46 PM, Filip Maj wrote: > O HELL YEAH I HAVE. Let me, an Adobe employee, give you, a RIM employee, > the awesome

Re: InAppBrowser api questions

2012-11-22 Thread Joe Bowser
Why do we have the Forward and Back buttons on the browser on Android when Chrome and the Default Browser only have a refresh button? How does this handle the hardware back button? I think we should do what the platform does, except that we don't need multi-tab browsing. On Thu, Nov 22, 2012 at 11

Re: InAppBrowser api questions

2012-11-22 Thread Simon MacDonald
Should the implementation of the InAppBrowser on Android mimic the UI of the iOS app or should it go it's own way? Currently the Android ChildBrowser has the buttons and location bar on the top of the screen. Is there any UI pattern we should be following for this type of in app browsing? Simon M

Re: Attempting to add debug token support for building on PlayBook

2012-11-22 Thread Filip Maj
O HELL YEAH I HAVE. Let me, an Adobe employee, give you, a RIM employee, the awesome run down of how to fix this. This is gonna be fun and I get to vent a bit too! :D 1. Locate your debug token. 2. Extract the .bar of the debug token with an archive app 3. There will be a META-INF folder 4. Open u

Re: Attempting to add debug token support for building on PlayBook

2012-11-22 Thread Gord Tanner
Note: I have since fixed the properties.qnx.bbwp.dir reference for the debugtoken and it still doesn't work On Thu, Nov 22, 2012 at 2:37 PM, Gord Tanner wrote: > I added debug token support to working on BB10 for cordova and would like > to do the same with playbook but I have the following p

Re: InAppBrowser - events

2012-11-22 Thread Simon MacDonald
Is this required for the 2.3.0 release? Simon Mac Donald http://hi.im/simonmacdonald On Wed, Nov 21, 2012 at 11:30 PM, Shazron wrote: > Great! Let's stick with one API, since we have Chrome members on the > Cordova team the choice is obvious :) > > > On Wed, Nov 21, 2012 at 8:06 PM, Andrew Gri

[jira] [Created] (CB-1931) Contact.find() docs don't match implementation for zero-length array

2012-11-22 Thread Andrew Grieve (JIRA)
Andrew Grieve created CB-1931: - Summary: Contact.find() docs don't match implementation for zero-length array Key: CB-1931 URL: https://issues.apache.org/jira/browse/CB-1931 Project: Apache Cordova

Re: Type checking in Cordova JS plugins

2012-11-22 Thread Brian LeRoux
Ok, hold up, I'm missing something---I thought this was for the *bridge protocol validation* not the actual API surface end developers invoke. Ideally the public API would define their own exceptional paths. (Har har.) Example: geolocation api has error callbacks whereas File API has FileError (or

[jira] [Updated] (CB-1892) Refactor type-checking code in plugins into a helper method

2012-11-22 Thread Andrew Grieve (JIRA)
[ https://issues.apache.org/jira/browse/CB-1892?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Grieve updated CB-1892: -- Description: ML Discussion: http://callback.markmail.org/thread/4vgze66wlaaxthsd The idea is to add a typ

[jira] [Commented] (CB-1879) DeviceReady event not firing on Nexus 7 4.2 emulator on a PC

2012-11-22 Thread Joe Bowser (JIRA)
[ https://issues.apache.org/jira/browse/CB-1879?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13502880#comment-13502880 ] Joe Bowser commented on CB-1879: Same here. I got crazy compile errors. I think I tweeted a

[jira] [Commented] (CB-1879) DeviceReady event not firing on Nexus 7 4.2 emulator on a PC

2012-11-22 Thread Simon MacDonald (JIRA)
[ https://issues.apache.org/jira/browse/CB-1879?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13502878#comment-13502878 ] Simon MacDonald commented on CB-1879: - Weird, when I added that annotation in Eclipse and

[jira] [Commented] (CB-1879) DeviceReady event not firing on Nexus 7 4.2 emulator on a PC

2012-11-22 Thread Andrew Grieve (JIRA)
[ https://issues.apache.org/jira/browse/CB-1879?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13502873#comment-13502873 ] Andrew Grieve commented on CB-1879: --- Committed this: https://git-wip-us.apache.org/repos/a

Re: Type checking in Cordova JS plugins

2012-11-22 Thread Andrew Grieve
On Thu, Nov 22, 2012 at 11:40 AM, Jesse MacFadyen wrote: > In the original thread the rational was that things were inconsistent, > but the examples were disparate. > > notification.alert(108); > // This is valid and should not fail, and a callback function (win or > lose) is not required. > > res

Re: Type checking in Cordova JS plugins

2012-11-22 Thread Jesse MacFadyen
In the original thread the rational was that things were inconsistent, but the examples were disparate. notification.alert(108); // This is valid and should not fail, and a callback function (win or lose) is not required. resolveLocalFileSystemURI.js // actually, it checks that there are not mult

Re: Type checking in Cordova JS plugins

2012-11-22 Thread Andrew Grieve
Good point Patrick. I'll go with a console.log + exception. On Thu, Nov 22, 2012 at 9:01 AM, Patrick Mueller wrote: > On Thu, Nov 22, 2012 at 6:00 AM, Brian LeRoux wrote: > > > ya upon further consideration making these TypeException's feels right > > since, ideally, this error would only be s

[jira] [Commented] (CB-1930) window.openDatabase() throws exception 18 on iOS

2012-11-22 Thread Andrew Grieve (JIRA)
[ https://issues.apache.org/jira/browse/CB-1930?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13502800#comment-13502800 ] Andrew Grieve commented on CB-1930: --- Thanks for the report Mikhail! Are you able to attach

Re: CB-1889 changes

2012-11-22 Thread Michal Mocny
Happy Thanksgiving, Shaz! On Thu, Nov 22, 2012 at 9:38 AM, Shazron wrote: > nvm i just pushed it :) cyu guys Monday > > > On Wed, Nov 21, 2012 at 5:33 PM, Shazron wrote: > >> Off for the next two days for Thanksgiving weekend. >> >> Don't have edit access to the new repos, so I pushed to a branc

Re: CB-1889 changes

2012-11-22 Thread Shazron
nvm i just pushed it :) cyu guys Monday On Wed, Nov 21, 2012 at 5:33 PM, Shazron wrote: > Off for the next two days for Thanksgiving weekend. > > Don't have edit access to the new repos, so I pushed to a branch in mine > if an iOS dev wants to integrate: > > > https://github.com/shazron/incubat

RE: [jira] [Updated] (CB-1905) Update JavaScript for webOS

2012-11-22 Thread Leutwyler, Markus
Michael and Herm, I just created a pull request to fix network type codes and to add network online/offline support plus window pause/resume support to cordova-js webOS: https://github.com/apache/incubator-cordova-js/pull/45 Herm: do you want to test? Should we add this to 2.2.3? Markus -

Re: Type checking in Cordova JS plugins

2012-11-22 Thread Patrick Mueller
On Thu, Nov 22, 2012 at 6:00 AM, Brian LeRoux wrote: > ya upon further consideration making these TypeException's feels right > since, ideally, this error would only be seen by a plugin author and not > something a plugin consumer (ideally) > huh? I thought this was all about informing users wh

Re: Type checking in Cordova JS plugins

2012-11-22 Thread Brian LeRoux
ya upon further consideration making these TypeException's feels right since, ideally, this error would only be seen by a plugin author and not something a plugin consumer (ideally) On Wed, Nov 21, 2012 at 8:53 PM, Michal Mocny wrote: > On Wed, Nov 21, 2012 at 3:51 PM, Andrew Grieve > wrote: >

Re: incubator repos no more - remove the prefix in your git urls

2012-11-22 Thread Brian LeRoux
\o/ On Thu, Nov 22, 2012 at 7:27 AM, Jukka Zitting wrote: > Hi, > > On Thu, Nov 22, 2012 at 3:26 AM, Shazron wrote: > > Also, I don't have edit privlieges on the new repos :/ > > The cordova group in Apache LDAP was not yet up to speed. Should be > fixed now (see below, done with my PMC chair p

Re: InAppBrowser - events

2012-11-22 Thread Brian LeRoux
agree, all of this work when completed will be documented as to what is non-standard which we can then take back to the w3c On Thu, Nov 22, 2012 at 4:30 AM, Shazron wrote: > Great! Let's stick with one API, since we have Chrome members on the > Cordova team the choice is obvious :) > > > On Wed

Re: Chrome Apps on Cordova

2012-11-22 Thread Brian LeRoux
this is killer! nice work guys On Thu, Nov 22, 2012 at 4:00 AM, Andrew Grieve wrote: > https://github.com/MobileChromeApps/chrome-cordova

[jira] [Created] (CB-1930) window.openDatabase() throws exception 18 on iOS

2012-11-22 Thread Mikhail Kadan (JIRA)
Mikhail Kadan created CB-1930: - Summary: window.openDatabase() throws exception 18 on iOS Key: CB-1930 URL: https://issues.apache.org/jira/browse/CB-1930 Project: Apache Cordova Issue Type: Bug

[jira] [Commented] (CB-975) camera.getPicture crashes app on iPad3 when capturing multiple images

2012-11-22 Thread Rahul Teotia (JIRA)
[ https://issues.apache.org/jira/browse/CB-975?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13502671#comment-13502671 ] Rahul Teotia commented on CB-975: - We have recently upgraded to 2.2 Cordova along with xcode 4

[jira] [Created] (CB-1929) create: use wget if curl is not available

2012-11-22 Thread Riccardo Magliocchetti (JIRA)
Riccardo Magliocchetti created CB-1929: -- Summary: create: use wget if curl is not available Key: CB-1929 URL: https://issues.apache.org/jira/browse/CB-1929 Project: Apache Cordova Issue

[jira] [Created] (CB-1928) Search field in "Elements" view

2012-11-22 Thread Metis Lab (JIRA)
Metis Lab created CB-1928: - Summary: Search field in "Elements" view Key: CB-1928 URL: https://issues.apache.org/jira/browse/CB-1928 Project: Apache Cordova Issue Type: Improvement Componen