Introduction

2013-04-05 Thread Lucas Holmquist
Hey all, i just wanted to introduce myself. I'm looking to start contributing and helping out with the project. I mainly focus on JS, but can help in others areas as well. I'll take a look at the JIRA's to get started with. anything that i can do to help, let me know -Luke

Re: Introduction

2013-04-05 Thread Lorin Beer
Hi Lucas, welcome to the dev list! You've got the right idea to get started, and if you have any questions, drop it on the mailing list. - Lorin On Fri, Apr 5, 2013 at 7:11 AM, Lucas Holmquist lholm...@redhat.com wrote: Hey all, i just wanted to introduce myself. I'm looking to start

Re: Cordova iOS ready for 2.6.0 tag (mobile-spec results)

2013-04-05 Thread Lorin Beer
Thanks Shaz! On Thu, Apr 4, 2013 at 9:36 PM, Steven Gill stevengil...@gmail.com wrote: Thanks Shaz! On Thu, Apr 4, 2013 at 4:54 PM, Shazron shaz...@gmail.com wrote: Ok, reverted CB-1517 / CB-1518 for 2.6.x branch of mobile-spec because those are tests for 2.7.0. Cherry-picked some

Re: App-Harness Description

2013-04-05 Thread Lorin Beer
perfect! On Thu, Apr 4, 2013 at 1:55 PM, Andrew Grieve agri...@chromium.org wrote: Shravan (our intern) has been started working on it late last week, and I think he's hoping to commit a first version of it some time tomorrow. Definitely would love help! More hands on this the better. Maybe

Re: THE f#%king Facebook Plugin

2013-04-05 Thread Lucas Holmquist
i've worked with the plugin a bit, i can take a look at some of the issues. after all, i am one of the 339 that has a fork ;) On Apr 4, 2013, at 1:54 PM, Steven Gill stevengil...@gmail.com wrote: Ally, do you want commit access to the plugin? A lot of those issues and pull requests are

Re: The plugin repos and reality

2013-04-05 Thread Lucas Holmquist
Is there currently a list of plugins that can be moved, i can start to move some, but don't want to repeat what someone has done already On Apr 3, 2013, at 3:53 PM, Brian LeRoux b...@brian.io wrote: Agree w/ Anis. Just move what can be moved and file up tickets for that which cannot be done

camera saveToPhotoAlbum intent

2013-04-05 Thread James Jong
I have been looking at Lorin's iOS image metadata writer that was recently merged in 2.6.x and noticed that the exif metadata was missing from the saved photos. After troubleshooting some w Lorin, I discovered that the image saved to the photo album is the image before scaling and writing of

iOS camera has two file writes

2013-04-05 Thread Lorin Beer
Images taken by the UIImagePickerController seem to be written twice. James Jong and I found some strange behaviour, and James tracked it down to here: https://github.com/apache/cordova-ios/blob/master/CordovaLib/Classes/CDVCamera.m#L275 An image is written to both the Cordova app's temp

Re: camera saveToPhotoAlbum intent

2013-04-05 Thread Lorin Beer
My 2 cents is that defaulting to two file writes for a single image is not desirable behaviour, a big reason why the Exif Writer exists is that it avoids multiple file writes, which the iOS native libraries would otherwise require. Behaviour should be: write to a single specified location. To

Re: google+ plugin

2013-04-05 Thread Lorin Beer
Steve and others can correct me if I'm wrong, but as far as I know, there is no google+ plus plugin, and no discussion on one that I could dig up. That having been said, it's a great idea. - Lorin On Fri, Apr 5, 2013 at 7:38 AM, Lucas Holmquist lholm...@redhat.com wrote: has there been any

Re: google+ plugin

2013-04-05 Thread Lucas Holmquist
i've been working on a project that needed it, so i have the beginnings of one, currently it just uses the child browser plugin, but it does work so far On Apr 5, 2013, at 11:20 AM, Lorin Beer lorin.beer@gmail.com wrote: Steve and others can correct me if I'm wrong, but as far as I

Re: Introduction

2013-04-05 Thread Filip Maj
Welcome Lucas! On 4/5/13 7:17 AM, Lorin Beer lorin.beer@gmail.com wrote: Hi Lucas, welcome to the dev list! You've got the right idea to get started, and if you have any questions, drop it on the mailing list. - Lorin On Fri, Apr 5, 2013 at 7:11 AM, Lucas Holmquist lholm...@redhat.com

Mobile-Spec contains Cordova 2.7 tests

2013-04-05 Thread Ian Clelland
It looks like a number of commits intended for 2.7.0 were merged back into the 2.6.x branch My commits: dbf631c: [CB-2305] Add spec tests for InAppBrowser.insertCSS and InAppBrowser.executeScript APIs 46e478f: [CB-2226] Add spec test for FileTransfer.abort error callback da89eaa: [CB-1517]

Re: Mobile-Spec contains Cordova 2.7 tests

2013-04-05 Thread Joe Bowser
Yeah, I realized this when I tagged 2.6.x for Android that the tests that were failing were features that didn't exist yet. It might make sense to revert mobile-spec. In hindsight, I think our reliance on cherry-picking is weird, and we should just work on 2.6 until release, THEN cherry-pick for

Re: Mobile-Spec contains Cordova 2.7 tests

2013-04-05 Thread Braden Shepherdson
Cherry-picking is the right solution for release branches. The problem is that people are merging between 2.6.x and master. Never do it. In either direction. It is always the wrong thing. Commit to master, cherry-pick to 2.6.x if it's fixing something critical for the release. On Fri, Apr 5,

[ios] Feature Request: Adding NSUrlProtocol handling for plugins

2013-04-05 Thread Michal Mocny
I've written a plugin to handle a custom url protocol using NSURLProtocol. However, I had to modify CDVViewController's shouldStartLoadWithRequest: in order to actually have the URL navigation progress to that point. Currently, we allow only a fixed set of schemes (file:, tel:, about: etc), then

Re: Mobile-Spec contains Cordova 2.7 tests

2013-04-05 Thread Ian Clelland
One possible solution to this is to encourage cherry-picking in the other direction, during the period between the RC release and the x.x.0 release. So, until 2.6.0 is released, if you are doing 2.6. work, then you can work on the 2.6.x branch, fix things there, and then cherry-pick those fixes

Re: Mobile-Spec contains Cordova 2.7 tests

2013-04-05 Thread Shazron
Let's revert, not rollback. I'm sure we expected some teething pains adjusting to the new scheme. On Friday, April 5, 2013, Ian Clelland wrote: It looks like a number of commits intended for 2.7.0 were merged back into the 2.6.x branch My commits: dbf631c: [CB-2305] Add spec tests for

Use of Google Docs for Planning / Specifications / etc

2013-04-05 Thread Michael Brooks
Hey guys, I know this has been on the minds of a number of contributors and I want to bring it up on the list. I think we need to stop using Google Docs for drafting our plans, specifications, and such. For myself, this is a little disappointing because I like Google Docs and I think it's easy

Re: Mobile-Spec contains Cordova 2.7 tests

2013-04-05 Thread Filip Maj
+1 to reverting. +1 to Shaz's point, slowly people will learn. For the record, if you want to cherry-pick a commit from master into 2.6.x, you would do: $ git checkout master $ git log --pretty=oneline --abbrev-commit HEAD^..HEAD # lets see the last commit abcd123 some commit message

Re: Use of Google Docs for Planning / Specifications / etc

2013-04-05 Thread Filip Maj
+1, it's a bad excuse on my side but the extra step in opening the link is sometimes enough to discourage me from even looking at proposals :P On 4/5/13 10:18 AM, Michael Brooks mich...@michaelbrooks.ca wrote: Hey guys, I know this has been on the minds of a number of contributors and I want to

Re: camera saveToPhotoAlbum intent

2013-04-05 Thread Shazron
Like the Transformers, I think there is more than meets the eye. On Friday, April 5, 2013, James Jong wrote: I have been looking at Lorin's iOS image metadata writer that was recently merged in 2.6.x and noticed that the exif metadata was missing from the saved photos. After troubleshooting

Re: Use of Google Docs for Planning / Specifications / etc

2013-04-05 Thread Joe Bowser
+1, I think there's an ASF rule about this somewhere. On Fri, Apr 5, 2013 at 10:22 AM, Filip Maj f...@adobe.com wrote: +1, it's a bad excuse on my side but the extra step in opening the link is sometimes enough to discourage me from even looking at proposals :P On 4/5/13 10:18 AM, Michael

Re: Use of Google Docs for Planning / Specifications / etc

2013-04-05 Thread Shazron
+1 On Friday, April 5, 2013, Michael Brooks wrote: Hey guys, I know this has been on the minds of a number of contributors and I want to bring it up on the list. I think we need to stop using Google Docs for drafting our plans, specifications, and such. For myself, this is a little

Re: Mobile-Spec contains Cordova 2.7 tests

2013-04-05 Thread Shazron
I'll revert those commits mentioned by Ian and tag 2.6.0 after. On Fri, Apr 5, 2013 at 10:19 AM, Filip Maj f...@adobe.com wrote: +1 to reverting. +1 to Shaz's point, slowly people will learn. For the record, if you want to cherry-pick a commit from master into 2.6.x, you would do: $

Re: Use of Google Docs for Planning / Specifications / etc

2013-04-05 Thread tommy-carlos Williams
+1 Guiltily admitting to being in the not-opening boat with Fil :/ On 06/04/2013, at 4:22, Filip Maj f...@adobe.com wrote: +1, it's a bad excuse on my side but the extra step in opening the link is sometimes enough to discourage me from even looking at proposals :P On 4/5/13 10:18 AM,

Re: google+ plugin

2013-04-05 Thread Andrew Grieve
Would love to see this happen! Were you using ChildBrowser for OAuth? We've got a rough implementation of OAuth working with InAppBrowser (Child Browser turned core plugin) here: https://github.com/MobileChromeApps/chrome-cordova/tree/master/plugins/identity On Fri, Apr 5, 2013 at 11:31 AM,

Re: Introduction

2013-04-05 Thread Andrew Grieve
Woohoo! Welcome! On Fri, Apr 5, 2013 at 11:52 AM, Michal Mocny mmo...@chromium.org wrote: Welcome Lucas! Have you signed the Apache Contributor License Agreement? Be sure to check out http://wiki.apache.org/cordova/ContributorWorkflow -Michal On Fri, Apr 5, 2013 at 11:33 AM, Filip Maj

Re: Mobile-Spec contains Cordova 2.7 tests

2013-04-05 Thread Filip Maj
Good tip, thanks! It seems like a rule that you learn one new thing about git every day :P On 4/5/13 11:48 AM, Michal Mocny mmo...@chromium.org wrote: Fil, I'll add that you can add a -x to cherry-pick line so that git automatically inserts (cherry picked from commit ...) to the original

Re: Mobile-Spec contains Cordova 2.7 tests

2013-04-05 Thread Shazron
Ian, if I revert CB-2226, now this test fails: FileTransfer download method should not leave partial file due to abort. Expected false to be true, 'downloadWin should not have been called. Got args:

Re: google+ plugin

2013-04-05 Thread Lucas Holmquist
yup, but just for the login and authorization of the app, then you can set the token you get back into the gapi lib and use that to make subsequent calls On Apr 5, 2013, at 2:49 PM, Andrew Grieve agri...@chromium.org wrote: Would love to see this happen! Were you using ChildBrowser for

Re: Use of Google Docs for Planning / Specifications / etc

2013-04-05 Thread Michal Mocny
-1, but hey, what can you do.. I guess that if we don't like opening links, then we will be consuming wiki doc proposals via the wiki-update emails that go out? Also, since it emails for each patch, perhaps update the wiki with as few commits as possible, including when making comments, and

Re: Mobile-Spec contains Cordova 2.7 tests

2013-04-05 Thread Michal Mocny
Yeah I learned that one today, too (thanks Ian/Braden) On Fri, Apr 5, 2013 at 2:51 PM, Filip Maj f...@adobe.com wrote: Good tip, thanks! It seems like a rule that you learn one new thing about git every day :P On 4/5/13 11:48 AM, Michal Mocny mmo...@chromium.org wrote: Fil, I'll add

Re: Use of Google Docs for Planning / Specifications / etc

2013-04-05 Thread Filip Maj
My main problem is starting a proposal or draft on a website to begin with. The initial discussion, in my mind, should be done on the list in email form, so the apache archives have a clear record of how a discussion about a new proposal or feature has evolved. So instead of here's my proposal:

Re: The plugin repos and reality

2013-04-05 Thread Max Woghiren
We should slow this process down a little bit. Our next step should be to structure the plugins in the existing repos so that the process of relocating them to their individual repos is straightforward. Trying to do it as we go will be messy and lead to the types of problems that prompted Joe to

Re: [ios] Feature Request: Adding NSUrlProtocol handling for plugins

2013-04-05 Thread Andrew Grieve
Idea #1: If there are any access tags that have a scheme set, add that scheme to the list of schemes that are processed by the whitelist. In this case, it would look like: access origin=chrome-extension://*/ Idea #2: Android has: url-filter value=chrome-extension:// / It causes all matching

Re: The plugin repos and reality

2013-04-05 Thread Max Woghiren
I should add that in the meantime, we can still test plugman and cli with some non-core plugins—for instance, chrome-cordova pluginshttps://github.com/MobileChromeApps/chrome-cordova/have already been pluginized. On Fri, Apr 5, 2013 at 3:00 PM, Max Woghiren m...@chromium.org wrote: We should

RE: Introduction

2013-04-05 Thread Erik Johnson
I will piggy back on the back of Lucas's intro as well: Hey All, I'm Erik a dev at BlackBerry. I've been working on the WebWorks product in some capacity for nearly a year now. I hope to be able to contribute as well in some meaningful way. Feel free to forward me any BB specific fixes that

Re: Use of Google Docs for Planning / Specifications / etc

2013-04-05 Thread Michal Mocny
Ah, thanks for clarifying. I actually like that change, then. On Fri, Apr 5, 2013 at 2:59 PM, Filip Maj f...@adobe.com wrote: My main problem is starting a proposal or draft on a website to begin with. The initial discussion, in my mind, should be done on the list in email form, so the

Re: Use of Google Docs for Planning / Specifications / etc

2013-04-05 Thread Filip Maj
Wewt! On 4/5/13 12:03 PM, Michal Mocny mmo...@chromium.org wrote: Ah, thanks for clarifying. I actually like that change, then. On Fri, Apr 5, 2013 at 2:59 PM, Filip Maj f...@adobe.com wrote: My main problem is starting a proposal or draft on a website to begin with. The initial

Re: Mobile-Spec contains Cordova 2.7 tests

2013-04-05 Thread Ian Clelland
I don't have any problem with CB-2226 going out with 2.6.0, if it can; it was just in the list of commits that were made after the branch point. If you can get the 2226 fix into 2.6, then by all means do it :) And then the mobile-spec test for it can go in as well Ian On Fri, Apr 5, 2013 at

Re: Introduction

2013-04-05 Thread Max Woghiren
Welcome Lucas and Erik! Great to have you. On Fri, Apr 5, 2013 at 3:02 PM, Erik Johnson erjohn...@blackberry.comwrote: I will piggy back on the back of Lucas's intro as well: Hey All, I'm Erik a dev at BlackBerry. I've been working on the WebWorks product in some capacity for nearly a

Re: Use of Google Docs for Planning / Specifications / etc

2013-04-05 Thread Michael Brooks
My main problem is starting a proposal or draft on a website to begin with. The initial discussion, in my mind, should be done on the list in email form, so the apache archives have a clear record of how a discussion about a new proposal or feature has evolved. This summaries that main

Re: The plugin repos and reality

2013-04-05 Thread Joe Bowser
On Fri, Apr 5, 2013 at 12:00 PM, Max Woghiren m...@chromium.org wrote: We should slow this process down a little bit. Our next step should be to structure the plugins in the existing repos so that the process of relocating them to their individual repos is straightforward. Trying to do it as

Re: Mobile-Spec contains Cordova 2.7 tests

2013-04-05 Thread Shazron
Ok never mind, after mucking around a bit more (I blame Xcode app transfer caching and UFOs) that test now passes :) Will tag On Fri, Apr 5, 2013 at 12:05 PM, Ian Clelland iclell...@google.com wrote: I don't have any problem with CB-2226 going out with 2.6.0, if it can; it was just in the

Re: Unifying the config.xml

2013-04-05 Thread Gorkem Ercan
I see your point... I have unified the template config.xmls on all platforms, perhaps it would be a better idea to differentiate the template config.xml per platform so that the values from other platforms are not spread to all... CLIs template can still carry the values of all platforms that is

Re: The plugin repos and reality

2013-04-05 Thread Joe Bowser
I've updated the CorePlugins update page and added my initial observations regarding moving the plugins over. I do agree that it does feel like we're putting the cart before the horse, but assuming that we want a 3.0 release, I don't see another option.

Re: The plugin repos and reality

2013-04-05 Thread Max Woghiren
I agree with a lot of what you said. On Fri, Apr 5, 2013 at 3:13 PM, Joe Bowser bows...@gmail.com wrote: On Fri, Apr 5, 2013 at 12:00 PM, Max Woghiren m...@chromium.org wrote: We should slow this process down a little bit. Our next step should be to structure the plugins in the existing

Re: Use of Google Docs for Planning / Specifications / etc

2013-04-05 Thread Filip Maj
yes On 4/5/13 12:13 PM, Michal Mocny mmo...@chromium.org wrote: Great point: down the road we will use ML search and that doesn't index the content of links to docs. Thus I concur its reasonable to discuss initial proposals and settling direction on ML, and finally linking to a wiki/gdoc which

Re: The plugin repos and reality

2013-04-05 Thread Michal Mocny
Warning: ** I'm not suggesting it, I'm not proposing it ** but, I'll chime in to say that we could still potentially ship 3.0 entirely using the new plugin architecture but without splitting core plugins into individual repos. We could move them out of cordova-js, but still keep them together in

Re: Introduction

2013-04-05 Thread Ken Wallis
Great to see you jumping in Erik! Sent from my BlackBerry Z10 smartphone. From: Lorin Beer Sent: Friday, April 5, 2013 1:02 PM To: dev Reply To: dev@cordova.apache.org Subject: Re: Introduction Welcome Erik! On Fri, Apr 5, 2013 at 12:07 PM, Max Woghiren m...@chromium.org wrote: Welcome

Re: Introduction

2013-04-05 Thread James Jong
Great to have you onboard Luke and Erik. Welcome! -James Jong On Apr 5, 2013, at 4:08 PM, Ken Wallis kwal...@blackberry.com wrote: Great to see you jumping in Erik! Sent from my BlackBerry Z10 smartphone. From: Lorin Beer Sent: Friday, April 5, 2013 1:02 PM To: dev Reply To:

Re: The plugin repos and reality

2013-04-05 Thread Andrew Grieve
I agree that moving plugins into repos isn't tied to API audits, but doesn't moving plugins gradually prevent our ability to do releases? E.g. 2.7 is missing two plugins since they were moved into different repos. On Fri, Apr 5, 2013 at 4:20 PM, Brian LeRoux b...@brian.io wrote: That synopsis

Re: Unifying the config.xml

2013-04-05 Thread Andrew Grieve
Yep, sounds good to me! On Fri, Apr 5, 2013 at 3:28 PM, Gorkem Ercan gorkem.er...@gmail.com wrote: I see your point... I have unified the template config.xmls on all platforms, perhaps it would be a better idea to differentiate the template config.xml per platform so that the values from

Re: The plugin repos and reality

2013-04-05 Thread Brian LeRoux
Those should be rolled back in by the COHO tool (using the plugman tool) for the phonegap dist. On Fri, Apr 5, 2013 at 1:24 PM, Andrew Grieve agri...@chromium.org wrote: I agree that moving plugins into repos isn't tied to API audits, but doesn't moving plugins gradually prevent our ability

Re: Introduction

2013-04-05 Thread Brian LeRoux
Right on! Welcome Luke and Erik, great to have more firepower on Cordova. =) On Fri, Apr 5, 2013 at 1:12 PM, James Jong wjamesj...@gmail.com wrote: Great to have you onboard Luke and Erik. Welcome! -James Jong On Apr 5, 2013, at 4:08 PM, Ken Wallis kwal...@blackberry.com wrote: Great

Ch-ch-ch-ch-changes

2013-04-05 Thread Gord Tanner
Hey everyone. Just a heads up that I am no longer working at BlackBerry anymore. I will be still contributing to Cordova on my own time but more directed at the tooling layer in regards to Ripple and Cordova integration. The great news is that BlackBerry has a whole team to step up and continue

Re: Ch-ch-ch-ch-changes

2013-04-05 Thread Max Woghiren
Glad you're sticking around! Good luck in your new adventures. :) On Fri, Apr 5, 2013 at 5:46 PM, Gord Tanner gtan...@gmail.com wrote: Hey everyone. Just a heads up that I am no longer working at BlackBerry anymore. I will be still contributing to Cordova on my own time but more directed

Re: Unifying the config.xml

2013-04-05 Thread Gorkem Ercan
Great! PRs are updated with the suggested changes -- Gorkem On Fri, Apr 5, 2013 at 11:36 PM, Andrew Grieve agri...@chromium.org wrote: Yep, sounds good to me! On Fri, Apr 5, 2013 at 3:28 PM, Gorkem Ercan gorkem.er...@gmail.com wrote: I see your point... I have unified the template