Re: Jake woes

2013-06-21 Thread Lucas Holmquist
+1 On Jun 20, 2013, at 11:20 PM, Steven Gill stevengil...@gmail.com wrote: +1 Grunt On Thu, Jun 20, 2013 at 7:15 PM, Andrew Grieve agri...@chromium.org wrote: I've burned quite a bit of time trying to get it to work, and I'm a bit realizing that it's probably not worth continuing. By

Re: Media API, DataResource, and empty URLs

2013-06-21 Thread Ian Clelland
On Thu, Jun 20, 2013 at 11:45 AM, Andrew Grieve agri...@chromium.orgwrote: WebView.getUrl() ? Or that, modulo any base tags that we detect? On Thu, Jun 20, 2013 at 9:49 AM, Braden Shepherdson bra...@chromium.org wrote: So the current state of handling URLs in DataResource is: if it

RE: Suggestion - pluginLoader

2013-06-21 Thread J Prince
So it's been about a week now and I haven't really had any feedback on this. https://github.com/jxp/cordova.pluginLoader I'm not sure if this means; a) Everyone is too busy b) Everyone assumed someone else would respond c) No-one is that interested in plugin javascript definitions d) You've had

Re: Opinions Needed: Platform specific features and mobilespec tests

2013-06-21 Thread Ian Clelland
For tests like this, I'd like to see something in Jasmine that is akin to the Expected Failure result in JUinit / python unittest. It means that we still run all of the tests, but a failure on a device that doesn't support the feature doesn't cause the whole test suite to turn red. On the other

Re: cordova-ios/iphone/beep.wav

2013-06-21 Thread Ian Clelland
That was an accidental commit, if it's ended up in cordova-ios. The file was previously in version control; I went back through the git repo history to find and restore it for cordova-mobile-spec, since iOS devices require it for the notification tests. I didn't expect that there would be a

Re: Suggestion - pluginLoader

2013-06-21 Thread Andrew Grieve
Hi Jonathan, First, thanks for a well-written proposal. At least for me, I'm not really sure that there is enough of a problem with the current approach that would justify changing it. That said, business is always an issue, and bumping your thread was the right thing to do :) For Android and

Re: Jake woes

2013-06-21 Thread Bryan Higgins
+1 On Fri, Jun 21, 2013 at 7:11 AM, Lucas Holmquist lholm...@redhat.comwrote: +1 On Jun 20, 2013, at 11:20 PM, Steven Gill stevengil...@gmail.com wrote: +1 Grunt On Thu, Jun 20, 2013 at 7:15 PM, Andrew Grieve agri...@chromium.org wrote: I've burned quite a bit of time trying to

RE: Suggestion - pluginLoader

2013-06-21 Thread J Prince
Hi Andrew, My main point was to make the actual plugin javascript definitions more flexible. That way it would support more unusual developer requirements (such as mine). If the plugin definitions did not contain any loader implementation then the same definition can be used different ways by

Re: Jake woes

2013-06-21 Thread Jeffrey Heifetz
+1 Sent from my BlackBerry 10 smartphone on the Rogers network. From: Bryan Higgins Sent: Friday, June 21, 2013 9:39 AM To: dev@cordova.apache.org Reply To: dev@cordova.apache.org Subject: Re: Jake woes +1 On Fri, Jun 21, 2013 at 7:11 AM, Lucas Holmquist lholm...@redhat.comwrote: +1 On Jun

Re: Suggestion - pluginLoader

2013-06-21 Thread Andrew Grieve
For your actual app, you're free to use any JS loader that you'd like. Are there really many existing Cordova plugins that use alternate module package definitions? On Fri, Jun 21, 2013 at 9:39 AM, J Prince princej.w...@hotmail.co.ukwrote: Hi Andrew, My main point was to make the actual

Re: Jake woes

2013-06-21 Thread Andrew Grieve
Okay, CB-3960 is the tracker. On Fri, Jun 21, 2013 at 9:57 AM, Jeffrey Heifetz jheif...@blackberry.comwrote: +1 Sent from my BlackBerry 10 smartphone on the Rogers network. From: Bryan Higgins Sent: Friday, June 21, 2013 9:39 AM To: dev@cordova.apache.org Reply To: dev@cordova.apache.org

RE: Suggestion - pluginLoader

2013-06-21 Thread J Prince
Perhaps my terminology is wrong but ALL plugins define how they are loaded. Either (old style) window.plugins = ... or (new style) cordova.define(... My fundamental point is they shouldn't. I don't want my plugins loaded in either of these ways. The loading of plugins should be separate to the

RE: Opinions Needed: Platform specific features and mobilespec tests

2013-06-21 Thread Li, Jonathan
Probably call the test failure for the unimplemented feature as Unimplemented Failure, and show in jasmine using a different color. Those failure are like a warning, and means the feature is expected to be supported by the platform, but is just not yet implemented. Expected failure is little

Re: Review Request: Fixing exec bug.

2013-06-21 Thread Jeffrey Willms
On June 21, 2013, 2:33 a.m., Andrew Grieve wrote: framework/src/org/apache/cordova/api/PluginManager.java, line 226 https://reviews.apache.org/r/12013/diff/1/?file=309778#file309778line226 These params don't need to be final. Isn't it better to make them final unless there is a

Re: Cordova Blog

2013-06-21 Thread Carlos Santana
This is great idea. I don't mind the same content in both places. (PhoneGap and Cordova) Phonegap is spelled Cordova anyway :-) Some of the blog posts in PhoneGap point to personal blogs. I would thin that the Cordova Blog will do the same have blogs hosted on its site or point to personal blog

Re: Suggestion - pluginLoader

2013-06-21 Thread Andrew Grieve
aha, so previously we didn't help plugins along at all. With plugman-compatible plugins, we do define a way for plugin JS to be loaded: you add a js-module tag to your plugin.xml and then plugman will wrap your file in a cordova.define(). Spec:

RE: Suggestion - pluginLoader

2013-06-21 Thread J Prince
That looks much more like what I need. I think there were two things adding to my confusion; 1. I was not aware plugman could affect the javascript 2. I don't think I've seen any clean plugman plugins in the wild I will look into the plugin spec a bit further and do some testing with it to see

Re: Cordova Blog

2013-06-21 Thread Brian LeRoux
+1 on a blog but I'd like to do something static if possible. (Jekyll, Scotch, Docpad are all nice enough). We used to use Wordpress for http://phonegap.com and it was a complete struggle to keep it up to date and online. The running joke when were dealing w/ this was 'static sites are web scale'.

Re: Cordova Blog

2013-06-21 Thread Carlos Santana
@Brian I'm not married to WordPress was just referring as an example, JekyII will do fine , Can we see if we can host the content on git/github instead of svn?, this way, I think it will be easier to contribute and maintain. --Carlos On Fri, Jun 21, 2013 at 12:29 PM, Brian LeRoux

Re: Cordova Blog

2013-06-21 Thread Brian LeRoux
We could mirror but stuff that lives on apache.org is svn deployed and I'm almost completely certain that infra would not be into changing that. On Fri, Jun 21, 2013 at 9:41 AM, Carlos Santana csantan...@gmail.com wrote: @Brian I'm not married to WordPress was just referring as an example,

Re: Cordova Blog

2013-06-21 Thread Shazron
... the github method would of course, apply to all the repos, they can have their own Github project pages if they want. And since they are git repos -- cherry-picking/merging of blog posts I suppose (which can be automated) On Fri, Jun 21, 2013 at 9:52 AM, Shazron shaz...@gmail.com wrote: +1

Re: Cordova Blog

2013-06-21 Thread Carlos Santana
Yes mirror to Github, official and live content will be stored on apache servers. +1 on the repo name cordova-blog On Fri, Jun 21, 2013 at 12:52 PM, Shazron shaz...@gmail.com wrote: +1 on Jekyll and Github. All we need is to request a cordova-blog repo on git-wip-us, and then the Github

Re: PhoneGap Day tickets

2013-06-21 Thread Brian LeRoux
NP, Colene (cc'd) can help get any/all committers tickets. (Its ridiculously cheap for any community that isn't yet a committer but pls email me if you need help.) On Thu, Jun 20, 2013 at 6:56 PM, Andrew Grieve agri...@chromium.org wrote: Do I (or other committers thinking of attending) need to

Re: Cordova Blog

2013-06-21 Thread Brian LeRoux
OR we could use Github pages for the Cordova org and just host on a subdomain: http://blog.cordova.io ??? Seems like the least friction. On Fri, Jun 21, 2013 at 9:56 AM, Carlos Santana csantan...@gmail.com wrote: Yes mirror to Github, official and live content will be stored on apache

Re: Review Request: Fixing exec bug.

2013-06-21 Thread Jeffrey Willms
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12013/ --- (Updated June 21, 2013, 5:21 p.m.) Review request for cordova and Andrew

Re: Apache VM for Medic's CouchDB

2013-06-21 Thread Brian LeRoux
If we can get one setup then yes why not (could be good to have more than one frankly). Pursing the Nodejitsu guys to donate an instance (as they do for npm itself) which has really good uptime... ;) On Thu, Jun 20, 2013 at 8:53 AM, Anis KADRI anis.ka...@gmail.com wrote: Should we use this for

Re: Jake woes

2013-06-21 Thread Benn Mapes
Could you also update the README? https://issues.apache.org/jira/browse/CB-3966 Thanks! On Fri, Jun 21, 2013 at 7:23 AM, Andrew Grieve agri...@chromium.org wrote: Okay, CB-3960 is the tracker. On Fri, Jun 21, 2013 at 9:57 AM, Jeffrey Heifetz jheif...@blackberry.com wrote: +1 Sent

plugman iOS + compiler flags

2013-06-21 Thread aaron barnes
I've really been enjoying the cordova cli/plugin.xml definition. I've been porting a bunch of old plugins to work with plugman's plugin.xml definition. Generally it's been going well, however one problem I've come across a few times particularly when trying to apply it to old code or

Re: plugman iOS + compiler flags

2013-06-21 Thread Filip Maj
It makes sense to me although I'd like to hear what other committers think about this as well. Related question: are there any other platforms where compiler flags would be helpful/useful? On 6/21/13 11:37 AM, aaron barnes aa...@stasis.org wrote: I've really been enjoying the cordova

Re: plugman iOS + compiler flags

2013-06-21 Thread Shazron
Of course it should be considered. We did discuss this briefly, but I don't think we added it as a feature request in time for 3.0.0. What I did recommend however, is for plugins to use the __has_feature(objc_arc) macro to support both ARC and non-ARC. This way, including it in any kind of project

Re: plugman iOS + compiler flags

2013-06-21 Thread Filip Maj
Sweet, let's file an issue as a feature request for this and I'll do my best to get this in time for 3.0. On 6/21/13 11:54 AM, Shazron shaz...@gmail.com wrote: Of course it should be considered. We did discuss this briefly, but I don't think we added it as a feature request in time for 3.0.0.

Re: plugman iOS + compiler flags

2013-06-21 Thread Shazron
Also, Andrew Grieve did propose it here in proposal #2: http://markmail.org/thread/tskkqinboyp5cjdg#query:+page:1+mid:ojea6mtsrtxx6f2a+state:results Awesome, I'll file it On Fri, Jun 21, 2013 at 11:58 AM, Filip Maj f...@adobe.com wrote: Sweet, let's file an issue as a feature request for this

Re: plugman iOS + compiler flags

2013-06-21 Thread Carlos Santana
+1 on the be able to inject compiler options per file from xml On the same area, what about coding a small script/tool to analyze a plugin folder and generate the plugin.xml section containing the list of files that need the flag? --Carlos On Fri, Jun 21, 2013 at 3:00 PM, Shazron

Re: plugman iOS + compiler flags

2013-06-21 Thread Filip Maj
That would be cool, have at it Carlos :D On 6/21/13 12:11 PM, Carlos Santana csantan...@gmail.com wrote: +1 on the be able to inject compiler options per file from xml On the same area, what about coding a small script/tool to analyze a plugin folder and generate the plugin.xml section

Re: plugman iOS + compiler flags

2013-06-21 Thread Shazron
Filed: https://issues.apache.org/jira/browse/CB-3967 On Fri, Jun 21, 2013 at 11:58 AM, Filip Maj f...@adobe.com wrote: Sweet, let's file an issue as a feature request for this and I'll do my best to get this in time for 3.0. On 6/21/13 11:54 AM, Shazron shaz...@gmail.com wrote: Of course

Re: plugman iOS + compiler flags

2013-06-21 Thread Filip Maj
Thanks Shaz! On 6/21/13 12:20 PM, Shazron shaz...@gmail.com wrote: Filed: https://issues.apache.org/jira/browse/CB-3967 On Fri, Jun 21, 2013 at 11:58 AM, Filip Maj f...@adobe.com wrote: Sweet, let's file an issue as a feature request for this and I'll do my best to get this in time for 3.0.

Re: plugman iOS + compiler flags

2013-06-21 Thread aaron barnes
Holy sh*t guys, that's some fast work. Much obliged, --aaron On 6/21/13 11:54 AM, Shazron shaz...@gmail.com wrote: Filed: https://issues.apache.org/jira/browse/CB-3967 On Fri, Jun 21, 2013 at 11:58 AM, Filip Maj fi...@adobe.com wrote: Sweet, let's file an issue as a feature request for

[Announce] Cordova 2.9.0rc1 released

2013-06-21 Thread Steven Gill
Just wanted to announce that Cordova 2.9.0rc1 has been released! You can download it on the Cordova website at http://cordova.apache.org/. This is the release candidate for Cordova 2.9.0 which should be released next week. A changelog is included in the download. Have a great weekend! -Steve

Re: [Announce] Cordova 2.9.0rc1 released

2013-06-21 Thread Filip Maj
Thanks for getting it out Steve! On 6/21/13 1:31 PM, Steven Gill stevengil...@gmail.com wrote: Just wanted to announce that Cordova 2.9.0rc1 has been released! You can download it on the Cordova website at http://cordova.apache.org/. This is the release candidate for Cordova 2.9.0 which should

Re: plugman iOS + compiler flags

2013-06-21 Thread Carlos Santana
I will take look into detecting incompatible ARC files that will potentially give compiler errors. So far what I had found is to look if code is using invalid functions (i.e. retain and release) Taking into consideration that file could be using macro to have dual path based on #if

Re: Jake woes

2013-06-21 Thread Patrick Mueller
It appears you've made a horrible, HORRIBLE mistake with your patch [1], and deleted the dalek. HORRIBLE. [1] https://git-wip-us.apache.org/repos/asf?p=cordova-js.git;a=commit;h=273e0a3a ps: I too once tried to delete the dalek, and look what happened to me. and the dalek :-( On Fri, Jun 21,

Re: Jake woes

2013-06-21 Thread Filip Maj
noo On 6/21/13 2:01 PM, Patrick Mueller pmue...@gmail.com wrote: It appears you've made a horrible, HORRIBLE mistake with your patch [1], and deleted the dalek. HORRIBLE. [1] https://git-wip-us.apache.org/repos/asf?p=cordova-js.git;a=commit;h=273e0a 3a ps: I too once tried to

Re: Jake woes

2013-06-21 Thread Jesse
Punishable by death or bunga-bunga, your choice. @purplecabbage risingj.com On Fri, Jun 21, 2013 at 2:09 PM, Filip Maj f...@adobe.com wrote: noo On 6/21/13 2:01 PM, Patrick Mueller pmue...@gmail.com wrote: It appears you've made a horrible, HORRIBLE mistake with your patch

Re: Jake woes

2013-06-21 Thread Lorin Beer
HORRIBLE On Fri, Jun 21, 2013 at 2:43 PM, Jesse purplecabb...@gmail.com wrote: Punishable by death or bunga-bunga, your choice. @purplecabbage risingj.com On Fri, Jun 21, 2013 at 2:09 PM, Filip Maj f...@adobe.com wrote: noo On 6/21/13 2:01 PM, Patrick Mueller

Re: Jake woes

2013-06-21 Thread Simon MacDonald
Guys no one can completely defeat the daleks. I'm sure that they will be back. Possibly in rainbow colours. On Jun 21, 2013 6:27 PM, Lorin Beer lorin.beer@gmail.com wrote: HORRIBLE On Fri, Jun 21, 2013 at 2:43 PM, Jesse purplecabb...@gmail.com wrote: Punishable by death or bunga-bunga,

Re: Jake woes

2013-06-21 Thread Gord Tanner
Ex-term-in-ate Sent from my iPhone On 2013-06-21, at 6:52 PM, Simon MacDonald simon.macdon...@gmail.com wrote: Guys no one can completely defeat the daleks. I'm sure that they will be back. Possibly in rainbow colours. On Jun 21, 2013 6:27 PM, Lorin Beer lorin.beer@gmail.com wrote:

Re: Review Request: Fixing exec bug.

2013-06-21 Thread Andrew Grieve
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12013/#review22279 --- Ship it! Looks good! Just send me the JS change and I'll commit

Re: Jake woes

2013-06-21 Thread Andrew Grieve
:) who needs the dalek. On Fri, Jun 21, 2013 at 7:17 PM, Gord Tanner gtan...@gmail.com wrote: Ex-term-in-ate Sent from my iPhone On 2013-06-21, at 6:52 PM, Simon MacDonald simon.macdon...@gmail.com wrote: Guys no one can completely defeat the daleks. I'm sure that they will be back.

Re: Review Request: Fixing exec bug.

2013-06-21 Thread Joe Bowser
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12013/#review22286 --- Ship it! Ship It! - Joe Bowser On June 21, 2013, 5:21 p.m.,

Re: Review Request: Fixing exec bug.

2013-06-21 Thread Joe Bowser
On June 21, 2013, 11:47 p.m., Joe Bowser wrote: Ship It! I really just wanted to push the Ship it! button, but yeah, this looks good. - Joe --- This is an automatically generated e-mail. To reply, visit: