[GitHub] cordova-plugin-inappbrowser pull request: window.open(url, '_syste...

2014-04-14 Thread alinnert
Github user alinnert commented on the pull request: https://github.com/apache/cordova-plugin-inappbrowser/pull/39#issuecomment-40447640 Ah, I see. Then I use the mentioned solution. Thank you. --- If your project is set up for it, you can reply to this email and have your reply appea

[GitHub] cordova-plugin-inappbrowser pull request: window.open(url, '_syste...

2014-04-14 Thread alinnert
Github user alinnert closed the pull request at: https://github.com/apache/cordova-plugin-inappbrowser/pull/39 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or

Re: cli e2e tests - delete the older duplicates in spec/

2014-04-14 Thread Mark Koudritsky
Merged, the old tests below are now gone. CB-6433 lists some coverage that is missing from the new tests. spec/create.spec.js spec/platform.spec.js spec/plugin.spec.js ​

[GitHub] cordova-cli pull request: Move e2e tests into spec overwriting dup...

2014-04-14 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-cli/pull/159 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cordova-plugin-inappbrowser pull request: Make InAppBrowser work w...

2014-04-14 Thread purplecabbage
Github user purplecabbage commented on the pull request: https://github.com/apache/cordova-plugin-inappbrowser/pull/38#issuecomment-40432983 I have merged your code into the dev branch, so this should close once it gets merged to master and published, Note: I added 'await' calls t

Re: Contributor/committer Google hangout April 15th 4pm EDT / 1 PDT

2014-04-14 Thread Steven Gill
Hangout is tomorrow at 1pm PDT! On Tue, Apr 8, 2014 at 1:00 PM, Steven Gill wrote: > Next Tuesday, April 15th is our next monthly hangout. > > Lets add to the Agenda! http://wiki.apache.org/cordova/Agenda20140415 >

[GitHub] cordova-mobile-spec pull request: CB-6437[Improvements & support f...

2014-04-14 Thread martincgg
Github user martincgg commented on a diff in the pull request: https://github.com/apache/cordova-mobile-spec/pull/55#discussion_r11610878 --- Diff: createmobilespec/createmobilespec.js --- @@ -17,99 +16,215 @@ KIND, either express or implied. See the License for the

RE: Great writeup from Ray Camden on PG/Cordova

2014-04-14 Thread Ray Camden
The raw data is linked to in the blog post. It is XLSX but if you need it some other way, let me know. From: mmo...@google.com on behalf of Michal Mocny Sent: Monday, April 14, 2014 11:39 AM To: dev Subject: Re: Great writeup from Ray Camden on PG/Cordo

[GitHub] cordova-mobile-spec pull request: CB-6437[Improvements & support f...

2014-04-14 Thread martincgg
Github user martincgg commented on a diff in the pull request: https://github.com/apache/cordova-mobile-spec/pull/55#discussion_r11607945 --- Diff: createmobilespec/createmobilespec.js --- @@ -17,99 +16,215 @@ KIND, either express or implied. See the License for the

Re: support on phonegap/cordova?

2014-04-14 Thread Joe Bowser
The reasons I prefer stack overflow to users lists are as follows: 1. Most of our users aren't skilled enough to get on or off of a users list 2. Stack Overflow's structure keeps things more professional than the mailing list. Personal attacks get downvoted on SO 3. Stack Overflow has better sear

[GitHub] cordova-mobile-spec pull request: CB-6437[Improvements & support f...

2014-04-14 Thread martincgg
Github user martincgg commented on a diff in the pull request: https://github.com/apache/cordova-mobile-spec/pull/55#discussion_r11607297 --- Diff: createmobilespec/createmobilespec.js --- @@ -17,99 +16,215 @@ KIND, either express or implied. See the License for the

Re: Introducing myself

2014-04-14 Thread Victor Sosa
Hello everybody. Thanks for the warming welcome, feels good being in a community that is so active and that worries about the people in it. I'll check the links you kindly provided. Also, I've sent the signed ICLA to Apache foundation. 2014-04-14 13:48 GMT-05:00 Marcel Kinard : > Welcome! Besid

[GitHub] cordova-mobile-spec pull request: CB-6437[Improvements & support f...

2014-04-14 Thread cmarcelk
Github user cmarcelk commented on a diff in the pull request: https://github.com/apache/cordova-mobile-spec/pull/55#discussion_r11607031 --- Diff: createmobilespec/createmobilespec.sh --- @@ -0,0 +1,3 @@ +#!/bin/bash --- End diff -- All files should include the Apa

Re: Introducing myself

2014-04-14 Thread Lisa Seacat DeLuca
Welcome to Cordova Victor! Ping if you have any questions on how to get started contributing. ...another IBMer++ Lisa Lisa Seacat DeLuca Mobile Engineer | t: +415.787.4589 | ldel...@apache.org | | ldel...@us.ibm.com | lisaseacat.com | | From: Victor Sosa To: dev@cordova.apache.or

[GitHub] cordova-mobile-spec pull request: CB-6437[Improvements & support f...

2014-04-14 Thread cmarcelk
Github user cmarcelk commented on a diff in the pull request: https://github.com/apache/cordova-mobile-spec/pull/55#discussion_r11606853 --- Diff: createmobilespec/createmobilespec.js --- @@ -17,99 +16,215 @@ KIND, either express or implied. See the License for the

[GitHub] cordova-mobile-spec pull request: CB-6437[Improvements & support f...

2014-04-14 Thread cmarcelk
Github user cmarcelk commented on a diff in the pull request: https://github.com/apache/cordova-mobile-spec/pull/55#discussion_r11606571 --- Diff: createmobilespec/createmobilespec.js --- @@ -17,99 +16,215 @@ KIND, either express or implied. See the License for the

[GitHub] cordova-mobile-spec pull request: CB-6437[Improvements & support f...

2014-04-14 Thread cmarcelk
Github user cmarcelk commented on a diff in the pull request: https://github.com/apache/cordova-mobile-spec/pull/55#discussion_r11606359 --- Diff: createmobilespec/createmobilespec.js --- @@ -17,99 +16,215 @@ KIND, either express or implied. See the License for the

BB10 com.blackberry.utils plugin .so?

2014-04-14 Thread Marcel Kinard
For BB10, cordova-plugin-contacts has a couple pre-reqs, one of which is the plugin "com.blackberry.utils". The plugin.xml for that utils plugin referenes a couple lib-files "device/libutils.so" and "simulator/libutils.so", which appears to be compiled from C source. I'd like to build them mysel

Re: Get customized feature parameter value from config.xml

2014-04-14 Thread Li, Jonathan
That works. Thanks. On 4/14/14 4:26 PM, "Shazron" wrote: >Yes, that is the known limitation. My suggestion is to prefix the >preference name with your plugin name, or whatever you prefer. > > >On Mon, Apr 14, 2014 at 1:12 PM, Li, Jonathan wrote: > >> Although the preference can be defined in pl

Re: Get customized feature parameter value from config.xml

2014-04-14 Thread Shazron
Yes, that is the known limitation. My suggestion is to prefix the preference name with your plugin name, or whatever you prefer. On Mon, Apr 14, 2014 at 1:12 PM, Li, Jonathan wrote: > Although the preference can be defined in plugin.xml on per platform and > plugin level, but when the informati

[GitHub] cordova-mobile-spec pull request: CB-6437[Improvements & support f...

2014-04-14 Thread martincgg
Github user martincgg commented on the pull request: https://github.com/apache/cordova-mobile-spec/pull/55#issuecomment-40413680 Changed tabs for spaces --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

Re: Duplicate plugin preferences - any docs on config/defaults xml mechanisms

2014-04-14 Thread Andrew Grieve
I think the original design of this was that duplicates are expected, and the last one wins. Not saying that's the best solution, but I'm pretty sure that's how it works. On Mon, Apr 14, 2014 at 8:41 AM, Matt Scafidi-McGuire < matt.scafidi-mcgu...@dealer.com> wrote: > Indeed the platform section

Re: Sharing code between plugman and cordova-cli

2014-04-14 Thread Brian LeRoux
If we manage to get down to 1 module === 1 function then its doubtful we'd have much advantage to the atomic commits thing. I'm cool w/ starting w/ one repo and seeing where it leads. Sort of a graduation step thing. On Mon, Apr 14, 2014 at 12:02 PM, Michal Mocny wrote: > Alright then, lets do

Re: support on phonegap/cordova?

2014-04-14 Thread Andrew Grieve
Most Apache projects have a users@ list for this purpose. Although SO often yields better answers, I don't think it would hurt to have a users@ list. On Fri, Apr 11, 2014 at 9:09 AM, Joe Bowser wrote: > This is a dev list, not a support list. I would recommend StackOverflow. > On Apr 9, 2014 3

Re: Get customized feature parameter value from config.xml

2014-04-14 Thread Li, Jonathan
Although the preference can be defined in plugin.xml on per platform and plugin level, but when the information is used to generate config.xml, the related preference element will be generated under the root "widget" element, and so shared by all plugins. This may cause conflict if the same prefere

[GitHub] cordova-mobile-spec pull request: CB-6437[Improvements & support f...

2014-04-14 Thread cmarcelk
Github user cmarcelk commented on a diff in the pull request: https://github.com/apache/cordova-mobile-spec/pull/55#discussion_r11604897 --- Diff: createmobilespec/createmobilespec.js --- @@ -17,99 +16,215 @@ KIND, either express or implied. See the License for the

Re: Icons and Splash Screens (bug?)

2014-04-14 Thread Axel Nennker
There is a pull request related to cb-2606 for cordoava-docs. Sorry can't find the link to it on my phone. Sergey knows more I think. Axel https://github.com/apache/cordova-cli/pull/126 Am 14.04.2014 20:35 schrieb "Brian LeRoux" : > Hey Jeremy: ah now I get you! I've cc'd the Cordova list to see

[GitHub] cordova-mobile-spec pull request: CB-6437[Improvements & support f...

2014-04-14 Thread martincgg
Github user martincgg commented on the pull request: https://github.com/apache/cordova-mobile-spec/pull/55#issuecomment-40410078 Tested it under Windows 7 & 8(Run as adminstrator), Mac and Linux(Ubuntu). --- If your project is set up for it, you can reply to this email and have your r

Re: Get customized feature parameter value from config.xml

2014-04-14 Thread Shazron
per platform in the platform tag - yes. plugin level - yes. On Mon, Apr 14, 2014 at 11:34 AM, Li, Jonathan wrote: > Does "preference" can be set on per platform and plugin level? > > On 4/14/14 2:27 PM, "Shazron" wrote: > > >Will a tag not suffice? > > > > > >On Mon, Apr 14, 2014 at 11:23 A

[GitHub] cordova-mobile-spec pull request: CB-6437[Improvements & support f...

2014-04-14 Thread martincgg
GitHub user martincgg opened a pull request: https://github.com/apache/cordova-mobile-spec/pull/55 CB-6437[Improvements & support for more platforms] -Added full compatibility cross platform -Works with absolute paths -Added support for Blackberry10, Windows 8 and Windows Pho

Re: Sharing code between plugman and cordova-cli

2014-04-14 Thread Michal Mocny
Alright then, lets do 3+ npm packages: cordova (cli only), plugman (cli only), and cordova-lib (or something similarly named, TBD, suggestions?). As cordova-lib refactors to have some useful self-contained utils, we will move those to dedicated npm modules published separately. However, we are cu

Re: Introducing myself

2014-04-14 Thread Marcel Kinard
Welcome! Besides the page that Brian referenced, the wiki overall has good information for developers, so browse around it. http://wiki.apache.org/cordova If you plan on making contributions, start by getting an ICLA signed, as described in ContributorWorkflow. On Apr 14, 2014, at 2:08 PM, Bria

Re: Introducing myself

2014-04-14 Thread Martin Gonzalez
Welcome Victor Connected by MOTOBLUR™ -Original message- From: Michal Mocny To: dev Sent: Mon, 14 Apr 2014, 18:41:44 GMT+00:00 Subject: Re: Introducing myself Hello Victor! On Mon, Apr 14, 2014 at 2:08 PM, Brian LeRoux wrote: > Welcome Victor! > > You can find more goodies to get s

Re: Introducing myself

2014-04-14 Thread Michal Mocny
Hello Victor! On Mon, Apr 14, 2014 at 2:08 PM, Brian LeRoux wrote: > Welcome Victor! > > You can find more goodies to get started on the wiki: > http://wiki.apache.org/cordova/ContributorWorkflow > > > On Mon, Apr 14, 2014 at 9:51 AM, Victor Sosa > wrote: > > > Hello Apache Cordova Community.

Re: Get customized feature parameter value from config.xml

2014-04-14 Thread Li, Jonathan
Does "preference" can be set on per platform and plugin level? On 4/14/14 2:27 PM, "Shazron" wrote: >Will a tag not suffice? > > >On Mon, Apr 14, 2014 at 11:23 AM, Li, Jonathan >wrote: > >> Hi, >> In the following sample plugin.xml and config.xml , the parameter >> "enable-redirect" can be co

Icons and Splash Screens (bug?)

2014-04-14 Thread Brian LeRoux
Hey Jeremy: ah now I get you! I've cc'd the Cordova list to see if this is known (and we'll add a bug either way to fix). Thanks mang! On Mon, Apr 14, 2014 at 9:58 AM, Jeremy Battle wrote: > Brian, > > This is @complexcarb from Twitter, sorry for moving to e-mail but 140 > characters is diffic

Re: Great writeup from Ray Camden on PG/Cordova

2014-04-14 Thread Anis KADRI
We do have usage stats on the cli vs bin/create plugman workflow. Last time I checked it was 93% CLI and 7% plugman. The stats are no longer available since we deployed the new site but we can add them back if needed. On Mon, Apr 14, 2014 at 11:20 AM, Brian LeRoux wrote: > A word of caution. Su

Re: Get customized feature parameter value from config.xml

2014-04-14 Thread Shazron
Will a tag not suffice? On Mon, Apr 14, 2014 at 11:23 AM, Li, Jonathan wrote: > Hi, > In the following sample plugin.xml and config.xml , the parameter > "enable-redirect" can be configured by app developers when they add the > plugin to cordova project. However, currently only "ios-package"

Get customized feature parameter value from config.xml

2014-04-14 Thread Li, Jonathan
Hi, In the following sample plugin.xml and config.xml , the parameter "enable-redirect" can be configured by app developers when they add the plugin to cordova project. However, currently only "ios-package" and "onload" parameters are parsed and stored by config.xml's settings parser, other par

Re: Great writeup from Ray Camden on PG/Cordova

2014-04-14 Thread Brian LeRoux
A word of caution. Surveys are a tool, and data is good, but lets not make it hte only driver for our feature/bug prioritization. Henry Ford — 'If I had asked people what they wanted, they would have said faster horses.' On Mon, Apr 14, 2014 at 10:06 AM, Michal Mocny wrote: > David pointed out

Re: Sharing code between plugman and cordova-cli

2014-04-14 Thread Anis KADRI
To brian and steve's points I think it's a bad idea to move common code to cordova-cli. I don't think we want another cordova-coho. On Fri, Apr 11, 2014 at 5:36 PM, Brian LeRoux wrote: > It would be very good for folks to understand the benefit of using npm is > that we will likely only have to

Re: Introducing myself

2014-04-14 Thread Brian LeRoux
Welcome Victor! You can find more goodies to get started on the wiki: http://wiki.apache.org/cordova/ContributorWorkflow On Mon, Apr 14, 2014 at 9:51 AM, Victor Sosa wrote: > Hello Apache Cordova Community. > > My Name is Victor Sosa. Really excited to start contributing to this > project. > M

[GitHub] cordova-plugin-inappbrowser pull request: window.open(url, '_syste...

2014-04-14 Thread purplecabbage
Github user purplecabbage commented on the pull request: https://github.com/apache/cordova-plugin-inappbrowser/pull/39#issuecomment-40398079 This has been addressed in JS code [1] , and is a native patch is also part of pull-req #38 Expect these changes to land in the ne

[GitHub] cordova-wp8 pull request: Fix for position fix not working.

2014-04-14 Thread purplecabbage
Github user purplecabbage commented on the pull request: https://github.com/apache/cordova-wp8/pull/31#issuecomment-40396152 The addition of Windows Phone support has not been published to the registry. If you install from source [1] support for WP is there. [1] https://githu

Re: Great writeup from Ray Camden on PG/Cordova

2014-04-14 Thread Michal Mocny
David pointed out the link to the raw results file is in your original post! On Mon, Apr 14, 2014 at 12:39 PM, Michal Mocny wrote: > Also, you referenced complaints about File plugin. Discussed with Ian > this morning that it may be great feedback to give him so he can address > it. Can we ge

Introducing myself

2014-04-14 Thread Victor Sosa
Hello Apache Cordova Community. My Name is Victor Sosa. Really excited to start contributing to this project. My background is as Java developer focused on Eclipse tools, but lately I've been doing some mobile development and that's how I discovered Cordova. I also have some background on other ar

Re: Duplicate plugin preferences - any docs on config/defaults xml mechanisms

2014-04-14 Thread Matt Scafidi-McGuire
Indeed the platform sections that you both mentioned are great in the shared config. I'm still seeing them duplicated in the config file after preparing though. So I guess I'll submit a bug report... Thanks, Matt On 4/14/14 10:19 AM, "Ian Clelland" wrote: >On Mon, Apr 14, 2014 at 9:57 AM, Mat

Re: Great writeup from Ray Camden on PG/Cordova

2014-04-14 Thread Michal Mocny
Also, you referenced complaints about File plugin. Discussed with Ian this morning that it may be great feedback to give him so he can address it. Can we get the raw results was it meant to be private? -Michal On Mon, Apr 14, 2014 at 11:08 AM, Ray Camden wrote: > I wasn't *planning* a survey

RE: Great writeup from Ray Camden on PG/Cordova

2014-04-14 Thread Ray Camden
I wasn't *planning* a survey, but this sounds interesting. Let me chew on this and create an initial doc. I'll share it here for folks to comment on and will then publish it. From: mmo...@google.com on behalf of Michal Mocny Sent: Saturday, April 12, 2

[GitHub] cordova-windows pull request: CB-6435 ./VERSION & /template/VERSIO...

2014-04-14 Thread martincgg
Github user martincgg commented on the pull request: https://github.com/apache/cordova-windows/pull/25#issuecomment-40375277 Yes, agree. This is completely odd, what worries me, is when trying to install plugins to a project with windows 8 platform installed, it throws an error with p

[GitHub] cordova-windows pull request: CB-6442 Fix build/deploy errors when...

2014-04-14 Thread vladimir-kotikov
GitHub user vladimir-kotikov opened a pull request: https://github.com/apache/cordova-windows/pull/26 CB-6442 Fix build/deploy errors when path to project contains spaces You can merge this pull request into a Git repository by running: $ git pull https://github.com/MSOpenTech

[GitHub] cordova-plugin-inappbrowser pull request: window.open(url, '_syste...

2014-04-14 Thread alinnert
GitHub user alinnert opened a pull request: https://github.com/apache/cordova-plugin-inappbrowser/pull/39 window.open(url, '_system') does work now Checking the variable `featString` for null value. If third parameter of `window.open()` is not used, the method fails at `featStri

Re: Duplicate plugin preferences - any docs on config/defaults xml mechanisms

2014-04-14 Thread Ian Clelland
On Mon, Apr 14, 2014 at 9:57 AM, Matt Scafidi-McGuire < matt.scafidi-mcgu...@dealer.com> wrote: > We're using cordova to build for iOS & Android and we struggle with a few > issues with the defaults/config mechanisms for plugin preferences. Perhaps > we just don't understand how it's meant to be

Re: Duplicate plugin preferences - any docs on config/defaults xml mechanisms

2014-04-14 Thread Bryan Higgins
Sounds like a bug if two preferences of the same name end up in the platform config.xml. I would encourage you to log this in our JIRA system: https://issues.apache.org/jira/browse/CB Platform specific preferences can be specified using the platform element, which I recently discovered was undocu

Duplicate plugin preferences - any docs on config/defaults xml mechanisms

2014-04-14 Thread Matt Scafidi-McGuire
We're using cordova to build for iOS & Android and we struggle with a few issues with the defaults/config mechanisms for plugin preferences. Perhaps we just don't understand how it's meant to be used or perhaps we've uncovered a bug. These first two issues lead us to the problem I'm writing ab

[GitHub] cordova-wp8 pull request: Fix for position fix not working.

2014-04-14 Thread sushant40
Github user sushant40 commented on the pull request: https://github.com/apache/cordova-wp8/pull/31#issuecomment-40365778 The config fixes the issue I was having with position fixed not working. However setting the app to full screen hides the system tray. My change allows for

[GitHub] cordova-cli pull request: CB-6377 superspawn: always wrap non .exe...

2014-04-14 Thread sgrebnov
Github user sgrebnov commented on the pull request: https://github.com/apache/cordova-cli/pull/161#issuecomment-40365473 @bryanhiggins thx! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have thi

[GitHub] cordova-cli pull request: CB-6377 superspawn: always wrap non .exe...

2014-04-14 Thread bryanhiggins
Github user bryanhiggins commented on the pull request: https://github.com/apache/cordova-cli/pull/161#issuecomment-40364475 @sgrebnov Thanks for testing. I've merged this in. Feel free to issue a pull request for your points which seem valid to me. Josh is on holiday until next week.

[GitHub] cordova-cli pull request: CB-6377 superspawn: always wrap non .exe...

2014-04-14 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-cli/pull/161 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cordova-wp8 pull request: Fix for position fix not working.

2014-04-14 Thread sushant40
Github user sushant40 commented on the pull request: https://github.com/apache/cordova-wp8/pull/31#issuecomment-40363300 The status-bar plugin is IiOS7 only? Do you suggest that I update that to support WP8? --- If your project is set up for it, you can reply to this email and have y

[GitHub] cordova-windows pull request: CB-6435 ./VERSION & /template/VERSIO...

2014-04-14 Thread clelland
Github user clelland commented on the pull request: https://github.com/apache/cordova-windows/pull/25#issuecomment-40361496 It seems odd that this wasn't taken care of automatically by coho when 3.3.0 was released (and when 3.4.0 was released); if it's still not happening when we do 3

[GitHub] cordova-cli pull request: CB-6377 superspawn: always wrap non .exe...

2014-04-14 Thread sgrebnov
Github user sgrebnov commented on the pull request: https://github.com/apache/cordova-cli/pull/161#issuecomment-40355369 LGTM + Tested. I think we should accept the changes and then look on the following improvements: 1. The line below is very complex to read/understa

[GitHub] cordova-plugin-network-information pull request: CB-3207 Newer imp...

2014-04-14 Thread zalun
GitHub user zalun opened a pull request: https://github.com/apache/cordova-plugin-network-information/pull/9 CB-3207 Newer implementation in FFOS implemented You can merge this pull request into a Git repository by running: $ git pull https://github.com/mozilla-cordova/cordov

[GitHub] cordova-plugin-file pull request: Add error codes.

2014-04-14 Thread aogilvie
Github user aogilvie commented on the pull request: https://github.com/apache/cordova-plugin-file/pull/37#issuecomment-40347485 +1 error codes and +1 @purplecabbage. Though `console.error(` would be your friend there. --- If your project is set up for it, you can reply to this email

[GitHub] cordova-plugin-inappbrowser pull request: Make InAppBrowser work w...

2014-04-14 Thread nadyaA
Github user nadyaA commented on the pull request: https://github.com/apache/cordova-plugin-inappbrowser/pull/38#issuecomment-40337912 Hello Jesse, Yes, that is me. Thank you for your quick answer. --- If your project is set up for it, you can reply to this email and have you