GitHub user aendu opened a pull request:
https://github.com/apache/cordova-plugins/pull/10
Update README.md
Fixed the typo in the call to cordova.filesystem.
Also it would be usefull to have a function that lists the actually
available ones. I made a simple version for my
Github user fardjad closed the pull request at:
https://github.com/apache/cordova-cli/pull/164
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
GitHub user tripodsan opened a pull request:
https://github.com/apache/cordova-osx/pull/8
CB-6516 (re) add missing test harness
- added TestApp
- added some initial test cases
- added bin/tests to execute the tests from the command line
You can merge this pull request into
GitHub user aendu opened a pull request:
https://github.com/apache/cordova-plugin-file/pull/41
Update index.md
As i had to figure this all out by myself i though we better share this
info with everybody.
There is a lot of outdated info on the net and also on the cordova docu
+1 for quick release, we have some people who would like to see this fixed
as well. We tried `cordova plugin add org.apache.cordova.statusbar#r0.1.3`
(to pull it in before the borked Android impl) but for some reason the tags
were deleted? Maybe I am misunderstanding something but I thought that
So is it 9am PST or 4pm PST?
On Thu, Apr 24, 2014 at 10:37 PM, Ian Clelland iclell...@chromium.orgwrote:
I approve of that time slot. I'll be there.
Ian
On Thu, Apr 24, 2014 at 10:32 PM, Hu, Ningxin ningxin...@intel.com
wrote:
Please let me know if we agree with this time (9am
On Fri, Apr 25, 2014 at 12:53 AM, Michal Mocny mmo...@chromium.org wrote:
TLDR; Ran a bunch of experiments tonight. I think this is too early to
merge into master. We pointed out several issues in previous threads and
seems they were ignored.
Few quick comments from trying this:
-
Also Anis, would it please be possible to squash most of these commits into
a few units of standalone work? Probably best way to do that is create a
new local branch from your old branch point, apply the diffs from
browserify branch, rebase -i them, then push that branch (this way you
don't need
That syntax is for git URLs. try org.apache.cordova.statusbar@0.1.3
Note that plugman info is a bit useless, but you can use npm info
with our registry via:
npm --registry http://registry.cordova.io info org.apache.cordova.statusbar
Also, +1 for a quick fix vote. Short vote times are
Sounds like 09:00AM PDT
12:00PM EDT
00:00 China Standard Time
16:00 UTC
2014-04-25T16:00:00Z
:)
(Based on Ningxin saying that he wasn't waiting around for the morning)
On Friday, April 25, 2014, Michal Mocny mmo...@chromium.org wrote:
So is it 9am PST or 4pm PST?
On Thu, Apr 24, 2014 at
Actually, why don't we just unpublish 0.1.5?
On Fri, Apr 25, 2014 at 9:55 AM, Andrew Grieve agri...@chromium.org wrote:
That syntax is for git URLs. try org.apache.cordova.statusbar@0.1.3
Note that plugman info is a bit useless, but you can use npm info
with our registry via:
npm
Yeah; it's clearly broken. If someone knows the plugman incantation to do
that them we should.
We can figure out the apache way to unreleased from dist later :)
On Friday, April 25, 2014, Andrew Grieve agri...@chromium.org wrote:
Actually, why don't we just unpublish 0.1.5?
On Fri, Apr 25,
Herp derp. Thanks Andrew.
On Fri, Apr 25, 2014 at 10:18 AM, Ian Clelland iclell...@chromium.orgwrote:
Yeah; it's clearly broken. If someone knows the plugman incantation to do
that them we should.
We can figure out the apache way to unreleased from dist later :)
On Friday, April 25,
Okay, unpublished.
plugman unpublish said it succeeded, but plugman/npm info after that
showed that it was still there.
npm --registry http://registry.cordova.io unpublish
org.apache.cordova.statusbar@0.1.5
Seemed to do more work, but then did gave an error. However, running
info now shows that
Hello Cordova,
I am developing iOS app using Apache Cordova APIs. May I Know if I Put only
Cordova.js file on remote site/server for the application, then will Apple
store reject my iOS application?
In above case, Cordova.js file on the server as well as one in my application
folder. While
Hi all,
I'm looking at the current 3.x Cordova implementations of platform.js in the
core cordova-js as part of adapting for webOS. Just had a quick question: I've
noticed some platforms with bootstrap function and other references to an
initialize function. Is there and general preference of
Github user zalun commented on the pull request:
https://github.com/apache/cordova-firefoxos/pull/7#issuecomment-41403013
Is it polished?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
I might be able to make it but Mozilla can't from what I heard. I don't
know if Brian can either.
On Apr 25, 2014 6:58 AM, Ian Clelland iclell...@chromium.org wrote:
Sounds like 09:00AM PDT
12:00PM EDT
00:00 China Standard Time
16:00 UTC
2014-04-25T16:00:00Z
:)
(Based on Ningxin saying
Github user zalun commented on the pull request:
https://github.com/apache/cordova-firefoxos/pull/6#issuecomment-41403158
Please close the pull request if it shouldn't be here
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Should be fine. Try it and see :)
On Fri, Apr 25, 2014 at 10:05 AM, Gaurav Purohit
gaurav.puro...@gatewaytechnolabs.com wrote:
Hello Cordova,
I am developing iOS app using Apache Cordova APIs. May I Know if I Put only
Cordova.js file on remote site/server for the application, then will Apple
Github user zalun closed the pull request at:
https://github.com/apache/cordova-mobile-spec/pull/44
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user zalun commented on the pull request:
https://github.com/apache/cordova-mobile-spec/pull/44#issuecomment-41403391
This is a PR to master - I will squash it, test with new Cordova version
and make a new one for dev. Closing
---
If your project is set up for it, you can
Github user zalun closed the pull request at:
https://github.com/apache/cordova-plugin-camera/pull/10
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user zalun closed the pull request at:
https://github.com/apache/cordova-plugin-device/pull/9
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
reverted the merge commits to plugman js.
On Fri, Apr 25, 2014 at 9:43 AM, Michal Mocny mmo...@chromium.org wrote:
Also Anis, would it please be possible to squash most of these commits into
a few units of standalone work? Probably best way to do that is create a
new local branch from your
Both work right now. looking at what's there, no platforms use
initialize() though, so that could probably be removed (unless you
need it). The difference is in when they are called (look at
common/init.js)
On Fri, Apr 25, 2014 at 10:48 AM, jason.robitai...@lge.com
jason.robitai...@lge.com wrote:
Github user zalun closed the pull request at:
https://github.com/apache/cordova-plugin-device-orientation/pull/7
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so,
Github user zalun commented on the pull request:
https://github.com/apache/cordova-plugin-dialogs/pull/15#issuecomment-41404063
It's in master
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user zalun closed the pull request at:
https://github.com/apache/cordova-plugin-dialogs/pull/15
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user jsoref commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-file/pull/41#discussion_r12001137
--- Diff: doc/index.md ---
@@ -24,6 +24,20 @@ to HTML5 Rocks' [FileSystem
article](http://www.html5rocks.com/en/tutorials/file
on the
Github user jsoref commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-file/pull/41#discussion_r12001097
--- Diff: doc/index.md ---
@@ -24,6 +24,20 @@ to HTML5 Rocks' [FileSystem
article](http://www.html5rocks.com/en/tutorials/file
on the
Github user zalun closed the pull request at:
https://github.com/apache/cordova-plugin-geolocation/pull/12
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if
Github user zalun commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-geolocation/pull/12#discussion_r12001202
--- Diff: doc/index.md ---
@@ -49,11 +49,22 @@ see the Privacy Guide.
cordova plugin add org.apache.cordova.geolocation
Github user zalun closed the pull request at:
https://github.com/apache/cordova-plugin-geolocation/pull/8
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if
Github user jsoref commented on a diff in the pull request:
https://github.com/apache/cordova-firefoxos/pull/7#discussion_r12001272
--- Diff: bin/lib/create.js ---
@@ -26,6 +26,7 @@ var fs = require('fs'),
ROOT= path.join(__dirname, '..', '..'),
check_reqs =
Github user jsoref commented on a diff in the pull request:
https://github.com/apache/cordova-firefoxos/pull/7#discussion_r12001296
--- Diff: bin/lib/create.js ---
@@ -53,14 +54,24 @@ exports.createProject =
function(project_path,package_name,project_name){
//copy
GitHub user stacic opened a pull request:
https://github.com/apache/cordova-mobile-spec/pull/57
CB-6520 Fixed cordova-incl.js for wp8
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/stacic/cordova-mobile-spec CB-6520
Github user zalun closed the pull request at:
https://github.com/apache/cordova-plugin-vibration/pull/8
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user jsoref commented on a diff in the pull request:
https://github.com/apache/cordova-firefoxos/pull/7#discussion_r12001446
--- Diff: bin/templates/project/cordova/clean ---
@@ -0,0 +1,38 @@
+#!/usr/bin/env node
+
+/*
+ Licensed to the Apache Software
Github user jsoref commented on a diff in the pull request:
https://github.com/apache/cordova-firefoxos/pull/7#discussion_r12001459
--- Diff: bin/templates/project/cordova/clean ---
@@ -0,0 +1,38 @@
+#!/usr/bin/env node
+
+/*
+ Licensed to the Apache Software
Github user jsoref commented on a diff in the pull request:
https://github.com/apache/cordova-firefoxos/pull/7#discussion_r12001480
--- Diff: bin/templates/project/cordova/lib/build.js ---
@@ -0,0 +1,167 @@
+#!/usr/bin/env node
+
+/*
+ * Licensed to the Apache
Github user jsoref commented on a diff in the pull request:
https://github.com/apache/cordova-firefoxos/pull/7#discussion_r12001463
--- Diff: bin/templates/project/cordova/lib/build.js ---
@@ -0,0 +1,167 @@
+#!/usr/bin/env node
+
+/*
+ * Licensed to the Apache
Github user jsoref commented on a diff in the pull request:
https://github.com/apache/cordova-firefoxos/pull/7#discussion_r12001511
--- Diff: bin/templates/project/cordova/lib/build.js ---
@@ -0,0 +1,167 @@
+#!/usr/bin/env node
+
+/*
+ * Licensed to the Apache
I will be on hangouts at that time.
Thanks,
-ningxin
-Original Message-
From: Joe Bowser [mailto:bows...@gmail.com]
Sent: Friday, April 25, 2014 11:00 PM
To: dev@cordova.apache.org
Subject: Re: [Android] Refactoring for different engines
I might be able to make it but Mozilla
I hate to say this but I think the best bet is to meet at 9 and 4.
On Apr 25, 2014 8:34 AM, Ian Clelland iclell...@chromium.org wrote:
Joe -- I'd definitely like to be able to chat with Mozilla folks as well --
if you want to set up something for later in the day, I'll make myself
available
I've created https://issues.apache.org/jira/browse/CB-6521 to track this
now.
My plan is to merge all of the dev branches into master, and push that. At
that point, anyone pushing new changes can just push directly to master,
and everything should be good.
If I delete the dev branches
On Fri, Apr 25, 2014 at 11:42 AM, Ian Clelland iclell...@chromium.orgwrote:
I've created https://issues.apache.org/jira/browse/CB-6521 to track this
now.
My plan is to merge all of the dev branches into master, and push that. At
that point, anyone pushing new changes can just push directly
Hangout link for this morning?
On Fri, Apr 25, 2014 at 8:57 AM, Hu, Ningxin ningxin...@intel.com wrote:
Are people also going to use older (1-4) versions of Crosswalk? Or is the
plan to encourage people to only use either stable or beta versions?
Crosswalk follows release cycles similar to
https://staging.talkgadget.google.com/hangouts/_/7ecpi3uaclcuedn7imn6b9jdqc
On Fri, Apr 25, 2014 at 11:58 AM, Joe Bowser bows...@gmail.com wrote:
Hangout link for this morning?
On Fri, Apr 25, 2014 at 8:57 AM, Hu, Ningxin ningxin...@intel.com wrote:
Are people also going to use older (1-4)
Sorry, thats the wrong url, correct one coming in a sec.
On Fri, Apr 25, 2014 at 12:00 PM, Ian Clelland iclell...@chromium.orgwrote:
https://staging.talkgadget.google.com/hangouts/_/7ecpi3uaclcuedn7imn6b9jdqc
On Fri, Apr 25, 2014 at 11:58 AM, Joe Bowser bows...@gmail.com wrote:
Hangout
This one should be much better:
https://plus.google.com/hangouts/_/72cpi1jlelgth9mhjgbg119hds
On Fri, Apr 25, 2014 at 12:02 PM, Michal Mocny mmo...@chromium.org wrote:
Sorry, thats the wrong url, correct one coming in a sec.
On Fri, Apr 25, 2014 at 12:00 PM, Ian Clelland
Are people also going to use older (1-4) versions of Crosswalk? Or is the
plan to encourage people to only use either stable or beta versions?
Crosswalk follows release cycles similar to Chromium. Current canary is
Crosswalk-6, beta is 5 and stable is 4. The developers work on canary for new
Ian Clelland wrote:
Sounds like 09:00AM PDT
12:00PM EDT
00:00 China Standard Time
16:00 UTC
2014-04-25T16:00:00Z
:)
(Based on Ningxin saying that he wasn't waiting around for the morning)
Which would be now, is there a way to join this meeting?
Ian Clelland wrote:
https://staging.talkgadget.google.com/hangouts/_/7ecpi3uaclcuedn7imn6b9jdq
c
https://talkgadget.google.com/hangouts/_/7ecpi3uaclcuedn7imn6b9jdqc
Might work. Staging is probably internal.
Github user jsoref commented on the pull request:
https://github.com/apache/cordova-blackberry/pull/155#issuecomment-41410913
You need to use `/ /g`
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
GitHub user bryanhiggins opened a pull request:
https://github.com/apache/cordova-blackberry/pull/155
CB-6522 Disallow space in target name
- Update target add command
- Update auto-detected target
You can merge this pull request into a Git repository by running:
$ git
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-blackberry/pull/155
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Notes:
- native junit tests needs fixing (due to deprication)
- common script for creating walk mobilespec
- fix failing mobile spec tests (file-transfer?, media?)
- who publishes the plugins, intel or cordova?
- static vs dynamic xwalk lib
- (option) one plugin, use hooks to download
/me groans
(that co business is really elegant…a rare sight for js)
On Thu, Apr 24, 2014 at 9:56 PM, Michal Mocny mmo...@chromium.org wrote:
On Thu, Apr 24, 2014 at 9:42 PM, Andrew Grieve agri...@chromium.org
wrote:
Yes, I will say that I was super impressed at how cleanly the code
Jshint seems to have pretty good defaults, so a short config line like this
might be enough for most node js files we have.
/* jshint node:true, unused:true, indent:4 */
One very simple option it is to start adding this config line in every
file, and then just run jshint without any extra config.
Github user sgrebnov commented on the pull request:
https://github.com/apache/cordova-plugin-contacts/pull/26#issuecomment-41418136
I've added minor update to WP8 code to populate 'photos' fields. This
functionality was missing.
---
If your project is set up for it, you can reply
Contacts is known to not work because some modules
require('./ContactError') instead of
('org.apache.cordova.contacts.ContactError') like most other modules do. I
didn't bother to fix yet it because it was an exception not a rule.
I didn't try any of the chrome plugins. They might be doing the
On Fri, Apr 25, 2014 at 1:27 PM, Anis KADRI anis.ka...@gmail.com wrote:
Contacts is known to not work because some modules
require('./ContactError') instead of
('org.apache.cordova.contacts.ContactError') like most other modules do. I
didn't bother to fix yet it because it was an exception
Had some discussions about this at ApacheCon, and I think it would be
good to formalize this in a release-process doc within coho/docs.
The best Apache docs for it is:
https://www.apache.org/dev/release-publishing.html
When we (or at least, members of the PMC), vote on a release, we
(should) be
On Fri, Apr 25, 2014 at 1:35 PM, Michal Mocny mmo...@chromium.org wrote:
On Fri, Apr 25, 2014 at 1:27 PM, Anis KADRI anis.ka...@gmail.com wrote:
Contacts is known to not work because some modules
require('./ContactError') instead of
('org.apache.cordova.contacts.ContactError') like most other
On Apr 25, 2014, at 1:55 PM, Andrew Grieve agri...@chromium.org wrote:
Had some discussions about this at ApacheCon, and I think it would be
good to formalize this in a release-process doc within coho/docs.
Totally agree. I think there is some variation currently in what we understand
it
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-plugin-file/pull/38
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-plugin-file/pull/37
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-plugin-inappbrowser/pull/33
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-plugin-inappbrowser/pull/40
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-plugin-inappbrowser/pull/41
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-plugin-network-information/pull/8
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
This is now done. Buildbot will be broken until we update it to always use
master plugin branches; otherwise everything should be okay.
For the morbidly curious:
$ cordova-coho/coho repo-update -r plugins
$ cordova-coho/coho foreach -r plugins git checkout master; git merge dev
$ echo -e \nThis
On Fri, Apr 25, 2014 at 10:55 AM, Andrew Grieve agri...@chromium.org wrote:
Had some discussions about this at ApacheCon, and I think it would be
good to formalize this in a release-process doc within coho/docs.
The best Apache docs for it is:
+1 to this!
On Fri, Apr 25, 2014 at 11:29 AM, Ian Clelland iclell...@chromium.org wrote:
On Fri, Apr 25, 2014 at 1:55 PM, Andrew Grieve agri...@chromium.org wrote:
Had some discussions about this at ApacheCon, and I think it would be
good to formalize this in a release-process doc within
+1 to this also.
Starting a new thread on the subject of automating #3
@purplecabbage
risingj.com
On Fri, Apr 25, 2014 at 11:35 AM, Joe Bowser bows...@gmail.com wrote:
+1 to this!
On Fri, Apr 25, 2014 at 11:29 AM, Ian Clelland iclell...@chromium.org
wrote:
On Fri, Apr 25, 2014 at
:+1:
On Fri, Apr 25, 2014 at 11:45 AM, Jesse purplecabb...@gmail.com wrote:
+1 to this also.
Starting a new thread on the subject of automating #3
@purplecabbage
risingj.com
On Fri, Apr 25, 2014 at 11:35 AM, Joe Bowser bows...@gmail.com wrote:
+1 to this!
On Fri, Apr 25, 2014
The automation of icla contributors being compared to commits was mentioned
in another thread[1].
3 - Code is made up of commits by individuals that have signed the
ICLA (or that are trivial commits)
I foresee issues as there are lots of cases where github usernames are not
easily compared to
This would get us into a pretty sweet world.
One question: Between [DISCUSS] and [RELEASE] how do we make sure nothing
slips in? Should DISCUSS include branching/tagging? Pointing at a CI
result? Trust nothing changes?
-Michal
On Fri, Apr 25, 2014 at 2:55 PM, Brian LeRoux b...@brian.io
Like this plan. Thanks for staying on top of that moving target Ian.
On Thu, Apr 24, 2014 at 1:46 PM, Ian Clelland iclell...@chromium.orgwrote:
Yeah, I've brought this up a couple of times before. There have been two
competing specs for file system access, and the one which Cordova
Yeah first thing that come to my mind was to just add it as part of the
commit itself, so AUTHORS and/or COMMITTERS files.
This means that we don't append anything with coho, we just do, git patch
author - lookup in AUTHORS - get real name - lookup in apache list
We could even make a git commit
On Fri, Apr 25, 2014 at 10:55 AM, Andrew Grieve agri...@chromium.org wrote:
Had some discussions about this at ApacheCon, and I think it would be
good to formalize this in a release-process doc within coho/docs.
I'd like to help with this. ASF release policy is an area of expertise for
me, and
On Fri, Apr 25, 2014 at 11:34 AM, Joe Bowser bows...@gmail.com wrote:
Well, there's a reason we do cadence. Of course, Apache seems to
despise cadence and the release early, release often thing.
There is no Apache policy stopping Cordova from scheduling release votes on a
fixed cadence.
Instead of having a map of username - Real Name, we could maintain a list
of usernames that we know have a valid ICLA.
AUTHORs files might if we want to maintain them in every repo that we have.
On Fri, Apr 25, 2014 at 3:16 PM, Michal Mocny mmo...@chromium.org wrote:
Yeah first thing that
There are numerous changes I would like to see pushed out. Can we start
talking about a 3.5.0 platform release?
@purplecabbage
risingj.com
This sounds to me like the simplest approach.
Would a git commit hook catch this scenario so a commit never goes in without
ICLA verification? Even if a non-ICLA author's commit can be reverted, that
content is still in the repo, which doesn't sound idea.
On Apr 25, 2014, at 3:31 PM, Andrew
It's probably time.
Joe and I were discussing the possibility of including an (alpha) API for
pluggable webviews in a 3.5.0 release of cordova-android. I'd like to see
that in place, but it would probably not be ready until mid-next-week at
the earliest.
iOS has had only a couple of commits
As long as we don't release with their code in it, I think it's fine for it
to be committed then reverted.
Note too, that AFAIK, there's no way for us to verify CCLAs :S
I was imagining adding this to our automated build. E.g. maybe have a coho
command for doing this, and then having our build
We can accept trivial commits without an ICLA, so the commit hook would
need a firm definition of 'trivial'.
Sounds like more work than it is worth, I would rather leave the definition
of 'trivial' to the reviewer of the pull request.
@purplecabbage
risingj.com
On Fri, Apr 25, 2014 at 12:37 PM,
Would love to get to a platforms-independently-released world, but am happy
to do another cadence release.
In terms of getting our act together, we need to update our cadence release
process to not have the release to dist/ as an afterthought:
How about: trivial = 10 lines || commit hash exists in a
trivial-commits.txt file?
On Fri, Apr 25, 2014 at 3:42 PM, Jesse purplecabb...@gmail.com wrote:
We can accept trivial commits without an ICLA, so the commit hook would
need a firm definition of 'trivial'.
Sounds like more work than it
Github user dematerializer commented on the pull request:
https://github.com/apache/cordova-plugin-vibration/pull/11#issuecomment-41433480
Hi! My ICLA has been filed by secretary.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Andrew Grieve wrote:
How about: trivial = 10 lines || commit hash exists in a
trivial-commits.txt file?
trivial-commits should be in a different repo (coho?)
GitHub user stacic opened a pull request:
https://github.com/apache/cordova-mobile-spec/pull/58
CB-6466 Created mobile-spec test
Added a test to mobile-spec to check that filetransfer.download()
automatically creates any nonexistent directories.
Associated with
Thats a decent plan.
(But instead of LOC for threshold I'd do weighted hamming distance that
puts little weight on whitespace and semicolons etc. ;)
-Michal
On Fri, Apr 25, 2014 at 4:00 PM, Josh Soref jso...@blackberry.com wrote:
Andrew Grieve wrote:
How about: trivial = 10 lines ||
again: I would rather leave the definition of 'trivial' to the reviewer of
the pull request.
An update to docs of 100 lines can be trivial ... Josh renaming 'cordova'
to 'Cordova' across 3 repos, and 15 files, could be considered trivial ...
4 lines of critical code could be non-trivial.
Note,
I doubt we could do a 10 lines policy -- I'm sure there are plenty of
significant changes that could be implemented in 10 lines or less. (Or a
series of 10 line commits)
I wouldn't want to have any policy in place that made it easy for us to
automatically miss potential ASF policy violations.
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-mobile-spec/pull/56
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Rush album titles.
On 4/17/2014 5:08 PM, Brian LeRoux wrote:
Since cordova-lib is going to be a sort of container for a whole bunch of
node modules with their own versioning in package.json we need to come up
with our convention for tagging releases of the aggregate cordova-lib
itself.
Ubuntu
FYI. Just updated the PR with separated save restore commands.
--
Gorkem
On Thu, Apr 24, 2014 at 7:21 PM, Gorkem Ercan gorkem.er...@gmail.comwrote:
I guess this is essentially moving save command as a flag to cordova
plugin * commands and restore becomes harder to discover. We need to
1 - 100 of 115 matches
Mail list logo
