Github user MariaBukharina commented on the pull request:
https://github.com/apache/cordova-plugin-contacts/pull/49#issuecomment-61074069
This PR is targeting Windows platform. Windows phone 8 is out of scope
---
If your project is set up for it, you can reply to this email and have
Steve,
You're right, I'm being an idiot. I'll make the changes today and submit the
PR. I'm just the tiniest bit intimidated by the process since I've not done it
before.
On 10/29/2014 2:40 PM, Steven Gill wrote:
Hey John,
Thanks for filing the two issues. It would be great if you could sen
I noticed something with Plugman this morning. When you add iOS as a platform,
the plugin.xml file points to src/ios/CDVpluginname.m, but the file created by
Plugman is actually src/ios/pluginname.m.
Submitted a ticket: https://issues.apache.org/jira/browse/CB-7909.
--
John M. Wargo
@johnwarg
Github user agrieve commented on a diff in the pull request:
https://github.com/apache/cordova-coho/pull/58#discussion_r19605710
--- Diff: src/gitutil.js ---
@@ -90,4 +90,6 @@ exports.hashForRef = function(ref) {
return executil.execHelper(executil.ARGS('git rev-parse', ref
Github user agrieve commented on a diff in the pull request:
https://github.com/apache/cordova-coho/pull/58#discussion_r19605765
--- Diff: src/nightly.js ---
@@ -0,0 +1,148 @@
+/*
+Licensed to the Apache Software Foundation (ASF) under one
+or more contributor license ag
Github user agrieve commented on a diff in the pull request:
https://github.com/apache/cordova-coho/pull/58#discussion_r19605826
--- Diff: src/nightly.js ---
@@ -0,0 +1,148 @@
+/*
+Licensed to the Apache Software Foundation (ASF) under one
+or more contributor license ag
Github user agrieve commented on a diff in the pull request:
https://github.com/apache/cordova-coho/pull/58#discussion_r19605982
--- Diff: src/nightly.js ---
@@ -0,0 +1,148 @@
+/*
+Licensed to the Apache Software Foundation (ASF) under one
+or more contributor license ag
Github user agrieve commented on a diff in the pull request:
https://github.com/apache/cordova-coho/pull/58#discussion_r19606137
--- Diff: src/npm-publish.js ---
@@ -0,0 +1,77 @@
+/*
+Licensed to the Apache Software Foundation (ASF) under one
+or more contributor license
Github user agrieve commented on a diff in the pull request:
https://github.com/apache/cordova-coho/pull/58#discussion_r19606268
--- Diff: src/repoutil.js ---
@@ -449,14 +450,23 @@ exports.forEachRepo = function*(repos, func) {
var newPath = isInForEachRepoFunction ? pa
Github user agrieve commented on a diff in the pull request:
https://github.com/apache/cordova-coho/pull/58#discussion_r19605898
--- Diff: src/nightly.js ---
@@ -0,0 +1,148 @@
+/*
+Licensed to the Apache Software Foundation (ASF) under one
+or more contributor license ag
Github user agrieve commented on a diff in the pull request:
https://github.com/apache/cordova-coho/pull/58#discussion_r19606358
--- Diff: src/repoutil.js ---
@@ -449,14 +450,23 @@ exports.forEachRepo = function*(repos, func) {
var newPath = isInForEachRepoFunction ? pa
Cool! Left some minor comments.
On Thu, Oct 30, 2014 at 1:16 AM, Steven Gill wrote:
> I have been doing some work on releasing nightlys recently.
>
> Please review PR [1] and comment on the issue [2].
>
> [1] https://github.com/apache/cordova-coho/pull/58
> [2] https://issues.apache.org/jira/bro
Insert a space after "if" here
https://github.com/apache/cordova-coho/pull/58#discussion_r19606268
--- Diff: src/repoutil.js ---
@@ -449,14 +450,23 @@ exports.forEachRepo = function*(repos, func) {
var newPath = isInForEachRepoFunction ? path.join('..', repo.repoName) :
repo.repoName;
isInForE
Steve,
I'm trying to get setup to make the changes and submit them, but I'm not a big
Git guy, so I'm running into some issues. Can you, or someone else, help me?
I'm working through the guide here:
http://wiki.apache.org/cordova/IssueWorkflow.
It says I need to setup my environment using:
$
>There seems to be a missing step there. Should it be?
>$ git clone https://git-wip-us.apache.org/repos/asf/cordova-docs.git
>$ cd cordova-docs
>$ git remote add github https://github.com/you/cordova-docs.git
Yes.
> There seems to be a step missing, when did I define a remote target of
> 'apa
Is there an issue with the semantics of "plugin add" and "platform add"?
This is just a high level query to see if this is something worth discussing in
more detail. I don't know exactly what each Cordova CLI command does. My
knowledge is based upon reading documentation (which is sometimes wr
On Wed, Oct 29, 2014 at 6:40 PM, Shazron wrote:
> Mark, this patch is important for us to get pulled in:
> https://github.com/apache/cordova-lib/pull/116
>
>
The patch looks good to me. I haven't branched yet, just merge it in if
everything else is ok with it.
> On Wed, Oct 29, 2014 at 3:27 PM
Thanks Steve, this is a very useful feature to implement.
I like the the dryrun idea "execOrPretend"
On Thu, Oct 30, 2014 at 10:11 AM, Andrew Grieve
wrote:
> Cool! Left some minor comments.
>
> On Thu, Oct 30, 2014 at 1:16 AM, Steven Gill
> wrote:
>
> > I have been doing some work on releasing
Really appreciate the comments and feedback.
execOrPretend was implemented by Andrew in cadence release script for
tagging + pushing. I just moved it out to executil so other functions can
use it.
On Oct 30, 2014 8:19 AM, "Carlos Santana" wrote:
> Thanks Steve, this is a very useful feature to i
Hey John,
Glad you had a change of heart!
I will get back to your questions when I get into the office.
Feel free to email me ANY problems you have. :)
On Oct 30, 2014 7:37 AM, "Josh Soref" wrote:
> >There seems to be a missing step there. Should it be?
>
> >$ git clone https://git-wip-us.apa
any way I think having nightly builds it's great, next conquer the world
with a nightly mobilespec app ready to run on a device using the nightly
build :-)
On Thu, Oct 30, 2014 at 11:22 AM, Steven Gill
wrote:
> Really appreciate the comments and feedback.
>
> execOrPretend was implemented by An
I'll get that tested and merged in later today as well as get the iOS
platform ready for vote.
On Thursday, October 30, 2014, Mark Koudritsky wrote:
> On Wed, Oct 29, 2014 at 6:40 PM, Shazron >
> wrote:
>
> > Mark, this patch is important for us to get pulled in:
> > https://github.com/apache/co
GitHub user tofumatt opened a pull request:
https://github.com/apache/cordova-docs/pull/242
Add Firefox OS to list of IndexedDB platforms
Firefox OS uses IndexedDB but wasn't in the storage page's list.
You can merge this pull request into a Git repository by running:
$ git pul
Github user clelland commented on the pull request:
https://github.com/apache/cordova-ios/pull/116#issuecomment-61135482
That's a terrible error, btw :)
EX_DATAERR (65) The input data was incorrect in some way. This
should only be used for user's data and not system
Github user clelland commented on a diff in the pull request:
https://github.com/apache/cordova-ios/pull/116#discussion_r19623071
--- Diff: CordovaLib/Classes/CDVViewController.m ---
@@ -714,24 +712,44 @@ - (BOOL)webView:(UIWebView*)theWebView
shouldStartLoadWithRequest:(NSURLReque
Waiting for any PRs?
Can we move forward. Want me to do it or do we have some windows
maintainers who want to give it a shot?
Essentially follow the steps at
https://github.com/apache/cordova-coho/blob/master/docs/platforms-release-process.md.
Skip the steps about updating cli & lib since we are
GitHub user johnwargo opened a pull request:
https://github.com/apache/cordova-plugman/pull/80
CB-7894 - Updated docs
Removed --uninstall, added docs for owner and some other cleanups
You can merge this pull request into a Git repository by running:
$ git pull https://github.co
Please review and vote on this 3.7.0 iOS Release.
Release issue: https://issues.apache.org/jira/browse/CB-7910
Repos ready to be released have been published to dist/dev:
https://dist.apache.org/repos/dist/dev/cordova/CB-7910
The package was published from its corresponding git tag:
cordova-
I've spent the majority of the week finishing up the whitelist-breakout
code, and I'd invite the rest of the community to take a look, before we
make anything official.
In order to retain some kind of backward compatibility with existing apps
(because it's a terrible situation for everyone when we
This looks good. I am waiting for Sergey to confirm. Can we also do a Wp8
release please ? We had a critical bug fix for this.
-Original Message-
From: Steven Gill [mailto:stevengil...@gmail.com]
Sent: Thursday, October 30, 2014 11:48 AM
To: dev@cordova.apache.org
Subject: [DISCUSS] Win
Can we also look at this pull request please ? It fixes a bug with dependency
plugins -
CB-7846 Fix plugin deletion when dependency plugin does not exist #110
https://github.com/apache/cordova-lib/pull/110
-Original Message-
From: Shazron [mailto:shaz...@gmail.com]
Sent: Thursday, Octo
Sure, why not!
On Thu, Oct 30, 2014 at 1:06 PM, Parashuram Narasimhan (MS OPEN TECH) <
panar...@microsoft.com> wrote:
> This looks good. I am waiting for Sergey to confirm. Can we also do a Wp8
> release please ? We had a critical bug fix for this.
>
> -Original Message-
> From: Steven Gi
`cordova-mobile-spec/createmobilespec/createmobilespec.js --ios
--globalplugins`
Has anyone gotten mobile-spec to work consistently? I get wildly different
results on each run. Sometimes there is more than one report in a run. See:
[image: Inline image 1]
Thanks :)
-Original Message-
From: Steven Gill [mailto:stevengil...@gmail.com]
Sent: Thursday, October 30, 2014 1:53 PM
To: dev@cordova.apache.org
Subject: Re: [DISCUSS] Windows Release
Sure, why not!
On Thu, Oct 30, 2014 at 1:06 PM, Parashuram Narasimhan (MS OPEN TECH) <
panar...@mic
The port conflict situation has been solved with the latest version of the
plugin. Passing in a port of "0" will choose a random port. More details in
the plugin's README.md
Ouch - didn't think about Camera plugin and File plugin impact. That proxy
thing might work, as long as there are no folder
Github user shazron commented on the pull request:
https://github.com/apache/cordova-lib/pull/116#issuecomment-61172837
Patched:
https://github.com/apache/cordova-lib/commit/281aee737dbe5143c9cb5957359ed5df6298a154
You can close this PR now.
---
If your project is set up for it,
That patch I talked about was merged in. cordova-ios is out for vote.
On Thu, Oct 30, 2014 at 8:06 AM, Mark Koudritsky wrote:
> On Wed, Oct 29, 2014 at 6:40 PM, Shazron wrote:
>
> > Mark, this patch is important for us to get pulled in:
> > https://github.com/apache/cordova-lib/pull/116
> >
> >
Github user goya closed the pull request at:
https://github.com/apache/cordova-lib/pull/116
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is e
Hi Shazron
Our team are running mobilespec for Android, iOS and Windows. I cannot see the
attachment but we also have been seeing what you’ve gotten since new style
mobilespec was introduced. It seems that each plugin test run works fine but if
all tests get run at once I am likely to get more
Seems to be exactly what I am seeing.
Here's the image as a link: http://i.imgur.com/n6ST1Kd.png?1
On Thu, Oct 30, 2014 at 2:57 PM, Toda, Shingo
wrote:
> Hi Shazron
>
> Our team are running mobilespec for Android, iOS and Windows. I cannot see
> the attachment but we also have been seeing what y
This is exactly what I got too.
Regards,
Shingo
From: Shazron [mailto:shaz...@gmail.com]
Sent: Friday, October 31, 2014 9:02 AM
To: dev@cordova.apache.org
Cc: Toda, Shingo
Subject: Re: [mobile-spec] consistency and reliability
Seems to be exactly what I am seeing.
Here's the image as a link: htt
Github user stevengill commented on a diff in the pull request:
https://github.com/apache/cordova-coho/pull/58#discussion_r19641256
--- Diff: src/nightly.js ---
@@ -0,0 +1,148 @@
+/*
+Licensed to the Apache Software Foundation (ASF) under one
+or more contributor license
Github user stevengill commented on a diff in the pull request:
https://github.com/apache/cordova-coho/pull/58#discussion_r19641787
--- Diff: src/npm-publish.js ---
@@ -0,0 +1,77 @@
+/*
+Licensed to the Apache Software Foundation (ASF) under one
+or more contributor lice
Github user stevengill commented on a diff in the pull request:
https://github.com/apache/cordova-coho/pull/58#discussion_r19642142
--- Diff: src/repoutil.js ---
@@ -449,14 +450,23 @@ exports.forEachRepo = function*(repos, func) {
var newPath = isInForEachRepoFunction ?
I've seen that in the past and it usually happens due to misuse of jasmine,
which seems unfortunately quite brittle. Specifically, if done() isn't
called, or an async event fires after a test has already failed / timed out
and calls done(), or registers new tests with it() etc, weird things will
h
tape (and or tap) has no globals and simple / shallow callback solution
which fixes that
we will have fresh intern blood to sacrifice to the test lib gods alter
soon..
On Thu, Oct 30, 2014, 4:10 PM Michal Mocny wrote:
> I've seen that in the past and it usually happens due to misuse of jasmine,
I would much rather we fix things, than continually rewrite + discard,
which seems to be the norm these days.
tape/tap would require us to throw away thousands of jasmine2 based tests
wouldn't it?
@purplecabbage
risingj.com
On Thu, Oct 30, 2014 at 4:44 PM, Brian LeRoux wrote:
> tape (and or ta
Nope.
On Thu, Oct 30, 2014, 5:04 PM Jesse wrote:
> I would much rather we fix things, than continually rewrite + discard,
> which seems to be the norm these days.
> tape/tap would require us to throw away thousands of jasmine2 based tests
> wouldn't it?
>
>
> @purplecabbage
> risingj.com
>
> On
Github user fujunwei commented on the pull request:
https://github.com/apache/cordova-lib/pull/111#issuecomment-61198123
hi @clelland , Could you give some suggestion on the PR.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as w
There've been some changes to CLI in the last month that fix Android
requiring an SDK to run create & plugin add. Likewise, a fix just went in
this week (last week?) that fixes the slash problem for xcode project files
on windows.
That said, I like your idea of not modifying platforms/ outside of
On Thu, Oct 30, 2014 at 5:05 PM, Shazron wrote:
> The port conflict situation has been solved with the latest version of the
> plugin. Passing in a port of "0" will choose a random port. More details in
> the plugin's README.md
>
Awesome! Why even allow a non-random port?
Also learned today that
It's great that this topic has been raised as we have some questions on mobile
spec.
We need to test Cordova and core plugins to assure ourselves of the quality so
we are running mobile spec and add tests if there are APIs for which we
couldn't find tests in mobile spec but I'm interested in ho
The following two pull requests look very important to me (there is a real
impact to @VSCordovaTools), can we have them included to upcoming tools release?
https://github.com/apache/cordova-lib/pull/114
CB-6992 Fix add/prepare/build issues for iOS when app name contains accented
characters
http
Found a blocker for plugman: https://issues.apache.org/jira/browse/CB-7915
I don't think we have a test for this.
On Thu, Oct 30, 2014 at 2:34 PM, Shazron wrote:
> That patch I talked about was merged in. cordova-ios is out for vote.
>
> On Thu, Oct 30, 2014 at 8:06 AM, Mark Koudritsky
> wrote:
Sergey, feel free to pull those changes in, and run the tests.
On Thu, Oct 30, 2014 at 10:51 PM, Sergey Grebnov (Akvelon) <
v-seg...@microsoft.com> wrote:
> The following two pull requests look very important to me (there is a real
> impact to @VSCordovaTools), can we have them included to upcomi
I'm writing the test for this right now.
On Thu, Oct 30, 2014 at 10:52 PM, Shazron wrote:
> Found a blocker for plugman: https://issues.apache.org/jira/browse/CB-7915
> I don't think we have a test for this.
>
> On Thu, Oct 30, 2014 at 2:34 PM, Shazron wrote:
>
>> That patch I talked about was
I suspect it breaks cordova-cli as well, since it also uses nopt 3.0.1
On Thu, Oct 30, 2014 at 10:52 PM, Shazron wrote:
> Found a blocker for plugman: https://issues.apache.org/jira/browse/CB-7915
> I don't think we have a test for this.
>
> On Thu, Oct 30, 2014 at 2:34 PM, Shazron wrote:
>
>>
Windows looks good to me (including wp8), no additional critical patches I want
to include to upcoming release.
PS. Sorry for the delayed response, had 24+ hrs flight from Russia to US.
Thx!
Sergey
-Original Message-
From: Parashuram Narasimhan (MS OPEN TECH) [mailto:panar...@microsoft
Github user sgrebnov commented on the pull request:
https://github.com/apache/cordova-android/pull/130#issuecomment-61223212
Could someone review this?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user sgrebnov commented on the pull request:
https://github.com/apache/cordova-plugin-contacts/pull/49#issuecomment-61225476
Ok, but where is the corresponding WP8 PR? How would you merge this in this
case? Commits/issue could be separate but I propose to have a single PR so th
60 matches
Mail list logo
