I've fixed an issue. What's next?

2014-11-13 Thread julio cesar sanchez
CB-7734 (https://issues.apache.org/jira/browse/CB-7734) was reported and I asked if it could be assigned to me. Shazron assigned to me and I fixed it with this pull request https://github.com/apache/cordova-plugin-dialogs/pull/39 It's been 3 weeks and it hasn't been merged, so I don't know if I ha

[GitHub] cordova-plugins pull request: Updated Plugin to iOS 8

2014-11-13 Thread fmgasparino
Github user fmgasparino commented on the pull request: https://github.com/apache/cordova-plugins/pull/16#issuecomment-63016646 @shazron, I've forwarded the iCLA to secret...@apache.org. I will let you know if I hear anything. Thanks --- If your project is set up for it, you

[GitHub] cordova-lib pull request: Add a type named "gradleReference" in fr...

2014-11-13 Thread fujunwei
Github user fujunwei commented on the pull request: https://github.com/apache/cordova-lib/pull/119#issuecomment-63012342 ping @clelland @agrieve again. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

Re: [GitHub] cordova-plugin-file pull request: CB-7917 Fixed tests file.spec.11...

2014-11-13 Thread Jesse
Merged, and de-BOM'd @purplecabbage risingj.com On Thu, Nov 13, 2014 at 3:48 PM, asfgit wrote: > Github user asfgit closed the pull request at: > > https://github.com/apache/cordova-plugin-file/pull/88 > > > --- > If your project is set up for it, you can reply to this email and have your >

[GitHub] cordova-plugin-file pull request: CB-7917 Fixed tests file.spec.11...

2014-11-13 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-file/pull/88 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the fea

Re: [VOTE] Tools Release, take 3

2014-11-13 Thread Mark Koudritsky
Ok, just published it all. Thanks for help and support. Another question, for blog post the instructions look as follows: cd cordova-website rake build svn st svn add blah.blah.blah svn commit -m "$JIRA Published blog post for tools release." The `svn st` shows a bunch of stuff I had no intention

[ANNOUNCEMENT] Tools Release

2014-11-13 Thread Mark Koudritsky
New cordova tools released: cordova@4.1.2 (the Cordova CLI) plugman@0.22.16 cordova-lib@4.1.2 cordova-js@3.7.2 You can view the release blog post at http://cordova.apache.org/news/2014/11/13/tools-release.html

Re: [VOTE] Tools Release, take 3

2014-11-13 Thread Josh Soref
Mark Koudritsky wrote: >Thanks for testing everyone, sending out an official results email >soon. Josh thanks for the fixes in blog post. I've merged them in. > The blog >post pull request also contains a change >1357dbe1

Re: [VOTE] Tools Release, take 3

2014-11-13 Thread Mark Koudritsky
The vote has now closed. The results are: Positive Binding Votes: 3 - Parashuram Narasimhan - Sergey Grebnov - Mark Koudritsky Negative Binding Votes: 0 The vote has passed. On Thu, Nov 13, 2014 at 3:06 PM, Mark Koudritsky wrote: > Thanks for testing everyone, sending out an official res

Re: [VOTE] Tools Release, take 3

2014-11-13 Thread Mark Koudritsky
Thanks for testing everyone, sending out an official results email soon. Josh thanks for the fixes in blog post. I've merged them in. The blog post pull request also contains a change to the win ce

[GitHub] cordova-plugins pull request: Updated Plugin to iOS 8

2014-11-13 Thread shazron
Github user shazron commented on the pull request: https://github.com/apache/cordova-plugins/pull/16#issuecomment-62951481 @fmgasparino please send the iCLA PDF directly to secret...@apache.org as stated in the iCLA itself. --- If your project is set up for it, you can reply to this

[GitHub] cordova-plugin-file pull request: CB-7917 Fixed tests file.spec.11...

2014-11-13 Thread clelland
Github user clelland commented on a diff in the pull request: https://github.com/apache/cordova-plugin-file/pull/88#discussion_r20315283 --- Diff: tests/tests.js --- @@ -1,4 +1,4 @@ -/* +/* --- End diff -- This line has a non-visible BOM (U+FEFF) -- can you s

[GitHub] cordova-plugins pull request: Updated Plugin to iOS 8

2014-11-13 Thread fmgasparino
Github user fmgasparino commented on the pull request: https://github.com/apache/cordova-plugins/pull/16#issuecomment-62937982 Hi Shaz, Thanks for looking into it. Please find the iCLA attached. > On Nov 12, 2014, at 1:17 PM, Shazron Abdullah wrote:

[GitHub] cordova-browser pull request: --user-data-dir working on windows

2014-11-13 Thread revolunet
Github user revolunet commented on the pull request: https://github.com/apache/cordova-browser/pull/3#issuecomment-62935869 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature ena

[GitHub] cordova-browser pull request: --user-data-dir working on windows

2014-11-13 Thread MetaMemoryT
Github user MetaMemoryT commented on the pull request: https://github.com/apache/cordova-browser/pull/3#issuecomment-62935538 :+1: please merge this, it works on windows 8.1. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

Re: [VOTE] Tools Release, take 3

2014-11-13 Thread Josh Soref
Ray Camden wrote: > +1 to this. > That was my first though - a ‘regular’ user may be confused > and think they need to get this when they don’t. https://github.com/cordova/apache-blog-posts/pull/22 has a change that should address it You can view it here: https://github.com/jsoref/cordova-apach

RE: [VOTE] Tools Release, take 3

2014-11-13 Thread Sergey Grebnov (Akvelon)
I vote +1 • Installed from archives, tested core platforms can be added, built and run Thx! Sergey -Original Message- From: Parashuram Narasimhan (MS OPEN TECH) [mailto:panar...@microsoft.com] Sent: Thursday, November 13, 2014 8:32 AM To: dev@cordova.apache.org Subject: RE: [VOTE]

RE: Questions re: plugin variables

2014-11-13 Thread Horn, Julian C
Thanks, that clears everything up. It seems the fact that tags don't work inside tags is a bug. Fortunately there is no advantage to putting a tag inside and everyone seems to put them outside. Julian -Original Message- From: Shazron [mailto:shaz...@gmail.com] Sent: Wednesday,

RE: [VOTE] Tools Release, take 3

2014-11-13 Thread Parashuram Narasimhan (MS OPEN TECH)
Voting +1 • Verified signatures and hashes via ‘coho verify-archive’. Pass • Manually verified tags. Pass • Installed Cordova from archives. Pass • Installed/uninstalled Cordova with npm via ‘npm install cordova@rc’. Pass • Verified ability to update Cordova from ol

Re: [VOTE] Tools Release, take 3

2014-11-13 Thread Ray Camden
+1 to this. That was my first though - a ‘regular’ user may be confused and think they need to get this when they don’t. On 11/13/14, 9:24 AM, "Josh Soref" wrote: >Ray Camden wrote: >> >The instructions would probably benefit from "if you have foo installed, >use X to update it". > >?B�K

Re: [VOTE] Tools Release, take 3

2014-11-13 Thread Josh Soref
Ray Camden wrote: > To update your tools: > > npm install -g cordova > npm install -g plugman > > To be clear, a "regular" user doesn't need to update plugman, right? I think there is a workflow where a regular user uses `plugman` directly (I think it's probably one where you aren't using cordova,

Re: [VOTE] Tools Release, take 3

2014-11-13 Thread Mark Koudritsky
On Thu, Nov 13, 2014 at 10:06 AM, Ray Camden wrote: > Mark, question about this: > > To update your tools: > > npm install -g cordova > npm install -g plugman > > > To be clear, a Œregular¹ user doesn¹t need to update plugman, right? > > At present the plugman npm package contains only the CLI to

[GitHub] cordova-plugin-file pull request: CB-7917 Fixed tests file.spec.11...

2014-11-13 Thread MariaBukharina
Github user MariaBukharina commented on the pull request: https://github.com/apache/cordova-plugin-file/pull/88#issuecomment-62903426 Could someone please review this? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If yo

[GitHub] cordova-plugin-file pull request: CB-7917 Fixed tests file.spec.11...

2014-11-13 Thread MariaBukharina
Github user MariaBukharina commented on the pull request: https://github.com/apache/cordova-plugin-file/pull/88#issuecomment-62903413 Could someone please review this? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If yo

[GitHub] cordova-plugin-file-transfer pull request: CB-7944 Pending unsuppo...

2014-11-13 Thread MariaBukharina
Github user MariaBukharina commented on the pull request: https://github.com/apache/cordova-plugin-file-transfer/pull/48#issuecomment-62903906 Could someone please review this? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as w

Re: [VOTE] Tools Release, take 3

2014-11-13 Thread Ray Camden
Mark, question about this: To update your tools: npm install -g cordova npm install -g plugman To be clear, a Œregular¹ user doesn¹t need to update plugman, right? On 11/12/14, 10:47 AM, "Mark Koudritsky" wrote: >Please also review the updated blog post: >https://github.com/cordova/apache-b