[GitHub] cordova-browser pull request: CB-8182 - port 'cordova serve' to 'c...

2015-01-23 Thread jsoref
Github user jsoref commented on the pull request: https://github.com/apache/cordova-browser/pull/9#issuecomment-71231047 Note that your commit messages should be of the form: `CB-8182 Add ...` or `CB-8182 Port ...` instead of `CB-8182 - add ...` Please use backticks

Re: [VOTE] 3.7.0 Android Platform release

2015-01-23 Thread Joe Bowser
The vote has now closed. The results are: Positive Binding Votes: 7 Joe Bowser Sergey Grebnov Parashuram N Brian LeRoux Marcel Kinard Jesse MacFadyen Andrew Grieve Negative Binding Votes: 0 The vote has passed. I will publish to dist and npm. On Thu Jan 22 2015 at 5:32:28 PM Andrew Grieve

[GitHub] cordova-plugin-vibration pull request: CB-8113 cordova-plugin-vibr...

2015-01-23 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-vibration/pull/29 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] cordova-browser pull request: CB-8182 - port 'cordova serve' to 'c...

2015-01-23 Thread jsoref
Github user jsoref commented on the pull request: https://github.com/apache/cordova-browser/pull/9#issuecomment-71231461 Why can't you just make `cordova serve` work with `cordova-browser`/`cordova run`? I really don't want to have a fork of `cordova serve`. --- If your project is

[GitHub] cordova-docs pull request: CB-8243 cordova-docs documentation tran...

2015-01-23 Thread sosahvictor
GitHub user sosahvictor opened a pull request: https://github.com/apache/cordova-docs/pull/262 CB-8243 cordova-docs documentation translation: cordova-docs CB-8243 cordova-docs documentation translation: cordova-docs You can merge this pull request into a Git repository by running:

[GitHub] cordova-browser pull request: CB-8206: Browser platform: Add suppo...

2015-01-23 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-browser/pull/6 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cordova-browser pull request: CB-8206: Browser platform: Add suppo...

2015-01-23 Thread jsoref
Github user jsoref commented on the pull request: https://github.com/apache/cordova-browser/pull/6#issuecomment-71222792 ok, one last final thing: * Please amend the commit message to not have the `:` after the `CB-8206` (I'm fairly confident this is documented in our

[GitHub] cordova-browser pull request: CB-8206: Browser platform: Add suppo...

2015-01-23 Thread nikhilkh
Github user nikhilkh commented on the pull request: https://github.com/apache/cordova-browser/pull/6#issuecomment-71228160 @jsoref Updated the commit message. Please review and help merge to master. --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] cordova-windows pull request: CB-8330 Added new unit tests

2015-01-23 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-windows/pull/54 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

Re: firefoxos cordova.js !lastName

2015-01-23 Thread Steven Gill
Hey Axel, It would be really helpful if you could file this as an issue and we can bring it to the attention of our ffos committers. Cheers, -Steve On Fri, Jan 23, 2015 at 5:43 AM, axel.nenn...@telekom.de wrote: Hi, I am using inappbrowser (0.5.5-dev) in a project on ios, android and

Re: So...can we merge 4.0.x into master yet?

2015-01-23 Thread Andrew Grieve
Not sure what the JB fiasco is, but merging SGTM. We can always work off of 3.7.x if we end up needing another 3.x release. On Fri, Jan 23, 2015 at 1:51 PM, Joe Bowser bows...@gmail.com wrote: Hey So, now that 3.7.0 is mostly out the door (dealing with npm stuff now), I think we should talk

So...can we merge 4.0.x into master yet?

2015-01-23 Thread Joe Bowser
Hey So, now that 3.7.0 is mostly out the door (dealing with npm stuff now), I think we should talk about getting 4.0.x merged into master and out the door. I know there's that CookeManager thing that breaks the File Transfer plugin that we have to deal with, and I'm wondering if we can actually

[GitHub] cordova-medic pull request: [INFRA-8588] Fixed a bug for ASF Build...

2015-01-23 Thread dblotsky
GitHub user dblotsky opened a pull request: https://github.com/apache/cordova-medic/pull/23 [INFRA-8588] Fixed a bug for ASF Buildbot, and a bug for Windows. Fixed a bug causing errors in Apache Buildbot. Improved cleanup method to work on Windows. You can merge this pull request

[GitHub] cordova-lib pull request: CB-8239 Add support for git urls to 'cor...

2015-01-23 Thread omefire
Github user omefire commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/148#discussion_r23488149 --- Diff: cordova-lib/src/cordova/util.js --- @@ -55,6 +61,8 @@ exports.preProcessOptions = preProcessOptions; exports.addModuleProperty =

[GitHub] cordova-lib pull request: CB-8239 Add support for git urls to 'cor...

2015-01-23 Thread omefire
Github user omefire commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/148#discussion_r23488114 --- Diff: cordova-lib/src/cordova/util.js --- @@ -262,3 +270,81 @@ function addModuleProperty(module, symbol, modulePath, opt_wrap, opt_obj) {

[cordova-android] Commit related to CB-8317 brings issue reported in CB-7371

2015-01-23 Thread Martin Gonzalez
Hello team, Recently tested cordova-android, master branch, and I found out that this commit: ccceaeaca Link: https://git-wip-us.apache.org/repos/asf?p=cordova-android.git;a=commit;h=ccceaeaca2d72fb9708100ab2f70adb903a27d66 brings back the issue about app crash after language is changed, by

Odd EOL in files in newly cloned repo

2015-01-23 Thread Victor Sosa
Hello community I'm cloning a repository in Apache Cordova (cordova-docs) and as soon as I check out the repo in my laptop, I check the status of the repo with *git status*. Oddly, I get some image files as modified (the ones under cordova-docs/templates folder). Looking around in internet I

Re: Odd EOL in files in newly cloned repo

2015-01-23 Thread Jesse
Odd. There appears to be an issue with how these files were checked in. Normally only text files have this issue, which is corrected by setting: git config core.autocrlf true on windows machines. We may need to check in the corrected version. @purplecabbage risingj.com On Fri, Jan 23, 2015 at

firefoxos cordova.js !lastName

2015-01-23 Thread Axel.Nennker
Hi, I am using inappbrowser (0.5.5-dev) in a project on ios, android and firefoxos. https://github.com/apache/cordova-plugin-inappbrowser The firefoxos version of the app reports two errors in the console log. Cordova.js:466 getElementByID called with empty id (or similar) Cordova.js:1171

[GitHub] cordova-lib pull request: CB-6973 enable JSHint for spec-cordova

2015-01-23 Thread muratsu
GitHub user muratsu opened a pull request: https://github.com/apache/cordova-lib/pull/154 CB-6973 enable JSHint for spec-cordova This change enables jshint for spec-cordova meaning that `npm run jshint` will not only check `src` folder but `spec-cordova` too. I've also fixed all

[GitHub] cordova-lib pull request: CB-6973 Improving JSHint for src folder

2015-01-23 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-lib/pull/153 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

Cordova issue 8080 - After migrating to 3.6.3 from 3.4.0, Appium (Android) tests fail because of open dialog

2015-01-23 Thread Andrea Tino
Hello My name is Andrea Tino. I am a Microsoft Developer in the Microsoft Dynamics NAV Team. Recently we started using Cordova for building our apps. All our tests fail We moved to Cordova 3.6.3 from 3.4.0 and from there all our tests (more than 200) started failing. After investigating on

Re: Monthly Hangouts - Jan 2015 Edition

2015-01-23 Thread Michal Mocny
Thanks Parashuram for coordinating. On Thu, Jan 22, 2015 at 8:04 PM, Parashuram N (MS OPEN TECH) panar...@microsoft.com wrote: Wanted to bump up the thread about the Cordova hangouts. A lot of people have responded, and looks like the following times are candidates. - Monday 26 Jan 2015,

[GitHub] cordova-ios pull request: CB-8197 Switch to nodejs for ios platfor...

2015-01-23 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-ios/pull/126 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cordova-browser pull request: CB-8206: Browser platform: Add suppo...

2015-01-23 Thread mmocny
Github user mmocny commented on the pull request: https://github.com/apache/cordova-browser/pull/6#issuecomment-71210975 I reviewed this in a previous iteration, and the latest changes look fine. Since this feature does not exist yet anyway, and I'm not too concerned about

[GitHub] cordova-browser pull request: CB-8206: Browser platform: Add suppo...

2015-01-23 Thread mmocny
Github user mmocny commented on the pull request: https://github.com/apache/cordova-browser/pull/6#issuecomment-71210993 ..Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] cordova-browser pull request: CB-8206: Browser platform: Add suppo...

2015-01-23 Thread mmocny
Github user mmocny commented on the pull request: https://github.com/apache/cordova-browser/pull/6#issuecomment-71211172 (Josh I'll let you have the last word on landing, you have been running this) --- If your project is set up for it, you can reply to this email and have your

RE: Cordova issue 8080 - After migrating to 3.6.3 from 3.4.0, Appium (Android) tests fail because of open dialog

2015-01-23 Thread Chuck Lantz
Andrea, Some folks in the developer division may be able to help out here. I'll connect you with our Cordova contributors. -Chuck From: Andrea Tino [mailto:andrea.t...@microsoft.com] Sent: Friday, January 23, 2015 12:10 AM To: dev@cordova.apache.org Cc: Vincent Nicolas; Michael Helligsø