Github user omefire commented on the pull request:
https://github.com/apache/cordova-lib/pull/144#issuecomment-72901151
@agrieve and @gorkem, plz review.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user gorkem commented on the pull request:
https://github.com/apache/cordova-lib/pull/144#issuecomment-72903015
@omefire Squash this to a single one commit? It will be easier for me to
take it into the rest of the save restore changes.
---
If your project is set up for it,
GitHub user Mitko-Kerezov opened a pull request:
https://github.com/apache/cordova-ios/pull/127
CB-8084 conform AppDelegate.m with provisioning profile
Hide the two methods in AppDelegate.m for push notifications
when provisioning profile doesn't include the push notifications
Github user fujunwei commented on the pull request:
https://github.com/apache/cordova-mobile-spec/pull/118#issuecomment-72810628
@agrieve Mybe we need git clone cordova-crosswalk-engine in top dir
manually, is it right? PTAL. thanks.
---
If your project is set up for it, you can
Github user vladimir-kotikov commented on the pull request:
https://github.com/apache/cordova-plugin-file-transfer/pull/53#issuecomment-72808407
Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
GitHub user fujunwei opened a pull request:
https://github.com/apache/cordova-mobile-spec/pull/118
Add a --webview flag to createmobilespec.js
Use Crosswalk webview instead of Android webview with --webview=crosswalk
You can merge this pull request into a Git repository by running:
Github user nikhilkh commented on the pull request:
https://github.com/apache/cordova-plugin-test-framework/pull/10#issuecomment-72810379
LGTM.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user sgrebnov commented on the pull request:
https://github.com/apache/cordova-plugin-test-framework/pull/10#issuecomment-72810268
@nikhilkh, addressed CR notes
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user sgrebnov commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-test-framework/pull/10#discussion_r24069058
--- Diff: www/medic.js ---
@@ -35,30 +35,27 @@ exports.log = function() {
};
exports.load = function (callback) {
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-plugin-file/pull/95
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-plugin-device/pull/29
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
On Wed, Feb 4, 2015 at 2:25 PM, Joe Bowser bows...@gmail.com wrote:
OK, so since we're using e-mail to do a sprint, here's where I think we're
at so far.
- Ian's been working on getting crosswalk 10 working and is hitting some
FileTransfer crash issues.
(Apparently Crosswalk-11 works? Ian,
I'm no JIRA expert, but I seems there would be a way to use it (maybe via
keywords) to track all issues remaining.
I just use a Google doc for my list locally and like that it's super fast
to make changes to.
Maybe a shared Google Sheet would work best? e.g. | description | issue
link | owner |
Just create a parent jira issue for the 4.0.x release, and assign the rest
as sub-tasks.
You get a nice checklist in the parent issue, and you can easily tell when
all sub-tasks are completed.
Isn't this the way we used to do releases?
@purplecabbage
risingj.com
On Wed, Feb 4, 2015 at 11:45 AM,
GitHub user dblotsky opened a pull request:
https://github.com/apache/cordova-medic/pull/25
[INFRA-8588] Stability improvements for medic and Linux slave config.
Using local npm cache for npm install to avoid conflicts with other
builders. Added Linux slave config.
You can merge
Do some of these plugins have fixes to work with cordova-android 4.0.0? If
so, do they still work with older versions of android?
On Wed, Feb 4, 2015 at 11:56 AM, Andrew Grieve agri...@chromium.org wrote:
I'll start going through easy PRs now, and will hopefully start a vote
around 9PM EST
Github user purplecabbage commented on the pull request:
https://github.com/apache/cordova-plugin-file/pull/92#issuecomment-72908173
Is this still relevant? Please rebase if so, and I will merge.
---
If your project is set up for it, you can reply to this email and have your
reply
+1
The main reason we left windows8 as an alias is we didn't want to break
existing plugins because of a name change given the code was compatible. So,
the same goes for referencing windows8 in plugin.xml - that will apply to the
cordova-windows platform for backwards compatibility reasons.
+1 to changing cordova-windows8 to cordova-windows.
On 2/4/15, 12:05 PM, Jesse purplecabb...@gmail.com wrote:
Yes, you can skip all the 'windows8' stuff and just use 'windows'.
windows8 is legacy and slowly all plugins are being migrated to just use
the 'windows' section in plugin.xml
GitHub user sgrebnov opened a pull request:
https://github.com/apache/cordova-plugin-media/pull/42
CB-8426 Add Windows platform section to Media plugin
https://issues.apache.org/jira/browse/CB-8426
You can merge this pull request into a Git repository by running:
$ git pull
GitHub user sgrebnov opened a pull request:
https://github.com/apache/cordova-plugin-media/pull/43
CB-8425 Media plugin .ctr: make src param required as per spec
https://issues.apache.org/jira/browse/CB-8425
You can merge this pull request into a Git repository by running:
$
GitHub user purplecabbage opened a pull request:
https://github.com/apache/cordova-plugin-device/pull/29
CB-7285 Add manufacturer property on WP8
You can merge this pull request into a Git repository by running:
$ git pull
OK, so since we're using e-mail to do a sprint, here's where I think we're
at so far.
- Ian's been working on getting crosswalk 10 working and is hitting some
FileTransfer crash issues.
(Apparently Crosswalk-11 works? Ian, what's happening with this?)
- Mobilespec really should be passing, let's
I have made the changes you suggested. I like the idea of cordova parent
key.
I added cordova-windows8 as a keyword but I would like someone from
microsoft to chime in about it. My understanding is that windows8 is around
for legacy and windows is preferred. Please correct me if I'm wrong. I'd
I'll start going through easy PRs now, and will hopefully start a vote
around 9PM EST tonight.
But... Anyone want to call out things re: plugins before doing a release?
Yes, you can skip all the 'windows8' stuff and just use 'windows'.
windows8 is legacy and slowly all plugins are being migrated to just use
the 'windows' section in plugin.xml
@purplecabbage
risingj.com
On Wed, Feb 4, 2015 at 11:36 AM, Steven Gill stevengil...@gmail.com wrote:
I have made the
love this, having a cordova key is a v good idea while this bakes too
On Wed, Feb 4, 2015 at 12:10 PM, Parashuram N (MS OPEN TECH)
panar...@microsoft.com wrote:
+1 to changing cordova-windows8 to cordova-windows.
On 2/4/15, 12:05 PM, Jesse purplecabb...@gmail.com wrote:
Yes, you can skip
The ones I'm aware of (SplashScreen and FileTransfer), the answer is yes
and yes
On Wed, Feb 4, 2015 at 3:09 PM, Steven Gill stevengil...@gmail.com wrote:
Do some of these plugins have fixes to work with cordova-android 4.0.0? If
so, do they still work with older versions of android?
On Wed,
GitHub user nikhilkh opened a pull request:
https://github.com/apache/cordova-plugin-media/pull/44
CB-8428 Fix multiple `done()` calls in media plugin test
This shows up as an issue on Windows when audio device is not configured
correctly and an exception happens.
You can merge
Normally I would say yes, except for this change:
http://issues.apache.org/jira/browse/CB-8197 where all the bash
scripts have been converted to nodejs.
One could say that for CLI users, this is no big deal, but for users
using bin/create this creates a dependency on nodejs now (although
this is
On Wed, Feb 4, 2015 at 7:58 PM, Fu, Junwei junwei...@intel.com wrote:
What are the test cases don't work for Crosswalk? I'd like to do whatever
I can to help.
So, Crosswalk 10 (and, I believe, 11) work great for Cordova. There is a
failing test in File Transfer, though, that appears to be a
I'm satisfied with that :)
Thanks for the explanation.
On Wed, Feb 4, 2015 at 6:21 PM, Shazron shaz...@gmail.com wrote:
Migrating to node was not the concern, people will need to upgrade,
tough luck. I was justifying the minor version bump, not just a patch
version bump because of the nodejs
Not on iOS. cordova-ios 3.7.0 and below all used bash/python scripts
(one or two were node but not critical for non-CLI use).
So post 3.7.0, non-CLI users will need nodejs installed to create a
project and run the scripts in the cordova subfolder of a project.
On Wed, Feb 4, 2015 at 2:39 PM,
Before migration there were a lot of nodejs dependencies already:
Depends on nodejs :
install-device, install-emulator, list-emulator-images, emulate, run, update
Doesn’t depend on nodejs:
list-devices, list-started-emulators, start-emulator, build, clean, log, create
I believe create and build
Migrating to node was not the concern, people will need to upgrade,
tough luck. I was justifying the minor version bump, not just a patch
version bump because of the nodejs dependency now for non-CLI users.
On Wed, Feb 4, 2015 at 3:19 PM, Shazron shaz...@gmail.com wrote:
Not on iOS. cordova-ios
+1
* Verified archive
* Ran hello-world sanity check against archive
On Tue Feb 03 2015 at 6:16:34 PM Andrew Grieve agri...@chromium.org wrote:
Please review and vote on this 3.5.0 Android Release.
Release issue: https://issues.apache.org/jira/browse/CB-8415
Repos ready to be released
What are the test cases don't work for Crosswalk? I'd like to do whatever I can
to help.
-Original Message-
From: agri...@google.com [mailto:agri...@google.com] On Behalf Of Andrew Grieve
Sent: Thursday, February 05, 2015 3:43 AM
To: dev
Subject: Re: [DISCUSS] Cordova-Android 4.0.0
It's not necessary. You can still just add the plugin after-the-fact as
well. (but perhaps I'm misunderstanding your question?)
On Wed, Feb 4, 2015 at 8:06 PM, Fu, Junwei junwei...@intel.com wrote:
Is it necessary to add the flag when creating Cordova project?
-Original Message-
Hmm, just had a look at the bug and it's not obvious to me what the problem
is? Is there a stack trace for the crash? Is there a known fix for it that
doesn't involve not sending the exit event?
On Fri, Jan 23, 2015 at 7:24 PM, Martin Gonzalez
martin.c.glez.g...@gmail.com wrote:
Right, an
Ok, I got it.
I want to install crosswalk-engine plugin automatically when creating Cordova
project with the option of --webview=crosswalk.
Thanks.
-Original Message-
From: agri...@google.com [mailto:agri...@google.com] On Behalf Of Andrew Grieve
Sent: Thursday, February 05, 2015 9:52
GitHub user nikhilkh opened a pull request:
https://github.com/apache/cordova-medic/pull/26
Re-direct output of removing working directory task
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/MSOpenTech/cordova-medic redirect
Github user nikhilkh commented on the pull request:
https://github.com/apache/cordova-plugin-device/pull/30#issuecomment-72979743
@purplecabbage - Can you please commit this? This is breaking our medic
setup.
---
If your project is set up for it, you can reply to this email and
GitHub user nikhilkh opened a pull request:
https://github.com/apache/cordova-plugin-device/pull/30
Fixes a syntax error introduced in 1a13ee0
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/MSOpenTech/cordova-plugin-device
No, this is a flag for createmobilespec
On Feb 4, 2015, at 5:06 PM, Fu, Junwei junwei...@intel.com wrote:
Is it necessary to add the flag when creating Cordova project?
-Original Message-
From: agri...@google.com [mailto:agri...@google.com] On Behalf Of Andrew
Grieve
Sent:
Is it necessary to add the flag when creating Cordova project?
-Original Message-
From: agri...@google.com [mailto:agri...@google.com] On Behalf Of Andrew Grieve
Sent: Wednesday, January 28, 2015 10:46 PM
To: dev
Subject: Re: File Transfer plugin and Crosswalk engine cookies
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-plugin-device/pull/30
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
oops, thank you!
@purplecabbage
risingj.com
On Wed, Feb 4, 2015 at 5:47 PM, nikhilkh g...@git.apache.org wrote:
Github user nikhilkh commented on the pull request:
https://github.com/apache/cordova-plugin-device/pull/30#issuecomment-72979743
@purplecabbage - Can you please commit
Please review and vote on the release of this plugins release.
Release issue: https://issues.apache.org/jira/browse/CB-8429 (contains
release notes for all plugins)
The plugins have been published to dist/dev:
https://dist.apache.org/repos/dist/dev/cordova/CB-8429/
The packages were published from
Done.
On Wed, Feb 4, 2015 at 8:44 PM, Nikhil Khandelwal
nikhi...@microsoft.com wrote:
I would also like to get JIRA permissions too. Thanks!
Thanks,
Nikhil
-Original Message-
From: Mefire O. [mailto:ommen...@microsoft.com]
Sent: Tuesday, February 3, 2015 4:12 PM
To:
GitHub user alsorokin opened a pull request:
https://github.com/apache/cordova-plugin-file/pull/98
CB-8423 Corrected usage of done() in async tests
This is a fix for https://issues.apache.org/jira/browse/CB-8423
You can merge this pull request into a Git repository by running:
GitHub user jarseneault opened a pull request:
https://github.com/apache/cordova-docs/pull/265
Volume events work on Android
Hi,
The volumedownbutton and volumeupbutton work on Android in addition to
BlackBerry on Cordova 4.0.0. I've updated the docs to add Android as a
Hey
I know that we have this bad habit of prioritizing what we do on the
mailing list instead of using JIRA, but when looking at JIRA today for
organizing the Cordova-Android 4.0.x release, I noticed that we don't have
the JIRA setup for independent platform releases. The main reason this is
a
GitHub user kant2002 opened a pull request:
https://github.com/apache/cordova-docs/pull/264
CB-8419 Add script which fix license issues across all languages in the our
docs
This script allows fix output which is produced by the errors during
translation using CrowdIn.
I made script which will ensure that translated MD files from Crowdin will
have correct license headers.
Please review:
https://github.com/apache/cordova-docs/pull/264
Usage:
from cordova-docs repository root directory invoke
./bin/fixyaml
Currently this script only working over cordova-docs
Github user agrieve commented on the pull request:
https://github.com/apache/cordova-mobile-spec/pull/118#issuecomment-72874844
Just made it add it from the git URL if it's not checked out. This will be
a short-lived thing anyways, as we'll want the plugin to be hosted on the
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-mobile-spec/pull/117
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-mobile-spec/pull/118
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
GitHub user vladimir-kotikov opened a pull request:
https://github.com/apache/cordova-plugin-file-transfer/pull/62
CB-7957 Adds support for `browser` platform
Implementation for [CB-7957](https://issues.apache.org/jira/browse/CB-7957)
You can merge this pull request into a Git
+1 for a new release to fix these.
Question: Should a no-new-features-bug-fix-only release be 3.7.1, rather
than 3.8.0?
On Tue Feb 03 2015 at 9:20:53 PM Andrew Grieve agri...@chromium.org wrote:
I know you've been single-handing iOS lately, so thanks for your hard work
Shaz!
Your list
On Wed Feb 04 2015 at 12:03:35 PM Jesse purplecabb...@gmail.com wrote:
Just create a parent jira issue for the 4.0.x release, and assign the rest
as sub-tasks.
You get a nice checklist in the parent issue, and you can easily tell when
all sub-tasks are completed.
Isn't this the way we used
I would also like to get JIRA permissions too. Thanks!
Thanks,
Nikhil
-Original Message-
From: Mefire O. [mailto:ommen...@microsoft.com]
Sent: Tuesday, February 3, 2015 4:12 PM
To: dev@cordova.apache.org
Cc: agri...@google.com
Subject: RE: JIRA : permission to assign tasks to self
61 matches
Mail list logo
