[GitHub] cordova-plugin-file-transfer pull request: Fix NoSuchMethodExcepti...

2015-03-05 Thread dpogue
GitHub user dpogue opened a pull request: https://github.com/apache/cordova-plugin-file-transfer/pull/68 Fix NoSuchMethodException looking up cookies. This was causing the FileTransfer plugin to always use the fallback android.webkit.CookieManager. You can merge this pull request

Re: Android's new Whitelist Plugins

2015-03-05 Thread Jesse
+1 better late than never @purplecabbage risingj.com On Thu, Mar 5, 2015 at 12:39 PM, Andrew Grieve agri...@chromium.org wrote: Going with it: https://issues.apache.org/jira/browse/INFRA-9238 On Wed, Mar 4, 2015 at 11:22 PM, Michal Mocny mmo...@chromium.org wrote: +1 to names. On Wed,

Re: Android's new Whitelist Plugins

2015-03-05 Thread Andrew Grieve
Going with it: https://issues.apache.org/jira/browse/INFRA-9238 On Wed, Mar 4, 2015 at 11:22 PM, Michal Mocny mmo...@chromium.org wrote: +1 to names. On Wed, Mar 4, 2015 at 9:03 PM, Andrew Grieve agri...@chromium.org wrote: No comments about the names yet, but I'm now leaning towards:

Re: Some thoughts/questions on the new --save feature

2015-03-05 Thread Andrew Grieve
I don't have strong feelings about this. When designing this, some wanted to have --save be default, some wanted to match npm for the sake of matching npm. In the end both ways were implemented. I don't think we need to spend a lot of time on strategizing this. If some one wants to doc it, go

[GitHub] cordova-plugin-file pull request: Implementation of read only acce...

2015-03-05 Thread ArnaudValensi
Github user ArnaudValensi commented on the pull request: https://github.com/apache/cordova-plugin-file/pull/84#issuecomment-77443680 ```js function fail(e) { console.log('FileSystem Error'); console.dir(e); } function

RE: Some thoughts/questions on the new --save feature

2015-03-05 Thread Mefire O .
Yep, I think both options should be documented. Thanks, Mefire -Original Message- From: agri...@google.com [mailto:agri...@google.com] On Behalf Of Andrew Grieve Sent: Thursday, March 5, 2015 11:28 AM To: dev Subject: Re: Some thoughts/questions on the new --save feature I don't have

[GitHub] cordova-plugin-file pull request: Implementation of read only acce...

2015-03-05 Thread mnill
Github user mnill commented on the pull request: https://github.com/apache/cordova-plugin-file/pull/84#issuecomment-77442515 @ArnaudValensi @dariosalviwork Can you provide sample of failed tests? please? --- If your project is set up for it, you can reply to this email and have your

[GitHub] cordova-plugin-file pull request: Implementation of read only acce...

2015-03-05 Thread ArnaudValensi
Github user ArnaudValensi commented on the pull request: https://github.com/apache/cordova-plugin-file/pull/84#issuecomment-77441938 Doesn't work for me neither :'( --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

Re: [DISCUSS] publishing cordova-app-hello-world to npm and adding as dependency of cordova-lib

2015-03-05 Thread Michal Mocny
Alight, remote branches (named copy-from-app-hello-world) are created for cordova-lib, cordova-cli, and cordova-app-hello-world. There are still 2 failing cordova-lib tests, but I'm working to resolve that. My actual end-to-end tests appear to be working with all use cases. Please, please: if

Re: [DISCUSS] publishing cordova-app-hello-world to npm and adding as dependency of cordova-lib

2015-03-05 Thread Michal Mocny
The current breaking change is that you cannot create a new project using cordova-lib directly, without providing a project template to import from. cordova-cli works as it always has, and will provide the app-hello-world as a default if you do not use --copy-from / --link-to. However, writing

[GitHub] cordova-plugin-file pull request: Implementation of read only acce...

2015-03-05 Thread mnill
Github user mnill commented on the pull request: https://github.com/apache/cordova-plugin-file/pull/84#issuecomment-77475566 Okay, i found another bug, but not with my fork. private JSONArray requestAllFileSystems in FileUtils.java not have error handler for IOException, like a

RE: [REVIEW] NPM Registry integration for fetching plugins and plugin rm

2015-03-05 Thread Tim Barham
Looks good to me! -Original Message- From: Steven Gill [mailto:stevengil...@gmail.com] Sent: Thursday, March 5, 2015 11:03 AM To: dev@cordova.apache.org Subject: Re: [REVIEW] NPM Registry integration for fetching plugins and plugin rm I have updated the PR based on feedback. Take a

RE: [DISCUSS] publishing cordova-app-hello-world to npm and adding as dependency of cordova-lib

2015-03-05 Thread Nikhil Khandelwal
Michal: I'm new to this area - can you please elaborate why this change could potentially break downstream distributions? IS there an API change? -Nikhil -Original Message- From: mmo...@google.com [mailto:mmo...@google.com] On Behalf Of Michal Mocny Sent: Thursday, March 5, 2015 1:12

Re: [REVIEW] NPM Registry integration for fetching plugins and plugin rm

2015-03-05 Thread Steven Gill
I will bump up the dep mapper to 1.0.0 and set it the dep to 1.x in cordova-lib. Then I will merge the PR into master! On Wed, Mar 4, 2015 at 5:55 PM, Andrew Grieve agri...@chromium.org wrote: looks good. Should you un-pin the version of dep-mapper though? On Wed, Mar 4, 2015 at 8:03 PM,

[GitHub] cordova-plugin-file pull request: Implementation of read only acce...

2015-03-05 Thread mnill
Github user mnill commented on the pull request: https://github.com/apache/cordova-plugin-file/pull/84#issuecomment-77476072 @ArnaudValensi I will publish my realization of hotupdate on weekend or next week. --- If your project is set up for it, you can reply to this email and have

[GitHub] cordova-plugin-file pull request: Implementation of read only acce...

2015-03-05 Thread mnill
Github user mnill commented on the pull request: https://github.com/apache/cordova-plugin-file/pull/84#issuecomment-77478232 @ArnaudValensi my realization is simple. 1) copy all files from www to PERSISTENT storage. (if not be copy before); 2) download config.json from server

[GitHub] cordova-plugin-file pull request: Implementation of read only acce...

2015-03-05 Thread ArnaudValensi
Github user ArnaudValensi commented on the pull request: https://github.com/apache/cordova-plugin-file/pull/84#issuecomment-77476397 @mnill Thanks, it would be great! Can you tell me what is the idea of the design? --- If your project is set up for it, you can reply to this email

[GitHub] cordova-plugin-file pull request: Implementation of read only acce...

2015-03-05 Thread ArnaudValensi
Github user ArnaudValensi commented on the pull request: https://github.com/apache/cordova-plugin-file/pull/84#issuecomment-77478838 @mnill awesome! I was thinking about something like that. I would be glad to use/test/improve it when it will be published. --- If your project is set

Re: [DISCUSS] publishing cordova-app-hello-world to npm and adding as dependency of cordova-lib

2015-03-05 Thread Andrew Grieve
Can we move the config.xml template out of cordova-lib/templates and into app-hello-world as a part of this? On Thu, Mar 5, 2015 at 5:13 PM, Michal Mocny mmo...@chromium.org wrote: The current breaking change is that you cannot create a new project using cordova-lib directly, without providing

[GitHub] cordova-lib pull request: CB-8551 npm registry integration for fet...

2015-03-05 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-lib/pull/175 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cordova-plugin-inappbrowser pull request: CB-8552 Add toolbar opti...

2015-03-05 Thread cjpearson
GitHub user cjpearson opened a pull request: https://github.com/apache/cordova-plugin-inappbrowser/pull/87 CB-8552 Add toolbar option for android This change adds the toolbar option to android. The location property determines whether or not the URL is visible while the toolbar

[GitHub] cordova-plugin-inappbrowser pull request: CB-3750: Add loading spi...

2015-03-05 Thread cjpearson
GitHub user cjpearson opened a pull request: https://github.com/apache/cordova-plugin-inappbrowser/pull/89 CB-3750: Add loading spinner for ios You can merge this pull request into a Git repository by running: $ git pull

Re: Some thoughts/questions on the new --save feature

2015-03-05 Thread Michal Mocny
Consensus is a strong word ;) On Thu, Mar 5, 2015 at 11:02 AM, Raymond Camden raymondcam...@gmail.com wrote: Hmm. Ok... so... is there a consensus to *not* promote it? On Thu, Mar 5, 2015 at 9:24 AM, Gorkem Ercan gorkem.er...@gmail.com wrote: config.son is not created by CLI by default

Re: Some thoughts/questions on the new --save feature

2015-03-05 Thread Raymond Camden
Heh, ok, so how about - for the typical Cordova user. And I'd still like to know where/if the settings for this file are documented? On Thu, Mar 5, 2015 at 10:24 AM, Michal Mocny mmo...@chromium.org wrote: Consensus is a strong word ;) On Thu, Mar 5, 2015 at 11:02 AM, Raymond Camden

[GitHub] cordova-plugin-inappbrowser pull request: CB-3750: Add loading spi...

2015-03-05 Thread cjpearson
GitHub user cjpearson opened a pull request: https://github.com/apache/cordova-plugin-inappbrowser/pull/88 CB-3750: Add loading spinner for android You can merge this pull request into a Git repository by running: $ git pull

Re: Some thoughts/questions on the new --save feature

2015-03-05 Thread Andrew Grieve
I don't think they are documented. There's really no settings in there (besides this one) that anyone would ever need to use. So this would be the time to add docs. However, I do think we should try and promote just one way of doing things before branching pointing out there are hidden knobs. On

Re: Some thoughts/questions on the new --save feature

2015-03-05 Thread Gorkem Ercan
On 5 Mar 2015, at 12:01, Raymond Camden wrote: just one way of doing things This confuses me though. It seemed as if this new config (I mean new to me) was a way to configure the CLI. Is there another way to configure the CLI? With the example that was given (default to auto save) being a

Re: Some thoughts/questions on the new --save feature

2015-03-05 Thread Victor Sosa
So, to me this file is a good way to automate the autosave feature just as Gorkem is pointing (configure the JSON file, add plugins in the usual way with cordova plugin add and share your project, no flags needed to simply allow a good, or best, SCM practice), but it has been mentioned that the

[GitHub] cordova-lib pull request: CB-8448 Add support for activities fie...

2015-03-05 Thread AxelNennker
Github user AxelNennker commented on the pull request: https://github.com/apache/cordova-lib/pull/163#issuecomment-77325833 This PR was replaced by #172 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] cordova-plugin-geolocation pull request: Wrong parameter in Firefo...

2015-03-05 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-geolocation/pull/31 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] cordova-plugin-geolocation pull request: Wrong parameter in Firefo...

2015-03-05 Thread zalun
Github user zalun commented on the pull request: https://github.com/apache/cordova-plugin-geolocation/pull/31#issuecomment-77323242 Done --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] cordova-lib pull request: CB-8448 Add support for activities fie...

2015-03-05 Thread zalun
Github user zalun commented on the pull request: https://github.com/apache/cordova-lib/pull/163#issuecomment-77322965 Isn't it already sorted? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] cordova-plugin-file-transfer pull request: CB-8590 (Windows) Fixed...

2015-03-05 Thread alsorokin
GitHub user alsorokin opened a pull request: https://github.com/apache/cordova-plugin-file-transfer/pull/67 CB-8590 (Windows) Fixed download.onprogress.lengthComputable https://issues.apache.org/jira/browse/CB-8590 You can merge this pull request into a Git repository by running:

Re: Some thoughts/questions on the new --save feature

2015-03-05 Thread Michal Mocny
Also also, I'm not sure we should actively promote it. It seems like the kind of config file we want to phase out. -Michal On Thu, Mar 5, 2015 at 10:22 AM, Michal Mocny mmo...@chromium.org wrote: By default, they do not get created unless they have non-default values. This is usually only

Re: Some thoughts/questions on the new --save feature

2015-03-05 Thread Gorkem Ercan
config.son is not created by CLI by default anymore. You need to do create the file and add the key. -- Gorkem On 5 Mar 2015, at 7:33, Raymond Camden wrote: Sorry - what file? I don't have that in my project. If you meant user root, I don't have it there either. On Tue, Mar 3, 2015 at 12:14

Re: plugin install using old version with cordova 4.2

2015-03-05 Thread Gorkem Ercan
Do you have a version number specified on your config.xml for your plugin? Have you used the --save switch earlier for instance? -- Gorkem On 4 Mar 2015, at 23:22, Don Coleman wrote: I published a new version of my plugin http://plugins.cordova.io/#/package/com.megster.cordova.ble, but my

Re: Some thoughts/questions on the new --save feature

2015-03-05 Thread Raymond Camden
Hmm. Ok... so... is there a consensus to *not* promote it? On Thu, Mar 5, 2015 at 9:24 AM, Gorkem Ercan gorkem.er...@gmail.com wrote: config.son is not created by CLI by default anymore. You need to do create the file and add the key. -- Gorkem On 5 Mar 2015, at 7:33, Raymond Camden wrote:

Re: Some thoughts/questions on the new --save feature

2015-03-05 Thread Raymond Camden
just one way of doing things This confuses me though. It seemed as if this new config (I mean new to me) was a way to configure the CLI. Is there another way to configure the CLI? With the example that was given (default to auto save) being a preference for the tooling - can we accomplish that

[GitHub] cordova-plugin-camera pull request: CB-8498: On windows import fro...

2015-03-05 Thread vldmrrr
Github user vldmrrr commented on a diff in the pull request: https://github.com/apache/cordova-plugin-camera/pull/64#discussion_r25863818 --- Diff: src/windows/CameraProxy.js --- @@ -165,7 +165,16 @@ module.exports = { var storageFolder =

[GitHub] cordova-plugin-splashscreen pull request: [WP8] Respect SplashScre...

2015-03-05 Thread galexandrov
GitHub user galexandrov opened a pull request: https://github.com/apache/cordova-plugin-splashscreen/pull/38 [WP8] Respect SplashScreen and SplashScreenDelay preferences from config file Extend WP8 Splash Screen to respect SplashScreen and SplashScreenDelay preferences from config

Re: Some thoughts/questions on the new --save feature

2015-03-05 Thread Raymond Camden
Sorry - what file? I don't have that in my project. If you meant user root, I don't have it there either. On Tue, Mar 3, 2015 at 12:14 PM, Gorkem Ercan gorkem.er...@gmail.com wrote: You can enable auto save by adding auto_save_plugins to be true on the .cordova/config.json file. I think this

Re: Some thoughts/questions on the new --save feature

2015-03-05 Thread Raymond Camden
Definitely - once I find the file. ;) On Tue, Mar 3, 2015 at 12:20 PM, Michal Mocny mmo...@chromium.org wrote: Worthy of a blogpost, Ray! On Tue, Mar 3, 2015 at 1:17 PM, Victor Sosa sosah.vic...@gmail.com wrote: Good to know this trick. .. Thanks, Gorkem! 2015-03-03 12:14 GMT-06:00 Gorkem

Re: Some thoughts/questions on the new --save feature

2015-03-05 Thread Raymond Camden
I found this doc, https://wiki.apache.org/cordova/ConfigurationFiles, which mentions that you can have a .cordova/config.json in projects and your user dir. I don't have them in either location. Does that mean - by default - they don't exist until I make one? If so - where is the documentation

[GitHub] cordova-plugin-camera pull request: CB-8498: On windows import fro...

2015-03-05 Thread Bubkastor
Github user Bubkastor commented on a diff in the pull request: https://github.com/apache/cordova-plugin-camera/pull/64#discussion_r25860399 --- Diff: src/windows/CameraProxy.js --- @@ -165,7 +165,16 @@ module.exports = { var storageFolder =

[GitHub] cordova-plugin-camera pull request: CB-8498: On windows import fro...

2015-03-05 Thread vldmrrr
Github user vldmrrr commented on a diff in the pull request: https://github.com/apache/cordova-plugin-camera/pull/64#discussion_r25861297 --- Diff: src/windows/CameraProxy.js --- @@ -165,7 +165,16 @@ module.exports = { var storageFolder =

No tag for 3.7.1 Android Release?

2015-03-05 Thread Homer, Tony
I was just reading about CB-8328 and saw it was merged into 3.7.x. I wanted to check whether it had been included in the latest Android release. I eventually checked the release notes and found it was included. While I was checking this out I realized that there is no 3.7.1 tag. There should be a

[GitHub] cordova-plugin-device-orientation pull request: CB-8614 Fixed getC...

2015-03-05 Thread alsorokin
GitHub user alsorokin opened a pull request: https://github.com/apache/cordova-plugin-device-orientation/pull/18 CB-8614 Fixed getCurrentHeading and watchHeading on windows platform https://issues.apache.org/jira/browse/CB-8614 You can merge this pull request into a Git repository

Re: No tag for 3.7.1 Android Release?

2015-03-05 Thread Andrew Grieve
Yep - definitely was missing. I've now pushed it up. Thanks Tony! On Thu, Mar 5, 2015 at 9:27 AM, Homer, Tony tony.ho...@intel.com wrote: I was just reading about CB-8328 and saw it was merged into 3.7.x. I wanted to check whether it had been included in the latest Android release. I

Re: plugin install using old version with cordova 4.2

2015-03-05 Thread Don Coleman
It was the same config.xml, not plugins were listed. I could duplicate consistently yesterday, but not today. I'll try again next time I push an update to the plugin. On Thu, Mar 5, 2015 at 10:30 AM, Gorkem Ercan gorkem.er...@gmail.com wrote: Do you have a version number specified on your