Re: [DISCUSS] Cordova-Android 4.0.0 Release

2015-03-16 Thread Shazron
+1 for vote thread, let's get this thing out so people (that are not us) can test... On Mon, Mar 16, 2015 at 1:41 PM, Joe Bowser bows...@gmail.com wrote: OK, this is a three month old thread, and we're waiting on a discussion before we release something? I really think we should go to a vote

Re: Deprecation of Config and the embedded use case (4.0.x related)

2015-03-16 Thread Joe Bowser
Well, this feature was tested using TDD, and when the tests were re-written I assumed that they would be run. In this case, I'll blame Android Studio, since we're still battling with the learning curve on that one. (I have no clue how to run the new tests from Gradle on the command line, only in

[GitHub] cordova-js pull request: CB-7992 prohibit multiple cordova include...

2015-03-16 Thread purplecabbage
GitHub user purplecabbage opened a pull request: https://github.com/apache/cordova-js/pull/104 CB-7992 prohibit multiple cordova includes Verify that window.cordova does not already exist and throw error if it does. Tested on ios/android/wp8. You can merge this pull request

Re: [DISCUSS] Cordova-Android 4.0.0 Release

2015-03-16 Thread Andrew Grieve
Everything's ready afaik (minus upgrade guide, publishing whitelist plugins, and making it so that the default project template includes plugin name=cordova-plugin-whitelist /). Maybe let's do a RC while we wait on these things being finished up? If anyone wants to take on any of these tasks,

[GitHub] cordova-ios pull request: CB-7428: Enable Swift development of Plu...

2015-03-16 Thread cjpearson
Github user cjpearson commented on the pull request: https://github.com/apache/cordova-ios/pull/133#issuecomment-82005079 That's correct. Thanks, @shazron. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

Re: [DISCUSS] Cordova-Android 4.0.0 Release

2015-03-16 Thread Ian Clelland
+1 -- Let's get this out the door :) I'll see what I can get done to move it in that direction. On Mon, Mar 16, 2015 at 7:51 PM, Andrew Grieve agri...@chromium.org wrote: Everything's ready afaik (minus upgrade guide, publishing whitelist plugins, and making it so that the default project

[GitHub] cordova-plugin-file-transfer pull request: Fix NoSuchMethodExcepti...

2015-03-16 Thread dpogue
Github user dpogue commented on the pull request: https://github.com/apache/cordova-plugin-file-transfer/pull/68#issuecomment-82073797 /cc @agrieve Would be good to get this in before cordova-android 4.0.0 release. --- If your project is set up for it, you can reply to this

[GitHub] cordova-ios pull request: CB-7428: Enable Swift development of Plu...

2015-03-16 Thread shazron
Github user shazron commented on the pull request: https://github.com/apache/cordova-ios/pull/133#issuecomment-81998000 Hi @cjpearson - I'd like this to get in sooner rather than later. Since CB-8643 has been resolved, this can be merged in. I see a Connor Pearson listed as someone

[GitHub] cordova-android pull request: Part of fix for CT-7992

2015-03-16 Thread purplecabbage
Github user purplecabbage commented on the pull request: https://github.com/apache/cordova-android/pull/163#issuecomment-82017424 This should handle it. Will test some more on windows and probably merge tomorrow. https://github.com/apache/cordova-js/pull/104 --- If your project

Re: Deprecation of Config and the embedded use case (4.0.x related)

2015-03-16 Thread Michal Mocny
Carlos, thats great, then perhaps you could give 4.0 embedded webview a shot to confirm that it is still adequately supported for your customers? I think this thread has been too much talk and not enough trying it out in practice. Everyone agrees the use case is important, what's left is to

[GitHub] cordova-plugin-media pull request: CB-8686 - remove musicLibrary c...

2015-03-16 Thread muratsu
GitHub user muratsu opened a pull request: https://github.com/apache/cordova-plugin-media/pull/48 CB-8686 - remove musicLibrary capability Media plugin by default requests musicLibrary capability but it's not using it. It should be removed since, it's not required. You can merge

Re: [DISCUSS] Cordova-Android 4.0.0 Release

2015-03-16 Thread Ian Clelland
We'll probably need at least an RC for the whitelist plugin, if not a vote, to be able to vote on this. Or can we just include instructions like Use cordova-plugin-whitelist@f70b1bc for testing while we start the official release process for the plugins? On Mon, Mar 16, 2015 at 11:17 PM, Ian

Re: Medic Improvements

2015-03-16 Thread Willy Aguirre
Hi Dmitry, I am working in add Firefox OS platform https://github.com/marti1125/cordova-medic I had problem with with some plugins media and mediacapture because itself doesn't suppor. In cordova-repos.json when I run in console $ buildslave start slave_firefoxos I have to remove: { title :

RE: Medic Improvements

2015-03-16 Thread Dmitriy Barkalov (Akvelon)
Hi Willy, I suppose just deleting repositories from cordova-repos.json will not help. Medic uses mobile-spec application to run plugin tests. It has both media and media-capture plugins as a dependencies https://github.com/apache/cordova-mobile-spec/blob/master/dependencies-plugin/plugin.xml.

[GitHub] cordova-plugin-globalization pull request: CB-7960 Add cordova-plu...

2015-03-16 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-globalization/pull/33 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or

RE: Introduction for Julian Horn

2015-03-16 Thread Horn, Julian C
Hi Jesse, While it's certainly true that it's impossible to bullet-proof Cordova, protection against multiple inclusion is pretty basic. All the C system include files protect against multiple inclusion. JavaScript objects like jQuery include code to tolerate multiple inclusion. We should

[GitHub] cordova-plugins pull request: TCP Socket working for FxOS

2015-03-16 Thread zalun
GitHub user zalun opened a pull request: https://github.com/apache/cordova-plugins/pull/21 TCP Socket working for FxOS You can merge this pull request into a Git repository by running: $ git pull https://github.com/zalun/cordova-plugins tcp-socket-plugin Alternatively you

[GitHub] cordova-plugin-media-capture pull request: CB-7963 Adds support fo...

2015-03-16 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-media-capture/pull/31 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or

[GitHub] cordova-plugin-inappbrowser pull request: CB-7961 Add cordova-plug...

2015-03-16 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-inappbrowser/pull/76 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or

[GitHub] cordova-plugin-inappbrowser pull request: CB-8659 - Update InAppBr...

2015-03-16 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-inappbrowser/pull/93 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or

Re: [Vote] 3.8.0 Cordova App Hello World Release (attempt 3)

2015-03-16 Thread Andrew Grieve
+1 On Fri, Mar 13, 2015 at 3:01 PM, Mark Koudritsky kam...@google.com wrote: +1 Built and ran on - Android 5.0.2 on Nexus 7 - iOS simulator On Fri, Mar 13, 2015 at 2:32 PM, Steven Gill stevengil...@gmail.com wrote: Please review and vote on this 3.8.0 Cordova App Hello World Release.

[GitHub] cordova-plugin-file-transfer pull request: [windows] added supprt ...

2015-03-16 Thread biodiv
GitHub user biodiv opened a pull request: https://github.com/apache/cordova-plugin-file-transfer/pull/70 [windows] added supprt for cdvfile:// Added support for cdvfile:// paths You can merge this pull request into a Git repository by running: $ git pull

[GitHub] cordova-plugin-camera pull request: fix wp8.1 UI, added wp8.1 focu...

2015-03-16 Thread biodiv
GitHub user biodiv opened a pull request: https://github.com/apache/cordova-plugin-camera/pull/77 fix wp8.1 UI, added wp8.1 focus control You can merge this pull request into a Git repository by running: $ git pull https://github.com/biodiv/cordova-plugin-camera master

[GitHub] cordova-wp8 pull request: JsonHelper testing, and use of Newtonsof...

2015-03-16 Thread robpaveza
Github user robpaveza commented on the pull request: https://github.com/apache/cordova-wp8/pull/62#issuecomment-81827543 LGTM. Was worried about possible compatibility breaks, but that library respects Data Contract attributes. So, should be g2g. --- If your project is set up for

Re: Introduction for Julian Horn

2015-03-16 Thread Joe Bowser
On Mon, Mar 16, 2015 at 6:40 AM Horn, Julian C julian.c.h...@intel.com wrote: The fix certainly does not require a large chunk of time! Here's the entire fix; you put this up near the top of cordova.js, inside the outermost function invocation: if (window.cordova) { return; } And

Re: Introduction for Julian Horn

2015-03-16 Thread julio cesar sanchez
And what about detecting if the user didn't include any cordova tag? I usually see questions on stackoverflow asking, X feature of cordova isn't working. And the accepted answer is include the cordova.js script tag in you index.html 2015-03-16 14:37 GMT+01:00 Horn, Julian C

[GitHub] cordova-plugin-media-capture pull request: CB-8687 consolidate man...

2015-03-16 Thread nikhilkh
Github user nikhilkh commented on the pull request: https://github.com/apache/cordova-plugin-media-capture/pull/35#issuecomment-82107826 @vladimir-kotikov Can you please review? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] cordova-ios pull request: CB-7428: Enable Swift development of Plu...

2015-03-16 Thread shazron
Github user shazron commented on the pull request: https://github.com/apache/cordova-ios/pull/133#issuecomment-82120865 PR merged into 4.0.x branch, see above commit reference and CB-7428 --- If your project is set up for it, you can reply to this email and have your reply appear on

Re: [GitHub] cordova-plugin-file-transfer pull request: Fix NoSuchMethodExcepti...

2015-03-16 Thread Jesse
They are independent no? Is this plugin relying on cordova-android 4.0? Or vice versa On Mar 16, 2015, at 8:39 PM, dpogue g...@git.apache.org wrote: Github user dpogue commented on the pull request:

[GitHub] cordova-lib pull request: Allow hyphen in platform name

2015-03-16 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-lib/pull/186 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cordova-lib pull request: CB-8670 Error when set engine name to c...

2015-03-16 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-lib/pull/185 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

Re: [DISCUSS] Cordova-Android 4.0.0 Release

2015-03-16 Thread Joe Bowser
OK, this is a three month old thread, and we're waiting on a discussion before we release something? I really think we should go to a vote thread now that we have a legacy whitelist plugin and a new style whitelist plugin. We shouldn't keep constantly delaying this release because of what's

[GitHub] cordova-lib pull request: Allow hyphen in platform name

2015-03-16 Thread kamrik
Github user kamrik commented on the pull request: https://github.com/apache/cordova-lib/pull/186#issuecomment-81965293 Looks good, merging. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] cordova-lib pull request: Make required subdirectories for icons

2015-03-16 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-lib/pull/169 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

Introduction for Byoungro So

2015-03-16 Thread So, Byoungro
Hi, I would like to introduce myself. I have been working for Intel as a software architect for 10 years, and had worked for several research institutes (including IBM T. J. Watson) before I join Intel. I had designed and developed the SIMD support in the JavaScript W3C standardization effort.

RE: Introduction for Julian Horn

2015-03-16 Thread Horn, Julian C
Well, I can see that this is kind of a philosophical disagreement. Today having two script tags for cordova.js is defined to be an error. As such the current behavior of cordova.js is correct. But you could just as well have said that it's not an error. I think that's a better choice. I've

Re: Introduction for Byoungro So

2015-03-16 Thread Shazron
Welcome Byoungro So! I've given you the appropriate role and assigned you. On Sun, Mar 15, 2015 at 11:47 PM, So, Byoungro byoungro...@intel.com wrote: Hi, I would like to introduce myself. I have been working for Intel as a software architect for 10 years, and had worked for several

[GitHub] cordova-medic pull request: Medic Refactor

2015-03-16 Thread dmitriy-barkalov
Github user dmitriy-barkalov commented on a diff in the pull request: https://github.com/apache/cordova-medic/pull/37#discussion_r26515411 --- Diff: buildbot-conf/cordova-internal.conf --- @@ -0,0 +1,101 @@ +import os +import json + +from buildbot.changes.gitpoller

[GitHub] cordova-lib pull request: CB-8636 Remove FEATURE_SPECIAL_PARAMS fr...

2015-03-16 Thread vladimir-kotikov
Github user vladimir-kotikov commented on the pull request: https://github.com/apache/cordova-lib/pull/181#issuecomment-81875689 @omefire Could you please delete MSOT branch as well. --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] cordova-android pull request: Part of fix for CT-7992

2015-03-16 Thread purplecabbage
Github user purplecabbage commented on the pull request: https://github.com/apache/cordova-android/pull/163#issuecomment-81908413 If only it were that easy ... This file is generated so we cannot just modify it. Changes need to be implemented in the cordova-js repo. --- If your

[GitHub] cordova-android pull request: Part of fix for CT-7992

2015-03-16 Thread jchorn
GitHub user jchorn opened a pull request: https://github.com/apache/cordova-android/pull/163 Part of fix for CT-7992 New Cordova users, especially those building applications from building blocks, sometimes end up with more than one script tag for cordova.js. This currently

[GitHub] cordova-android pull request: Part of fix for CT-7992

2015-03-16 Thread jchorn
Github user jchorn closed the pull request at: https://github.com/apache/cordova-android/pull/163 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] cordova-android pull request: Part of fix for CT-7992

2015-03-16 Thread jchorn
Github user jchorn commented on the pull request: https://github.com/apache/cordova-android/pull/163#issuecomment-81909526 Thanks for the pointer! I had a feeling all these platforms were sharing code somewhere. I will try again with the right component. --- If your project is set

[GitHub] cordova-plugin-media pull request: CB-7962 Adds browser platform s...

2015-03-16 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-media/pull/45 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the