[REVIEW] Cordova 5.0.0 + Tools blog post

2015-04-20 Thread Steven Gill
Please review and send PRs. Do we want to include anything about whitelists on here? They were covered in both the android and plugins post. Anything else we should highlight? Plugins post is going to go out at the same time as this post.

RE: Scoped package names for npm?

2015-04-20 Thread Parashuram N (MS OPEN TECH)
Scopes are like namespaces. In the reverse domain name world, org.apache.cordova was considered a namespace, right ? We did not want non core packages to publish to that namespace, so does the same argument apply ? Alternatively, we can think of scope as packages that apply to a particular

RE: Scoped package names for npm?

2015-04-20 Thread Murat Sutunc
From what I read so far, scopes are like namespaces for npm modules. So each npm user has their own scope. In our case we'll have one cordova user who will have modules like: .. @cordova/platform-ios @cordova/plugin-camera .. Unless you're the user cordova (or a collaborator), you can't publish

Re: Question about bypassing the run-loop wait/entire bridge for plugins on iOS

2015-04-20 Thread Andrew Grieve
I think Jesse pretty much covered it. I would be surprised if you could get web animations to be in sync with native animations like the keyboard. If you are to try, I think you'd get closest by attaching a timestamp to the event you're sending to JS, and use requestAnimationFrame to animate. CSS

[GitHub] cordova-windows pull request: CB-8856 Fix 'Id' attr is invalid whe...

2015-04-20 Thread nikhilkh
Github user nikhilkh commented on the pull request: https://github.com/apache/cordova-windows/pull/66#issuecomment-94604271 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] cordova-plugin-dialogs pull request: Fix CB-7734. Changed plugin t...

2015-04-20 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-dialogs/pull/39 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] cordova-js pull request: [CB-8838]Disabled commandQueue for WK_WEB...

2015-04-20 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-js/pull/107 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

Scoped package names for npm?

2015-04-20 Thread Michal Mocny
https://docs.npmjs.com/getting-started/scoped-packages Should we be @cordova/plugin-device instead of cordova-plugin-device? -Michal

Re: Scoped package names for npm?

2015-04-20 Thread Michal Mocny
Other questions to answer: - Can 3rd-parties publish to this scope? - Do we want them to? - Do we want to default to @cordova scope if none is provided, such that you could do `cordova plugin add device`? -Michal On Mon, Apr 20, 2015 at 5:00 PM, Michal Mocny mmo...@google.com wrote:

Re: Question about bypassing the run-loop wait/entire bridge for plugins on iOS

2015-04-20 Thread Jesse
I think you are best off to experiment and see what you can get working consistently. The focus lately has been on the wkwebview bridge, which is entirely new, while the current webview implementation is a collection of workarounds for various issues. If you can distill this down to a simple

[GitHub] cordova-plugin-camera pull request: feature CB-8777 Add option onl...

2015-04-20 Thread thehuijb
Github user thehuijb commented on the pull request: https://github.com/apache/cordova-plugin-camera/pull/80#issuecomment-94647452 I rebased this pull request to the latest master, anyone care to check it out? would really appreciate it --- If your project is set up for it, you

[GitHub] cordova-medic pull request: [CB-8803] Properly fixing the intermit...

2015-04-20 Thread dmitriy-barkalov
Github user dmitriy-barkalov commented on the pull request: https://github.com/apache/cordova-medic/pull/44#issuecomment-94609690 LGTM Successfully run medic build several times --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] cordova-plugin-dialogs pull request: Fix CB-7734. Changed plugin t...

2015-04-20 Thread bau720123
Github user bau720123 commented on the pull request: https://github.com/apache/cordova-plugin-dialogs/pull/39#issuecomment-94611365 finally solved~ really thanks everybody's help !!! I will waiting the new version release --- If your project is set up for it, you can reply

Re: Scoped package names for npm?

2015-04-20 Thread Steven Gill
I also like scoped packages but am against another rename. Haha. I know organizations are coming soon so we will be able to create the Cordova organization and I believe scope packages that way. Add PMC members to the organization to be able to publish instead of relying on a Cordova npm user

[GitHub] cordova-plugin-splashscreen pull request: CB-8875 execute entire c...

2015-04-20 Thread chrskrchr
GitHub user chrskrchr opened a pull request: https://github.com/apache/cordova-plugin-splashscreen/pull/44 CB-8875 execute entire call to [UIView transitionWithView] on the main t... ...hread so that view fades as expected You can merge this pull request into a Git repository by

[GitHub] cordova-plugin-dialogs pull request: Fix CB-7734. Changed plugin t...

2015-04-20 Thread jcesarmobile
Github user jcesarmobile commented on the pull request: https://github.com/apache/cordova-plugin-dialogs/pull/39#issuecomment-94396822 Don't merge it yet, I've just noticed that I'm comparing [[UIApplication sharedApplication] statusBarOrientation] with UIDeviceOrientation, and it

[GitHub] cordova-plugin-dialogs pull request: Fix CB-7734. Changed plugin t...

2015-04-20 Thread shazron
Github user shazron commented on the pull request: https://github.com/apache/cordova-plugin-dialogs/pull/39#issuecomment-94391292 Looks good to me. I'll pull it in in the morning, but this block could have been tightened up a bit:

[GitHub] cordova-plugin-statusbar pull request: fix warning message

2015-04-20 Thread pbakondy
GitHub user pbakondy opened a pull request: https://github.com/apache/cordova-plugin-statusbar/pull/24 fix warning message This change is fix for the following warning message at startup: W/CordovaPlugin( 6470): Attempted to send a second callback for ID:

Re: [Vote] Tools Release

2015-04-20 Thread Ian Clelland
+1 Verified signatures and hashes Verified tarball contents against public repository Created and ran iOS (3.8.0) and Android (4.0.0) applications. On Fri, Apr 17, 2015 at 11:43 AM, Parashuram N (MS OPEN TECH) panar...@microsoft.com wrote: Voting +1 * Verified signatures and hashes *

[GitHub] cordova-plugin-whitelist pull request: Fixed error in Content-Secu...

2015-04-20 Thread Bnaya
Github user Bnaya commented on the pull request: https://github.com/apache/cordova-plugin-whitelist/pull/3#issuecomment-94456743 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] cordova-plugin-camera pull request: CB-8404 Rotate camera feed wit...

2015-04-20 Thread nikhilkh
Github user nikhilkh commented on the pull request: https://github.com/apache/cordova-plugin-camera/pull/88#issuecomment-94514784 It might be a good idea to file a JIRA to improve the code for resizeImage and not to use canvas for a resize operation. --- If your project is set up

[GitHub] cordova-plugin-dialogs pull request: Fix CB-7734. Changed plugin t...

2015-04-20 Thread jcesarmobile
Github user jcesarmobile commented on the pull request: https://github.com/apache/cordova-plugin-dialogs/pull/39#issuecomment-94505096 I've just added the changes --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] cordova-plugin-camera pull request: CB-8404 Rotate camera feed wit...

2015-04-20 Thread nikhilkh
Github user nikhilkh commented on a diff in the pull request: https://github.com/apache/cordova-plugin-camera/pull/88#discussion_r28708275 --- Diff: src/windows/CameraProxy.js --- @@ -310,29 +319,50 @@ function takePictureFromCameraWP(successCallback, errorCallback, args) {

[GitHub] cordova-plugin-camera pull request: CB-8404 Rotate camera feed wit...

2015-04-20 Thread nikhilkh
Github user nikhilkh commented on a diff in the pull request: https://github.com/apache/cordova-plugin-camera/pull/88#discussion_r28708793 --- Diff: src/windows/CameraProxy.js --- @@ -310,29 +319,50 @@ function takePictureFromCameraWP(successCallback, errorCallback, args) {

[GitHub] cordova-plugin-camera pull request: CB-8404 Rotate camera feed wit...

2015-04-20 Thread nikhilkh
Github user nikhilkh commented on a diff in the pull request: https://github.com/apache/cordova-plugin-camera/pull/88#discussion_r28708855 --- Diff: src/windows/CameraProxy.js --- @@ -310,29 +319,50 @@ function takePictureFromCameraWP(successCallback, errorCallback, args) {

[GitHub] cordova-plugin-media pull request: iOS play audio in background

2015-04-20 Thread kaushikmukunda
Github user kaushikmukunda commented on the pull request: https://github.com/apache/cordova-plugin-media/pull/12#issuecomment-94505186 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

RE: [Vote] Tools Release

2015-04-20 Thread Sergey Grebnov (Akvelon)
I vote +1 * Verified cordova installation * Verified ability create blank app for Android, iOS and Windows * Verified ability to build and run apps for Android, iOS and Windows Thx! Sergey -Original Message- From: iclell...@google.com [mailto:iclell...@google.com] On Behalf Of Ian

Re: moving plugins to npm

2015-04-20 Thread Andrew Grieve
On Thu, Apr 16, 2015 at 3:51 PM, Steven Gill stevengil...@gmail.com wrote: On Thu, Apr 16, 2015 at 1:36 PM, Don Coleman don.cole...@gmail.com wrote: I'm little nervous about changing the ids for my plugins for npm. I like the cordova-plugin-* prefix. I think the consistency is good. Is

Re: Keyboard plugin

2015-04-20 Thread Connor Pearson
That was a good read. Thanks for sharing, Kerri. I'll definitely have to try it out sometime.  Also, I'm sorry if I came off negatively. I do really appreciate all the Cordova team does. :) — Sent from Mailbox On Fri, Apr 17, 2015 at 3:22 AM, Kerri Shotts kerrisho...@gmail.com wrote:

RE: Proposal: Expose check_reqs at the CLI level

2015-04-20 Thread Vladimir Kotikov (Akvelon)
Hi, list. I would like to share a draft implementation for check_reqs command and check_reqs API: Changes could be found here: CLI: https://github.com/apache/cordova-cli/compare/master...MSOpenTech:requirements_check LIB:

[GitHub] cordova-plugin-camera pull request: CB-8054 Support taking picture...

2015-04-20 Thread muratsu
Github user muratsu commented on the pull request: https://github.com/apache/cordova-plugin-camera/pull/86#issuecomment-94503319 This one is ready to be merged. Would be glad if someone can merge this in. --- If your project is set up for it, you can reply to this email and have

RE: Proposal: Expose check_reqs at the CLI level

2015-04-20 Thread Josh Soref
-1 Didn't everyone agree to call it `cordova doctor` or worst, `cordova requirements`? -Original Message- From: Vladimir Kotikov (Akvelon) [mailto:v-vlk...@microsoft.com] Sent: Monday, April 20, 2015 11:46 AM To: dev@cordova.apache.org Subject: RE: Proposal: Expose check_reqs at

[GitHub] cordova-plugin-media pull request: iOS play audio in background

2015-04-20 Thread shazron
Github user shazron commented on the pull request: https://github.com/apache/cordova-plugin-media/pull/12#issuecomment-94539632 Thanks for the recent interest in this. Like @Rickgbw mentioned, it's an old issue and he may not be interested any more to proceed. There are still a

[GitHub] cordova-plugin-media pull request: iOS play audio in background

2015-04-20 Thread purplecabbage
Github user purplecabbage commented on the pull request: https://github.com/apache/cordova-plugin-media/pull/12#issuecomment-94539960 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

RE: Proposal: Expose check_reqs at the CLI level

2015-04-20 Thread Parashuram N (MS OPEN TECH)
This was only an initial implementation - no pull request has been sent. I think this is just a way for folks to play with what Vlad has now. I am sure we will change the verb name before a PR comes in. -Original Message- From: Josh Soref [mailto:jso...@blackberry.com] Sent: Monday,

Re: Question about bypassing the run-loop wait/entire bridge for plugins on iOS

2015-04-20 Thread Jesse
If you can be sure that your calls into js will not result in more calls back to native, then it is probably fine. Delegating back to the main thread may have similar performance trouble though ... For this specific case, can't you use a timed css animation that matches the keyboard animation?

Question about bypassing the run-loop wait/entire bridge for plugins on iOS

2015-04-20 Thread Tim Lancina
Hey Andrew, Just had a quick question about plugins on iOS. For the keyboard plugin we're using evalJS to fire an event when the keyboard shows, which by default waits for the run loop to cycle before executing any JS. My question is, would terrible things happen if we didn't wait, or even just