[GitHub] cordova-ios pull request: CB-9013: Fix listing of multiple devices...

2015-05-12 Thread gpetrov
Github user gpetrov commented on the pull request: https://github.com/apache/cordova-ios/pull/140#issuecomment-101184870 @shazron is different issue indeed, the other is about the emulators. Mine is about the connected devices list. Created:

[GitHub] cordova-plugin-splashscreen pull request: CB-3562: Disable screen ...

2015-05-12 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-splashscreen/pull/47 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or

RE: SHA512 does not match

2015-05-12 Thread Sergey Grebnov (Akvelon)
I saw this issue before as well - related to apache server which sets Content-Type header to application/x-gzip (for .sha files) - there was even some JIRA issue opened for this. Additional possible workarounds for Windows: 1. Use curl: curl

Re: SHA512 does not match

2015-05-12 Thread Jesse
Thanks Alexander! I can confirm that this worked for me. On a mac, I renamed cordova-plugin-vibration-1.1.0.tgz.sha - cordova-plugin-vibration-1.1.0.tgz.sha.zip then double clicked it in Finder. Primary key fingerprint: EBAC 6409 FA2F 2FCF A42C 1080 3843 B8F9 FFCA 68BE *./*

RE: [Vote] Android@4.0.1, WP8@3.8.1, Windows@3.8.2 Releases

2015-05-12 Thread Sergey Grebnov (Akvelon)
I vote +1 * Verified blank app can be successfully built and run (Android, Windows, WP8) * Ran autotests * Verified compatibility with core plugins Thx! Sergey -Original Message- From: Steven Gill [mailto:stevengil...@gmail.com] Sent: Tuesday, May 12, 2015 3:12 AM To:

RE: SHA512 does not match

2015-05-12 Thread Alexander Sorokin (Akvelon)
Hi Murat. This issue (not matching SHA512) is happening because your downloaded .sha file is compressed for some reason. Try to decompress it using, for example, 7zip. Regards, Alexander Sorokin -Original Message- From: Murat Sutunc [mailto:mura...@microsoft.com] Sent: Tuesday, May

[GitHub] cordova-js pull request: CB-8996 (Windows) Fixed invalid null comp...

2015-05-12 Thread purplecabbage
Github user purplecabbage commented on the pull request: https://github.com/apache/cordova-js/pull/110#issuecomment-101361898 Status can be 0 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

Re: Cordova 5.0 user feedback - move to npm whitelist plugin

2015-05-12 Thread Andrew Grieve
if you use --copy-from and the template doesn't already have a config.xml, then the default config.xml will be used. I wouldn't expect what you describe if your template already had a config.xml On Tue, May 12, 2015 at 10:46 AM, Raymond Camden raymondcam...@gmail.com wrote: So query - I

[DISCUSS] Cordova-Windows Release

2015-05-12 Thread Rob Paveza
Does anyone have a reason to delay a cordova-windows platform release? Any outstanding patches to land? I'm looking to merge Windows 10 support into main and release 4.0.0. If not, I will start a release tomorrow. Thanks, -Rob

RE: [DISCUSS] Cordova-Windows Release

2015-05-12 Thread Parashuram N (MS OPEN TECH)
+1 to merging Cordova-windows10 in master. I don't think it breaks anything existing, and windows10 support seems to be enabled only via flags or cli args. I think merging it into master will make developing windows 10 easier. -Original Message- From: Rob Paveza

[GitHub] cordova-wp8 pull request: Added Newtonsoft json dll

2015-05-12 Thread purplecabbage
Github user purplecabbage commented on the pull request: https://github.com/apache/cordova-wp8/pull/79#issuecomment-101383321 yes, it is a breaking change. That is why it is a 4.0.0 change. Plugin authors need to use engine tags, and we need to make sure they work.

Re: [Vote] Android@4.0.1, WP8@3.8.1, Windows@3.8.2 Releases

2015-05-12 Thread Steven Gill
The vote has now closed. The results are: Positive Binding Votes: 3 Steve Gill Sergey Grebnov Tim Barham The vote has passed. I will publish to dist npm now. On Tue, May 12, 2015 at 6:23 AM, Tim Barham tim.bar...@microsoft.com wrote: I vote +1 * Verified archive sigs and hashes ('coho

[GitHub] cordova-wp8 pull request: Added Newtonsoft json dll

2015-05-12 Thread nikhilkh
Github user nikhilkh commented on the pull request: https://github.com/apache/cordova-wp8/pull/79#issuecomment-101388610 If we can avoid the breaking change it would be better and in this case we have a solution that works well to avoid it (apache/cordova-plugin-file-transfer#72). I

[GitHub] cordova-windows pull request: CB-8486 Support for signing and buil...

2015-05-12 Thread nikhilkh
Github user nikhilkh commented on a diff in the pull request: https://github.com/apache/cordova-windows/pull/75#discussion_r30174837 --- Diff: template/cordova/lib/build.js --- @@ -32,88 +33,175 @@ var projFiles = { win: 'CordovaApp.Windows.jsproj', win80:

[GitHub] cordova-wp8 pull request: Added Newtonsoft json dll

2015-05-12 Thread nikhilkh
Github user nikhilkh commented on the pull request: https://github.com/apache/cordova-wp8/pull/79#issuecomment-101378234 @purplecabbage I'm really concerned with this switch for WP8 as it is breaking in nature. It changes how the Cordova WP8 JSON APIs behave and will cause a fair

[GitHub] cordova-js pull request: CB-9016: Added template-packaged WinJS re...

2015-05-12 Thread robpaveza
GitHub user robpaveza opened a pull request: https://github.com/apache/cordova-js/pull/111 CB-9016: Added template-packaged WinJS reference for Windows 10 support. Windows 10 no longer has a Framework Reference for WinJS, instead we include it in the project template (since we

Re: [GitHub] cordova-wp8 pull request: Added Newtonsoft json dll

2015-05-12 Thread Jesse
That sounds like a very reasonable approach. So we'll revert the changes to JSONHelper.cs + leave NewtonsoftJSON lib in and plugin developers can use it if they prefer. Sound good? Yes, currently PG-Build supports only cordova-wp8. Windows Universal (8.1) is in the works. @purplecabbage

Re: [DISCUSS] Cordova-Windows Release

2015-05-12 Thread Jesse
+1 The less branches we maintain the better. @purplecabbage risingj.com On Tue, May 12, 2015 at 11:44 AM, Parashuram N (MS OPEN TECH) panar...@microsoft.com wrote: +1 to merging Cordova-windows10 in master. I don't think it breaks anything existing, and windows10 support seems to be enabled

[GitHub] cordova-wp8 pull request: Added Newtonsoft json dll

2015-05-12 Thread brodybits
Github user brodybits commented on the pull request: https://github.com/apache/cordova-wp8/pull/79#issuecomment-101394601 If we can avoid the breaking change it would be better and in this case we have a solution that works well to avoid it (apache/cordova-plugin-file-transfer#72).

[GitHub] cordova-ios pull request: CB-9013: Fix listing of multiple devices...

2015-05-12 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-ios/pull/140 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cordova-windows pull request: CB-8486 Support for signing and buil...

2015-05-12 Thread purplecabbage
Github user purplecabbage commented on the pull request: https://github.com/apache/cordova-windows/pull/75#issuecomment-101421281 +1 and yeah, showing at least one valid publisher Id would be great. I would recommend you also add a comment with a passing value whenever you

Re: [VOTE] cordova-plugin-vibration release

2015-05-12 Thread Steven Gill
The vote has now closed. The results are: Positive Binding Votes: 4 Steve Gill Jesse MacFadyen Shazron Abdullah Murat Sutunc The vote has passed. I will move it over to dist and publish to npm On Mon, May 11, 2015 at 5:20 PM, Murat Sutunc mura...@microsoft.com wrote: Sorry to hijack this

[ANNOUNCE] Platform and plugin releases

2015-05-12 Thread Steven Gill
Platforms released: cordova-windows@3.8.2 cordova-wp8@3.8.1 cordova-android@4.0.1 Plugins released: cordova-plugin-camera@1.1.0 cordova-plugin-device-motion@1.1.0 cordova-plugin-dialogs@1.1.0 cordova-plugin-file-transfer@1.1.0 cordova-plugin-vibration@1.1.0 Everything has been published to

[GitHub] cordova-windows pull request: CB-8946: Added the WindowsToastCapa...

2015-05-12 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-windows/pull/74 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] cordova-js pull request: CB-8996 (Windows) Fixed invalid null comp...

2015-05-12 Thread dblotsky
Github user dblotsky commented on the pull request: https://github.com/apache/cordova-js/pull/110#issuecomment-101424430 Merged, making it check explicitly for `undefined` and `null`, as per Jesse's note that 0 is a valid return value, and `if(condition)` wasn't sufficient. --- If

[GitHub] cordova-windows pull request: CB-8856 Fix 'Id' attr is invalid whe...

2015-05-12 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-windows/pull/66 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] cordova-windows pull request: CB-8486 Support for signing and buil...

2015-05-12 Thread nikhilkh
Github user nikhilkh commented on the pull request: https://github.com/apache/cordova-windows/pull/75#issuecomment-101407929 Looks great, otherwise - let's get it in! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] cordova-js pull request: CB-8996 (Windows) Fixed invalid null comp...

2015-05-12 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-js/pull/110 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cordova-js pull request: CB-8996 (Windows) Fixed invalid null comp...

2015-05-12 Thread purplecabbage
Github user purplecabbage commented on the pull request: https://github.com/apache/cordova-js/pull/110#issuecomment-101426677 Looks good! @purplecabbage risingj.com On Tue, May 12, 2015 at 2:18 PM, Dmitry Blotsky notificati...@github.com wrote:

[GitHub] cordova-wp8 pull request: Update index.html

2015-05-12 Thread purplecabbage
Github user purplecabbage commented on the pull request: https://github.com/apache/cordova-wp8/pull/78#issuecomment-101426531 index.html is a resource that comes from https://github.com/apache/cordova-app-hello-world This cannot be patched here. --- If your project is set up for

[GitHub] cordova-app-hello-world pull request: CB-9009 default CSP needs to...

2015-05-12 Thread stevengill
Github user stevengill commented on the pull request: https://github.com/apache/cordova-app-hello-world/pull/10#issuecomment-101429782 As long as this doesn't negatively impact other platforms, merge away. --- If your project is set up for it, you can reply to this email and have

RE: [DISCUSS] Cordova-Windows Release

2015-05-12 Thread Rob Paveza
Jesse, where have we landed on the issue of the local-notifications plugin change? It seems to me that whatever change we make isn't particularly relevant to other platforms. Since Windows Cordova apps are entirely in JS, the solution has to be in JS. Why focus on it being an event-based

[GitHub] cordova-windows pull request: CB-9015: Merge windows10 support to ...

2015-05-12 Thread robpaveza
GitHub user robpaveza opened a pull request: https://github.com/apache/cordova-windows/pull/76 CB-9015: Merge windows10 support to Master This change merges the Windows 10 support from the 'windows10' branch into master. I've also gone through and tidied up a couple of the places

[GitHub] cordova-js pull request: CB-8996 (Windows) Fixed invalid null comp...

2015-05-12 Thread purplecabbage
Github user purplecabbage commented on the pull request: https://github.com/apache/cordova-js/pull/110#issuecomment-101466299 ultimately this was a failure of our use of jshint. The original check of (undef != null) was fine, but jshint considered it an error ... which led to a

Re: [CI] WP8 mobilespec failing to get created (CB-9021)

2015-05-12 Thread Jesse
On the flip side, if we do not update cordova-js with the latest on its master, we would have found this bug CB-8996 much later Yeah, true. Ultimately I would like to see the entire matrix of possibilities. cordova-wp8@npm-published-version + cordova-js@master cordova-wp8@master

Re: [CI] WP8 mobilespec failing to get created (CB-9021)

2015-05-12 Thread Jesse
I am not entirely sure what the best approach is, personally I would just expect it to build with the cordova.js installed by the version. There is no guarantee that platforms and cordova-js are in sync at any given time. Maybe we should put this behind a flag and have the CI run it both with and

[GitHub] cordova-lib pull request: CB-9023 Add support to specify a build c...

2015-05-12 Thread nikhilkh
GitHub user nikhilkh opened a pull request: https://github.com/apache/cordova-lib/pull/215 CB-9023 Add support to specify a build config file. If none is specified `bui… …ld.json` in the project root is used as a default You can merge this pull request into a Git repository by

[GitHub] cordova-docs pull request: Small fix on index.md

2015-05-12 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-docs/pull/282 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[CI] Windows build restored

2015-05-12 Thread Dmitry Blotsky
Thanks to all who participated in fixing it! Latest Windows mobilespec run passed: http://ci.apache.org/builders/cordova-windows/builds/1457 Kindly, Dmitry

Re: [DISCUSS] Should pinned platforms allow for patch updates?

2015-05-12 Thread Shazron
+1 on loosening the grip on platform pinning On Tue, May 12, 2015 at 3:21 PM, Steven Gill stevengil...@gmail.com wrote: I am totally on board with --save flag saving '^1.2.3' in config.xml since it mimics the behavior of npm --save. No need to change anything. The more I think about it, the

[GitHub] cordova-docs pull request: CB-8752 Adds docs for hooks functionali...

2015-05-12 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-docs/pull/285 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cordova-docs pull request: CB-9004 Russian translation

2015-05-12 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-docs/pull/286 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cordova-docs pull request: CB-8960 Add docs for AppendUserAgent, O...

2015-05-12 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-docs/pull/284 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cordova-docs pull request: CB-8486 docs for windows packaging

2015-05-12 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-docs/pull/288 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cordova-docs pull request: CB-9006 Fix Russian headers correctly

2015-05-12 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-docs/pull/287 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

Re: [CI] WP8 mobilespec failing to get created (CB-9021)

2015-05-12 Thread Dmitry Blotsky
Mobilespec builds it by design, I think, to use the latest version of cordova.js. Is that undesired behaviour? We're always using the master version of cordova-wp8 in periodic CI builds. Kindly, Dmitry On May 12, 2015, at 3:22 PM, Jesse purplecabb...@gmail.com wrote: What version of

[GitHub] cordova-plugin-camera pull request: CB-8879 fix stripe issue with ...

2015-05-12 Thread muratsu
GitHub user muratsu opened a pull request: https://github.com/apache/cordova-plugin-camera/pull/94 CB-8879 fix stripe issue with correct aspect ratio This fixes the stripe issue we had on windows phone 8+. The fix was to set up resolutions with a common aspect ratio. Default

RE: [DISCUSS] Should pinned platforms allow for patch updates?

2015-05-12 Thread Nikhil Khandelwal
For platform releases, we would have to test it with the oldest version of the CLI that could potentially pull it down. This one worries me a bit in terms of the testing burden and the version matrix that we will need to support. Totally in favor of having patch versions be available right

[CI] WP8 mobilespec failing to get created (CB-9021)

2015-05-12 Thread Dmitry Blotsky
Hi all, Mobilespec is failing to get created on WP8 because there is an issue with dependencies in package.json. I’ve created a JIRA: https://issues.apache.org/jira/browse/CB-9021. Kindly, Dmitry

RE: [CI] WP8 mobilespec failing to get created (CB-9021)

2015-05-12 Thread Nikhil Khandelwal
On the flip side, if we do not update cordova-js with the latest on its master, we would have found this bug https://issues.apache.org/jira/browse/CB-8996 much later - only when the cordova.js would have merged to the platform repo - which I believe happens only around the time of a release?

Re: [CI] WP8 mobilespec failing to get created (CB-9021)

2015-05-12 Thread Jesse
What version of cordova-wp8 are you testing? The failure seems like is doing what it should ... cordova-wp8@4.0.0 should not be able to install cordova-plugin-file-transfer@4.0.0 Also, why is createmobilespec always building cordova-js? I would expect this to sporadically break. @purplecabbage

Re: [DISCUSS] Should pinned platforms allow for patch updates?

2015-05-12 Thread Steven Gill
I am totally on board with --save flag saving '^1.2.3' in config.xml since it mimics the behavior of npm --save. No need to change anything. The more I think about it, the more I think we should loosen our grips on platform pinning. As long as we are being semver compliant for all of our

[ios-deploy] version 1.6.0 released

2015-05-12 Thread Shazron
Release notes: https://github.com/phonegap/ios-deploy/releases/tag/1.6.0 - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org

Re: Cordova 5.0 user feedback - move to npm whitelist plugin

2015-05-12 Thread Andrew Grieve
On Mon, May 11, 2015 at 1:56 PM, Nikhil Khandelwal nikhi...@microsoft.com wrote: Responses inline. -Original Message- From: Steven Gill [mailto:stevengil...@gmail.com] Sent: Thursday, May 7, 2015 6:17 PM To: dev@cordova.apache.org Subject: Re: Cordova 5.0 user feedback - move to

[GitHub] cordova-js pull request: CB-8996 (Windows) Fixed invalid null comp...

2015-05-12 Thread alsorokin
GitHub user alsorokin opened a pull request: https://github.com/apache/cordova-js/pull/110 CB-8996 (Windows) Fixed invalid null comparison https://issues.apache.org/jira/browse/CB-8996 You can merge this pull request into a Git repository by running: $ git pull

RE: [CI] Windows Build Still Broken

2015-05-12 Thread Alexander Sorokin (Akvelon)
Hi Dmitry, It turned out to be a regression in cordova-js caused by this commit: https://github.com/apache/cordova-js/commit/867fcac79d82823b356a771ce5aaf52e057a2319#diff-94c2e7d53ca6fc7837eddee66fdf4a52R64 I've fixed it and created a PR: https://github.com/apache/cordova-js/pull/110 Thanks,

[DISCUSS] Should pinned platforms allow for patch updates?

2015-05-12 Thread Tim Barham
?Currently our pinned platforms are all in the form 1.2.3, which I expect means we'll always get that exact version. Should we instead use the form 1.2.x to allow for patches without having to do a tools release? BTW... When you add a platform, and we use the pinned version of, say, '1.2.3',

Re: [DISCUSS] wp8@3.8.1, windows@3.8.2, android@4.0.1 release

2015-05-12 Thread Tim Barham
Hey a question about 'coho verify-tags' - this is the first time I've used it. Anyone else here using it with a standard Windows command window? There is no way to enter an EOF, which is required to trigger it to parse the tags/hashes you've provided (I ended up hacking the source a bit to get

Re: [Vote] Android@4.0.1, WP8@3.8.1, Windows@3.8.2 Releases

2015-05-12 Thread Tim Barham
I vote +1 * Verified archive sigs and hashes ('coho verify-archive'). * Verified tag sha1s ('coho verify-tags'). * Verified can build and run blank app for each platform. * Verified tests were green (windows and wp8). * Verified android platform now works in Ripple. Thanks, Tim

Re: Cordova 5.0 user feedback - move to npm whitelist plugin

2015-05-12 Thread Raymond Camden
So query - I thought the whitelist plugin was being added because it was in the default Cordova sample config.xml - but when I built a new project and used --copy-from, it *also* installed the plugin. So is it just *always* added? On Tue, May 12, 2015 at 9:21 AM, Andrew Grieve

[GitHub] cordova-plugin-media pull request: iOS play audio in background

2015-05-12 Thread gerwinbrunner
Github user gerwinbrunner commented on the pull request: https://github.com/apache/cordova-plugin-media/pull/12#issuecomment-101324760 Hi, is anybody able to pick this up and create a fix for this? It seems to be quite an issue and a lot of people are experiencing this problem.