[GitHub] cordova-plugin-splashscreen pull request: CB-8396 - Read property ...

2015-05-29 Thread miqmago
Github user miqmago commented on the pull request: https://github.com/apache/cordova-plugin-splashscreen/pull/48#issuecomment-106736212 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] cordova-wp8 pull request: CB-8954 Adds support for `requirements` ...

2015-05-29 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-wp8/pull/82 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cordova-lib pull request: CB-9001 Set WMAppManifest.xml Author, De...

2015-05-29 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-lib/pull/229 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cordova-windows pull request: CB-8954 Adds support for `requiremen...

2015-05-29 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-windows/pull/83 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] cordova-ios pull request: CB-8954 Adds support for `requirements` ...

2015-05-29 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-ios/pull/142 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

Media getCurrentPosition kills app after a while (cpu usage increases continously

2015-05-29 Thread Gerwin Brunner
Hi, I'm experiencing a very strange behavior in the Media API. I just play a MP3 file and update the time spent playing. Here is a very simplistic code: var self; self = this; self.interval = 50; self.audioFile= asd.wav; self.audio = new Media(self.audioFile, function() { return

[GitHub] cordova-android pull request: CB-8954 Adds support for `requiremen...

2015-05-29 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-android/pull/176 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

Re: Building cordova.js on first build

2015-05-29 Thread Brian LeRoux
+1 On Thu, May 28, 2015 at 6:32 PM, Steven Gill stevengil...@gmail.com wrote: Right now, only the --browserify way does cordova.js generation in the cli. --browserify is currently designed to work with the CLI. I don't think it is worth it to add cordova.js generation functionality to the

[GitHub] cordova-windows pull request: Update LICENSE NOTE file to includ...

2015-05-29 Thread TimBarham
Github user TimBarham commented on a diff in the pull request: https://github.com/apache/cordova-windows/pull/88#discussion_r31341319 --- Diff: LICENSE --- @@ -1,12 +1,309 @@ -Licensed under the Apache License, Version 2.0 (the License); -you may not use this file

[GitHub] cordova-plugin-camera pull request: Update docs

2015-05-29 Thread muratsu
GitHub user muratsu opened a pull request: https://github.com/apache/cordova-plugin-camera/pull/100 Update docs Update docs to enhance reading experience You can merge this pull request into a Git repository by running: $ git pull

[GitHub] cordova-windows pull request: Update LICENSE NOTE file to includ...

2015-05-29 Thread TimBarham
Github user TimBarham commented on a diff in the pull request: https://github.com/apache/cordova-windows/pull/88#discussion_r31341629 --- Diff: LICENSE --- @@ -1,12 +1,309 @@ -Licensed under the Apache License, Version 2.0 (the License); -you may not use this file

[GitHub] cordova-windows pull request: Update LICENSE NOTE file to includ...

2015-05-29 Thread TimBarham
Github user TimBarham commented on a diff in the pull request: https://github.com/apache/cordova-windows/pull/88#discussion_r31341940 --- Diff: LICENSE --- @@ -1,12 +1,309 @@ -Licensed under the Apache License, Version 2.0 (the License); -you may not use this file

[GitHub] cordova-windows pull request: Draft implementation for Unified pla...

2015-05-29 Thread nikhilkh
Github user nikhilkh commented on the pull request: https://github.com/apache/cordova-windows/pull/84#issuecomment-106845669 I think we should wait for the impending Cordova-windows 4.0 release before we merge this. --- If your project is set up for it, you can reply to this email

[GitHub] cordova-windows pull request: Update LICENSE NOTE file to includ...

2015-05-29 Thread nikhilkh
GitHub user nikhilkh opened a pull request: https://github.com/apache/cordova-windows/pull/88 Update LICENSE NOTE file to include appropriare third-party licenses You can merge this pull request into a Git repository by running: $ git pull

[GitHub] cordova-windows pull request: Update LICENSE NOTE file to includ...

2015-05-29 Thread TimBarham
Github user TimBarham commented on the pull request: https://github.com/apache/cordova-windows/pull/88#issuecomment-106868556 What about `elementtree`? It's released under Apache license, but I think we still need to specifically mention it. --- If your project is set up for it, you

[GitHub] cordova-lib pull request: CB-9065 Allow removing plugins by short ...

2015-05-29 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-lib/pull/225 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cordova-windows pull request: CB-9097 fail with a more descriptive...

2015-05-29 Thread muratsu
GitHub user muratsu opened a pull request: https://github.com/apache/cordova-windows/pull/89 CB-9097 fail with a more descriptive error if run as admin `cordova run` will fail for windows if invoked from admin prompt. Currently we will wait until ActivateApplication stage and fail

[GitHub] cordova-coho pull request: Improvements to coho list-pulls.

2015-05-29 Thread muratsu
Github user muratsu commented on the pull request: https://github.com/apache/cordova-coho/pull/82#issuecomment-106893231 LGTM :shipit: --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] cordova-coho pull request: Improvements to coho list-pulls.

2015-05-29 Thread TimBarham
GitHub user TimBarham opened a pull request: https://github.com/apache/cordova-coho/pull/82 Improvements to coho list-pulls. 1. Supports an environment variable (`CORDOVA_GIT_ACCOUNT`) to specify `username:apitoken` to avoid hitting GitHub rate limits. 2. Uses API to get most

[GitHub] cordova-plugin-camera pull request: Update README.md

2015-05-29 Thread muratsu
Github user muratsu commented on the pull request: https://github.com/apache/cordova-plugin-camera/pull/84#issuecomment-106874924 @antonellopasella if you can edit your text I can merge it, thanks --- If your project is set up for it, you can reply to this email and have your reply

RE: Hello

2015-05-29 Thread Murat Sutunc
Welcome Vishal !! Happy to have another contributor :) -Original Message- From: Vishal Mishra [mailto:vismi...@adobe.com] Sent: Thursday, May 28, 2015 11:30 AM To: dev@cordova.apache.org Subject: Hello Hi, I am Vishal and have joined the Adobe team that works on Cordova. I will be

[GitHub] cordova-windows pull request: Update LICENSE NOTE file to includ...

2015-05-29 Thread TimBarham
Github user TimBarham commented on a diff in the pull request: https://github.com/apache/cordova-windows/pull/88#discussion_r31345590 --- Diff: LICENSE --- @@ -1,12 +1,309 @@ -Licensed under the Apache License, Version 2.0 (the License); -you may not use this file

[GitHub] cordova-coho pull request: Improvements to coho list-pulls.

2015-05-29 Thread muratsu
Github user muratsu commented on a diff in the pull request: https://github.com/apache/cordova-coho/pull/82#discussion_r31345599 --- Diff: src/list-pulls.js --- @@ -23,7 +23,9 @@ var apputil = require('./apputil'); var flagutil = require('./flagutil'); var repoutil =

[GitHub] cordova-windows pull request: Update LICENSE NOTE file to includ...

2015-05-29 Thread nikhilkh
Github user nikhilkh commented on the pull request: https://github.com/apache/cordova-windows/pull/88#issuecomment-106878445 Updated. Thanks @TimBarham for taking a look! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well.

[GitHub] cordova-windows pull request: Update LICENSE NOTE file to includ...

2015-05-29 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-windows/pull/88 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[DISCUSS] Moving Rat Excludes closer to source

2015-05-29 Thread Dmitry Blotsky
Hi all, Right now coho stores rat excludes inside its source code, which often goes out of date and we end up with a lot of noise in coho audit-license-headers”. Do you think it would be a good idea to instead add a “.ratignore” file in each repo, much like .npmignore and .gitignore? Kindly,

Re: coho tag-release issue

2015-05-29 Thread Steven Gill
hmm, maybe that command has issues running on windows machines. Looking at the cordova-windows repo ( https://git-wip-us.apache.org/repos/asf?p=cordova-windows.git) You pushed 4.0.x branch and 4.0.0 tag 4 hours ago. That command would tag + push. I'll try it on my end and report back. On Fri,

Re: [Vote] Tools Release May 27th

2015-05-29 Thread Dmitry Blotsky
I vote +1: * Ran 'coho verify-tags', and it passed * Ran 'coho audit-license-headers', and got some files reported as non-compliant, but I’ve been convinced by Nikhil Khandelwal and Tim Barham that they should be in ratExcludes * Installed the code and ran NPM tests using Medic: * OSX:

[GitHub] cordova-plugin-camera pull request: Update docs

2015-05-29 Thread nikhilkh
Github user nikhilkh commented on a diff in the pull request: https://github.com/apache/cordova-plugin-camera/pull/100#discussion_r31369165 --- Diff: README.md --- @@ -35,6 +35,16 @@ Although the object is attached to the global scoped `navigator`, it is not avai

[GitHub] cordova-plugin-camera pull request: Update docs

2015-05-29 Thread nikhilkh
Github user nikhilkh commented on a diff in the pull request: https://github.com/apache/cordova-plugin-camera/pull/100#discussion_r31370376 --- Diff: README.md --- @@ -83,47 +93,68 @@ quality, even if a `quality` parameter is specified. To avoid common memory problems, set

[GitHub] cordova-plugin-camera pull request: Update docs

2015-05-29 Thread muratsu
Github user muratsu commented on a diff in the pull request: https://github.com/apache/cordova-plugin-camera/pull/100#discussion_r31368757 --- Diff: README.md --- @@ -35,6 +35,16 @@ Although the object is attached to the global scoped `navigator`, it is not avai

Re: coho tag-release issue

2015-05-29 Thread Steven Gill
Definitely a bug with coho. Works fine if I do it for android but fails if I do it for windows. I'll look into fixing it On Fri, May 29, 2015 at 2:55 PM, Steven Gill stevengil...@gmail.com wrote: hmm, maybe that command has issues running on windows machines. Looking at the cordova-windows

[GitHub] cordova-plugin-camera pull request: Update docs

2015-05-29 Thread muratsu
Github user muratsu commented on a diff in the pull request: https://github.com/apache/cordova-plugin-camera/pull/100#discussion_r31369274 --- Diff: README.md --- @@ -83,47 +93,68 @@ quality, even if a `quality` parameter is specified. To avoid common memory problems, set

[CI] Medic Report

2015-05-29 Thread Dmitry Blotsky
Hi list, Here are some points of interest regarding our CI this week: * PR-triggered and commit-triggered builds waiting on INFRA-9683 and INFRA-9678 * build-breaking issues from last week got fixed promptly * Android build turned green this week, thanks to Alexander

[GitHub] cordova-plugins pull request: CB-8337: Fix keyboardShrinksView for...

2015-05-29 Thread Fmstrat
Github user Fmstrat commented on the pull request: https://github.com/apache/cordova-plugins/pull/18#issuecomment-106986865 Ahh, I gave that a shot, thanks. I've got a console.log running with the keyboard height, but any idea where I can find an example of using JS to shrink the

[GitHub] cordova-plugins pull request: CB-8337: Fix keyboardShrinksView for...

2015-05-29 Thread akrymski
Github user akrymski commented on the pull request: https://github.com/apache/cordova-plugins/pull/18#issuecomment-106972661 I believe the general consensus is that it’s too hard to get resizing to behave reliably across many OS versions, and that the best solution is to use detect

[GitHub] cordova-coho pull request: Improvements to coho list-pulls.

2015-05-29 Thread TimBarham
Github user TimBarham commented on a diff in the pull request: https://github.com/apache/cordova-coho/pull/82#discussion_r31346258 --- Diff: src/list-pulls.js --- @@ -23,7 +23,9 @@ var apputil = require('./apputil'); var flagutil = require('./flagutil'); var repoutil =

Re: Why does coho need coho?

2015-05-29 Thread Andrew Grieve
I think it's because it downloads the RAT tool to coho's directory. On Thu, May 28, 2015 at 9:52 PM, Dmitry Blotsky dblot...@microsoft.com wrote: Hi all, When I run 'coho audit-licence-headers' INSIDE of 'cordova-js' (should work since it runs in the current directory by default), I get the

[GitHub] cordova-plugin-camera pull request: Update docs

2015-05-29 Thread nikhilkh
Github user nikhilkh commented on a diff in the pull request: https://github.com/apache/cordova-plugin-camera/pull/100#discussion_r31364877 --- Diff: README.md --- @@ -35,6 +35,16 @@ Although the object is attached to the global scoped `navigator`, it is not avai

[VOTE] 4.0.0 Windows Release

2015-05-29 Thread Nikhil Khandelwal
Please review and vote on this Windows Release by replying to this email (and keep discussion on the DISCUSS thread) Release issue: https://issues.apache.org/jira/browse/CB-9064 Cordova-windows have been published to: dist/dev:https://dist.apache.org/repos/dist/dev/cordova/CB-9064/ The

Re: [BUG] Fail to build Mobilespec with --thirdpartyplugins (CB-9032)

2015-05-29 Thread Andrew Grieve
I think we can mostly cover this by saying anything that's marked as public or protected is part of the public API. If we don't want it to be public, we should use package private. On Wed, May 27, 2015 at 11:21 PM, Joe Bowser bows...@gmail.com wrote: The bigger issue is the question of what is

[GitHub] cordova-plugin-camera pull request: fix wp8.1 UI, added wp8.1 focu...

2015-05-29 Thread muratsu
Github user muratsu commented on the pull request: https://github.com/apache/cordova-plugin-camera/pull/77#issuecomment-106875324 @biodiv can you please squash and rebase it? There have been many changes on the Windows side, I would love to get this checked. --- If your project is

Hello

2015-05-29 Thread Vishal Mishra
Hi, I am Vishal and have joined the Adobe team that works on Cordova. I will be working on making Cordova work better with the new devices and platforms. Regards, Vishal - To unsubscribe, e-mail:

[GitHub] cordova-plugin-camera pull request: Update docs

2015-05-29 Thread nikhilkh
Github user nikhilkh commented on a diff in the pull request: https://github.com/apache/cordova-plugin-camera/pull/100#discussion_r31364978 --- Diff: README.md --- @@ -83,47 +93,68 @@ quality, even if a `quality` parameter is specified. To avoid common memory problems, set

Re: [Vote] Tools Release May 27th

2015-05-29 Thread Steven Gill
bump On Wed, May 27, 2015 at 4:58 PM, Steven Gill stevengil...@gmail.com wrote: Please review and vote on this Tools Release by replying to this email (and keep discussion on the DISCUSS thread) Release issue: https://issues.apache.org/jira/browse/CB-9087 Both tools have been published to

RE: [DISCUSS] Tools Release

2015-05-29 Thread Nikhil Khandelwal
I am late to this discussion, but I just started a Windows 4.0.0 platform release and would like to do a tools release after that to pin this Windows release. I'm not sure if there is a guideline around this - and wonder if it makes sense to combine the two TOOLS releases. Thanks, Nikhil

Re: [DISCUSS] Tools Release

2015-05-29 Thread Steven Gill
We could easily do another tools release starting next week once the windows 4.0 vote ends. On Fri, May 29, 2015 at 2:11 PM, Nikhil Khandelwal nikhi...@microsoft.com wrote: I am late to this discussion, but I just started a Windows 4.0.0 platform release and would like to do a tools release

coho tag-release issue

2015-05-29 Thread Nikhil Khandelwal
To do the Windows release, I was following the steps outlined here: https://github.com/apache/cordova-coho/blob/master/docs/platforms-release-process.md In one of the steps, I ran into an issue. coho tag-release --version 4.0.0 -r windows --pretend Running from d:\cordova cordova-windows/

Re: Hello

2015-05-29 Thread Michael Brooks
Welcome Vish! On Fri, May 29, 2015 at 11:08 AM, Murat Sutunc mura...@microsoft.com wrote: Welcome Vishal !! Happy to have another contributor :) -Original Message- From: Vishal Mishra [mailto:vismi...@adobe.com] Sent: Thursday, May 28, 2015 11:30 AM To: dev@cordova.apache.org