[GitHub] cordova-lib pull request: CB-9033 : fix WatchKit support

2015-06-02 Thread galexandrov
Github user galexandrov commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/219#discussion_r31506402 --- Diff: cordova-lib/package.json --- @@ -42,7 +42,7 @@ underscore: 1.7.0, unorm: 1.3.3, valid-identifier: 0.0.1, -

[GitHub] cordova-lib pull request: CB-9033 : fix WatchKit support

2015-06-02 Thread galexandrov
Github user galexandrov commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/219#discussion_r31507207 --- Diff: cordova-lib/src/plugman/platforms/ios.js --- @@ -184,13 +192,76 @@ module.exports = { var xcBuildConfiguration =

Re: npm info cordova returning version 5.1.0

2015-06-02 Thread Steven Gill
Yeah, 5.1.0 was published as RC so we could test it. On Tue, Jun 2, 2015 at 8:10 AM, Shazron shaz...@gmail.com wrote: I see the 'latest' tag as 5.0.0? That is what is associated with the dist tarball you see. On Tue, Jun 2, 2015 at 7:25 AM, Nikhil Khandelwal nikhi...@microsoft.com wrote:

[GitHub] cordova-plugin-file-transfer pull request: Fix NoSuchMethodExcepti...

2015-06-02 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-file-transfer/pull/68 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or

Re: [DISCUSS] Plugins Release

2015-06-02 Thread Steven Gill
Thanks Darryl! Merged. On Tue, Jun 2, 2015 at 10:57 AM, Darryl Pogue dar...@dpogue.ca wrote: https://github.com/apache/cordova-plugin-file-transfer/pull/68 This bug is causing app crashes on older OS versions for anyone using FileTransfer on Android with Crosswalk. On 2 June 2015 at

RE: npm info cordova returning version 5.1.0

2015-06-02 Thread Nikhil Khandelwal
Thanks for the explanation. I was not familiar with npm and our release process and this confused me. It makes sense now. -Nikhil -Original Message- From: Steven Gill [mailto:stevengil...@gmail.com] Sent: Tuesday, June 2, 2015 10:52 AM To: dev@cordova.apache.org Subject: Re: npm info

Android plugin crash on resume when activity destroyed

2015-06-02 Thread Dan Polivy
On Android, when using plugins that launch other intents, e.g. the Camera plugin, I'm now seeing reliable crashes when the cordova activity is resumed - if it was destroyed when the intent launched. The reliable way to reproduce this is to enable the Don't keep activities setting in Android's

Re: [DISCUSS] Plugins Release

2015-06-02 Thread Darryl Pogue
https://github.com/apache/cordova-plugin-file-transfer/pull/68 This bug is causing app crashes on older OS versions for anyone using FileTransfer on Android with Crosswalk. On 2 June 2015 at 10:50, Steven Gill stevengil...@gmail.com wrote: Going to start a plugins release tomorrow. If you

Re: [Vote] Tools Release May 27th

2015-06-02 Thread Steven Gill
This vote has failed. I will start another vote thread after I fix the --usegit regression. On Fri, May 29, 2015 at 6:02 PM, Dmitry Blotsky dblot...@microsoft.com wrote: I vote +1: * Ran 'coho verify-tags', and it passed * Ran 'coho audit-license-headers', and got some files reported as

[GitHub] cordova-lib pull request: CB-9033 : fix WatchKit support

2015-06-02 Thread ogoguel
Github user ogoguel commented on the pull request: https://github.com/apache/cordova-lib/pull/219#issuecomment-108063507 Added SKIP_INSTALL to improve plist detection Using node-xcode 0.7.0 (which includes the required modification) --- If your project is set up for it, you can

[DISCUSS] Plugins Release

2015-06-02 Thread Steven Gill
Going to start a plugins release tomorrow. If you have PRs you want me to review, please bring them up in this thread. -Steve

Re: [DISCUSS] Plugins Release

2015-06-02 Thread Joe Bowser
Is there a test attached to that PR? This seems like something that would break again. On Tue, Jun 2, 2015 at 11:11 AM Steven Gill stevengil...@gmail.com wrote: Thanks Darryl! Merged. On Tue, Jun 2, 2015 at 10:57 AM, Darryl Pogue dar...@dpogue.ca wrote:

[GitHub] cordova-blackberry pull request: Fixes CB-9072

2015-06-02 Thread timwindsor
GitHub user timwindsor opened a pull request: https://github.com/apache/cordova-blackberry/pull/184 Fixes CB-9072 You can merge this pull request into a Git repository by running: $ git pull https://github.com/timwindsor/cordova-blackberry CB-9072 Alternatively you can

[GitHub] cordova-lib pull request: CB-9108 Handle version ranges when add p...

2015-06-02 Thread stevengill
Github user stevengill commented on the pull request: https://github.com/apache/cordova-lib/pull/232#issuecomment-108136533 Sure. I'll get to it later today On Jun 2, 2015 4:59 PM, Tim Barham notificati...@github.com wrote: Hey @stevengill https://github.com/stevengill

[GitHub] cordova-lib pull request: Fix four failing tests on Windows.

2015-06-02 Thread purplecabbage
Github user purplecabbage commented on the pull request: https://github.com/apache/cordova-lib/pull/233#issuecomment-108146207 Yeah, gotta love the 'weird error' when it happens. This does resolve the other errors I had. I think we can still pull this in. --- If your project is

[GitHub] cordova-windows pull request: CB-9097 fail with a more descriptive...

2015-06-02 Thread purplecabbage
Github user purplecabbage commented on the pull request: https://github.com/apache/cordova-windows/pull/89#issuecomment-108130162 wfm! Merging. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] cordova-lib pull request: CB-9108 Handle version ranges when add p...

2015-06-02 Thread TimBarham
Github user TimBarham commented on the pull request: https://github.com/apache/cordova-lib/pull/232#issuecomment-108135207 Hey @stevengill ... could you take a look at this? Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] cordova-lib pull request: Fix four failing tests on Windows.

2015-06-02 Thread purplecabbage
Github user purplecabbage commented on the pull request: https://github.com/apache/cordova-lib/pull/233#issuecomment-108145177 Awesome, I was just looking into this, waiting for appveyor now ... --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] cordova-lib pull request: Fix four failing tests on Windows.

2015-06-02 Thread TimBarham
Github user TimBarham commented on the pull request: https://github.com/apache/cordova-lib/pull/233#issuecomment-108146017 Bummer... AppVeyor is still broken (which I pretty much expected since its failure is different from what I was seeing - but it would have been nice :smile:).

[GitHub] cordova-windows pull request: CB-9097 fail with a more descriptive...

2015-06-02 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-windows/pull/89 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] cordova-lib pull request: Fix four failing tests on Windows.

2015-06-02 Thread TimBarham
GitHub user TimBarham opened a pull request: https://github.com/apache/cordova-lib/pull/233 Fix four failing tests on Windows. Two tests fail on Windows in a non-admin command window because they rely on creating symlinks. Since creating the symlinks isn't the purpose of the test

[GitHub] cordova-lib pull request: Fix four failing tests on Windows.

2015-06-02 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-lib/pull/233 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cordova-lib pull request: CB-9108 Handle version ranges when add p...

2015-06-02 Thread omefire
Github user omefire commented on the pull request: https://github.com/apache/cordova-lib/pull/232#issuecomment-108146590 I spent some time reviewing this, it looks good to me even though I think the --usegit flag should be eliminated (some time in the future) now that we have the

[GitHub] cordova-lib pull request: CB-9108 Handle version ranges when add p...

2015-06-02 Thread TimBarham
GitHub user TimBarham opened a pull request: https://github.com/apache/cordova-lib/pull/232 CB-9108 Handle version ranges when add platform with --usegit. Adding a platform using a version range didn't work with `--usegit`, since it would try to use that version range as a git tag.

[GitHub] cordova-windows pull request: CB-9097 fail with a more descriptive...

2015-06-02 Thread vladimir-kotikov
Github user vladimir-kotikov commented on the pull request: https://github.com/apache/cordova-windows/pull/89#issuecomment-108119813 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] cordova-plugin-media pull request: fix record and play NullPointer...

2015-06-02 Thread uareurapid
Github user uareurapid commented on the pull request: https://github.com/apache/cordova-plugin-media/pull/56#issuecomment-107903213 Any feedback? seems a clear bug... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

Re: plugins framework on Android

2015-06-02 Thread Andrew Grieve
We want plugman to always work, even if you don't have the android sdk installed. So, plugman calling android update project is not allowed. As of cordova-5.0, this line will be re-written by the build script to its Gradle equivalent, where no android update project call is necessary (this was an

npm info cordova returning version 5.1.0

2015-06-02 Thread Nikhil Khandelwal
Why does npm info cordova - give me 5.1.0 version which points to cordova 5.0.0 tgz? See the lines below in asterisk. { name: 'cordova', description: 'Cordova command line interface tool', 'dist-tags': { latest: '5.0.0', rc: '5.1.0', '3.6.0-0.2.8': '3.6.0-0.2.8', nightly:

Re: plugins framework on Android

2015-06-02 Thread Axel Nennker
If a developer writes a plugin that adds a framework in the platform name=android .. section then the android sdk needs to be installed anyways to build the app later, right? But OK. Still plugman tries to read project_dir/local.properties to get sdk.dir which fails because local.properties does

[GitHub] cordova-plugin-file-transfer pull request: Added support for PATCH...

2015-06-02 Thread alvaromb
GitHub user alvaromb opened a pull request: https://github.com/apache/cordova-plugin-file-transfer/pull/86 Added support for PATCH request uploads Adds support to PATCH request uploads. Keeps POST as default fallback. You can merge this pull request into a Git repository by

[GitHub] cordova-plugin-splashscreen pull request: Add fullscreen options

2015-06-02 Thread danielreuterwall
Github user danielreuterwall commented on the pull request: https://github.com/apache/cordova-plugin-splashscreen/pull/45#issuecomment-107930682 Shouldn't the `SYSTEM_UI_FLAG_FULLSCREEN` flag be based on the `SplashHideStatusBar` preference instead of `SplashHideNavigationBar`?

Re: Best place to browse plugins

2015-06-02 Thread Raymond Camden
So adding a # in front of each line makes it compile. Here is a Gist showing the change - since the ASF is *incredibly* particular about stuff, do the # marks 'break' something for them? https://gist.github.com/cfjedimaster/a236919daea219e4c5d2 And here is the rendered HTML:

[GitHub] cordova-lib pull request: CB-9033 : fix WatchKit support

2015-06-02 Thread ogoguel
Github user ogoguel commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/219#discussion_r31520090 --- Diff: cordova-lib/src/plugman/platforms/ios.js --- @@ -184,13 +192,76 @@ module.exports = { var xcBuildConfiguration =

[GitHub] cordova-lib pull request: CB-9033 : fix WatchKit support

2015-06-02 Thread ogoguel
Github user ogoguel commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/219#discussion_r31519205 --- Diff: cordova-lib/package.json --- @@ -42,7 +42,7 @@ underscore: 1.7.0, unorm: 1.3.3, valid-identifier: 0.0.1, -

[Android] VERSION_CODE generation

2015-06-02 Thread Joe Bowser
I just fixed CB-9080 by removing the fix for CB-8834, since I consider VERSION_DOWNGRADE to be easily worked around while not launching the application on older devices is an unacceptable fail state. The thing is why is VERSION_DOWNGRADE happening in the first place, and why are we generating the

Re: [Android] VERSION_CODE generation

2015-06-02 Thread Andrew Grieve
I can shed some light. The code for it is here: https://github.com/apache/cordova-android/blob/master/bin/templates/project/build.gradle#L178 There are two times we fiddle with it: 1 - When building multiple architectures (cough crosswalk cough) 2 - When a minSdkVersion is set. Play store

Re: Best place to browse plugins

2015-06-02 Thread Shazron
Looks ok to me. Not sure if Apache RAT passes it, but I think it would. If it doesn't its easily worked around since we would have manually verified that it passes (and put it in the ignore file for RAT) On Tue, Jun 2, 2015 at 6:18 AM, Raymond Camden raymondcam...@gmail.com wrote: So adding a

Re: Best place to browse plugins

2015-06-02 Thread Raymond Camden
Ok. So... this is my first time. I commit to the repo and... in theory npm will just pick it up. Here goes nothing. On Tue, Jun 2, 2015 at 10:08 AM, Shazron shaz...@gmail.com wrote: Looks ok to me. Not sure if Apache RAT passes it, but I think it would. If it doesn't its easily worked around

Re: Best place to browse plugins

2015-06-02 Thread Raymond Camden
Done - so how soon will npm pick up on the change so I can see? On Tue, Jun 2, 2015 at 10:17 AM, Raymond Camden raymondcam...@gmail.com wrote: Ok. So... this is my first time. I commit to the repo and... in theory npm will just pick it up. Here goes nothing. On Tue, Jun 2, 2015 at 10:08 AM,

Re: npm info cordova returning version 5.1.0

2015-06-02 Thread Shazron
I see the 'latest' tag as 5.0.0? That is what is associated with the dist tarball you see. On Tue, Jun 2, 2015 at 7:25 AM, Nikhil Khandelwal nikhi...@microsoft.com wrote: Why does npm info cordova - give me 5.1.0 version which points to cordova 5.0.0 tgz? See the lines below in asterisk. {

RE: [VOTE] 4.0.0 Windows Release

2015-06-02 Thread Sergey Grebnov (Akvelon)
+1 -verified platform could be added, built and run on windows8.1 and windows10 -verified windows10 target support Thx! Sergey -Original Message- From: Jesse [mailto:purplecabb...@gmail.com] Sent: Tuesday, June 2, 2015 8:01 AM To: dev@cordova.apache.org Subject: Re: [VOTE] 4.0.0

Re: Best place to browse plugins

2015-06-02 Thread Raymond Camden
I've gone through about half of them but I'll just keep going. If we can just remove them completely, then next time we mod the docs they can be killed then too. On Tue, Jun 2, 2015 at 10:49 AM, Nikhil Khandelwal nikhi...@microsoft.com wrote: Don't we have to publish the plugin to npm for this

Re: Best place to browse plugins

2015-06-02 Thread Steven Gill
Once you are done we can start a discuss for a plugins release. Thanks Ray! On Jun 2, 2015 8:53 AM, Raymond Camden raymondcam...@gmail.com wrote: I've gone through about half of them but I'll just keep going. If we can just remove them completely, then next time we mod the docs they can be

[VOTE] Partial Tools Release June 1, 2015

2015-06-02 Thread Tim Barham
Please review and vote on this partial Tools Release (lib and cli only) by replying to this email (and keep discussion on the DISCUSS thread) This release is to provide a 4.3.1 patch that pins Android 3.7.2 (a security release). Release issue: https://issues.apache.org/jira/browse/CB-9103 The

RE: Best place to browse plugins

2015-06-02 Thread Nikhil Khandelwal
Don't we have to publish the plugin to npm for this to be picked up? I think npm does not look at the git repo itself. Also, we might as well remove the license, ASF does not require docs to have the license header - only sources. .md files should ideally be part of RAT excludes.

RE: [VOTE] 4.0.0 Windows Release

2015-06-02 Thread Nikhil Khandelwal
I vote +1 * ran coho verify-archive * Verified tags manually * Verified blank app creates correctly with platform * Verified blank app can be successfully ran and built * Ran smoke testing of mobilespec app (ran autotests) Thanks, Nikhil -Original Message- From: Sergey Grebnov (Akvelon)

Re: Best place to browse plugins

2015-06-02 Thread Raymond Camden
I updated every plugin listed here (http://cordova.apache.org/docs/en/5.0.0/cordova_plugins_pluginapis.md.html#Plugin%20APIs) I ran marky-markdown on the README to ensure it spit out HTML. I've pushed up everything. If I need to do anything else to 'officially' start the process, just let me

[GitHub] cordova-plugin-splashscreen pull request: Add fullscreen options

2015-06-02 Thread TheBosZ
Github user TheBosZ commented on the pull request: https://github.com/apache/cordova-plugin-splashscreen/pull/45#issuecomment-107997719 Thanks Daniel! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does