[GitHub] cordova-plugin-whitelist pull request: Update README.md

2015-07-21 Thread vaenow
GitHub user vaenow opened a pull request: https://github.com/apache/cordova-plugin-whitelist/pull/8 Update README.md Update some confusing comments. see: `Content-Security-Policy Examples` in http://content-security-policy.com/ You can merge this pull request into a Git re

RE: [VOTE] cordova-android 4.1.0 release

2015-07-21 Thread Steven Gill
If it isn't on npm, then no problem On Jul 21, 2015 6:54 PM, "Tim Barham" wrote: > Doesn't look like Nikhil has published this to npm, so that shouldn't be a > problem, right? > > -Original Message- > From: Steven Gill [mailto:stevengil...@gmail.com] > Sent: Wednesday, July 22, 2015 11:41

RE: [VOTE] cordova-android 4.1.0 release

2015-07-21 Thread Tim Barham
Doesn't look like Nikhil has published this to npm, so that shouldn't be a problem, right? -Original Message- From: Steven Gill [mailto:stevengil...@gmail.com] Sent: Wednesday, July 22, 2015 11:41 AM To: dev@cordova.apache.org Subject: Re: [VOTE] cordova-android 4.1.0 release Because rc

Re: [VOTE] cordova-android 4.1.0 release

2015-07-21 Thread Steven Gill
Because rcs get published on npm under the rc tag, the version has to increase. On Jul 21, 2015 6:33 PM, "Joe Bowser" wrote: > I mean that we should be able to release on Windows without having problems > with the character returns. It sounds like there's a coho issue. > > On Tue, Jul 21, 2015 a

Re: [VOTE] cordova-android 4.1.0 release

2015-07-21 Thread Joe Bowser
I mean that we should be able to release on Windows without having problems with the character returns. It sounds like there's a coho issue. On Tue, Jul 21, 2015 at 6:32 PM Joe Bowser wrote: > If the vote is called off, we release a new release candidate for 4.1.0, > not issue a 4.1.1. If we'r

Re: [VOTE] cordova-android 4.1.0 release

2015-07-21 Thread Joe Bowser
If the vote is called off, we release a new release candidate for 4.1.0, not issue a 4.1.1. If we're calling off the vote, then I would recommend deleting the current copies on cordova-dist-dev. Also, the line-endings should be based on unix-based platforms. On Tue, Jul 21, 2015 at 6:30 PM Nikhi

RE: [VOTE] cordova-android 4.1.0 release

2015-07-21 Thread Nikhil Khandelwal
I used Windows to publish this package and the line endings are an issue on *nix based platforms. This vote is called off - I will publish a 4.1.1 version soon. Thanks, Nikhil -Original Message- From: Joe Bowser [mailto:bows...@gmail.com] Sent: Monday, July 20, 2015 3:24 PM To: dev@co

[GitHub] cordova-lib pull request: The concat() method returns a new array.

2015-07-21 Thread purplecabbage
Github user purplecabbage commented on the pull request: https://github.com/apache/cordova-lib/pull/216#issuecomment-123516003 This change has already been applied here: dff78b0779444d06e259140694e07d5e8c5f5308 Please close this pr. --- If your project is set up for it, you can r

RE: Huge performance gap between iOS SQLite and Android SQLite

2015-07-21 Thread Parashuram N
It would also be interesting to see the SQLite plugin that you are using for this test. -Original Message- From: Jesse [mailto:purplecabb...@gmail.com] Sent: Tuesday, July 21, 2015 3:33 PM To: dev@cordova.apache.org Subject: Re: Huge performance gap between iOS SQLite and Android SQLite

Re: [CI] iOS build breaking

2015-07-21 Thread Shazron
This is not true -- the v1.2.0 (latest) version of the camera plugin builds with cordova-ios 3.8.0 (released), it just won't build with cordova-ios master (by the time cordova-ios 4.0 is released, a new plugin release will be out with the required changes). The master version of the camera plugin

[GitHub] cordova-plugin-inappbrowser pull request: give the ability to trus...

2015-07-21 Thread brad
GitHub user brad opened a pull request: https://github.com/apache/cordova-plugin-inappbrowser/pull/111 give the ability to trust a certificate authority We found ourselves in a position where we needed to access a site with a certificate issued by a CA not trusted by default in Andr

Re: Huge performance gap between iOS SQLite and Android SQLite

2015-07-21 Thread Jesse
Please post a brief sample demonstrating the issue and someone will have a look. It is virtually impossible without even knowing what plugin you are using Gut reaction is the android code is doing something wrong, but it's hard to know with a concrete example. My team is hiring! @purplecabb

[GitHub] cordova-lib pull request: CB-9278: BugFix: Restoring multiple plat...

2015-07-21 Thread omefire
Github user omefire commented on the pull request: https://github.com/apache/cordova-lib/pull/266#issuecomment-123498882 @nikhilkh, log level updated. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does n

Huge performance gap between iOS SQLite and Android SQLite

2015-07-21 Thread Rob Sherman
Hello Cordova Dev's. My company develops a mobile inventory/ERP client/scheduling/Logistics App for the medical industry. We support iOS and Android (and possibly Windows Tablets soon) We are seeing (as are many others) extreme differences in SQLite data load times between iOS and Android. We hav

Re: Plugin discussion: Feature detection

2015-07-21 Thread Jesse
There are a couple different ways to go about this, but ultimately the mechanisms are already there. 1. WaitForInit If you look at the cordova-device plugin, it pre-populates data about the device it is running on, and this info is available when the deviceready event fires. Essentially the plugin

[GitHub] cordova-lib pull request: CB-9278: BugFix: Restoring multiple plat...

2015-07-21 Thread nikhilkh
Github user nikhilkh commented on the pull request: https://github.com/apache/cordova-lib/pull/266#issuecomment-123493951 One small comment. LGTM otherwise. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] cordova-lib pull request:

2015-07-21 Thread purplecabbage
Github user purplecabbage commented on the pull request: https://github.com/apache/cordova-lib/commit/d8f491b0e47f47e44e41697e5fd9781fdd1b29b7#commitcomment-12286034 It is also NOT mocked! Making real calls to a real plugin .. ftw! --- If your project is set up for it, you can reply

[GitHub] cordova-lib pull request: CB-9278: BugFix: Restoring multiple plat...

2015-07-21 Thread nikhilkh
Github user nikhilkh commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/266#discussion_r35160288 --- Diff: cordova-lib/src/cordova/restore-util.js --- @@ -56,24 +57,23 @@ function installPlatformsFromConfigXML(platforms) { if (!targets || !t

[GitHub] cordova-lib pull request:

2015-07-21 Thread omefire
Github user omefire commented on the pull request: https://github.com/apache/cordova-lib/commit/d8f491b0e47f47e44e41697e5fd9781fdd1b29b7#commitcomment-12285831 LGTM ! Thanks @purplecabbage. This goes way beyond the documentation we had discussed, :+1: --- If your project is se

[GitHub] cordova-lib pull request:

2015-07-21 Thread omefire
Github user omefire commented on the pull request: https://github.com/apache/cordova-lib/commit/d8f491b0e47f47e44e41697e5fd9781fdd1b29b7#commitcomment-12285816 LGTM ! Thanks @purplecabbage . --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] cordova-lib pull request: CB-9278: BugFix: Restoring multiple plat...

2015-07-21 Thread omefire
GitHub user omefire opened a pull request: https://github.com/apache/cordova-lib/pull/266 CB-9278: BugFix: Restoring multiple platforms fails You can merge this pull request into a Git repository by running: $ git pull https://github.com/MSOpenTech/cordova-lib CB-9278 Alterna

[GitHub] cordova-registry-web pull request: Modularize code and faster sear...

2015-07-21 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-registry-web/pull/29 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the fe

Re: [DISCUSS] Website Repo

2015-07-21 Thread Brian LeRoux
thumbs up! (idk what happened) On Tue, Jul 21, 2015 at 11:55 AM, Jesse wrote: > Brian? was that a thumbs-up or a poo-poo? > Not seeing your emoji ... > > I agree with Nikhil that we should optimize for contribution, and probably > stay within the apache org at github. > > > My team is hiring! >

[GitHub] cordova-registry-web pull request: Adding delete-this to blacklist...

2015-07-21 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-registry-web/pull/28 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the fe

Re: JSHint breaks the build again

2015-07-21 Thread Rob Paveza
I would be OK with a style warning as long as the warning checks the contents of the string for a single-quote, in which case it says, "Oh, you used double quotes so you could author a single quote without an escape prefix! I won't error you here." From:

Re: [DISCUSS] Website Repo

2015-07-21 Thread Jesse
Brian? was that a thumbs-up or a poo-poo? Not seeing your emoji ... I agree with Nikhil that we should optimize for contribution, and probably stay within the apache org at github. My team is hiring! @purplecabbage risingj.com On Tue, Jul 21, 2015 at 10:53 AM, Nikhil Khandelwal wrote: > 'Cord

[GitHub] cordova-registry-web pull request: Modularize code and faster sear...

2015-07-21 Thread nikhilkh
Github user nikhilkh commented on the pull request: https://github.com/apache/cordova-registry-web/pull/29#issuecomment-123440248 This is a good change and cleanup. Love the perf improvements. Let's get this deployed! --- If your project is set up for it, you can reply to this email

[GitHub] cordova-windows pull request: CB-9359: Adds support for .appxbundl...

2015-07-21 Thread nikhilkh
Github user nikhilkh commented on the pull request: https://github.com/apache/cordova-windows/pull/102#issuecomment-123432881 This is awesome! LGTM. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] cordova-windows pull request: CB-9235 Adds more checks based on th...

2015-07-21 Thread robpaveza
Github user robpaveza commented on the pull request: https://github.com/apache/cordova-windows/pull/92#issuecomment-123432180 I'm supposing build.spec.js spec.13 fails because it doesn't mock `findAllAvailableVersions` (or was also `findAvailableVersions` in your code). I wrote a use

RE: JSHint breaks the build again

2015-07-21 Thread Murat Sutunc
Yeah this rule is more of a style rule and doesn't check for language correctness. I'm ok with removing it but I'm also wondering if we should separately have some sort of a style checker (which will not block CI but give out warnings). -Original Message- From: Nikhil Khandelwal [mailt

[GitHub] cordova-windows pull request: CB-9235 Adds more checks based on th...

2015-07-21 Thread robpaveza
Github user robpaveza commented on the pull request: https://github.com/apache/cordova-windows/pull/92#issuecomment-123430303 build.spec.js spec.13 fails. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project do

RE: JSHint breaks the build again

2015-07-21 Thread Nikhil Khandelwal
I agree with your disagreement. :) +1 to relaxing the condition. Thanks, Nikhil -Original Message- From: Jesse [mailto:purplecabb...@gmail.com] Sent: Monday, July 20, 2015 6:00 PM To: dev@cordova.apache.org Subject: JSHint breaks the build again I am sick of seeing my commits cause b

[GitHub] cordova-windows pull request: CB-9359: Adds support for .appxbundl...

2015-07-21 Thread muratsu
Github user muratsu commented on a diff in the pull request: https://github.com/apache/cordova-windows/pull/102#discussion_r35134586 --- Diff: template/cordova/lib/run.js --- @@ -104,12 +104,16 @@ module.exports.run = function (argv) { projectType = 'windows80';

[GitHub] cordova-windows pull request: CB-9359: Adds support for .appxbundl...

2015-07-21 Thread muratsu
Github user muratsu commented on a diff in the pull request: https://github.com/apache/cordova-windows/pull/102#discussion_r35133583 --- Diff: template/cordova/lib/build.js --- @@ -229,11 +268,66 @@ function buildTargets(msbuild, config) { if (msbuild.version == '4.

[GitHub] cordova-windows pull request: CB-9359: Adds support for .appxbundl...

2015-07-21 Thread muratsu
Github user muratsu commented on a diff in the pull request: https://github.com/apache/cordova-windows/pull/102#discussion_r35133311 --- Diff: template/cordova/lib/build.js --- @@ -229,11 +268,66 @@ function buildTargets(msbuild, config) { if (msbuild.version == '4.

[GitHub] cordova-windows pull request: CB-9359: Adds support for .appxbundl...

2015-07-21 Thread nikhilkh
Github user nikhilkh commented on a diff in the pull request: https://github.com/apache/cordova-windows/pull/102#discussion_r35133250 --- Diff: template/cordova/lib/build.js --- @@ -229,11 +268,66 @@ function buildTargets(msbuild, config) { if (msbuild.version == '4

RE: [CI] iOS build breaking

2015-07-21 Thread Nikhil Khandelwal
There is another JIRA that is needed, that the latest version of the 'camera' plugin cannot work against released version of iOS. If that's by design (which is breaking and unfortunate) - the plugin.xml needs to specify that. Thanks, Nikhil -Original Message- From: Dmitry Blotsky [mail

[GitHub] cordova-windows pull request: CB-9359: Adds support for .appxbundl...

2015-07-21 Thread muratsu
Github user muratsu commented on a diff in the pull request: https://github.com/apache/cordova-windows/pull/102#discussion_r35132724 --- Diff: template/cordova/lib/build.js --- @@ -134,6 +141,12 @@ function parseAndValidateArgs(argv) { config.phone = args.phone ? true :

RE: [DISCUSS] Website Repo

2015-07-21 Thread Nikhil Khandelwal
'Cordova' github org is good for committers, but it's unclear we have the right basis (CLAs etc.) for accepting contributions there. Even though Apache org does not provide us with some features like labels (and that might change soon), keeping it under that org might be a good path forward.

[GitHub] cordova-windows pull request: CB-9283: Add support for Windows 10 ...

2015-07-21 Thread muratsu
Github user muratsu commented on the pull request: https://github.com/apache/cordova-windows/pull/96#issuecomment-123413943 lgtm --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature e

[GitHub] cordova-windows pull request: CB-9235 Adds more checks based on th...

2015-07-21 Thread robpaveza
Github user robpaveza commented on the pull request: https://github.com/apache/cordova-windows/pull/92#issuecomment-123413927 When I run this branch on my local, I get an npm test failure for check_reqs.spec.js, failing to find config.xml in cordova-windows root. --- If your project

[GitHub] cordova-windows pull request: CB-9235 Adds more checks based on th...

2015-07-21 Thread robpaveza
Github user robpaveza commented on the pull request: https://github.com/apache/cordova-windows/pull/92#issuecomment-123412166 I'm checking out how it works with #102 . --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

Re: [DISCUSS] Website Repo

2015-07-21 Thread Brian LeRoux
On Tue, Jul 21, 2015 at 2:09 AM Dmitry Blotsky wrote: > Hey folks, > > In lieu of the changes coming to the docs and the website design proposed > at the hangout, I’d like to consolidate our docs, blog, and website under > one Git repo. Right now we have some code in several Git repos (docs, blog

[GitHub] cordova-windows pull request: CB-9159 Fix Windows Phone 8.1 deploy...

2015-07-21 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-windows/pull/91 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cordova-windows pull request: CB-9159 Fix Windows Phone 8.1 deploy...

2015-07-21 Thread vladimir-kotikov
Github user vladimir-kotikov commented on the pull request: https://github.com/apache/cordova-windows/pull/91#issuecomment-123306596 LGTM, merging. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] cordova-windows pull request: CB-9239 Fixes issue with windows pre...

2015-07-21 Thread vladimir-kotikov
Github user vladimir-kotikov commented on the pull request: https://github.com/apache/cordova-windows/pull/99#issuecomment-123304958 @robpaveza, ping --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does no

[GitHub] cordova-plugin-camera pull request: Retain ascpect ratio in resize...

2015-07-21 Thread benjamineberle
Github user benjamineberle closed the pull request at: https://github.com/apache/cordova-plugin-camera/pull/32 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or

[DISCUSS] Website Repo

2015-07-21 Thread Dmitry Blotsky
Hey folks, In lieu of the changes coming to the docs and the website design proposed at the hangout, I’d like to consolidate our docs, blog, and website under one Git repo. Right now we have some code in several Git repos (docs, blog posts), and some in the SVN repo (website itself). I’d like t

Re: [CI] iOS build breaking

2015-07-21 Thread Dmitry Blotsky
It seems that Mobilespec is using NPM plugins instead of the local ones: https://ci.apache.org/builders/cordova-ios/builds/50/steps/creating-mobilespec-app/logs/stdio. And this is because ‘cordova plugin add’ is not respecting the ‘--searchpath’ argument. Bug reopened: CB-8993. Any idea how thi

Re: [DISCUSS] CI Hardware

2015-07-21 Thread Dmitry Blotsky
Hey Jesse, The requirements are: the machine should be able to access the Internet, and the connected devices should be able to access the Internet. You could even place the machine on a connection isolated from your corporate network (like the guest wifi) if you need to. The other requirement