Re: [Vote] Tools Release Sep 17th (Take 2)

2015-09-24 Thread Carlos Santana
Thank you Steve for keeping the train running Choo Choo ... On Thu, Sep 24, 2015 at 9:34 PM Steven Gill wrote: > anytime :) > > On Thu, Sep 24, 2015 at 4:21 PM, Sergey Grebnov (Akvelon) < > v-seg...@microsoft.com> wrote: > > > Thank you guys! > > > > -Sergey > > -Original Message- > > Fr

Re: [Vote] Tools Release Sep 17th (Take 2)

2015-09-24 Thread Steven Gill
anytime :) On Thu, Sep 24, 2015 at 4:21 PM, Sergey Grebnov (Akvelon) < v-seg...@microsoft.com> wrote: > Thank you guys! > > -Sergey > -Original Message- > From: Steven Gill [mailto:stevengil...@gmail.com] > Sent: Thursday, September 24, 2015 3:09 PM > To: dev@cordova.apache.org > Subject:

Re: [Discuss] Cordova-common release

2015-09-24 Thread Carlos Santana
Sorry if I take my inner purist theoretical developer out for a minute :-) The point of having a "node module" it should be explicit and small, meaning that should be easy to name in a way that describes what it is or do. Take into account that "node module" is not the same as a "npm package" Ha

Re: Cordova website redesign

2015-09-24 Thread Carlos Santana
Hi Ryan What about adding "Plugin Specification" after "Building Plugin" in the navigation menu? see here http://snag.gy/zRvMx.jpg On Thu, Sep 24, 2015 at 6:03 PM Ryan J. Salva wrote: > Ben, Wow. I really dig the logo! The new typeface looks pretty sweet with > both the flat and illustrated r

[GitHub] cordova-android pull request: Current Cordova-Android 5.0 changes.

2015-09-24 Thread infil00p
Github user infil00p commented on a diff in the pull request: https://github.com/apache/cordova-android/pull/220#discussion_r40387288 --- Diff: framework/src/org/apache/cordova/CordovaInterfaceImpl.java --- @@ -161,4 +164,35 @@ public ActivityResultHolder(int requestCode, int resul

[GitHub] cordova-android pull request: Current Cordova-Android 5.0 changes.

2015-09-24 Thread nikhilkh
Github user nikhilkh commented on a diff in the pull request: https://github.com/apache/cordova-android/pull/220#discussion_r40386990 --- Diff: framework/src/org/apache/cordova/CordovaInterfaceImpl.java --- @@ -161,4 +164,35 @@ public ActivityResultHolder(int requestCode, int resul

[GitHub] cordova-android pull request: Current Cordova-Android 5.0 changes.

2015-09-24 Thread nikhilkh
Github user nikhilkh commented on a diff in the pull request: https://github.com/apache/cordova-android/pull/220#discussion_r40386760 --- Diff: framework/src/org/apache/cordova/CordovaInterface.java --- @@ -69,4 +69,7 @@ Licensed to the Apache Software Foundation (ASF) under one

[GitHub] cordova-android pull request: Current Cordova-Android 5.0 changes.

2015-09-24 Thread nikhilkh
Github user nikhilkh commented on a diff in the pull request: https://github.com/apache/cordova-android/pull/220#discussion_r40386599 --- Diff: framework/project.properties --- @@ -10,7 +10,7 @@ # Indicates whether an apk should be generated for each density. split.density

RE: [Vote] Tools Release Sep 17th (Take 2)

2015-09-24 Thread Sergey Grebnov (Akvelon)
Thank you guys! -Sergey -Original Message- From: Steven Gill [mailto:stevengil...@gmail.com] Sent: Thursday, September 24, 2015 3:09 PM To: dev@cordova.apache.org Subject: Re: [Vote] Tools Release Sep 17th (Take 2) Done. On Thu, Sep 24, 2015 at 2:32 PM, Carlos Santana wrote: > Do it

[GitHub] cordova-plugin-media pull request: Cordova-Android 5.0/Marshmallow...

2015-09-24 Thread infil00p
GitHub user infil00p opened a pull request: https://github.com/apache/cordova-plugin-media/pull/71 Cordova-Android 5.0/Marshmallow Updates This one had to be re-written because of our workflow. The PHONE_STATE permission needs to be removed in favour of AudioFocus You can merge th

[GitHub] cordova-plugin-geolocation pull request: Creation of the Geolocati...

2015-09-24 Thread infil00p
GitHub user infil00p opened a pull request: https://github.com/apache/cordova-plugin-geolocation/pull/52 Creation of the Geolocation Plugin entirely for permissions handling on Marshmallow. This is an ugly hack, but it works. It may make sense for a webview to come packaged with a

[GitHub] cordova-plugin-contacts pull request: Changes for Cordova Android ...

2015-09-24 Thread infil00p
GitHub user infil00p opened a pull request: https://github.com/apache/cordova-plugin-contacts/pull/78 Changes for Cordova Android 5.0/Marshmallow Functionality This includes a refactor since many of the methods had to be pulled out of the if/else statement. You can merge this pull

[GitHub] cordova-plugin-camera pull request: Marshmallow/Cordova Android 5....

2015-09-24 Thread infil00p
GitHub user infil00p opened a pull request: https://github.com/apache/cordova-plugin-camera/pull/125 Marshmallow/Cordova Android 5.0.x compatibility changes You can merge this pull request into a Git repository by running: $ git pull https://github.com/infil00p/cordova-plugin-

[Announce] Cordova@5.3.3 released!

2015-09-24 Thread Steven Gill
Cordova-cli@5.3.3, cordova-lib@5.3.3, plugman@1.0.4 http://cordova.apache.org/news/2015/09/22/tools-release.html https://twitter.com/apachecordova/status/647171426147954688

Re: [Vote] Tools Release Sep 17th (Take 2)

2015-09-24 Thread Steven Gill
Done. On Thu, Sep 24, 2015 at 2:32 PM, Carlos Santana wrote: > Do it ! > This quick release is not being quick > > - Carlos > Sent from my iPhone > > > On Sep 24, 2015, at 5:24 PM, Steven Gill wrote: > > > > Can we switch this to latest and publish the blog post? If you want, I > can > > do it.

Re: [Android] XDA is reporting that Marshmallow is out October 5th on TELUS

2015-09-24 Thread Joe Bowser
As requested, here's the pull request for Cordova-Android. This should still work with the other smores plugins. https://github.com/apache/cordova-android/pull/220 On Thu, Sep 24, 2015 at 2:51 PM, Joe Bowser wrote: > After looking at the failure of what happened on 5.0.x, I'm just going to > d

[GitHub] cordova-android pull request: Current Cordova-Android 5.0 changes.

2015-09-24 Thread infil00p
GitHub user infil00p opened a pull request: https://github.com/apache/cordova-android/pull/220 Current Cordova-Android 5.0 changes. These are the changes to Cordova-Android that make it a 5.0 change. This is a very minor major release, since we're literally just adding the ability

RE: Cordova website redesign

2015-09-24 Thread Ryan J. Salva
Ben, Wow. I really dig the logo! The new typeface looks pretty sweet with both the flat and illustrated robot. It preserves a strong sense of continuity with the current logo, but... I dunno. Looks a little more modern. I'd totally be down with integrating it into the website redesign. Are there

Re: [Android] XDA is reporting that Marshmallow is out October 5th on TELUS

2015-09-24 Thread Joe Bowser
After looking at the failure of what happened on 5.0.x, I'm just going to delete it, because rebasing master on a topic branch is a terribly stupid idea, and that's exactly what happened with that. I'm going to try and make the changes prettier, and hopefully they'll still work. On Thu, Sep 24, 2

Re: [Android] XDA is reporting that Marshmallow is out October 5th on TELUS

2015-09-24 Thread Carlos Santana
+1 on major version bump for plugins. The API signature didn't change but behavior and support did. - Carlos Sent from my iPhone > On Sep 24, 2015, at 5:31 PM, Joe Bowser wrote: > > The 5.0 branch already has all the commits from the topic branch on github. > > On Thu, Sep 24, 2015 at 2:21

Re: [Vote] Tools Release Sep 17th (Take 2)

2015-09-24 Thread Carlos Santana
Do it ! This quick release is not being quick - Carlos Sent from my iPhone > On Sep 24, 2015, at 5:24 PM, Steven Gill wrote: > > Can we switch this to latest and publish the blog post? If you want, I can > do it. Just let me know. > > -Steve > > On Tue, Sep 22, 2015 at 7:34 PM, Sergey Grebnov

Re: [Android] XDA is reporting that Marshmallow is out October 5th on TELUS

2015-09-24 Thread Joe Bowser
The 5.0 branch already has all the commits from the topic branch on github. On Thu, Sep 24, 2015 at 2:21 PM, Nikhil Khandelwal wrote: > +1 to major version rev. for plugins. It also is a signal these plugins > will not work with any previous version of cordova. > > For reviewing changes, can you

Re: [Vote] Tools Release Sep 17th (Take 2)

2015-09-24 Thread Steven Gill
Can we switch this to latest and publish the blog post? If you want, I can do it. Just let me know. -Steve On Tue, Sep 22, 2015 at 7:34 PM, Sergey Grebnov (Akvelon) < v-seg...@microsoft.com> wrote: > The vote has now closed. The results are: > > Positive Binding Votes: 3 > > Carlos Santana > Vla

RE: [Android] XDA is reporting that Marshmallow is out October 5th on TELUS

2015-09-24 Thread Nikhil Khandelwal
+1 to major version rev. for plugins. It also is a signal these plugins will not work with any previous version of cordova. For reviewing changes, can you submit a PR perhaps from your topic branch to apache/cordova-android 5.x-dev branch? It's hard to review and comment on branch diffs - PRs a

[GitHub] cordova-lib pull request: CB-6462 CB-6026 Orientation preference n...

2015-09-24 Thread christoph-neumann
Github user christoph-neumann commented on the pull request: https://github.com/apache/cordova-lib/pull/207#issuecomment-143053886 @shazron Done. Thanks for looking into it! https://issues.apache.org/jira/browse/CB-9703 --- If your project is set up for it, you can reply to this ema

[GitHub] cordova-lib pull request: CB-6462 CB-6026 Orientation preference n...

2015-09-24 Thread shazron
Github user shazron commented on the pull request: https://github.com/apache/cordova-lib/pull/207#issuecomment-143048648 Hmm never did thought of that scenario. Not sure how we would tackle this -- I suggest filing a feature request at issues.cordova.io so we can discuss. My

[GitHub] cordova-lib pull request: CB-9371: Fix prepare deleting orientatio...

2015-09-24 Thread christoph-neumann
Github user christoph-neumann commented on the pull request: https://github.com/apache/cordova-lib/pull/260#issuecomment-143048429 This is a needed fix! Why has this not been merged? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[Android] XDA is reporting that Marshmallow is out October 5th on TELUS

2015-09-24 Thread Joe Bowser
Hey So, this is really weird. TELUS, just leaked that the OTA for the Nexus 5 and Nexus 6 is Oct 5. http://www.xda-developers.com/xda-external-link/telus-says-android-6-0-ota-update-starts-on-october-5th/ I don't like to rush things, but if people could review all the Smores changes while I fin

[GitHub] cordova-lib pull request: CB-6462 CB-6026 Orientation preference n...

2015-09-24 Thread christoph-neumann
Github user christoph-neumann commented on the pull request: https://github.com/apache/cordova-lib/pull/207#issuecomment-143042865 How are we supposed to set iPhone and iPad differently now? My app is portrait only for iPhones, but portrait and landscape for iPads. We need a way to ha

Re: Cordova website redesign

2015-09-24 Thread Ben Sperry
I really like where this update is going, and what it signals to the community: Cordova is a legitimate, modern tech solution that's still very much alive and growing. The website look/feel has a lot of confidence, love it! I'm curious what thoughts are around a Cordova logo update itself. I put t

Re: CVE-2015-5204: HTTP header injection vulnerability in Apache Cordova File Transfer Plugin for Android

2015-09-24 Thread Shazron
CVE-2015-5204: HTTP header injection vulnerability in Apache Cordova File Transfer Plugin for Android Severity: Medium Vendor: The Apache Software Foundation Versions Affected: Cordova Android File Transfer Plugin (1.2.1 and below) Description: Android applications built with the Cordova f

[GitHub] cordova-medic pull request: CB-9660 Kill wp8.1 emulator in medic-k...

2015-09-24 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-medic/pull/66 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature i

Re: CVE-2015-5204: HTTP header injection vulnerability in Apache Cordova File Transfer Plugin for Android

2015-09-24 Thread Shazron
Will re-send to bugtraq On Tue, Sep 22, 2015 at 11:22 AM, Joe Bowser wrote: > CVE-2015-5204: HTTP header injection vulnerability in Apache Cordova File > Transfer Plugin for Android > > Severity: > Medium > > Vendor: > The Apache Software Foundation > > Versions Affected: > Cordova Android Fil

[GitHub] cordova-medic pull request: CB-9660 Kill wp8.1 emulator in medic-k...

2015-09-24 Thread dblotsky
Github user dblotsky commented on the pull request: https://github.com/apache/cordova-medic/pull/66#issuecomment-143029488 LGTM though. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this fe

[GitHub] cordova-medic pull request: CB-9660 Kill wp8.1 emulator in medic-k...

2015-09-24 Thread dblotsky
Github user dblotsky commented on the pull request: https://github.com/apache/cordova-medic/pull/66#issuecomment-143029400 In the future we can probably do something like inspect the running processes, find the specific one we want to kill, and then kill it by PID. --- If your projec

Re: Introduction: Timo Tiuraniemi

2015-09-24 Thread Shazron
Welcome! We love new contributors :) Join us on slack.cordova.io as well On Thu, Sep 24, 2015 at 1:24 AM, Timo Tiuraniemi wrote: > Hi, > > I'd like to introduce myself: my name is Timo Tiuraniemi (ttiurani) and I'm > a full stack developer writing Cordova apps for Android and iOS, and would > lik

Re: Cordova website redesign

2015-09-24 Thread Frederico Galvão
Looks great indeed, nice job! One thing I noticed is that https://projects.apache.org/project.html?cordova seems very outdated. 2015-09-23 22:49 GMT-03:00 Carlos Santana : > This looks great. > Can you add a sub page link in the navigation column to this page? > > > http://cordova.apache.org/use

[Android] Marshmallow Update: Media kind-of works

2015-09-24 Thread Joe Bowser
Hey I got media mostly working with the new permissions, but I think that we're going to have to figure out the AudioFocus issue. Right now, when you play music from the media plugin and you receive a phone call, the media plugin should pause the audio in favour of the phone ringing, and then pla

[Discuss] Cordova-common release

2015-09-24 Thread Sergey Grebnov (Akvelon)
Hi guys - we've decided to combine shared logic as cordova-common module and publish it separately (read [1] for more details). Corresponding change has landed to master[2] on last week so I'm wondering if we should release this module and then update LIB to rely on it (similar to cordova-serve)

[GitHub] cordova-ios pull request: CB-9698 Add rsync error handling in ios ...

2015-09-24 Thread nikhilkh
Github user nikhilkh commented on the pull request: https://github.com/apache/cordova-ios/pull/168#issuecomment-142978524 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature ena

Re: Introduction: Timo Tiuraniemi

2015-09-24 Thread Simon MacDonald
Someday I would love for us not to welcome a new contributor to the project as a joke. Just completely shun them but today is not that day. Welcome Timo! Simon Mac Donald http://hi.im/simonmacdonald On Thu, Sep 24, 2015 at 8:48 AM, Carlos Santana wrote: > welcome > > > On Thu, Sep 24, 2015 at

[GitHub] cordova-ios pull request: CB-9690 Can't submit iPad apps to the Ap...

2015-09-24 Thread macdonst
Github user macdonst commented on the pull request: https://github.com/apache/cordova-ios/pull/167#issuecomment-142941572 Yes, that is the intention. Comments on the JIRA ticket don't show up in this PR but that is our plan. --- If your project is set up for it, you can reply to this

[GitHub] cordova-android pull request: Fixed CB-9697 Cordova emulate for An...

2015-09-24 Thread mleoking
Github user mleoking commented on the pull request: https://github.com/apache/cordova-android/pull/219#issuecomment-142937008 @daserge Thanks for letting me know about [the commit](https://github.com/apache/cordova-android/commit/bf57aa1df061b3fcd429bb8d673de02bcb26f872#diff-257a87acd5

Re: Introduction: Timo Tiuraniemi

2015-09-24 Thread Carlos Santana
welcome On Thu, Sep 24, 2015 at 4:34 AM julio cesar sanchez wrote: > Welcome! > > 2015-09-24 10:24 GMT+02:00 Timo Tiuraniemi : > > > Hi, > > > > I'd like to introduce myself: my name is Timo Tiuraniemi (ttiurani) and > I'm > > a full stack developer writing Cordova apps for Android and iOS, and

RE: Buildbot: buildslave cordova-windows-slave was lost

2015-09-24 Thread Alexander Sorokin (Akvelon)
The slave brought down to debug weird test run failure we occasionally get on windows. Estimated downtime is ~4 hours. Sincerely, Alexander Sorokin -Original Message- From: build...@apache.org [mailto:build...@apache.org] Sent: Thursday, September 24, 2015 2:08 PM To: dev@cordova.apach

Buildbot: buildslave cordova-windows-slave was lost

2015-09-24 Thread buildbot
The Buildbot working for 'ASF Buildbot' has noticed that the buildslave named cordova-windows-slave went away It last disconnected at Thu Sep 24 11:02:53 2015 (buildmaster-local time) The admin on record (as reported by BUILDSLAVE:info/admin) was 'Dmitry Blotsky '. Sincerely, The Buildbot htt

[GitHub] cordova-android pull request: Fixed CB-9697 Cordova emulate for An...

2015-09-24 Thread daserge
Github user daserge commented on the pull request: https://github.com/apache/cordova-android/pull/219#issuecomment-142880086 Is `-d` just about reinstalling an app with version less than the installed one has? --- If your project is set up for it, you can reply to this email and have

[GitHub] cordova-android pull request: Fixed CB-9697 Cordova emulate for An...

2015-09-24 Thread daserge
Github user daserge commented on the pull request: https://github.com/apache/cordova-android/pull/219#issuecomment-142878060 @mleoking Thanks for the explanation! I think `-d` was also being removed in master before [this commit](https://github.com/apache/cordova-android/commit/bf5

[GitHub] cordova-ios pull request: CB-9698 Add rsync error handling in ios ...

2015-09-24 Thread daserge
GitHub user daserge opened a pull request: https://github.com/apache/cordova-ios/pull/168 CB-9698 Add rsync error handling in ios copy-www-build-step.js [Jira issue](https://issues.apache.org/jira/browse/CB-9698) You can merge this pull request into a Git repository by running:

[GitHub] cordova-android pull request: Fixed CB-9697 Cordova emulate for An...

2015-09-24 Thread mleoking
Github user mleoking commented on the pull request: https://github.com/apache/cordova-android/pull/219#issuecomment-142874106 @daserge If you visit https://github.com/apache/cordova-android/blob/4.1.x/bin/templates/cordova/lib/device.js in the `4.1.x branch`, you will see that `device

[GitHub] cordova-android pull request: Fixed CB-9697 Cordova emulate for An...

2015-09-24 Thread daserge
Github user daserge commented on the pull request: https://github.com/apache/cordova-android/pull/219#issuecomment-142867588 @mleoking thanks! It should be fixed in `device.js` as well. I believe this is a duplicate of #216 though. --- If your project is set up for it, you can

[GitHub] cordova-android pull request: Fixed CB-9697 Cordova emulate for An...

2015-09-24 Thread mleoking
GitHub user mleoking opened a pull request: https://github.com/apache/cordova-android/pull/219 Fixed CB-9697 Cordova emulate for Android versions 4.1.1 does not work After running 'cordova emulate android' the apk is not installed & shown on the emulator despite the log shows the ap

[GitHub] cordova-android pull request: CB-9696: Add possibility to use non-...

2015-09-24 Thread ttiurani
GitHub user ttiurani opened a pull request: https://github.com/apache/cordova-android/pull/218 CB-9696: Add possibility to use non-immersive fullscreen in all Andro… …id versions When setting the new preference "fullscreen-immersive" to false like this:

Re: Introduction: Timo Tiuraniemi

2015-09-24 Thread julio cesar sanchez
Welcome! 2015-09-24 10:24 GMT+02:00 Timo Tiuraniemi : > Hi, > > I'd like to introduce myself: my name is Timo Tiuraniemi (ttiurani) and I'm > a full stack developer writing Cordova apps for Android and iOS, and would > like to contribute to Cordova. > > I signed the CLA and will no proceed to try

[GitHub] cordova-plugin-dialogs pull request: add CSS class to prompt div f...

2015-09-24 Thread snowhow
GitHub user snowhow opened a pull request: https://github.com/apache/cordova-plugin-dialogs/pull/61 add CSS class to prompt div for windows platform As the prompt dialog does not show correctly in our application, we need to style the `div` wrapper element. With this simple change w

Introduction: Timo Tiuraniemi

2015-09-24 Thread Timo Tiuraniemi
Hi, I'd like to introduce myself: my name is Timo Tiuraniemi (ttiurani) and I'm a full stack developer writing Cordova apps for Android and iOS, and would like to contribute to Cordova. I signed the CLA and will no proceed to try to do my first pull request for Android Cordova concerning the new

[GitHub] cordova-medic pull request: CB-9660 Kill wp8.1 emulator in medic-k...

2015-09-24 Thread alsorokin
Github user alsorokin commented on the pull request: https://github.com/apache/cordova-medic/pull/66#issuecomment-142846186 @dblotsky yep, same process. I agree that this could be a problem if we need to debug a windows phone 8.1 build and it is followed by wp8 build which kills th

[GitHub] cordova-medic pull request: CB-8936 Tweaking windows log gathering...

2015-09-24 Thread alsorokin
Github user alsorokin closed the pull request at: https://github.com/apache/cordova-medic/pull/64 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the featur

[GitHub] cordova-ios pull request: CB-9690 Can't submit iPad apps to the Ap...

2015-09-24 Thread tripodsan
Github user tripodsan commented on the pull request: https://github.com/apache/cordova-ios/pull/167#issuecomment-142838642 I think this should be revisited, once the multi-tasking support is enabled (CB-9161) --- If your project is set up for it, you can reply to this email and have