[GitHub] cordova-android pull request: CB-9608 cordova-android no longer bu...

2015-09-29 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-android/pull/217 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

RE: [Discuss] Cordova-common release

2015-09-29 Thread Vladimir Kotikov (Akvelon)
Agree with you, guys. Unfortunately, the underlying modules in `cordova-common` are not really atomic, since they depending on each other. For example ConfigParser requires `xmlHelpers`, `events` and `CordovaError` as a dependencies. Reworking them to be truly separated might be sort of

[GitHub] cordova-lib pull request: CB-9354 Fix array merging with complex i...

2015-09-29 Thread vladimir-kotikov
Github user vladimir-kotikov commented on the pull request: https://github.com/apache/cordova-lib/pull/256#issuecomment-143984151 @gregavola, this change has not released yet, so you have to wait for next cordova release. As an option you could try to clone this repository

[GitHub] cordova-android pull request: CB-9608 cordova-android no longer bu...

2015-09-29 Thread vladimir-kotikov
Github user vladimir-kotikov commented on the pull request: https://github.com/apache/cordova-android/pull/217#issuecomment-143960093 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] cordova-plugin-media pull request: Streaming & Background threadin...

2015-09-29 Thread leon
Github user leon commented on the pull request: https://github.com/apache/cordova-plugin-media/pull/62#issuecomment-143993324 +1 Please merge this :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

Re: Cordova Face to Face Meeting

2015-09-29 Thread Carlos Santana
Thanks Ryan we can have sunny side eggs in the cloud room. I can bring bagels Looking forward :-) On Tue, Sep 29, 2015 at 1:38 AM Ryan J. Salva wrote: > Carlos, > > We'd be happy to put our heads in the cloud with you ;-) > > Maybe we can schedule "breakfast in the cloud

[GitHub] cordova-plugin-dialogs pull request: set cancelable to false by de...

2015-09-29 Thread kavka3
Github user kavka3 commented on the pull request: https://github.com/apache/cordova-plugin-dialogs/pull/56#issuecomment-144113273 ++ --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] cordova-plugin-contacts pull request: custom label for phoneNumber

2015-09-29 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-contacts/pull/67 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

Re: Understanding the Cordova developer better - Cordova developer survey

2015-09-29 Thread Raymond Camden
Have you tweeted about it yet? (Will help with an RT.) On Tue, Sep 29, 2015 at 5:11 PM, Carlos Santana wrote: > I'm with Joe on actionable items and with Jesse on plugins area. > What plugins you have used, which plugins have giving you problems, how > often do you upgrade

Re: cordova-plugin-whitelist ios issue

2015-09-29 Thread Tommy Williams
Maybe less terse? It’s a little confronting, like you have messed something up and actually need to figure out how to update to 4.0.0-dev :/ On 30 September 2015 at 10:14:57, Steven Gill (stevengil...@gmail.com) wrote: It is just a warning though. Shouldn't break any builds. This will become

Re: Understanding the Cordova developer better - Cordova developer survey

2015-09-29 Thread Brian LeRoux
Surveys remind me of that Henry Ford quote. Doesn't hurt to do them but I would not take the responses too seriously or we will end up with a faster horse. ;) On Tue, Sep 29, 2015 at 10:39 PM Parashuram N wrote: > Hey, > > We have had multiple discussions on this mailing

Re: Understanding the Cordova developer better - Cordova developer survey

2015-09-29 Thread Joe Bowser
I'd like to make it the last question, and I'd change it to general feedback. Spinning it so negative will just get negative responses IMO. We can just read JIRA to get that. On Tue, Sep 29, 2015 at 1:54 PM, Parashuram N wrote: > @Joe - that is good feedback - I was not

RE: Understanding the Cordova developer better - Cordova developer survey

2015-09-29 Thread Parashuram N
I have not tweeted about it yet. I wanted to get feedback from the folks here - we are indeed getting good feedback. @Carlos, I have moved the open ended question to the bottom. About the plugin question, I am waiting for Jesse's response. -Original Message- From: Raymond Camden

Re: Understanding the Cordova developer better - Cordova developer survey

2015-09-29 Thread Jesse
Something like this? === Which of the following plugins do you use? Past or present, check all that apply : Battery StatusBar Camera Console Contacts Device Device Motion (Accelerometer) Device Orientation (Compass) Dialogs FileSystem File Transfer Geolocation Globalization InAppBrowser Media

Re: cordova-plugin-whitelist ios issue

2015-09-29 Thread Shazron
If you have cordova-ios and android 3.x you do not need cordova-plugin-whitelist *at all*. It is only for cordova-ios and android 4.x. The 3.x series have built in whitelists. On Tue, Sep 29, 2015 at 5:17 PM, Shazron wrote: > No its not a "rogue version".

Re: Understanding the Cordova developer better - Cordova developer survey

2015-09-29 Thread Joe Bowser
I think this is way too open ended. The first question shouldn't just be a giant area where users get to talk about how they hate the project, or the committers, or whatever. We get enough of that already. What we should do with this survey is try and narrow it down to actionable things that we

Re: Understanding the Cordova developer better - Cordova developer survey

2015-09-29 Thread Carlos Santana
I'm with Joe on actionable items and with Jesse on plugins area. What plugins you have used, which plugins have giving you problems, how often do you upgrade platforms and plugins. which plugin you are always getting that you wish should be part of cordova code (i.e push notifications, bluetooth,

cordova-plugin-whitelist ios issue

2015-09-29 Thread Nikhil Khandelwal
1. cordova create test 2. cordova platform add ios WARNING: Applications for platform ios can not be built on this OS - win32. Adding ios project... iOS project created with cordova-ios@3.9.1 Discovered plugin "cordova-plugin-whitelist" in config.xml. Installing to the project

RE: cordova-plugin-whitelist ios issue

2015-09-29 Thread Nikhil Khandelwal
I understand the warning w.r.t. plugins and android 5.0 as we will release android 5.0 along with the plugin update and there would be a path for people to resolve the warning. In this case, ios 4.0 is not even released and users have no way to work around this warning. We're getting feedback

Re: cordova-plugin-whitelist ios issue

2015-09-29 Thread Shazron
This is only happening because we have two engine requirements - cordova-android 4.x and cordova-ios 4.x. This is correct for cordova-plugin-whitelist. Like I mentioned before, cordova-android+ios 3.x *do not* require this plugin as it is built in. Perhaps this could be communicated better, but

Re: Understanding the Cordova developer better - Cordova developer survey

2015-09-29 Thread Jesse
I would add a : Select all the (core) plugins you have used. And maybe, a : Is there a plugin you wish existed? I agree that asking users what they want may lead to 'new coke' [1] Moving the opened ended question to last and letting users choose whether to use it to state what they love OR hate

[GitHub] cordova-docs pull request: Fixed the images on homepage and associ...

2015-09-29 Thread bgashler1
GitHub user bgashler1 opened a pull request: https://github.com/apache/cordova-docs/pull/364 Fixed the images on homepage and associated apps/tools showcase rules For some reason, it's showing a commit on Sept 17, 2015 in this PR. You probably already pulled that one in, so just

Re: cordova-plugin-whitelist ios issue

2015-09-29 Thread Steven Gill
It is just a warning though. Shouldn't break any builds. This will become more common once we release the new plugins which will require cordova-android 5.0+. Is the suggestion to remove the warning completely? On Tue, Sep 29, 2015 at 5:08 PM, Nikhil Khandelwal wrote:

RE: Cordova Face to Face Meeting

2015-09-29 Thread Parashuram N
I just created a form to get an idea of the people who will be attending the meeting - https://docs.google.com/forms/d/1peBvvVXocf8_Z-JzB12HwRd83YtFkMPITkpsLutqRxg/viewform Will help plan the capacity of the venue and other logistics. Please do fill it in if you have planned your travel. If

Re: cordova-plugin-whitelist ios issue

2015-09-29 Thread Shazron
"IMO we should never release a plugin which always emits a warning that cannot be resolved." There is nothing to resolve. The resolution is to ignore it. It's supposed to warn you, as it is working as expected. On Tue, Sep 29, 2015 at 5:19 PM, Nikhil Khandelwal wrote: >

[GitHub] cordova-plugin-contacts pull request: Windows phone contact picker...

2015-09-29 Thread purplecabbage
Github user purplecabbage commented on the pull request: https://github.com/apache/cordova-plugin-contacts/pull/51#issuecomment-144200424 Hey @Hurtyto Any update on this? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

RE: Understanding the Cordova developer better - Cordova developer survey

2015-09-29 Thread Parashuram N
@Joe - that is good feedback - I was not sure about it myself. Do we want to just remove the first question ? The reason I kept it open ended was to see what things people really say. What do you want to change it to ? -Original Message- From: Joe Bowser [mailto:bows...@gmail.com]

RE: Understanding the Cordova developer better - Cordova developer survey

2015-09-29 Thread Parashuram N
Makes sense - Moved the question to the very end. @Jesse - about the plugin, what do you want the exact question and its answer options to be ? Should we list all the core plugins ? Is this a good list - https://cordova.apache.org/docs/en/4.0.0/cordova_plugins_pluginapis.md.html ? Is it a lot

Re: Cordova Face to Face Meeting

2015-09-29 Thread Jesse
+1 for breakfast in the clouds My team is hiring! @purplecabbage risingj.com On Tue, Sep 29, 2015 at 1:51 PM, Parashuram N wrote: > I just created a form to get an idea of the people who will be attending > the meeting - >

[GitHub] cordova-plugin-contacts pull request: custom label for phoneNumber

2015-09-29 Thread purplecabbage
Github user purplecabbage commented on the pull request: https://github.com/apache/cordova-plugin-contacts/pull/67#issuecomment-144191524 I am closing this pr as it has conflicts, and un-does other commits. The discussion thread can be found here:

[GitHub] cordova-plugin-contacts pull request: Windows phone contact picker...

2015-09-29 Thread Hurtyto
Github user Hurtyto commented on the pull request: https://github.com/apache/cordova-plugin-contacts/pull/51#issuecomment-144287589 Still haven't. Couldn't find much time :( I hope that will do it soon. --- If your project is set up for it, you can reply to this email and have your

Re: cordova-plugin-whitelist ios issue

2015-09-29 Thread Shazron
This has nothing to do with cordova-ios being released. Think of it solely by the plugin's requirements: it requires cordova-android 4, and cordova-ios 4. I have cordova-android 4, so it installs. I have cordova-ios 3.9 so it doesn't, and it warns me. We *will* have this problem later with

[GitHub] cordova-docs pull request: Making Page Index Title Concrete

2015-09-29 Thread dblotsky
GitHub user dblotsky opened a pull request: https://github.com/apache/cordova-docs/pull/365 Making Page Index Title Concrete Removing the JS that sets the page index title, and instead setting the `title` attribute in the file's front matter. ### Justification It

RE: cordova-plugin-whitelist ios issue

2015-09-29 Thread Nikhil Khandelwal
I think the first version of the whitelist plugin was released without the corodva-ios 4.0 check, so that developers do not see this warning because cordova-ios 4.0 was not released. I agree with Tommy, that the wording of the warning seems to suggest there is a way for me to fix this issue:

Re: cordova-plugin-whitelist ios issue

2015-09-29 Thread Shazron
I don't agree. I still don't think you understand the issue. I realize you want to get "rid of the warnings" but there is really nothing to fix. Nothing at all. Users do not have to do anything, you don't have to do anything. If they have cordova-ios 3.x installed - ignore this warning. This

Re: cordova-plugin-whitelist ios issue

2015-09-29 Thread Carlos Santana
Here are my two cents, and I'm aware of the situation. publish a new version of cordova-plugin-whitelist that only contains the android code and only supports android platform (means to remove any ios code from the plugin) Currently the plugin is public and published on npm as latest, and it

Re: cordova-plugin-whitelist ios issue

2015-09-29 Thread Shazron
One solution is to add an tag with more information/clarification. On Tue, Sep 29, 2015 at 5:28 PM, Shazron wrote: > This is only happening because we have two engine requirements - > cordova-android 4.x and cordova-ios 4.x. This is correct for > cordova-plugin-whitelist. > >

Re: cordova-plugin-whitelist ios issue

2015-09-29 Thread Carlos Santana
In summary I proposed that we update the plugin with a version that only contains the android code. When we publish cordova-ios@4.0.0 then we publish a new version that contains the ios code and contains engine tag stating that it needs minimum cordova-ios@4.0.0 I'm OK if you want to have two

Re: cordova-plugin-whitelist ios issue

2015-09-29 Thread Tommy Williams
This. +1 On 30 September 2015 at 12:31:29, Carlos Santana (csantan...@gmail.com) wrote: In summary I proposed that we update the plugin with a version that only  contains the android code.  When we publish cordova-ios@4.0.0 then we publish a new version that  contains the ios code and contains

Re: [Discuss] Cordova-common release

2015-09-29 Thread Carlos Santana
Do we need to absolutely publish this to npm? Can we just include the dependency in the platform as a bundle dependency? We just need to update coho to npm install/link the cordoba-common package when doing a release of what ever component need it? (i.e. cordova-android) Will this get you what

[GitHub] cordova-plugin-contacts pull request: add JIRA issue tracker link

2015-09-29 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-contacts/pull/76 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] cordova-plugin-contacts pull request: Return rawId

2015-09-29 Thread purplecabbage
Github user purplecabbage commented on the pull request: https://github.com/apache/cordova-plugin-contacts/pull/68#issuecomment-144136865 Hey @manugb Sorry for the delay in looking at this. Can you point to where it says rawId should be returned, or explain why? Looking at the

RE: [Discuss] Cordova-common release

2015-09-29 Thread Steven Gill
Sounds good. Let's move forward On Sep 29, 2015 10:21 AM, "Nikhil Khandelwal" wrote: > +1. I understand the value of Carlos' proposal, but in the spirit of > moving forward with this which is fairly complicated refactor involving > multiple releases and repos, I would

[GitHub] cordova-plugin-contacts pull request: CB-8537

2015-09-29 Thread purplecabbage
GitHub user purplecabbage opened a pull request: https://github.com/apache/cordova-plugin-contacts/pull/79 CB-8537 Some refactoring, literally factored out repeated code. You can merge this pull request into a Git repository by running: $ git pull

[GitHub] cordova-plugin-contacts pull request: CB-8537

2015-09-29 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-contacts/pull/79 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] cordova-plugin-contacts pull request: CB-8537 Updated source to pa...

2015-09-29 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-contacts/pull/56 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if