Github user nikhilkh commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/311#discussion_r41231011
--- Diff: cordova-lib/package.json ---
@@ -40,14 +38,19 @@
"tar": "1.0.2",
"underscore": "1.7.0",
"unorm": "1.3.3",
-"
Github user vladimir-kotikov commented on the pull request:
https://github.com/apache/cordova-lib/pull/313#issuecomment-145759968
@stevengill, looks good :+1:
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your proje
doc folder comes from the Crowdin translation. I believe this was created
in main repository mainly as side-effect of same CrowdIn config file for
main docs and plugins.
As far as I aware these translation files was not popularized, althrough I
try translate them, since having our repository rules
Haha yeah - just ping the people in your company directory Carlos for
some advice :) Maybe they can even update the licenses just for you ;)
On Mon, Oct 5, 2015 at 7:43 PM, Carlos Santana wrote:
> Also express is sponsored by StrongLoop which I heard recently got acquired
> by a big company where
Sorry - that commit does not tell me anything. In that commit I see
files added to "doc" and I see files added to "docs".
But perusing the files now I see why I was confused: "doc" is the
translation for the README for the repo itself; docs is for the actual
documentation files.
On Mon, Oct 5, 2
Github user TimBarham commented on the pull request:
https://github.com/apache/cordova-lib/pull/314#issuecomment-145742256
No problem :smile:
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have t
Github user purplecabbage commented on the pull request:
https://github.com/apache/cordova-lib/pull/314#issuecomment-145741933
Great, thanks.
I love express, just wanted to be sure.
---
If your project is set up for it, you can reply to this email and have your
reply appear on G
Github user TimBarham commented on the pull request:
https://github.com/apache/cordova-lib/pull/314#issuecomment-145741275
It only impacts the `cordova run browser` command (which already runs on a
local node server) - it has no impact on how users might deploy their app when
targetin
Github user purplecabbage commented on the pull request:
https://github.com/apache/cordova-lib/pull/314#issuecomment-145737064
How does this impact the cordova-browser platform? Do browser targeting
apps now depend on express and node on the server? Or can they be deployed as
static s
I can ask the StrongLoop for their legal clearance and be done with it :-)
On Mon, Oct 5, 2015 at 10:41 PM Tim Barham wrote:
> > Now we are planning to add express as new npm dependency to cordova-cli,
> > brining with it 43 npm packages for us to clear on the next release of
> our
> > product.
Also express is sponsored by StrongLoop which I heard recently got acquired
by a big company where a bunch of cool engineer work at ;-p
On Mon, Oct 5, 2015 at 10:38 PM Carlos Santana wrote:
> Yeah, that was my question since I was aware of the heavy list of packages
> use by express was wonderin
> Now we are planning to add express as new npm dependency to cordova-cli,
> brining with it 43 npm packages for us to clear on the next release of our
> product.
Heh, sorry about that :). At least the good news is they all have well
documented licenses (apart from the one where you have to look
Yeah, that was my question since I was aware of the heavy list of packages
use by express was wondering any red flags that license check catch and
what was the outcome of further investigation.
I just also did a quick review and no red flags I saw. But again i'm not a
lawyer :-)
On Mon, Oct 5, 2
Oh, regarding the legal aspect...
I can 'coho check-license', and didn't encounter any issues. It flagged two
packages under express:
* 'ms' (a millisecond conversion utility) which has no license file or license
entry in package.json, but on investigation is released under the MIT license
(i
I did a quick on review with my limited on android native skills :-)
1. I think the file plugin is missing the engine tag, I saw the other's had
the plugin.xml with the engine tag added
2. Don't understand why cordova-android is concern with geolocation
permissions, it's like the web view checks a
Yeah... This is a philosophy of the Express guys - they keep packages really
small, and have more packages. Basically, their philosophy is that each package
should only define one discrete piece of functionality, in a single source
file. As soon as that file gets too big or there is a feeling th
It's docs
https://github.com/apache/cordova-docs/commit/89be0380ba2a80ccfde1d28387b4ed228e10a9f8
On Mon, Oct 5, 2015 at 6:08 PM Shazron wrote:
> https://github.com/apache/cordova-docs
>
> I think "doc" is a remnant of a prior re-factor and can be removed, maybe?
>
>
Sorry for all the typos, I blame Siri dictation taking ;-p
On Mon, Oct 5, 2015 at 9:47 PM Carlos Santana wrote:
> Hi I wanted to share some insight about the experience we had when we try
> to include the cordova cli, plugins, and platform with our IBM product
> MobileFirst Platform Foundation (
survey looks great, yes I agree let's send it now to see how much data we
collect by F2F time frame.
On Mon, Oct 5, 2015 at 9:22 PM Parashuram N wrote:
> Looks like the URL had a dot at the end. Here is the URL that worked for me
>
> https://apachecordovabot.typeform.com/to/BCc5co
>
> -Origi
Tim you realize that by bringing in "express" as a dependency to cordova
cli you are bringing a 43 other npm packages?
Did you or your team did a quick assessment on how healthy legally speaking
on the complete set of dependencies?
⛄ $ npm install express 1>/dev/null && find node_modules/express
Looks like the URL had a dot at the end. Here is the URL that worked for me
https://apachecordovabot.typeform.com/to/BCc5co
-Original Message-
From: Nikhil Khandelwal [mailto:nikhi...@microsoft.com]
Sent: Monday, October 5, 2015 3:21 PM
To: dev@cordova.apache.org
Subject: RE: Understand
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-plugin-splashscreen/pull/61
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-plugin-splashscreen/pull/44
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-plugin-splashscreen/pull/56
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-plugin-splashscreen/pull/62
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if
Github user stevengill commented on the pull request:
https://github.com/apache/cordova-lib/pull/313#issuecomment-145705106
@vladimir-kotikov switched to warnings and added some verbose output. Also
added a conversion step to fetch.js as it was needed in there since cordova-lib
calls
Please review and vote on this 1.0.0 release of cordova-serve by replying to
this email (and keep discussion on the DISCUSS thread).
Release issue: https://issues.apache.org/jira/browse/CB-9748
The archive has been published to dist/dev:
https://dist.apache.org/repos/dist/dev/cordova/CB-9748/
GitHub user purplecabbage opened a pull request:
https://github.com/apache/cordova-plugin-splashscreen/pull/62
CB-8875 FadeSplashScreen was not fading
fixes some weak/strong self identity + confidence issues
You can merge this pull request into a Git repository by running:
$ g
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-lib/pull/312
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user TimBarham commented on the pull request:
https://github.com/apache/cordova-lib/commit/932ad578589d1c825fa57f330dafd3092f193e3c#commitcomment-13603467
Hey @vladimir-kotikov - you should probably bump version in master to
`5.3.3-dev`, right?
---
If your project is set up f
Thanks for all the input! Here's the final public facing URL:
https://apachecordovabot.typeform.com/to/BCc5co.
It will be great to get some of this data before the F2F meeting. Let's all
tweet about it, post it on slack etc.
In couple of days we can see if we can want to make more tweaks to th
Github user csantanapr commented on a diff in the pull request:
https://github.com/apache/cordova-coho/pull/95#discussion_r41204416
--- Diff: src/create-verify-archive.js ---
@@ -76,6 +77,49 @@ exports.createCommand = function*(argv) {
var absOutDir = path.resolve(outDir);
https://github.com/apache/cordova-docs
I think "doc" is a remnant of a prior re-factor and can be removed, maybe?
-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apac
Merging soon, unless there are comments.
https://github.com/apache/cordova-lib/pull/312
-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org
GitHub user ogoguel opened a pull request:
https://github.com/apache/cordova-lib/pull/315
CB-9747 Fix Android Parser
Fix parser error if the activity name refers a full package class, instead
of just the class
Added tests
You can merge this pull request into a Git repository b
Github user shazron commented on the pull request:
https://github.com/apache/cordova-lib/pull/312#issuecomment-145671308
Hmm one problem that I can see is, this assumes the last item to "clobber"
the ATS entry is the last one standing. There is no merge strategy. For example:
```
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-lib/pull/314
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user daserge commented on a diff in the pull request:
https://github.com/apache/cordova-coho/pull/95#discussion_r41180911
--- Diff: src/create-verify-archive.js ---
@@ -76,6 +77,49 @@ exports.createCommand = function*(argv) {
var absOutDir = path.resolve(outDir);
I was screwing up the scope, sorry.
We should be initializing it with the permissions in the constructor. The
purpose of it is for the Java API. So, if we have a plugin dependency that
needs to access the permissions of the parent plugin somehow, they can just
request the permissions instead of
I'd rather we bump the major and get out of 0.x.x land.
On Oct 5, 2015 9:58 AM, "Tim Barham" wrote:
> If the version is 0.x.x, then bumping the minor version is treated as a
> breaking change (by npm/semver) - the idea is that until version 1.0.0,
> things are still in flux.
>
> That said, I'm ha
Sorry for not responding earlier. I like where this is going. I have a bunch of
comments on the PRs.
I have some confusion around how CordovaPlugin has a protected field
'permissions' and what a derived CordovaPlugin is supposed to do with it. None
of our core plugins seem to use it.
Thanks,
N
Github user nikhilkh commented on a diff in the pull request:
https://github.com/apache/cordova-android/pull/223#discussion_r41171305
--- Diff: framework/src/org/apache/cordova/CordovaPlugin.java ---
@@ -40,6 +42,7 @@ Licensed to the Apache Software Foundation (ASF) under one
Github user nikhilkh commented on a diff in the pull request:
https://github.com/apache/cordova-android/pull/223#discussion_r41170824
--- Diff: framework/src/org/apache/cordova/CordovaPlugin.java ---
@@ -40,6 +42,7 @@ Licensed to the Apache Software Foundation (ASF) under one
Github user nikhilkh commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-file/pull/135#discussion_r41170122
--- Diff: src/android/FileUtils.java ---
@@ -65,9 +69,27 @@ Licensed to the Apache Software Foundation (ASF) under
one
public static in
Github user nikhilkh commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-media/pull/71#discussion_r41170726
--- Diff: src/android/AudioHandler.java ---
@@ -55,6 +59,16 @@ Licensed to the Apache Software Foundation (ASF) under
one
private int o
Github user nikhilkh commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-media/pull/71#discussion_r41170559
--- Diff: src/android/AudioHandler.java ---
@@ -55,6 +59,16 @@ Licensed to the Apache Software Foundation (ASF) under
one
private int o
Github user nikhilkh commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-contacts/pull/78#discussion_r41170319
--- Diff: src/android/ContactManager.java ---
@@ -48,13 +54,38 @@ Licensed to the Apache Software Foundation (ASF) under
one
public
Github user nikhilkh commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-geolocation/pull/53#discussion_r41169794
--- Diff: src/android/Geolocation.java ---
@@ -0,0 +1,97 @@
+/*
+ Licensed to the Apache Software Foundation (ASF) under one
Github user nikhilkh commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-geolocation/pull/53#discussion_r41169177
--- Diff: src/android/Geolocation.java ---
@@ -0,0 +1,97 @@
+/*
+ Licensed to the Apache Software Foundation (ASF) under one
If the version is 0.x.x, then bumping the minor version is treated as a
breaking change (by npm/semver) - the idea is that until version 1.0.0, things
are still in flux.
That said, I'm happy to call it 1.0.0 if that's preferable.
-Original Message-
From: Steven Gill [mailto:stevengil...
Github user nikhilkh commented on a diff in the pull request:
https://github.com/apache/cordova-android/pull/223#discussion_r41164437
--- Diff: framework/src/org/apache/cordova/CordovaInterface.java ---
@@ -69,4 +69,20 @@ Licensed to the Apache Software Foundation (ASF) under
one
Hey
I'm going to pull the 5.0.x proposed pull requests into Master today. Can
anyone take a look at them before I do this. I'm going to wait until after
1 PM to do it, so if you can check out the new pull requests and comment on
them before then, that would be greatly appreciated, otherwise I'm
Why not 1.0.0 if it is breaking
On Oct 4, 2015 5:22 PM, "Tim Barham" wrote:
> Hi all... Yesterday I submitted a PR that was a bit of a rework to
> cordova-serve - previously it had essentially been a direct port of what
> was in cordova-lib's 'serve' command and cordova-browser, with a couple of
GitHub user pstoll opened a pull request:
https://github.com/apache/cordova-plugin-network-information/pull/35
Fix checks that always evaluate to true.
The compiler in Xcode [Version 7.0 (7A220)] warned on these lines that they
always evaluate to true. Sure enough, taking the addres
I’m new here, and I don’t know how these meetings usually work, but I thought
it might make sense to structure the sessions around questions instead of
smaller topics. This way, we can get a more open discussion going and talk
about these topics within a larger context.
Some of the questions I
Github user idpaterson commented on the pull request:
https://github.com/apache/cordova-plugin-splashscreen/pull/56#issuecomment-145523163
[The above code](#issuecomment-132235333) has been working for us in
production, I can submit a pull request but I'm not quite clear enough on the
Github user vladimir-kotikov commented on the pull request:
https://github.com/apache/cordova-lib/pull/311#issuecomment-145505359
@nikhilkh, please review once more. The failing tests was fixed.
ConfigChanges also was reworked in 2e11c52 as per [conversation on dev
thread](http://
Github user chaffeqa commented on the pull request:
https://github.com/apache/cordova-plugin-splashscreen/pull/56#issuecomment-145501931
any decision on this? would be a real plus to have back in the plugin!
---
If your project is set up for it, you can reply to this email and have y
Github user chaffeqa commented on the pull request:
https://github.com/apache/cordova-ios/pull/164#issuecomment-145500663
:+1:
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
e
GitHub user coderReview opened a pull request:
https://github.com/apache/cordova-plugin-file/pull/136
Fix crash and add new feature
1- Fix crash when modified date is null (NullPointerException)
2- Added mime-type to Metadata (in Android when Content filesystem is used
is the on
GitHub user daserge opened a pull request:
https://github.com/apache/cordova-plugin-camera/pull/129
CB-9745 Camera plugin docs should be generated from the source
Moved the docs to jsdoc comments in the code, removed redundancy.
Moved Quirks and extra examples to errata sections
Github user vladimir-kotikov commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/313#discussion_r41121964
--- Diff: cordova-lib/src/plugman/uninstall.js ---
@@ -142,8 +143,17 @@ module.exports.uninstallPlugin = function(id,
plugins_dir, options) {
Github user vladimir-kotikov commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/313#discussion_r41121974
--- Diff: cordova-lib/src/plugman/uninstall.js ---
@@ -256,6 +266,15 @@ function runUninstallPlatform(actions, platform,
project_dir, plugin_dir
Github user vladimir-kotikov commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/313#discussion_r41121721
--- Diff: cordova-lib/src/plugman/install.js ---
@@ -404,6 +418,20 @@ function installDependencies(install, dependencies,
options) {
re
Github user vladimir-kotikov commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/313#discussion_r41121704
--- Diff: cordova-lib/src/plugman/install.js ---
@@ -79,6 +80,19 @@ module.exports = function installPlugin(platform,
project_dir, id, plugins_d
65 matches
Mail list logo
