[GitHub] cordova-android pull request: CB-9519 Fix the engine destruction b...

Github user vladimir-kotikov commented on the pull request: https://github.com/apache/cordova-android/pull/208#issuecomment-149906885 @nikhilkh, i'm not 100% sure - according to comments in the code it might sense to have this checked in, but looking at where this code was introduced

[GitHub] cordova-android pull request: CB-9835 Downgrade `properties-parser...

Github user nikhilkh commented on the pull request: https://github.com/apache/cordova-android/pull/230#issuecomment-149912745 Is there an appropriate e2e/unit test case that can be added to cordova-android to detect this? It's unfortunate cordova-lib tests are the only way we found

[GitHub] cordova-lib pull request: On Windows, verify browsers installed be...

Github user asfgit closed the pull request at: https://github.com/apache/cordova-lib/pull/327 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cordova-windows pull request: CB-9408: Added a `windows-packageVer...

Github user GuilhemBarboux commented on the pull request: https://github.com/apache/cordova-windows/pull/105#issuecomment-149894196 Hi, when i add windows platform on cordova project, the version number in .appxmanifests aren't update on identity tag. It's normaly ?

[GitHub] cordova-android pull request: CB-9831 Rewrote 'test-build' script ...

GitHub user alsorokin opened a pull request: https://github.com/apache/cordova-android/pull/232 CB-9831 Rewrote 'test-build' script to use jasmine https://issues.apache.org/jira/browse/CB-9831 You can merge this pull request into a Git repository by running: $ git pull

[GitHub] cordova-android pull request: CB-9835 Downgrade `properties-parser...

Github user TimBarham commented on the pull request: https://github.com/apache/cordova-android/pull/230#issuecomment-149915429 :+1: (to getting this change in, and to then creating tests to guard against this going forwards). --- If your project is set up for it, you can reply to

RE: [DISCUSS] cordova-ios 4.0.0 release

What are good tasks to be poached on cordova-ios-4.x? In particular, my team can help out with cordova-lib related ios tasks. Also, fixing plugins or filing issues for upcoming breakages are great areas we can help out. ios 4.x has critical fixes for XCode 7 usage which people need sooner

[GitHub] cordova-android pull request: CB-9835 Downgrade `properties-parser...

Github user vladimir-kotikov commented on the pull request: https://github.com/apache/cordova-android/pull/230#issuecomment-149912138 It does not. We use 0.2.3 in cordova-lib for `android_parser`: https://github.com/apache/cordova-lib/blob/master/cordova-lib/package.json#L32 --- If

[GitHub] cordova-plugin-file pull request: Windows prefix paths

Github user ghenry22 commented on the pull request: https://github.com/apache/cordova-plugin-file/pull/121#issuecomment-150114300 Have tried this on a windows 10 universal app and had some issues. cordova.file values seem to return a absolute path eg:

Re: [Discuss] Cordova-common release

OK, how will this impact the 5.0 release of Android? On Tue, Oct 20, 2015 at 6:07 PM, Nikhil Khandelwal wrote: > It got checked in earlier this morning. > > -Nikhil > > -Original Message- > From: Joe Bowser [mailto:bows...@gmail.com] > Sent: Tuesday, October 20,

RE: [Discuss] Cordova-common release

It should not - it's a good change for Android 5.0. However, it does represent a big change and we need more testing. From what I understand, it's release ready with no known issues. Vladimir: Is that correct? As for the cordova-common dependency, cordova-android will bundle it. And we don't

RE: [DISCUSS] cordova-ios 4.0.0 release

Sent the message before completing it. What are good tasks to be poached on cordova-ios-4.x? In particular, my team can help out with cordova-lib related ios tasks. Also, fixing plugins or filing issues for upcoming breakages are great areas we can help out. ios 4.x has critical fixes for

[GitHub] cordova-plugin-camera pull request: CB-9193: Add 'showLibraryButto...

Github user infil00p commented on the pull request: https://github.com/apache/cordova-plugin-camera/pull/104#issuecomment-149986619 I agree with @purplecabbage, and I'm still -1 on this. --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] cordova-plugin-splashscreen pull request: CB-8396 - Read property ...

Github user infil00p commented on the pull request: https://github.com/apache/cordova-plugin-splashscreen/pull/48#issuecomment-149992603 Does this actually work if you have a signficantly large application loading in the background? Or is this going to cause more white flashes? ---

[GitHub] cordova-plugin-file-transfer pull request: Gzip support for wp8.x ...

Github user daserge commented on the pull request: https://github.com/apache/cordova-plugin-file-transfer/pull/85#issuecomment-149973070 @sviluppatoribk, thanks for your contribution! I have filed a Jira issue for this: https://issues.apache.org/jira/browse/CB-9839 In

[GitHub] cordova-plugin-statusbar pull request: fade animation and duration...

GitHub user andreistanica opened a pull request: https://github.com/apache/cordova-plugin-statusbar/pull/36 fade animation and duration added to iOS show/hide You can merge this pull request into a Git repository by running: $ git pull

[GitHub] cordova-plugin-statusbar pull request: fade animation and duration...

Github user andreistanica closed the pull request at: https://github.com/apache/cordova-plugin-statusbar/pull/36 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so,

Re: Using Cordova Plugins with ReactNative

Thanks for sharing Parashuram this is very cool to see the separation and the API layer in the works, will be cool to do similar POC after cordova-ios@4 is out with support for plugable web views. On Sun, Oct 18, 2015 at 11:16 PM Parashuram N wrote: > Thanks :) > >

[GitHub] cordova-plugin-splashscreen pull request: CB-8396 - Read property ...

Github user kentmw commented on the pull request: https://github.com/apache/cordova-plugin-splashscreen/pull/48#issuecomment-149990798 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] cordova-plugin-camera pull request: CB-9193: Add 'showLibraryButto...

Github user purplecabbage commented on the pull request: https://github.com/apache/cordova-plugin-camera/pull/104#issuecomment-149985578 -1 This should probably be 3 plugins 1. camera plugin 2. image picker plugin 3. image src chooser plugin We can revisit

[GitHub] cordova-plugin-splashscreen pull request: CB-8396 - Read property ...

Github user kentmw commented on the pull request: https://github.com/apache/cordova-plugin-splashscreen/pull/48#issuecomment-149993662 Good question, I haven't been able to test this. But it seems crazy that AutoHideSplashScreen isn't being read currently on the android side. Is

[GitHub] cordova-plugin-file-transfer pull request: Gzip support for wp8.x ...

Github user daserge commented on a diff in the pull request: https://github.com/apache/cordova-plugin-file-transfer/pull/85#discussion_r42656825 --- Diff: src/wp/FileTransfer.cs --- @@ -697,31 +698,39 @@ private void downloadCallback(IAsyncResult asynchronousResult)

[GitHub] cordova-plugin-file-transfer pull request: uploadResponse encoding...

Github user daserge commented on the pull request: https://github.com/apache/cordova-plugin-file-transfer/pull/71#issuecomment-149979511 Filed Jira issue: https://issues.apache.org/jira/browse/CB-9840 --- If your project is set up for it, you can reply to this email and have your

[GitHub] cordova-plugin-statusbar pull request: CB-9841 - Allow iOS statusb...

GitHub user andreistanica opened a pull request: https://github.com/apache/cordova-plugin-statusbar/pull/37 CB-9841 - Allow iOS statusbar to animate hide/show You can merge this pull request into a Git repository by running: $ git pull

[GitHub] cordova-docs pull request: Please add One Verse BIBLE app

Github user ozexpert commented on the pull request: https://github.com/apache/cordova-docs/pull/384#issuecomment-150003401 any progress on this? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] cordova-docs pull request: Please add One Verse BIBLE app

Github user purplecabbage commented on the pull request: https://github.com/apache/cordova-docs/pull/384#issuecomment-150010814 Documenting cordova code + usage is the priority. Please be patient. --- If your project is set up for it, you can reply to this email and have your

[GitHub] cordova-lib pull request: CB-9736 - Extra main activity generated ...

GitHub user gorkem opened a pull request: https://github.com/apache/cordova-lib/pull/328 CB-9736 - Extra main activity generated when an android package name specified Removes the old package name after the new one is created. If the package name is different You can merge

[GitHub] cordova-docs pull request: GapDebug

Github user dblotsky commented on the pull request: https://github.com/apache/cordova-docs/pull/369#issuecomment-150030506 Yep, that did it. Thanks, @AnabellaGenuitec! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[Android] Merging Camera Pull Request for Marshmallow Compatibility

Hey Now that we merged in the compatibility for Android 5.0 I want to do the same for the Camera plugin. This will also allow us to do a bunch of other work that we're currently waiting on this pull request for. Is there any reason I shouldn't pull the current changes into master? If not, I'm

RE: [Android][Discuss] Change name of CordovaWebView to CordovaWebInterface

Thanks, Joe for the summary of the impact later. -1. IMO - a naming change is no worth the effort and future breakage. -Nikhil -Original Message- From: Joe Bowser [mailto:bows...@gmail.com] Sent: Wednesday, October 21, 2015 11:06 AM To: dev Subject: Re:

Buildbot: buildslave cordova-osx-slave was lost

The Buildbot working for 'ASF Buildbot' has noticed that the buildslave named cordova-osx-slave went away It last disconnected at Wed Oct 21 22:28:33 2015 (buildmaster-local time) The admin on record (as reported by BUILDSLAVE:info/admin) was 'Dmitry Blotsky '.

Re: Buildbot: buildslave cordova-osx-slave was lost

Dang thing took longer than 5 min to reboot. Sorry, folks. It’s back up now. Kindly, Dmitry > On Oct 21, 2015, at 3:33 PM, build...@apache.org wrote: > > The Buildbot working for 'ASF Buildbot' > has noticed that the buildslave named cordova-osx-slave went away > > It last disconnected at Wed

Re: [Android][Discuss] Change name of CordovaWebView to CordovaWebInterface

Yes, I do. I had to search through mobilespec, but here it is: private static final boolean HAS_BUILT_IN_SPLASH_SCREEN = Integer.valueOf(CordovaWebView.CORDOVA_VERSION.split("\\.")[0]) < 4; Also, every plugin that calls initialize requires a CordovaWebView passed into it. That's a pretty big

[GitHub] cordova-coho pull request: Adding docs around JIRA issue triage

Github user riknoll commented on the pull request: https://github.com/apache/cordova-coho/pull/97#issuecomment-150067184 Does it make sense to reference the platform owner as well as the component owner if there is trouble reproducing? Also, do we need to develop a criteria for what

[GitHub] cordova-lib pull request: CB-6698 Fix directory resolution of fram...

Github user stevengill commented on the pull request: https://github.com/apache/cordova-lib/pull/289#issuecomment-150069617 It looks good to me. It is essentially just fixing `parent=true` --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] cordova-android pull request: CB-9519 Fix the engine destruction b...

Github user NoLongerLazyDhl commented on the pull request: https://github.com/apache/cordova-android/pull/208#issuecomment-150070324 @vladimir-kotikov When I want to receive the "exit" message in my activity which extends CordovaActivity to do something, it make that I'm not able to

[GitHub] cordova-android pull request: CB-9835 Downgrade `properties-parser...

Github user TimBarham commented on the pull request: https://github.com/apache/cordova-android/pull/230#issuecomment-149905998 Looks fine to me, as long as we're sure the older version doesn't lose any functionality we need. --- If your project is set up for it, you can reply to

[GitHub] cordova-android pull request: CB-9835 Downgrade `properties-parser...

Github user asfgit closed the pull request at: https://github.com/apache/cordova-android/pull/230 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

Re: [DISCUSS] Curating Apps

Sounds like we’ve got some (potentially mutually exclusive) points: - request detailed app descriptions from submitters - curate based on detailed criteria - curate based on loose criteria - only accept blog posts, and get rid of the showcase - just accept all requests Should this be a proposal

[GitHub] cordova-docs pull request: Removing the survey banner

GitHub user rakatyal opened a pull request: https://github.com/apache/cordova-docs/pull/398 Removing the survey banner You can merge this pull request into a Git repository by running: $ git pull https://github.com/rakatyal/cordova-docs raghav/remove_banner Alternatively you

[GitHub] cordova-android pull request: CB-9836 Add .gitattributes to preven...

GitHub user daserge opened a pull request: https://github.com/apache/cordova-android/pull/231 CB-9836 Add .gitattributes to prevent CRLF line endings in repos [Jira issue](https://issues.apache.org/jira/browse/CB-9836) You can merge this pull request into a Git repository by

[GitHub] cordova-android pull request: CB-9835 Downgrade `properties-parser...

GitHub user vladimir-kotikov opened a pull request: https://github.com/apache/cordova-android/pull/230 CB-9835 Downgrade `properties-parser` to prevent failures in Node < 4.x JIRA: https://issues.apache.org/jira/browse/CB-9835 You can merge this pull request into a Git repository

[GitHub] cordova-android pull request: CB-9835 Downgrade `properties-parser...

Github user vladimir-kotikov commented on the pull request: https://github.com/apache/cordova-android/pull/230#issuecomment-149848724 @TimBarham. @nikhilkh, @stevengill, please review --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] cordova-android pull request: CB-9577 Quoted specific device name ...

Github user vladimir-kotikov commented on the pull request: https://github.com/apache/cordova-android/pull/210#issuecomment-149873722 @nikhilkh, yes, `superspawn` module handles arguments with spaces correctly. I can't test it on real device, but tested using some mocks, and it

[GitHub] cordova-docs pull request: GapDebug

Github user AnabellaGenuitec closed the pull request at: https://github.com/apache/cordova-docs/pull/369 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] cordova-docs pull request: GapDebug

Github user AnabellaGenuitec commented on the pull request: https://github.com/apache/cordova-docs/pull/369#issuecomment-149878959 Sorry, Dmitry. I think I did now. On Tue, Oct 20, 2015 at 7:48 PM, Dmitry Blotsky wrote: > Friendly ping

[GitHub] cordova-plugin-camera pull request: CB-9446 Fix real path returnin...

Github user nikopolv commented on the pull request: https://github.com/apache/cordova-plugin-camera/pull/112#issuecomment-149804724 @charlesverge The Sony Aqua M2 had 4.4 kitkat running in it. --- If your project is set up for it, you can reply to this email and have your reply