[GitHub] cordova-plugin-camera pull request: CB-9960 android: Fixed FileNot...

Github user infil00p commented on the pull request: https://github.com/apache/cordova-plugin-camera/pull/135#issuecomment-154574485 Looks fine, but maybe we should just remove this check and do this another way. --- If your project is set up for it, you can reply to this email and

Re: Integrate binaries (apk / ipa) upload to stores into Cordova CLI

I am with Jesse… I think it would be great, but wouldn’t hold my breath. Also agree documenting the process would be fantastic both as a reality check and a resource for our users. The more we can provide after "Hello World", the better. - tommy On 7 November 2015 at 09:54:41, Jesse

[DISCUSS] Docs Release

Going to do one tied to 5.4.0 tools release. Any objections or concerns?

[GitHub] cordova-plugin-file pull request: Fixed NullPointer Exception in A...

Github user stevengill commented on the pull request: https://github.com/apache/cordova-plugin-file/pull/119#issuecomment-154577821 I think we need @aroberson to sign and submit an ICLA https://www.apache.org/licenses/icla.txt --- If your project is set up for it, you can reply to

[GitHub] cordova-android pull request: API for saving/restoring plugin and ...

Github user riknoll commented on the pull request: https://github.com/apache/cordova-android/pull/236#issuecomment-154590431 After getting some feedback from @purplecabbage on the dev list and talking this over with @jasongin, it sounds as though we should cut everything from this

[GitHub] cordova-plugin-statusbar pull request: Fixes CB-4712, CB-5439 stat...

Github user csantanapr commented on the pull request: https://github.com/apache/cordova-plugin-statusbar/pull/38#issuecomment-154596695 LGTM, rebase the two commits into a single one. Basically you added an observer that anytime that you get notify about status bar change, you do

RE: [DISCUSS] Plugins release

I plan on merging in https://github.com/apache/cordova-plugin-camera/pull/135 for the camera plugin if there are no objections. Thanks, Richard -Original Message- From: Steven Gill [mailto:stevengil...@gmail.com] Sent: Friday, November 6, 2015 11:38 AM To: dev@cordova.apache.org

Re: Native vs. File URIs

I always thought a native URI was if the image was retrieved from the ALAssetsLibrary (Photos Album). https://developer.apple.com/library/ios/documentation/AssetsLibrary/Reference/ALAssetsLibrary_Class/ and the file URI was the image we dumped into tmp. On Fri, Nov 6, 2015 at 11:43 AM, Richard

[GitHub] cordova-android pull request: API for saving/restoring plugin and ...

Github user riknoll commented on the pull request: https://github.com/apache/cordova-android/pull/236#issuecomment-154566865 So in terms of a common API across platforms, what part are we looking at generalizing? Obviously we should ensure that each platform properly fires its pause

Plugin Audit 2015

Jesse, Simon and I spent sometime doing a plugin audit. Our recommendations can be found at https://github.com/cordova/cordova-discuss/pull/28 Overview: https://github.com/stevengill/cordova-discuss/blob/master/proposals/PluginsAudit2015/overview.md Please give us feedback! -Steve

Re: Integrate binaries (apk / ipa) upload to stores into Cordova CLI

Yes, I too see the value, but I think it's a bit of wishful thinking. I would love to be proven wrong though. There are vast differences between the stores submission processes, as well as the meta that they require. In the case of iOS, you would likely need to scrape the website and live with

[GitHub] cordova-docs pull request: CB-9903 added 5.4.0 tools release blog

Github user asfgit closed the pull request at: https://github.com/apache/cordova-docs/pull/411 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

Re: Integrate binaries (apk / ipa) upload to stores into Cordova CLI

How about sending a PR to the docs, and list these tools in those docs ? These tools could be useful for folks who are looking at Cordova continuous integration scenarios. Speaking of which, what do folks on this usually use for Cordova continuous integration ? On 11/6/15, 4:58 PM,

[GitHub] cordova-plugin-camera pull request: CB-9960 android: Fixed FileNot...

Github user jasongin commented on the pull request: https://github.com/apache/cordova-plugin-camera/pull/135#issuecomment-154568849 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] cordova-plugin-camera pull request: CB-9960 android: Fixed FileNot...

Github user riknoll commented on the pull request: https://github.com/apache/cordova-plugin-camera/pull/135#issuecomment-154577011 I was trying to preserve the existing behavior, but I totally agree it's not ideal. What we lose by doing this check is the filename and EXIF data for

[GitHub] cordova-plugin-camera pull request: CB-9960 android: Fixed FileNot...

Github user infil00p commented on the pull request: https://github.com/apache/cordova-plugin-camera/pull/135#issuecomment-154577826 I think that's what #112 does. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] cordova-plugin-file pull request: Fixed NullPointer Exception in A...

Github user aroberson commented on the pull request: https://github.com/apache/cordova-plugin-file/pull/119#issuecomment-154581790 I will get to this tonight. > On Nov 6, 2015, at 5:38 PM, Steve Gill wrote: > > I think we need

Re: [VOTE] Tools Release (attempt 3)

The vote has now closed. The results are: Positive Binding Votes: 4 Steve Gill Alexander Sorokin Parashuram N Sergey Grebnov The vote has passed. I will now publish to dist + npm. I will also publish the release blog post. On Thu, Nov 5, 2015 at 10:27 PM, Sergey Grebnov (Akvelon) <

Re: [DISCUSS] Docs Release

+1 7 Ноя 2015 г. 6:25 пользователь "Steven Gill" написал: > Going to do one tied to 5.4.0 tools release. Any objections or concerns? >

Re: Integrate binaries (apk / ipa) upload to stores into Cordova CLI

Would a hook or plugin work better then? On Fri, Nov 6, 2015 at 8:42 PM, Shazron wrote: > The problem with using "unofficial" methods is, at least for some of > our code contributors *cough IBM*, it won't fly with them, and IMO I'd > rather not support unofficial methods as

[GitHub] cordova-windows pull request: Add support for back button on win10

Github user EionRobb commented on the pull request: https://github.com/apache/cordova-windows/pull/120#issuecomment-154648176 I wouldn't personally make it look for the "MSAppHost/3.0" string, maybe doing a regex match on that to see if it's version 3.0 or higher might be better?

[GitHub] cordova-plugin-file pull request: Fixed NullPointer Exception in A...

Github user aroberson commented on the pull request: https://github.com/apache/cordova-plugin-file/pull/119#issuecomment-154613677 I filled it out and sent it to the secretary. Thanks, Adam Roberson On 11/6/15 5:38 PM, Steve Gill wrote: > > I think

[GitHub] cordova-android pull request: CB-9831 CB-9835 CB-9932 Added e2e te...

GitHub user alsorokin opened a pull request: https://github.com/apache/cordova-android/pull/238 CB-9831 CB-9835 CB-9932 Added e2e tests https://issues.apache.org/jira/browse/CB-9831 https://issues.apache.org/jira/browse/CB-9835 https://issues.apache.org/jira/browse/CB-9932

[GitHub] cordova-docs pull request: Default value for required variables

GitHub user mbektchiev opened a pull request: https://github.com/apache/cordova-docs/pull/415 Default value for required variables You can merge this pull request into a Git repository by running: $ git pull https://github.com/Icenium/cordova-docs bektchiev/default-value

Re: [DISCUSS] Plugins release

I was writing a mail with the same subject, luckily I saw your message before sending. I have this PR for statusbar plugin (ios), it fixes at least 2 jira issues related to hotspot/call status bar and maybe a lot of more webview size/resize issues (will check once it's merged)

Re: [DISCUSS] Plugins release

Yeah, but I was told that my pull requests still had to pass reviews. As the issues are related to the native webview size, I can't think any test to add that can check that. The pull request fixes CB-4712 and CB-5439 but it might fix other webview size related issues as side effect. I've just

[GitHub] cordova-plugin-file pull request: Fix default persistent file loca...

Github user macdonst commented on the pull request: https://github.com/apache/cordova-plugin-file/pull/146#issuecomment-154414663 @jasongin +1 Yeah, the change to compatibility looks like a mistake. It is supposed to be "internal" as of the 3.0.0 release.e --- If your

[GitHub] cordova-coho pull request: CB-9962 Fixed CI builds

Github user asfgit closed the pull request at: https://github.com/apache/cordova-coho/pull/103 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cordova-windows pull request: Add support for back button on win10

Github user sgrebnov commented on the pull request: https://github.com/apache/cordova-windows/pull/120#issuecomment-154416603 @EionRobb could you please verify the following change: ``` parseInt(window.clientInformation.userAgent.match(/Windows NT ([0-9.]+)/)[1]) >= 10 ->

[GitHub] cordova-plugin-file pull request: Fix default persistent file loca...

Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-file/pull/146 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] cordova-docs pull request: Update to plugin.md regarding Cordova-A...

Github user dpogue commented on a diff in the pull request: https://github.com/apache/cordova-docs/pull/409#discussion_r44178488 --- Diff: www/_posts/2015-11-05-cordova-android-5.0.0.md --- @@ -0,0 +1,57 @@ +--- +layout: post +author: +name:Joe Bowser +

Re: [DISCUSS] Plugins release

With plugin changes, it is always nice to get reviews since it could affect every platform. file:146 is merged file: 119 LGTM Statusbar: 38 could use a review by iOS experts Keep em coming in! -Steve On Fri, Nov 6, 2015 at 5:53 AM, Simon MacDonald wrote: > I agree

[GitHub] cordova-plugin-file-transfer pull request: getCookies bugfix

Github user jeroenv commented on the pull request: https://github.com/apache/cordova-plugin-file-transfer/pull/107#issuecomment-154436541 @daserge All pictures selected from Dropbox fail when i use File Transfer plugin together with Crosswalk Webview. --- If your project is set up

Integrate binaries (apk / ipa) upload to stores into Cordova CLI

Hello Cordova devs, Because Cordova CLI is a great tool for command line for almost everything about creating, building hybrids apps, it would be great to include a new command for uploading the generated binaries to the app stores. As far as I know, nothing exists at the moment in Cordova. I

Re: [DISCUSS] Plugins release

Julio, You are a committer now :-), you can go ahead and merge if it's ready. Any manual or auto tests you can add or the one that exist today enough? What you mean by once it's merge you can check? You mean for any other uses cases in addition of the ones you already fixed - Carlos

[GitHub] cordova-windows pull request: Add support for back button on win10

Github user asfgit closed the pull request at: https://github.com/apache/cordova-windows/pull/120 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

Re: [DISCUSS] Plugins release

Yes that makes sense Julio, don't add more CBs to the PR. Let's keep PR focus one thing at a time. I will review and add comments. On Fri, Nov 6, 2015 at 7:25 AM julio cesar sanchez wrote: > Yeah, but I was told that my pull requests still had to pass reviews. > > As the

[GitHub] cordova-plugin-camera pull request: iOS: new resizable cropping re...

Github user riknoll commented on the pull request: https://github.com/apache/cordova-plugin-camera/pull/131#issuecomment-154495633 There are a number of JIRAs that are unhappy with the native iOS crop (CB-9930, CB-2648), but I agree that this needs to be discussed on the mailing

[GitHub] cordova-docs pull request: Update to plugin.md regarding Cordova-A...

Github user dpogue commented on a diff in the pull request: https://github.com/apache/cordova-docs/pull/409#discussion_r44178971 --- Diff: www/docs/en/edge/guide/platforms/android/plugin.md --- @@ -259,9 +259,100 @@ As of Cordova 2.0, Plugins can no longer directly access the

[GitHub] cordova-plugin-camera pull request: feature CB-8777 Add option onl...

Github user riknoll commented on a diff in the pull request: https://github.com/apache/cordova-plugin-camera/pull/80#discussion_r44180556 --- Diff: src/android/CameraLauncher.java --- @@ -270,18 +279,20 @@ public void getImage(int srcType, int returnType, int encodingType) {

RE: [DISCUSS] Cordova-Windows Release

Hi guys, I've started the Vote thread, but I see that release tag has not been automatically mirrored from asf to github. Is it a known issue - should this be done manually? 4.2.0 tag exists here [1] but I don't see it on github[2]

RE: [DISCUSS] Cordova-Windows Release

The Vote thread also starts with "Please review and vote on this 5.0.0 Android Release" which should be actually " Please review and vote on this 4.2.0 Windows Release ". Should I restart Vote due to this mistake? Thx! Sergey -Original Message- From: Sergey Grebnov (Akvelon)

[GitHub] cordova-docs pull request: Update to plugin.md regarding Cordova-A...

Github user dpogue commented on a diff in the pull request: https://github.com/apache/cordova-docs/pull/409#discussion_r44179259 --- Diff: www/docs/en/edge/guide/platforms/android/plugin.md --- @@ -259,9 +259,100 @@ As of Cordova 2.0, Plugins can no longer directly access the

Native vs. File URIs

Hey all, I was wondering if anybody could clarify for me what the difference between FILE_URI and NATIVE_URI is in the camera plugin. Do we have a clear definition of either? I assumed that FILE_URI would refer to an actual path on the device (i.e. a URI using the "file" scheme) but the docs

Re: [DISCUSS] Plugins release

I agree with Jason, https://github.com/apache/cordova-plugin-file/pull/146 should be merged. Simon Mac Donald http://hi.im/simonmacdonald On Thu, Nov 5, 2015 at 8:07 PM, Jason Ginchereau wrote: > I think this PR should get in the release: >

[GitHub] cordova-windows pull request: Add support for back button on win10

Github user sgrebnov commented on the pull request: https://github.com/apache/cordova-windows/pull/120#issuecomment-154417511 PS. changing `appViewBackButtonVisibility ` on Mobile 10 does not take any effect, standard phone back button works as expected (correctly handled using

Re: [DISCUSS] Cordova-Windows Release

In terms of the tag and mirroring, here is the response I got from infra last time about android's tag and if it gets automatically updated. "It is automated, however if you just updated a tag, the mirroring daemon will not sync as there is no substance to the change (same got for just creating a

Re: [DISCUSS] Cordova-Windows Release

or push an empty commit --allow-empty @purplecabbage risingj.com On Fri, Nov 6, 2015 at 1:37 PM, Steven Gill wrote: > In terms of the tag and mirroring, here is the response I got from infra > last time about android's tag and if it gets automatically updated. > > "It

Re: Integrate binaries (apk / ipa) upload to stores into Cordova CLI

I think this is a great idea. I understand that we already have a package command and this could be a logical extension. However, will this be a functionality that can be supported on multiple stores ? I am not sure if this is legal on an iOS store. On 11/6/15, 2:41 AM, "M Alexandre"