[GitHub] cordova-plugin-file-transfer pull request: CB-7006 Empty file is c...

Github user daserge commented on the pull request: https://github.com/apache/cordova-plugin-file-transfer/pull/113#issuecomment-156022070 Added a workaround for iOS using query parameters. The similar iOS issue is described in [CB-8606 File-Transfer with Range-Header is cached on

[GitHub] cordova-lib pull request: Cb 9964

Github user dubeejw commented on the pull request: https://github.com/apache/cordova-lib/pull/339#issuecomment-155998408 Test failures are related to cordova-common, which was not modified in this code. --- If your project is set up for it, you can reply to this email and have your r

[GitHub] cordova-android pull request: CB-9971 Redirect gradlew stderr to c...

Github user dblotsky commented on a diff in the pull request: https://github.com/apache/cordova-android/pull/240#discussion_r44614185 --- Diff: bin/templates/cordova/lib/builders/GradleBuilder.js --- @@ -211,3 +209,46 @@ module.exports = GradleBuilder; function isAutoGenerated(

[GitHub] cordova-plugin-camera pull request: CB-5479 android: changed saveT...

Github user riknoll commented on the pull request: https://github.com/apache/cordova-plugin-camera/pull/137#issuecomment-155970708 The commit I just pushed handles cropped images. I believe it also fixes an undocumented bug where requesting uncompressed/unedited images caused the app

[GitHub] cordova-plugin-file pull request: CB-9891: Fix permission errors d...

Github user jasongin commented on the pull request: https://github.com/apache/cordova-plugin-file/pull/148#issuecomment-155969774 This also fixes CB-7024. CB-9891 is really a duplicate of that one. --- If your project is set up for it, you can reply to this email and have your reply

Re: [DISCUSS] Cordova-Windows Release

That's still a minor bump. Minor can include bug fixes on top of enhancements. Patch is if it's only bugs Our common practice have being to tell folks to update to the new version. - Carlos @csantanapr > On Nov 11, 2015, at 7:27 PM, Dmitry Blotsky wrote: > > It’s got enhancements AND bug f

Re: [DISCUSS] Cordova-Windows Release

It’s got enhancements AND bug fixes. Should we backport the bug fixes? Or do we tell everyone to switch to the newer version because it’s the only one that contains them? On Nov 11, 2015, at 3:31 PM, Carlos Santana mailto:csantan...@gmail.com>> wrote: Agree bump minor it's not a bug/patch it's

Re: [DISCUSS] Proposal to Remove the Cordova iOS Native Whitelist

https://issues.apache.org/jira/browse/CB-9972 3 pull requests sent for review: 1. https://github.com/apache/cordova-ios/pull/181 2. https://github.com/apache/cordova-plugin-whitelist/pull/16 3. https://github.com/apache/cordova-mobile-spec/pull/133 On Wed, Nov 11, 2015 at 12:44 AM, julio cesar

[GitHub] cordova-plugin-file pull request: CB-9891: Fix permission errors d...

Github user jasongin commented on the pull request: https://github.com/apache/cordova-plugin-file/pull/148#issuecomment-155954986 @riknoll please review --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project doe

[GitHub] cordova-plugin-file pull request: CB-9891: Fix permission errors d...

GitHub user jasongin opened a pull request: https://github.com/apache/cordova-plugin-file/pull/148 CB-9891: Fix permission errors due to URI encoding inconsistency on Android You can merge this pull request into a Git repository by running: $ git pull https://github.com/jasong

[GitHub] cordova-mobile-spec pull request: CB-9972 - Remove iOS whitelist

GitHub user shazron opened a pull request: https://github.com/apache/cordova-mobile-spec/pull/133 CB-9972 - Remove iOS whitelist You can merge this pull request into a Git repository by running: $ git pull https://github.com/shazron/cordova-mobile-spec CB-9972 Alternatively y

[GitHub] cordova-plugin-whitelist pull request: CB-9972 - Remove iOS whitel...

GitHub user shazron opened a pull request: https://github.com/apache/cordova-plugin-whitelist/pull/16 CB-9972 - Remove iOS whitelist You can merge this pull request into a Git repository by running: $ git pull https://github.com/shazron/cordova-plugin-whitelist CB-9972 Altern

[GitHub] cordova-ios pull request: CB-9972 - Remove iOS whitelist

GitHub user shazron opened a pull request: https://github.com/apache/cordova-ios/pull/181 CB-9972 - Remove iOS whitelist You can merge this pull request into a Git repository by running: $ git pull https://github.com/shazron/cordova-ios CB-9972 Alternatively you can review an

Re: [DISCUSS] Cordova-Windows Release

Agree bump minor it's not a bug/patch it's an enhancement On Wed, Nov 11, 2015 at 5:51 PM Steven Gill wrote: > Lets do a minor lib bump for a minor platform bump. > > On Wed, Nov 11, 2015 at 2:39 PM, Dmitry Blotsky > wrote: > > > Hey guys, > > > > What kind of version bump will result from updat

[GitHub] cordova-plugin-camera pull request: CB-5479 android: changed saveT...

Github user riknoll commented on the pull request: https://github.com/apache/cordova-plugin-camera/pull/137#issuecomment-155942860 Oh, [according to this](http://callback.markmail.org/search/?q=+saveToPhotoAlbum+list%3Aorg.apache.incubator.callback-dev#query:saveToPhotoAlbum%20list%3A

[GitHub] cordova-plugin-camera pull request: CB-5479 android: changed saveT...

Github user riknoll commented on the pull request: https://github.com/apache/cordova-plugin-camera/pull/137#issuecomment-155940388 @infil00p This might be breaking (sorta). What is the protocol we usually follow for merging breaking changes in? --- If your project is set up for it,

[GitHub] cordova-plugin-camera pull request: CB-5479 android: changed saveT...

GitHub user riknoll opened a pull request: https://github.com/apache/cordova-plugin-camera/pull/137 CB-5479 android: changed saveToPhotoAlbum to save uncompressed images It was apparently decided a while back (CB-5749) that we should be saving the uncompressed image with `saveToPhot

[GitHub] cordova-plugin-inappbrowser pull request: Fix lint warnings

Github user purplecabbage commented on the pull request: https://github.com/apache/cordova-plugin-inappbrowser/pull/120#issuecomment-155934837 Hi Martin, I am unable to see the lint warnings, what exactly are you running to see them? Also, it seems these id's are never us

Re: [DISCUSS] Cordova-Windows Release

Lets do a minor lib bump for a minor platform bump. On Wed, Nov 11, 2015 at 2:39 PM, Dmitry Blotsky wrote: > Hey guys, > > What kind of version bump will result from updating cordova-lib to this > pinned version (4.2.0) of cordova-windows? > > Kindly, > Dmitry > > > On Nov 10, 2015, at 4:01 AM,

Re: [DISCUSS] Cordova-Windows Release

Hey guys, What kind of version bump will result from updating cordova-lib to this pinned version (4.2.0) of cordova-windows? Kindly, Dmitry > On Nov 10, 2015, at 4:01 AM, Sergey Grebnov (Akvelon) > wrote: > > Please review blog post draft > https://github.com/apache/cordova-docs/pull/417 >

[GitHub] cordova-android pull request: CB-9971 Redirect gradlew stderr to c...

Github user dblotsky commented on a diff in the pull request: https://github.com/apache/cordova-android/pull/240#discussion_r44595632 --- Diff: bin/templates/cordova/lib/builders/GradleBuilder.js --- @@ -211,3 +209,46 @@ module.exports = GradleBuilder; function isAutoGenerated(

[GitHub] cordova-plugin-statusbar pull request: Fixes CB-4712, CB-5439 stat...

Github user purplecabbage commented on the pull request: https://github.com/apache/cordova-plugin-statusbar/pull/38#issuecomment-155920277 Merged thanks! I made a small change to use a weakSelf reference for the async block. --- If your project is set up for it, you can reply to

[GitHub] cordova-plugin-statusbar pull request: Fixes CB-4712, CB-5439 stat...

Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-statusbar/pull/38 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if th

[GitHub] cordova-android pull request: CB-9971 Redirect gradlew stderr to c...

Github user vladimir-kotikov commented on the pull request: https://github.com/apache/cordova-android/pull/240#issuecomment-155912830 @jasongin, i will double check this --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] cordova-android pull request: CB-9971 Redirect gradlew stderr to c...

Github user vladimir-kotikov commented on a diff in the pull request: https://github.com/apache/cordova-android/pull/240#discussion_r44586855 --- Diff: bin/templates/cordova/lib/builders/GradleBuilder.js --- @@ -211,3 +209,46 @@ module.exports = GradleBuilder; function isAutoGe

[GitHub] cordova-android pull request: CB-9971 Redirect gradlew stderr to c...

Github user vladimir-kotikov commented on a diff in the pull request: https://github.com/apache/cordova-android/pull/240#discussion_r44585568 --- Diff: bin/templates/cordova/lib/builders/GradleBuilder.js --- @@ -211,3 +209,46 @@ module.exports = GradleBuilder; function isAutoGe

[GitHub] cordova-lib pull request: Adds copying of blackberry10 splashscree...

Github user timwindsor commented on the pull request: https://github.com/apache/cordova-lib/pull/342#issuecomment-155906551 I don't think the checks are relevant to the code changed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] cordova-docs pull request: Document and

Github user nikhilkh commented on the pull request: https://github.com/apache/cordova-docs/pull/416#issuecomment-155905961 can this be merged to the 5.4 docs release on the website? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

Re: New Camera Plugin iOS feature

+1 @purplecabbage risingj.com On Wed, Nov 11, 2015 at 12:35 PM, Mefire O. wrote: > +1 > I think this is a useful feature. > We should also think about integrating this into other platforms in the > future. > > Thanks, > Omar Mefire > > On Nov 11, 2015 11:30 AM, Sarah Goldman wrote: > Hello, >

[GitHub] cordova-lib pull request: Adds copying of blackberry10 splashscree...

GitHub user timwindsor opened a pull request: https://github.com/apache/cordova-lib/pull/342 Adds copying of blackberry10 splashscreens - fixes CB-9653 Only icons were getting copied before. You can merge this pull request into a Git repository by running: $ git pull https://gi

Re: New Camera Plugin iOS feature

+1 I think this is a useful feature. We should also think about integrating this into other platforms in the future. Thanks, Omar Mefire On Nov 11, 2015 11:30 AM, Sarah Goldman wrote: Hello, I am proposing a new feature for the camera plugin: the ability to manually dismiss camera popover views

New Camera Plugin iOS feature

Hello, I am proposing a new feature for the camera plugin: the ability to manually dismiss camera popover views and view controllers on iOS. I encountered a need for this function when implementing a timeout based logout on my app. If the user timed out while sitting there with the camera open, I

[GitHub] cordova-plugin-camera pull request: Manual dismissal method for iO...

Github user sarahgoldman commented on the pull request: https://github.com/apache/cordova-plugin-camera/pull/117#issuecomment-155885595 I have created a Jira issue here: https://issues.apache.org/jira/browse/CB-9980 I have also emailed dev@cordova.apache.org with the proposal

[GitHub] cordova-android pull request: CB-8917: Added pending plugin callba...

Github user riknoll commented on a diff in the pull request: https://github.com/apache/cordova-android/pull/239#discussion_r44567817 --- Diff: framework/src/org/apache/cordova/ResumeCallback.java --- @@ -0,0 +1,71 @@ +/* + Licensed to the Apache Software Foundation (AS

[GitHub] cordova-android pull request: CB-9971 Redirect gradlew stderr to c...

Github user jasongin commented on a diff in the pull request: https://github.com/apache/cordova-android/pull/240#discussion_r44567649 --- Diff: bin/templates/cordova/lib/builders/GradleBuilder.js --- @@ -211,3 +209,46 @@ module.exports = GradleBuilder; function isAutoGenerated(

Re: Introduction per contribution guidelines

Welcome, Toni! Small question: when you said that you registered an account on apache.org, what do you mean? Kindly, Dmitry On Nov 11, 2015, at 8:18 AM, Zombie protection mailto:zombieprotectionage...@gmail.com>> wrote: I assume I am just supposed to send a small introducti

[GitHub] cordova-android pull request: CB-9971 Redirect gradlew stderr to c...

Github user dblotsky commented on the pull request: https://github.com/apache/cordova-android/pull/240#issuecomment-155867938 Also :+1: on what @jasongin said. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your proje

[GitHub] cordova-android pull request: CB-9971 Redirect gradlew stderr to c...

Github user dblotsky commented on a diff in the pull request: https://github.com/apache/cordova-android/pull/240#discussion_r44566177 --- Diff: bin/templates/cordova/lib/builders/GradleBuilder.js --- @@ -211,3 +209,46 @@ module.exports = GradleBuilder; function isAutoGenerated(

[GitHub] cordova-android pull request: CB-9971 Redirect gradlew stderr to c...

Github user dblotsky commented on a diff in the pull request: https://github.com/apache/cordova-android/pull/240#discussion_r44566085 --- Diff: bin/templates/cordova/lib/builders/GradleBuilder.js --- @@ -211,3 +209,46 @@ module.exports = GradleBuilder; function isAutoGenerated(

[GitHub] cordova-android pull request: CB-9971 Redirect gradlew stderr to c...

Github user dblotsky commented on a diff in the pull request: https://github.com/apache/cordova-android/pull/240#discussion_r44566005 --- Diff: bin/templates/cordova/lib/builders/GradleBuilder.js --- @@ -211,3 +209,46 @@ module.exports = GradleBuilder; function isAutoGenerated(

[GitHub] cordova-android pull request: CB-8917: Added pending plugin callba...

Github user riknoll commented on a diff in the pull request: https://github.com/apache/cordova-android/pull/239#discussion_r44565905 --- Diff: framework/src/org/apache/cordova/ResumeCallback.java --- @@ -0,0 +1,71 @@ +/* + Licensed to the Apache Software Foundation (AS

Re: Introduction per contribution guidelines

Welcome Toni! If you need help, feel free to ping us also on http://slack.cordova.io On Wed, Nov 11, 2015 at 8:18 AM, Zombie protection wrote: > I assume I am just supposed to send a small introduction but this got > pretty long before I realized it, I hope that is OK. > > Hello, my name is Toni

[GitHub] cordova-android pull request: CB-8917: Added pending plugin callba...

Github user riknoll commented on a diff in the pull request: https://github.com/apache/cordova-android/pull/239#discussion_r44564738 --- Diff: framework/src/org/apache/cordova/CordovaInterfaceImpl.java --- @@ -147,6 +151,8 @@ public void onSaveInstanceState(Bundle outState) {

Introduction per contribution guidelines

I assume I am just supposed to send a small introduction but this got pretty long before I realized it, I hope that is OK. Hello, my name is Toni and I am a programmer for a small company. I have experience with HTML, CSS, bash, javascript, Java, C#, VB, and PHP. I am entirely self taught and I ha

[GitHub] cordova-android pull request: CB-8917: Added pending plugin callba...

Github user jasongin commented on a diff in the pull request: https://github.com/apache/cordova-android/pull/239#discussion_r44564318 --- Diff: framework/src/org/apache/cordova/ResumeCallback.java --- @@ -0,0 +1,71 @@ +/* + Licensed to the Apache Software Foundation (A

[GitHub] cordova-android pull request: CB-8917: Added pending plugin callba...

Github user riknoll commented on a diff in the pull request: https://github.com/apache/cordova-android/pull/239#discussion_r44563854 --- Diff: framework/src/org/apache/cordova/CordovaInterfaceImpl.java --- @@ -115,6 +115,10 @@ public boolean onActivityResult(int requestCode, int re

[GitHub] cordova-android pull request: CB-8917: Added pending plugin callba...

Github user jasongin commented on a diff in the pull request: https://github.com/apache/cordova-android/pull/239#discussion_r44563555 --- Diff: framework/src/org/apache/cordova/ResumeCallback.java --- @@ -0,0 +1,71 @@ +/* + Licensed to the Apache Software Foundation (A

[GitHub] cordova-android pull request: CB-8917: Added pending plugin callba...

Github user jasongin commented on a diff in the pull request: https://github.com/apache/cordova-android/pull/239#discussion_r44562734 --- Diff: framework/src/org/apache/cordova/CordovaInterfaceImpl.java --- @@ -115,6 +115,10 @@ public boolean onActivityResult(int requestCode, int r

[GitHub] cordova-android pull request: CB-8917: Added pending plugin callba...

Github user jasongin commented on a diff in the pull request: https://github.com/apache/cordova-android/pull/239#discussion_r44562494 --- Diff: framework/src/org/apache/cordova/CoreAndroid.java --- @@ -113,6 +110,10 @@ else if (action.equals("exitApp")) { }

[GitHub] cordova-android pull request: CB-8917: Added pending plugin callba...

Github user jasongin commented on a diff in the pull request: https://github.com/apache/cordova-android/pull/239#discussion_r44562203 --- Diff: framework/src/org/apache/cordova/CordovaInterfaceImpl.java --- @@ -147,6 +151,8 @@ public void onSaveInstanceState(Bundle outState) {

[GitHub] cordova-plugin-inappbrowser pull request: Fix lint warnings

Github user dblotsky commented on the pull request: https://github.com/apache/cordova-plugin-inappbrowser/pull/120#issuecomment-155859376 I don't know much about Android, but I found a [StackOverflow post](http://stackoverflow.com/questions/29696879/android-expected-resource-of-type-i

[GitHub] cordova-android pull request: CB-8917: Added pending plugin callba...

Github user riknoll commented on a diff in the pull request: https://github.com/apache/cordova-android/pull/239#discussion_r44561745 --- Diff: framework/src/org/apache/cordova/CordovaInterface.java --- @@ -22,6 +22,7 @@ Licensed to the Apache Software Foundation (ASF) under one

[GitHub] cordova-android pull request: CB-8917: Added pending plugin callba...

Github user jasongin commented on a diff in the pull request: https://github.com/apache/cordova-android/pull/239#discussion_r44561465 --- Diff: framework/src/org/apache/cordova/CordovaInterface.java --- @@ -22,6 +22,7 @@ Licensed to the Apache Software Foundation (ASF) under one

[GitHub] cordova-android pull request: CB-9971 Redirect gradlew stderr to c...

Github user jasongin commented on the pull request: https://github.com/apache/cordova-android/pull/240#issuecomment-155854701 Does java.exe output compilation errors and warnings to stderr or stdout? If they go to stderr then we should NOT redirect those. --- If your project is set u

[GitHub] cordova-lib pull request: use plist@1.2 to be able to use cordova ...

GitHub user rubensayshi opened a pull request: https://github.com/apache/cordova-lib/pull/341 use plist@1.2 to be able to use cordova with node v0.12. `plist@1.1` had `xmlbuilder@2.2` as dependency, which had `engine@<=0.10`. with `plist@1.2` it now depends on `xmlbuilder@4.4`.

[GitHub] cordova-ios pull request: CB-9883

Github user purplecabbage commented on the pull request: https://github.com/apache/cordova-ios/pull/179#issuecomment-155847309 Are you able to verify this works @chaffeqa? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. I

[GitHub] cordova-plugin-file-transfer pull request: CB-7006 Empty file is c...

GitHub user daserge opened a pull request: https://github.com/apache/cordova-plugin-file-transfer/pull/113 CB-7006 Empty file is created on file transfer if server response is 304 Adds a corresponding test. Fixes the Windows proxy to not to delete the file in case of 304. As

[GitHub] cordova-android pull request: CB-9971 Redirect gradlew stderr to c...

GitHub user vladimir-kotikov opened a pull request: https://github.com/apache/cordova-android/pull/240 CB-9971 Redirect gradlew stderr to current process stdout This is a fix for https://issues.apache.org/jira/browse/CB-9971 You can merge this pull request into a Git repository by r

[GitHub] cordova-ios pull request: CB-9883

Github user chaffeqa commented on the pull request: https://github.com/apache/cordova-ios/pull/179#issuecomment-155768503 That looks great to me! honestly i dont know how i felt about the idea of dynamically injecting a script... call me old school ;) Thanks guys a ton for all

RE: [Vote] 4.2.0 Windows Release

I vote +1 * Verified release candidate with 'coho verify-archive' * Verified that blank app created and built successfully * Verified that upgrade from previous version succeeds - Best regards, Vladimir -Original Message- From: Alexander Sorokin (Akvelon) [mailto:v-als...@microsoft.com]

Re: [DISCUSS] Proposal to Remove the Cordova iOS Native Whitelist

Ahh, missed that, thanks Shazron! 2015-11-11 1:39 GMT+01:00 Shazron : > This is handled by this: > > https://github.com/apache/cordova-ios/tree/master/CordovaLib/Classes/Private/Plugins/CDVSystemSchemes > > Doc: > > https://github.com/apache/cordova-docs/commit/80906ac23c77f4ce7a5d330b28fba803736