[GitHub] cordova-plugin-inappbrowser pull request: CB-8180: Changing method...

Github user falkobuttler commented on the pull request: https://github.com/apache/cordova-plugin-inappbrowser/pull/136#issuecomment-173542915 This PR caused a major outage for our Android users due to the fact that the LOAD_START event does not fire anymore. We relied on that event

[GitHub] cordova-android pull request: CB-10157 Uninstall app from device/e...

GitHub user vladimir-kotikov opened a pull request: https://github.com/apache/cordova-android/pull/251 CB-10157 Uninstall app from device/emulator only when signed apk is already installed JIRA: [CB-10157](https://issues.apache.org/jira/browse/CB-10157) You can merge this pull

[GitHub] cordova-android pull request: Parse options correctly

Github user vladimir-kotikov commented on the pull request: https://github.com/apache/cordova-android/pull/248#issuecomment-173500760 The second fix LGTM. Regarding the first - looks like it breaks the scenario when platform-specific options are passed behind `--` arguments

[GitHub] cordova-windows pull request: CB-10381 fix the bug when removing a...

Github user purplecabbage commented on the pull request: https://github.com/apache/cordova-windows/pull/140#issuecomment-173503621 Thanks @bso-intel, and @vladimir-kotikov for merging! --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] cordova-plugin-media pull request: Streaming & Background threadin...

Github user ghenry22 commented on the pull request: https://github.com/apache/cordova-plugin-media/pull/62#issuecomment-173504921 @purplecabbage I have added rate control when streaming from a URL using avplayer and tested that it works. However test case 19 still fails in the

[GitHub] cordova-android pull request: CB-10406 Fixes an exception, thrown ...

GitHub user vladimir-kotikov opened a pull request: https://github.com/apache/cordova-android/pull/250 CB-10406 Fixes an exception, thrown when building using Ant See [CB-10406](https://issues.apache.org/jira/browse/CB-10406) You can merge this pull request into a Git repository by

RE: [Vote] 5.1.0 Android Release

I vote +1: * Verified archives via `coho verify-archive` * Verified tags manually * Verified that blank app creates correctly with platform * Verified that blank app can be successfully ran and built * Verified that platform can be updated from previous version * Verified compatibility with core

Re: PhoneGap Day US - In Utah next week

I'll be there. On Thu, Jan 21, 2016 at 10:05 AM, Parashuram N wrote: > From Microsoft, Ryan, Dmitry and Mefire should be there. > > > > > On 1/20/16, 5:48 PM, "Don Coleman" wrote: > >>I'll be there. >> >>On Wed, Jan 20, 2016 at 8:25 PM, Jesse

[GitHub] cordova-ios pull request: Disable ios-deploy wifi mode when deploy...

GitHub user mlegenhausen opened a pull request: https://github.com/apache/cordova-ios/pull/190 Disable ios-deploy wifi mode when deploying to a device Currently when running `cordova run ios --device` the app gets deployed two times via usb and wifi. But when disconnecting from USB

[GitHub] cordova-android pull request: CB-10157 Uninstall app from device/e...

Github user nikhilkh commented on the pull request: https://github.com/apache/cordova-android/pull/251#issuecomment-173645357 LGTM - Not clear why travis test is failing. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well.

[GitHub] cordova-docs pull request: CB-10330 Adding style guide for xml ref...

Github user nikhilkh commented on the pull request: https://github.com/apache/cordova-docs/pull/460#issuecomment-173651559 This looks great! Couple of comments - while your example illustrates this - your specification is not very precise: 1. Consider clarifying the position of

[GitHub] cordova-docs pull request: CB-10330 Adding style guide for xml ref...

Github user riknoll commented on the pull request: https://github.com/apache/cordova-docs/pull/460#issuecomment-173656844 The content looks good to me, but I had difficulty reading the document. It wasn't clear to me which parts of it are examples and which are the guidelines. The

[GitHub] cordova-plugin-inappbrowser pull request: CB-8180: Changing method...

Github user falkobuttler commented on the pull request: https://github.com/apache/cordova-plugin-inappbrowser/pull/136#issuecomment-173673675 @asfgit --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] cordova-plugin-splashscreen pull request: make android support Aut...

Github user daserge commented on the pull request: https://github.com/apache/cordova-plugin-splashscreen/pull/71#issuecomment-173654883 @njleonzhang, will not this change cause a memory leak? `// hide the splash screen to avoid leaking a window` --- If your project is set up for

[GitHub] cordova-docs pull request: CB-8917: Improving Android lifecycle do...

GitHub user riknoll opened a pull request: https://github.com/apache/cordova-docs/pull/461 CB-8917: Improving Android lifecycle docs @nikhilkh @jasongin please give this a review when you get the chance. I rewrote the lifecycle guide to clarify a few things. Mostly, I wanted to

[GitHub] cordova-docs pull request: CB-10330 Adding style guide for xml ref...

Github user omefire commented on the pull request: https://github.com/apache/cordova-docs/pull/460#issuecomment-173674096 Looks good, but I'm a bit confused with examples, which ones are examples ? which aren't ? --- If your project is set up for it, you can reply to this email and

RE: [DISCUSS] Android@5.1.0

When this release goes out, I think it's a good idea for us to point to the new Android Lifecycle Guide I added to the docs in the blog post. http://cordova.apache.org/docs/en/dev/guide/platforms/android/lifecycle.html I also have a PR open that improves it here:

[GitHub] cordova-docs pull request: CB-10330 Adding style guide for xml ref...

Github user riknoll commented on the pull request: https://github.com/apache/cordova-docs/pull/460#issuecomment-173687210 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

Re: PhoneGap Day US - In Utah next week

From Microsoft, Ryan, Dmitry and Mefire should be there. On 1/20/16, 5:48 PM, "Don Coleman" wrote: >I'll be there. > >On Wed, Jan 20, 2016 at 8:25 PM, Jesse wrote: > >> Who all from this list is attending PGD next week in Utah? >> Of course

[GitHub] cordova-ios pull request: Disable ios-deploy wifi mode when deploy...

Github user shazron commented on the pull request: https://github.com/apache/cordova-ios/pull/190#issuecomment-173697815 Note that this has to be bumped up to 1.8.3 as well:

[GitHub] cordova-medic pull request: CB-10401: Connectivity Issue to github...

Github user asfgit closed the pull request at: https://github.com/apache/cordova-medic/pull/71 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cordova-medic pull request: CB-10401: Connectivity Issue to github...

Github user dblotsky commented on the pull request: https://github.com/apache/cordova-medic/pull/71#issuecomment-173702949 LGTM! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

Re: --browserify workflow status?

Should we set a rough goal/timeline on when to make this default? Cordova 6.1.0? Put the non browserify workflow behind a --no-browserify flag. I'll plan to write a blog post and put it up for review week after PGDAY. On Thu, Jan 21, 2016 at 1:19 PM, Nikhil Khandelwal

[GitHub] cordova-docs pull request: CB-10330 Adding style guide for xml ref...

Github user asfgit closed the pull request at: https://github.com/apache/cordova-docs/pull/460 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cordova-medic pull request: CB-10401: Connectivity Issue to github...

Github user dblotsky commented on the pull request: https://github.com/apache/cordova-medic/pull/71#issuecomment-173743128 @nikhilkh: yep. Committed at the same time that this got merged. --- If your project is set up for it, you can reply to this email and have your reply appear on

Re: [DISCUSS] Android@5.1.0

Sent a PR for the blog post for review https://github.com/apache/cordova-docs/pull/462 Richard, can you add a section about the new lifecycle stuff. I figured you could explain it better than I as I am unfamiliar with the changes. Just send a PR or leave it as a comment and I can integrate it.

[GitHub] cordova-plugin-camera pull request: CB-10227 Fix to allow spam tap...

Github user nikhilkh commented on the pull request: https://github.com/apache/cordova-plugin-camera/pull/159#issuecomment-173744561 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] cordova-docs pull request: added android 5.1.0 release blog post

GitHub user stevengill opened a pull request: https://github.com/apache/cordova-docs/pull/462 added android 5.1.0 release blog post Please leave comments or send a PR with changes. You can merge this pull request into a Git repository by running: $ git pull

[GitHub] cordova-plugin-camera pull request: CB-10227 Fix to allow spam tap...

GitHub user rakatyal opened a pull request: https://github.com/apache/cordova-plugin-camera/pull/159 CB-10227 Fix to allow spam tapping on camera video screen on Windows You can merge this pull request into a Git repository by running: $ git pull

[GitHub] cordova-medic pull request: CB-10405 - Connectivity issue to Cordo...

GitHub user sarangan12 opened a pull request: https://github.com/apache/cordova-medic/pull/72 CB-10405 - Connectivity issue to Cordova VM 1. Added retry logic while checking if cordova vms are up. 2. Increased server response timeout from 3 seconds to 15 seconds

[GitHub] cordova-plugin-camera pull request: CB-10227 Fix to allow spam tap...

Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-camera/pull/159 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

Re: Docs versioning scheme

+1 On Thu, Jan 21, 2016 at 1:38 PM, Nikhil Khandelwal wrote: > Should we version our docs on every major version (instead of minor > version) of cordova CLI that comes out? Should the next version of the docs > be "6.x"? Honestly, not much changes every minor release and

[GitHub] cordova-medic pull request: CB-10401: Connectivity Issue to github...

Github user nikhilkh commented on the pull request: https://github.com/apache/cordova-medic/pull/71#issuecomment-173708497 @dblotsky Are you planning to commit this to svn repo? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] cordova-plugin-camera pull request: [CB-10388] - Added correctOrie...

GitHub user horozco opened a pull request: https://github.com/apache/cordova-plugin-camera/pull/158 [CB-10388] - Added correctOrientation support for android 4.4 Jira issue: https://issues.apache.org/jira/browse/CB-10388 - Currently If You pass the correctOrientation param

[GitHub] cordova-cli pull request: Remove browserify from experimental flag...

GitHub user nikhilkh opened a pull request: https://github.com/apache/cordova-cli/pull/231 Remove browserify from experimental flags list You can merge this pull request into a Git repository by running: $ git pull https://github.com/MSOpenTech/cordova-cli updateHelp

RE: --browserify workflow status?

Great! Looks like we just need to update the help text then. I sent a PR for this: https://github.com/apache/cordova-cli/pull/231 Anyone wants to talk about the merits of using the browserify workflow? Our blog might be a good place for that. -Nikhil -Original Message- From:

Docs versioning scheme

Should we version our docs on every major version (instead of minor version) of cordova CLI that comes out? Should the next version of the docs be "6.x"? Honestly, not much changes every minor release and maintaining multiple copies has quite a few downsides w.r.t. SEO (referring to older

[GitHub] cordova-plugin-geolocation pull request: iOS: Clearing all Watches...

Github user Tempus35 commented on the pull request: https://github.com/apache/cordova-plugin-geolocation/pull/25#issuecomment-173720901 I am having this issue still on android --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

Re: Docs versioning scheme

SGTM! +1 @purplecabbage risingj.com On Thu, Jan 21, 2016 at 1:47 PM, Steven Gill wrote: > +1 > > On Thu, Jan 21, 2016 at 1:38 PM, Nikhil Khandelwal > > wrote: > > > Should we version our docs on every major version (instead of minor > >

[GitHub] cordova-medic pull request: CB-10405 - Connectivity issue to Cordo...

Github user sarangan12 commented on the pull request: https://github.com/apache/cordova-medic/pull/72#issuecomment-173762044 @dblotsky Refactored the code to use callback. Can you review the latest code? --- If your project is set up for it, you can reply to this email and have

[GitHub] cordova-medic pull request: CB-10405 - Connectivity issue to Cordo...

Github user sarangan12 commented on the pull request: https://github.com/apache/cordova-medic/pull/72#issuecomment-173767433 @dblotsky Incorporated both the comments --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] cordova-medic pull request: CB-10405 - Connectivity issue to Cordo...

Github user dblotsky commented on a diff in the pull request: https://github.com/apache/cordova-medic/pull/72#discussion_r50489033 --- Diff: medic/medic-run.js --- @@ -324,23 +349,8 @@ function main() { util.fatal("app " + appPath + " does not exist"); }

[GitHub] cordova-medic pull request: CB-10405 - Connectivity issue to Cordo...

Github user dblotsky commented on a diff in the pull request: https://github.com/apache/cordova-medic/pull/72#discussion_r50488969 --- Diff: medic/medic-run.js --- @@ -324,23 +349,8 @@ function main() { util.fatal("app " + appPath + " does not exist"); }

[GitHub] cordova-docs pull request: added android 5.1.0 release blog post

Github user riknoll commented on the pull request: https://github.com/apache/cordova-docs/pull/462#issuecomment-173770573 Here's my blurb: This update introduces a new API for Android plugin authors. Plugins that launch external activities can now better handle method calls

[GitHub] cordova-medic pull request: CB-10405 - Connectivity issue to Cordo...

Github user dblotsky commented on a diff in the pull request: https://github.com/apache/cordova-medic/pull/72#discussion_r50492408 --- Diff: medic/medic-run.js --- @@ -44,7 +44,9 @@ var MEDIC_BUILD_PREFIX= "medic-cli-build"; var DEFAULT_WINDOWS_VERSION = "store";

[GitHub] cordova-plugin-splashscreen pull request: make android support Aut...

Github user njleonzhang commented on the pull request: https://github.com/apache/cordova-plugin-splashscreen/pull/71#issuecomment-173780749 @daserge, I don't think this will cause memory leak. In addition, it doesn't make sense to hide the splash, if you have disabled

[GitHub] cordova-medic pull request: CB-10405 - Connectivity issue to Cordo...

Github user dblotsky commented on the pull request: https://github.com/apache/cordova-medic/pull/72#issuecomment-173771334 LGTM! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] cordova-docs pull request: added android 5.1.0 release blog post

Github user stevengill commented on the pull request: https://github.com/apache/cordova-docs/pull/462#issuecomment-173790600 Great write up! Very detailed and informative. I'll add it to the blog soon. --- If your project is set up for it, you can reply to this email and have your

RE: --browserify workflow status?

Thanks, Steve for taking up on writing the blog post. It would be great to use that to drive some usage and feedback loop. Also, we might want to do JIRA triage of related issues to ensure that it does not result in any regressions. I took a quick look and most of it is not relevant currently

[GitHub] cordova-medic pull request: CB-10405 - Connectivity issue to Cordo...

Github user dblotsky commented on a diff in the pull request: https://github.com/apache/cordova-medic/pull/72#discussion_r50489182 --- Diff: medic/medic-run.js --- @@ -291,6 +293,29 @@ function failedBecauseNoDevice(output) { return NO_DEVICE_PATTERN.test(output); }

[GitHub] cordova-medic pull request: CB-10405 - Connectivity issue to Cordo...

Github user sarangan12 commented on the pull request: https://github.com/apache/cordova-medic/pull/72#issuecomment-173774638 @dblotsky Changed the name of the constant --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] cordova-docs pull request: CB-8917: Improving Android lifecycle do...

Github user nikhilkh commented on a diff in the pull request: https://github.com/apache/cordova-docs/pull/461#discussion_r50504102 --- Diff: www/docs/en/dev/guide/platforms/android/lifecycle.md --- @@ -116,10 +196,21 @@ onResume(event) { if(event.pendingResult) {

[GitHub] cordova-ios pull request: Disable ios-deploy wifi mode when deploy...

Github user mlegenhausen commented on the pull request: https://github.com/apache/cordova-ios/pull/190#issuecomment-173837624 Thanks for the hint. Commit updated. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] cordova-docs pull request: CB-8917: Improving Android lifecycle do...

Github user nikhilkh commented on a diff in the pull request: https://github.com/apache/cordova-docs/pull/461#discussion_r50504004 --- Diff: www/docs/en/dev/guide/platforms/android/lifecycle.md --- @@ -102,12 +178,16 @@ The possible plugin statuses in the `pendingResult` field

[GitHub] cordova-docs pull request: CB-8917: Improving Android lifecycle do...

Github user nikhilkh commented on a diff in the pull request: https://github.com/apache/cordova-docs/pull/461#discussion_r50503985 --- Diff: www/docs/en/dev/guide/platforms/android/lifecycle.md --- @@ -22,57 +22,127 @@ title: Android Lifecycle Guide # Android Lifecycle

[GitHub] cordova-docs pull request: CB-8917: Improving Android lifecycle do...

Github user nikhilkh commented on a diff in the pull request: https://github.com/apache/cordova-docs/pull/461#discussion_r50503967 --- Diff: www/docs/en/dev/guide/platforms/android/lifecycle.md --- @@ -80,14 +150,20 @@ The payload for the `resume` event adheres to the following

[GitHub] cordova-docs pull request: CB-8917: Improving Android lifecycle do...

Github user nikhilkh commented on a diff in the pull request: https://github.com/apache/cordova-docs/pull/461#discussion_r50503717 --- Diff: www/docs/en/dev/guide/platforms/android/lifecycle.md --- @@ -80,14 +150,20 @@ The payload for the `resume` event adheres to the following

[GitHub] cordova-docs pull request: CB-8917: Improving Android lifecycle do...

Github user nikhilkh commented on the pull request: https://github.com/apache/cordova-docs/pull/461#issuecomment-173819724 It will be useful to add references to Android docs. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] cordova-docs pull request: CB-8917: Improving Android lifecycle do...

Github user nikhilkh commented on a diff in the pull request: https://github.com/apache/cordova-docs/pull/461#discussion_r50503891 --- Diff: www/docs/en/dev/guide/platforms/android/lifecycle.md --- @@ -102,12 +178,16 @@ The possible plugin statuses in the `pendingResult` field

Re: --browserify workflow status?

YES YES YES! Please cordova_plugins.js is killing me. On Wed, Jan 20, 2016 at 4:10 PM Nikhil Khandelwal wrote: > Where are we with --browserify support? From what I can see, most or all > the work has been completed: > > https://issues.apache.org/jira/browse/CB-8801 > >

Re: [DISCUSS] Android@5.1.0

Sounds great! I'll post the blog for review soon and would love for you to add a little blurb about this in it. For docs, I say merge it in and I can update the site. It would fall into the `dev` branch unless you explicitly add the changes to 5.4.0 docs folder as well. I plan on cutting a 6.0.0

[GitHub] cordova-docs pull request: CB-10330 Adding style guide for xml ref...

Github user rakatyal commented on the pull request: https://github.com/apache/cordova-docs/pull/460#issuecomment-173686307 Addressed comments. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

Re: --browserify workflow status?

I've been using the --browserify flag for several months and it's been working great On 21 January 2016 at 11:02, Anis KADRI wrote: > YES YES YES! Please cordova_plugins.js is killing me. > > On Wed, Jan 20, 2016 at 4:10 PM Nikhil Khandelwal >

[GitHub] cordova-docs pull request: CB-10330 Adding style guide for xml ref...

Github user nikhilkh commented on the pull request: https://github.com/apache/cordova-docs/pull/460#issuecomment-173687010 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature