[Discuss] return statement in plugins js modules

Hi guys, working on some browserify issue I found out that some plugins use `return` statement to prevent logic from being loaded due to some reason (Api is natively supported, we are under Ripple emulation, etc) - see example below. This is totally fine since this will be wrapped in function

[GitHub] cordova-docs pull request: CB-10331 & CB-10436 - Improving Overvie...

Github user nikhilkh commented on a diff in the pull request: https://github.com/apache/cordova-docs/pull/465#discussion_r50803037 --- Diff: www/docs/en/dev/guide/overview/index.md --- @@ -45,39 +43,56 @@ Use Apache Cordova if you are: device-level APIs, or if you want to

[GitHub] cordova-docs pull request: CB-10331 & CB-10436 - Improving Overvie...

Github user rakatyal commented on a diff in the pull request: https://github.com/apache/cordova-docs/pull/465#discussion_r50796924 --- Diff: www/docs/en/dev/guide/overview/index.md --- @@ -45,39 +43,56 @@ Use Apache Cordova if you are: device-level APIs, or if you want to

[GitHub] cordova-docs pull request: CB-10331 & CB-10436 - Improving Overvie...

Github user nikhilkh commented on a diff in the pull request: https://github.com/apache/cordova-docs/pull/465#discussion_r50803345 --- Diff: www/docs/en/dev/guide/overview/index.md --- @@ -45,39 +43,56 @@ Use Apache Cordova if you are: device-level APIs, or if you want to

[GitHub] cordova-docs pull request: CB-10331 & CB-10436 - Improving Overvie...

Github user nikhilkh commented on a diff in the pull request: https://github.com/apache/cordova-docs/pull/465#discussion_r50803151 --- Diff: www/docs/en/dev/guide/overview/index.md --- @@ -45,39 +43,56 @@ Use Apache Cordova if you are: device-level APIs, or if you want to

[GitHub] cordova-docs pull request: CB-10331 & CB-10436 - Improving Overvie...

Github user nikhilkh commented on the pull request: https://github.com/apache/cordova-docs/pull/465#issuecomment-174881537 For future, consider splitting PRs - a PR should typically address 1 JIRA/issue --- If your project is set up for it, you can reply to this email and have your

[GitHub] cordova-plugin-camera pull request: Update CDVCamera.m

Github user Raaj19091 closed the pull request at: https://github.com/apache/cordova-plugin-camera/pull/157 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] cordova-mobile-spec pull request: CB-10439: Option for windows8 op...

Github user nikhilkh commented on the pull request: https://github.com/apache/cordova-mobile-spec/pull/135#issuecomment-174868989 +1 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] cordova-docs pull request: CB-10331 & CB-10436 - Improving Overvie...

Github user nikhilkh commented on a diff in the pull request: https://github.com/apache/cordova-docs/pull/465#discussion_r50802820 --- Diff: www/docs/en/dev/guide/overview/index.md --- @@ -45,39 +43,56 @@ Use Apache Cordova if you are: device-level APIs, or if you want to

RE: [DISCUSS] Cordova 6.0.0 Release!

Hey guys, I think there is a regression in tools, but I'm not sure where it's located. In short, there is a build failure when trying to build the app for windows platform after removing and re-adding the windows platform. For more details, please see CB-10432:

[GitHub] cordova-plugin-inappbrowser pull request: Feature/windows style

GitHub user stipegrbic opened a pull request: https://github.com/apache/cordova-plugin-inappbrowser/pull/140 Feature/windows style Styling aligned with other platforms Back button handling ![wp_ss_20160125_0001

[GitHub] cordova-windows pull request: don't copy resource-files at plugin ...

Github user biasmv commented on the pull request: https://github.com/apache/cordova-windows/pull/139#issuecomment-174499126 @sgrebnov: I've verified that it's still possible to have files in non-root folder locations. I've inserted the following into my project (which is essentially

[GitHub] cordova-plugin-splashscreen pull request: CB-10422 Splashscreen di...

GitHub user daserge opened a pull request: https://github.com/apache/cordova-plugin-splashscreen/pull/77 CB-10422 Splashscreen displays black screen with no image on Android [Jira issue](https://issues.apache.org/jira/browse/CB-10422) You can merge this pull request into a Git

[GitHub] cordova-plugin-camera pull request: Update CDVCamera.m

Github user jcesarmobile commented on the pull request: https://github.com/apache/cordova-plugin-camera/pull/157#issuecomment-174537581 Is this a mistake? it seems that it only removes the L from License --- If your project is set up for it, you can reply to this email and have your

RE: [DISCUSS] Old platforms support deprecation

Thanks, Steve, for clarification. And sorry for being unclear. - Best regards, Vladimir -Original Message- From: Steven Gill [mailto:stevengil...@gmail.com] Sent: Monday, January 25, 2016 10:17 PM To: dev@cordova.apache.org Subject: Re: [DISCUSS] Old platforms support deprecation

RE: [DISCUSS] Old platforms support deprecation

+1 for 6-month deprecation (or even earlier) for platforms where we have already released a platform with Platform API. Duplicated code can be a real maintenance problem here. For other platforms that we have not released a platform API implementation and do not plan to e.g. WP8, WebOS, Ubuntu

Re: [DISCUSS] Old platforms support deprecation

Nikhil, sounds reasonable. I originally misunderstood Vlads message. He isn't proposing the PlatformAPI Polyfill for deprecation. This is the code which is used by platforms that haven't released a platform API implementation. He is suggesting removing code from cordova-lib that supports *

[GitHub] cordova-plugin-camera pull request: Update CDVCamera.m

Github user purplecabbage commented on the pull request: https://github.com/apache/cordova-plugin-camera/pull/157#issuecomment-174626524 Yeah. Please close your experimental pull request. --- If your project is set up for it, you can reply to this email and have your reply appear

RE: [DISCUSS] inAppBrowser plugin release

I'm curious what caused the regression? Why do we not have tests for this important scenario? -Nikhil -Original Message- From: Steven Gill [mailto:stevengil...@gmail.com] Sent: Monday, January 25, 2016 1:19 AM To: dev@cordova.apache.org Subject: Re: [DISCUSS] inAppBrowser plugin

[GitHub] cordova-lib pull request: CB-10432 Fix plugin installation for new...

GitHub user vladimir-kotikov opened a pull request: https://github.com/apache/cordova-lib/pull/365 CB-10432 Fix plugin installation for newly added platform A fix for [CB-10432](https://issues.apache.org/jira/browse/CB-10432) You can merge this pull request into a Git repository by

[GitHub] cordova-cli pull request: Remove browserify from experimental flag...

Github user asfgit closed the pull request at: https://github.com/apache/cordova-cli/pull/231 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cordova-windows pull request: CB-10381 fix the bug when removing a...

Github user nikhilkh commented on the pull request: https://github.com/apache/cordova-windows/pull/140#issuecomment-174647257 Another scenario where we need more test coverage. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] cordova-mobile-spec pull request: CB-10439: Option for windows8 op...

GitHub user sarangan12 opened a pull request: https://github.com/apache/cordova-mobile-spec/pull/135 CB-10439: Option for windows8 option must be removed from cordova-mob… …ile-spec package Removed windows8 platform from the list @dblotsky @riknoll @nikhilkh

[GitHub] cordova-mobile-spec pull request: CB-10439: Option for windows8 op...

Github user riknoll commented on the pull request: https://github.com/apache/cordova-mobile-spec/pull/135#issuecomment-174759166 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] cordova-docs pull request: CB-10363: Cleaning up the 'plugin spec'...

Github user rakatyal commented on a diff in the pull request: https://github.com/apache/cordova-docs/pull/456#discussion_r5031 --- Diff: www/docs/en/dev/plugin_ref/spec.md --- @@ -345,17 +347,20 @@ associating the element's children with that platform. Platform names

[Vote] Tools Release!

Please review and vote on this Tools Release by replying to this email (and keep discussion on the DISCUSS thread) Release issue: https://issues.apache.org/jira/browse/CB-10424 Both tools have been published to dist/dev:https://dist.apache.org/repos/dist/dev/cordova/CB-10424/ The packages were

[GitHub] cordova-docs pull request: CB-10331 & CB-10436 - Improving Overvie...

Github user riknoll commented on a diff in the pull request: https://github.com/apache/cordova-docs/pull/465#discussion_r50783365 --- Diff: www/docs/en/dev/guide/overview/index.md --- @@ -45,39 +43,56 @@ Use Apache Cordova if you are: device-level APIs, or if you want to

[GitHub] cordova-docs pull request: CB-10331 & CB-10436 - Improving Overvie...

Github user sarangan12 commented on a diff in the pull request: https://github.com/apache/cordova-docs/pull/465#discussion_r50784016 --- Diff: www/docs/en/dev/guide/overview/index.md --- @@ -45,39 +43,56 @@ Use Apache Cordova if you are: device-level APIs, or if you want to

[GitHub] cordova-docs pull request: CB-10331 & CB-10436 - Improving Overvie...

Github user sarangan12 commented on a diff in the pull request: https://github.com/apache/cordova-docs/pull/465#discussion_r50784050 --- Diff: www/docs/en/dev/guide/overview/index.md --- @@ -45,39 +43,56 @@ Use Apache Cordova if you are: device-level APIs, or if you want to

[GitHub] cordova-docs pull request: CB-10331 & CB-10436 - Improving Overvie...

Github user riknoll commented on a diff in the pull request: https://github.com/apache/cordova-docs/pull/465#discussion_r50783262 --- Diff: www/docs/en/dev/guide/overview/index.md --- @@ -45,39 +43,56 @@ Use Apache Cordova if you are: device-level APIs, or if you want to

[GitHub] cordova-docs pull request: CB-10331 & CB-10436 - Improving Overvie...

Github user riknoll commented on a diff in the pull request: https://github.com/apache/cordova-docs/pull/465#discussion_r50783200 --- Diff: www/docs/en/dev/guide/overview/index.md --- @@ -45,39 +43,56 @@ Use Apache Cordova if you are: device-level APIs, or if you want to

[GitHub] cordova-docs pull request: CB-10363: Cleaning up the 'plugin spec'...

Github user rakatyal commented on a diff in the pull request: https://github.com/apache/cordova-docs/pull/456#discussion_r50777672 --- Diff: www/docs/en/dev/plugin_ref/spec.md --- @@ -98,12 +98,14 @@ Here's a list of the default engines that the `` tag supports: *

[GitHub] cordova-docs pull request: CB-10363: Cleaning up the 'plugin spec'...

Github user rakatyal commented on the pull request: https://github.com/apache/cordova-docs/pull/456#issuecomment-174737596 There is already a Jira (CB-10363) for this under Docs 6.x tag. Can you please refer to that one instead and close this one? --- If your project is set up for

[GitHub] cordova-ios pull request: Disable ios-deploy wifi mode when deploy...

Github user asfgit closed the pull request at: https://github.com/apache/cordova-ios/pull/190 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cordova-docs pull request: CB-10331 & CB-10436 - Improving Overvie...

GitHub user sarangan12 opened a pull request: https://github.com/apache/cordova-docs/pull/465 CB-10331 & CB-10436 - Improving Overview Page and fixing the Heading h2 size This PR consists of changes for 2 JIRAs. 1. Improving the Overview page 2. h2 size is smaller than

[GitHub] cordova-docs pull request: CB-10331 & CB-10436 - Improving Overvie...

Github user sarangan12 commented on a diff in the pull request: https://github.com/apache/cordova-docs/pull/465#discussion_r50783466 --- Diff: www/docs/en/dev/guide/overview/index.md --- @@ -45,39 +43,56 @@ Use Apache Cordova if you are: device-level APIs, or if you want to

[GitHub] cordova-windows pull request: don't copy resource-files at plugin ...

Github user sgrebnov commented on the pull request: https://github.com/apache/cordova-windows/pull/139#issuecomment-174453773 I like the idea, but I think we will miss `target` attribute support as resource-file will be always copied to root (pls correct me if I'm wrong). In some

[GitHub] cordova-windows pull request: don't copy resource-files at plugin ...

Github user sgrebnov commented on the pull request: https://github.com/apache/cordova-windows/pull/139#issuecomment-174454890 @nikhilkh - looks like the doc describing `target` support on windows and corresponding example exist in dev version only.We should make it released. --- If

[DISCUSS] inAppBrowser plugin release

On latest release of inAppBrowser plugin the loadstart event stopped working on android. It has been fixed on the 1.2.1-dev. Should we release it? I think loadstart is very important and a lot of apps rely on it for closing the window.

Re: [DISCUSS] inAppBrowser plugin release

+1 Lets do it! On Mon, Jan 25, 2016 at 1:00 AM, julio cesar sanchez wrote: > On latest release of inAppBrowser plugin the loadstart event stopped > working on android. > It has been fixed on the 1.2.1-dev. > Should we release it? > > I think loadstart is very important

[GitHub] cordova-windows pull request: CB-8056 Implement splashscreen for W...

Github user daserge commented on the pull request: https://github.com/apache/cordova-windows/pull/141#issuecomment-174487439 @purplecabbage, thanks for reviewing! The main reason to move the code to the platform was the need to hook into activated event so that the initial