Github user mbektchiev commented on the pull request:
https://github.com/apache/cordova-lib/pull/290#issuecomment-185053836
Won't fix.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this fea
Github user mbektchiev closed the pull request at:
https://github.com/apache/cordova-lib/pull/290
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the featur
Github user daserge commented on the pull request:
https://github.com/apache/cordova-mobile-spec/pull/138#issuecomment-185047527
I believe `HTML 5 Storage`->`storage.spec.9` and `storage.spec.17` can be
merged into one spec as they are testing the same thing.
---
If your project is
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-medic/pull/79
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature i
Github user dblotsky commented on the pull request:
https://github.com/apache/cordova-medic/pull/79#issuecomment-185016544
LGTM.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
e
Github user bso-intel closed the pull request at:
https://github.com/apache/cordova-lib/pull/387
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user TimBarham commented on the pull request:
https://github.com/apache/cordova-lib/pull/387#issuecomment-185005103
Thanks @bso-intel. I've merged this in
https://github.com/apache/cordova-lib/commit/87d8e171, but I rebased on forgot
to add "This closes #387" to the comment, so
Github user dblotsky commented on the pull request:
https://github.com/apache/cordova-mobile-spec/pull/138#issuecomment-185000962
LGTM.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this f
Github user bso-intel commented on the pull request:
https://github.com/apache/cordova-lib/pull/388#issuecomment-184999128
Thank you very much, Tim.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user bso-intel commented on the pull request:
https://github.com/apache/cordova-lib/pull/387#issuecomment-184998947
Hi @TimBarham
Thanks for reviewing this pull request.
I updated the comment as you requested.
---
If your project is set up for it, you can reply to this
Github user riknoll commented on the pull request:
https://github.com/apache/cordova-medic/pull/79#issuecomment-184983527
The issue here was that we currently don't have any way to test medic with
buildbot prior to pushing. These commits test fine locally, but due to some
quirk in bui
Github user rakatyal commented on the pull request:
https://github.com/apache/cordova-medic/pull/79#issuecomment-184982255
LGTM!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
e
Github user riknoll commented on the pull request:
https://github.com/apache/cordova-medic/pull/79#issuecomment-184981066
@rakatyal check it out
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not hav
GitHub user riknoll opened a pull request:
https://github.com/apache/cordova-medic/pull/79
Revert commits 7682cd7 and 90d06a3
This reverts commits 7682cd7205f153bc252ab8e1ef445169d34e11c2
and 90d06a39cbaf9313edae0fa3cc63a63003b65553 because they were
causing the cordova-andro
I took this down to debug some changes I made to medic-run for the Android CI.
I'll bring it back up in a bit.
Thanks,
Richard
-Original Message-
From: build...@apache.org [mailto:build...@apache.org]
Sent: Tuesday, February 16, 2016 5:42 PM
To: dev@cordova.apache.org
Subject: Buildbot:
The Buildbot working for ''
has noticed that the buildslave named cordova-osx-slave went away
It last disconnected at Wed Feb 17 01:37:09 2016 (buildmaster-local time)
The admin on record (as reported by BUILDSLAVE:info/admin)
was 'Dmitry Blotsky
'.
Sincerely,
The Buildbot
https://ci.apache.o
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-mobile-spec/pull/138
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the fe
Any issues with me starting this release?
I think I will wait for the cordova-common release to finish so I can
bundle it in.
Changes:
* CB-10510: Add an optional timeout to emu start script
* CB-10498: Resume event should be sticky if it has a plugin result
* fix HtmlNotFoundTest so that it pass
Blog post for review.
https://github.com/apache/cordova-docs/pull/502
Add any comments to the PR
On Thu, Feb 11, 2016 at 4:28 PM, Steven Gill wrote:
>
> Does anyone have any reason to delay a cordova-osx platform release?
> Any outstanding patches to land?
>
> If not, I will start the release.
GitHub user stevengill opened a pull request:
https://github.com/apache/cordova-docs/pull/502
added osx release blog post
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/stevengill/cordova-docs master
Alternatively you can revie
Hey
https://issues.apache.org/jira/browse/CB-10625
For some reason Google Photos breaks the Camera's Gallery API, and I'm
having trouble trying to fix this one. For some reason I can't get the
FileHelper to work with the new file URI that's being provided by an
application. Is there something o
Github user rakatyal commented on the pull request:
https://github.com/apache/cordova-mobile-spec/pull/138#issuecomment-184941366
LGTM!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this f
GitHub user shazron opened a pull request:
https://github.com/apache/cordova-ios/pull/193
CB-10530 - App freezes sometimes directly after starting on iOS
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/shazron/cordova-ios CB-1053
GitHub user agilethomas opened a pull request:
https://github.com/apache/cordova-plugin-device/pull/49
CB-10631 ios: Fix for device.uuid in iOS 5.1.1
- Check if identifierForVendor exists and if not create a new UUID
and store in on the device for future use.
You can merge thi
GitHub user sarangan12 opened a pull request:
https://github.com/apache/cordova-mobile-spec/pull/138
CB-10595: Windows Store 8.1 builds finish with warning 'Expected undefined
to be defined' on running mobilespec storage tests
IE does not support openDatabase method. So, marking the
Github user riknoll commented on the pull request:
https://github.com/apache/cordova-medic/pull/77#issuecomment-184904386
Merged in 90d06a39cbaf9313edae0fa3cc63a63003b65553
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well.
Github user riknoll closed the pull request at:
https://github.com/apache/cordova-medic/pull/77
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Hi everyone!
Here's the latest status for our continuous integration (CI) machinery, broken
down by platforms:
BuildersStatus
Issues
Cordova-osx Success
C
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-app-hello-world/pull/15
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user dblotsky commented on the pull request:
https://github.com/apache/cordova-app-hello-world/pull/15#issuecomment-184885794
Cool, seems like we've reached a consensus. Merging!
---
If your project is set up for it, you can reply to this email and have your
reply appear on Gi
Github user nikhilkh commented on the pull request:
https://github.com/apache/cordova-android/pull/260#issuecomment-184884824
How can we test this?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user dblotsky commented on the pull request:
https://github.com/apache/cordova-plugin-geolocation/pull/71#issuecomment-184882741
LGTM.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-plugin-geolocation/pull/71
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-android/pull/258
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the featur
GitHub user sarangan12 opened a pull request:
https://github.com/apache/cordova-plugin-geolocation/pull/71
CB-10574: MobileSpec can't get results for WP8.1 Builds
Adding 'var' to make the variable local.
@dblotsky @rakatyal Can you review and merge this PR?
You can merge th
Check out the default template we use in TACO-CLI.
Index.js is a lot simpler and we adopted the new Cordova typeface. If folks
like this template, we could issue a PR for it.
rjs
Ryan J. Salva | Principal PM Manager
Visual Studio Tools for Apache Cordova
rsa...@microsoft.com
425 706 5270 off
Personally, I think we should rewrite/simplify that template ALOT.
The app binding stuff is confusing to users, but not potentially any less
confusing with PR#15. The use of an object is the issue in my mind.
Also, if this is the starting point for a new developer, they will soon
wonder why everyt
I do agree that our starter app needs to change. However, we encountered this
when we were looking at documenting, and our object of concern was the way
events are bound. My suggestion would be to simply fix the event binding so
that the docs are less confusing.
We could then look at re-writin
+1 for the template change
LGTM
This conversation made it sound like this was going to suggest binding
offline/online etc in deviceready. Glad to see that's not the case in the
template at least.
I would discourage teaching people that they need to wait for Cordova’s
deviceready before bindin
Github user devgeeks commented on the pull request:
https://github.com/apache/cordova-app-hello-world/pull/15#issuecomment-184856505
LGTM. That third layer of binding always seemed confusing.
:+1:
---
If your project is set up for it, you can reply to this email and have yo
Github user NGumby commented on the pull request:
https://github.com/apache/cordova-plugin-inappbrowser/pull/99#issuecomment-184857676
I think a better approach to communicate between an external website and
the app, is to raise an event in shouldOverrideLoadUrl like this :
`
The vote has now closed. The results are:
Positive Binding Votes: 3
Steve Gill
Mefire O
Tobias Bocanegra
The vote has passed. I will now publish to dist and npm. I'll share
the blog post for review too.
On Fri, Feb 12, 2016 at 2:16 PM, Tobias Bocanegra
wrote:
> I vote +1:
> - ran: mobile-spec
Will do.
-Original Message-
From: Steven Gill [mailto:stevengil...@gmail.com]
Sent: Tuesday, February 16, 2016 10:44 AM
To: dev@cordova.apache.org
Subject: Re: [DISCUSS] Update to starter template
LGTM
Could you also add the keyword 'cordova:template' to package.json?
On Tue, Feb 16,
LGTM
Could you also add the keyword 'cordova:template' to package.json?
On Tue, Feb 16, 2016 at 9:58 AM, Parashuram N
wrote:
> :) Sounds good
>
> Anyone else have any objections to the change ?
>
> -Original Message-
> From: Carlos Santana [mailto:csantan...@gmail.com]
> Sent: Monday, F
Github user riknoll commented on the pull request:
https://github.com/apache/cordova-android/pull/258#issuecomment-184821410
@omefire
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this fea
Github user nikhilkh commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/383#discussion_r53056714
--- Diff: cordova-lib/src/cordova/compile.js ---
@@ -40,7 +40,7 @@ module.exports = function compile(options) {
}).then(function() {
Github user riknoll commented on the pull request:
https://github.com/apache/cordova-docs/pull/471#issuecomment-184817446
Rebased to master and updated to fix the redirects merged in with #494
---
If your project is set up for it, you can reply to this email and have your
reply appea
Cutting releases don't cost $$, just some time
We just try to minimize effort and consolidate many bugs that are ready for
one release.
if we have a fix that can make it in the release window that's OK to wait,
but we can always do a bug release today, and another bug release when that
bug is fix
Github user riknoll commented on the pull request:
https://github.com/apache/cordova-android/pull/258#issuecomment-184808170
@vladimir-kotikov can you take a quick look at this? I want to make sure
I'm not messing with the platform API at all given that we don't have any tests
for thi
:) Sounds good
Anyone else have any objections to the change ?
-Original Message-
From: Carlos Santana [mailto:csantan...@gmail.com]
Sent: Monday, February 15, 2016 7:51 PM
To: dev@cordova.apache.org
Subject: Re: [DISCUSS] Update to starter template
I'm always in favor of having simple
Github user nikhilkh commented on the pull request:
https://github.com/apache/cordova-android/pull/259#issuecomment-184778783
LGTM. How can we add tests for this scenario?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. I
GitHub user daserge opened a pull request:
https://github.com/apache/cordova-android/pull/260
CB-10628 Fix emulate android --target
[Jira issue](https://issues.apache.org/jira/browse/CB-10628)
You can merge this pull request into a Git repository by running:
$ git pull https://
Sorry for the typo. I meant
If I install a piece of software component version 1.2.3 today, and install
version 1.2.3 a week after I'm expecting to reproduce the same environment.
Net is that a user complains to us about problem, we should be able to
reproduce it if we know the version number, and
I'm not big fan of dynamic dependencies, but I'm fan a predictable and
reproducible environments
managing dependencies during development is much different than managing
dependencies when go live into production.
Take into account that not just the cordova code that runs on the phone
runtime I co
Github user eymorale commented on the pull request:
https://github.com/apache/cordova-plugin-whitelist/pull/17#issuecomment-184741324
@infil00p and @csantanapr can you take a look at this and see if you have
any problems with it?
---
If your project is set up for it, you can reply t
GitHub user eymorale opened a pull request:
https://github.com/apache/cordova-plugin-whitelist/pull/17
CB-10624 remove error message from whitelist.js, which leaves it empty
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/eymoral
https://issues.apache.org/jira/browse/CB-10530 is a showstopper for quite a
few people. If that ever requires changes to cordova-ios, I'm voting that
the bugfix releases wait for it or that we find a workaround that isn't
uninstalling every plugin.
2016-02-16 1:58 GMT-02:00 Carlos Santana :
> Tom
GitHub user TanaseButcaru opened a pull request:
https://github.com/apache/cordova-plugin-media-capture/pull/54
new MediaFile() - fix wrong property name for localURL
If manually created a ``MediaFile`` object and calling ``getFormatData`` on
it, it will run into an error with code
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-plugin-camera/pull/171
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
GitHub user alsorokin opened a pull request:
https://github.com/apache/cordova-plugin-camera/pull/171
CB-10619 Appium tests: Properly switch to webview
https://issues.apache.org/jira/browse/CB-10619
You can merge this pull request into a Git repository by running:
$ git pull ht
Github user TimBarham commented on the pull request:
https://github.com/apache/cordova-lib/pull/384#issuecomment-184676141
Thanks @vladimir-kotikov. Looks good on a quick look through. Will take a
closer look in the morning.
---
If your project is set up for it, you can reply to this
Yes, a new patch release, I think.
Can't wait when we start to install platforms as packages - then we won't need
to bundle everything :)
-
Best regards, Vladimir
-Original Message-
From: Carlos Santana [mailto:csantan...@gmail.com]
Sent: Tuesday, February 16, 2016 3:23 PM
To: dev@cordo
Github user vladimir-kotikov commented on the pull request:
https://github.com/apache/cordova-lib/pull/384#issuecomment-184667609
@TimBarham, updated
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does no
Vladimir,
I forgot about that it's a bundled dependency. No blog is need it then
But a new Windows platform release will be required to be able to pick up the
new cordova-commons release right?
- Carlos
@csantanapr
On Feb 16, 2016, at 5:23 AM, Vladimir Kotikov (Akvelon)
wrote:
>> cordova-w
Github user TimBarham commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/384#discussion_r52993992
--- Diff: cordova-lib/src/cordova/build.js ---
@@ -17,22 +17,26 @@
under the License.
*/
-var cordovaUtil = require('./util
> cordova-windows won't as it has the dependency listed as ^1.0.0 which
> includes minor releases.
IMO since cordova-common is a bundled dependency, we still need for new release
to bundle new version.
A small question - do we need for blog post for this release? I'd say no, as we
releasing som
Github user andorman commented on the pull request:
https://github.com/apache/cordova-windows/pull/149#issuecomment-184611560
@sgrebnov Sorry for screwing up my previous PR, I opened a new one instead.
I hope it's alright this time.
---
If your project is set up for it, you can reply
GitHub user andorman opened a pull request:
https://github.com/apache/cordova-lib/pull/392
CB-10622 fix target attribute being ignored for images in config.xml
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/andorman/cordova-lib
Please review and vote on this Cordova-common Release
by replying to this email (and keep discussion on the DISCUSS thread)
Release issue: https://issues.apache.org/jira/browse/CB-10626
Both tools have been published to dist/dev:
https://dist.apache.org/repos/dist/dev/cordova/CB-10626/
The packa
GitHub user andorman opened a pull request:
https://github.com/apache/cordova-windows/pull/149
CB-10622 fix targetsize images being ignored
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/andorman/cordova-windows master
Alternat
Github user vladimir-kotikov commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/384#discussion_r52985929
--- Diff: cordova-lib/src/cordova/build.js ---
@@ -17,22 +17,26 @@
under the License.
*/
-var cordovaUtil = require(
Github user TimBarham commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/384#discussion_r52984062
--- Diff: cordova-lib/src/cordova/build.js ---
@@ -17,22 +17,26 @@
under the License.
*/
-var cordovaUtil = require('./util
Github user andorman closed the pull request at:
https://github.com/apache/cordova-windows/pull/148
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feat
Github user andorman closed the pull request at:
https://github.com/apache/cordova-lib/pull/391
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
74 matches
Mail list logo
