Github user rakatyal commented on the pull request:
https://github.com/apache/cordova-plugin-media/pull/89#issuecomment-203159625
LGTM.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this f
The Buildbot working for ''
has noticed that the buildslave named cordova-windows-slave went away
It last disconnected at Tue Mar 29 23:02:35 2016 (buildmaster-local time)
The admin on record (as reported by BUILDSLAVE:info/admin)
was 'Dmitry Blotsky
'.
Sincerely,
The Buildbot
https://ci.apac
The Buildbot working for ''
has noticed that the buildslave named cordova-osx-slave went away
It last disconnected at Tue Mar 29 22:36:41 2016 (buildmaster-local time)
The admin on record (as reported by BUILDSLAVE:info/admin)
was 'Dmitry Blotsky
'.
Sincerely,
The Buildbot
https://ci.apache.o
Github user dblotsky commented on a diff in the pull request:
https://github.com/apache/cordova-docs/pull/569#discussion_r57813112
--- Diff: www/.htaccess ---
@@ -18,29 +18,31 @@ RewriteEngine on
# pages to new pages.
# 302 (temp):
-# docs -> docs
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-android/pull/285
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the featur
Github user rakatyal commented on the pull request:
https://github.com/apache/cordova-plugin-media/pull/89#issuecomment-203137750
Is there any reason to specify the upper bound?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Hey,
While the discussion on including additional tools is still happening on the
mailing list, I had a quick question about the Evothings Studio. I was looking
at the website and it was not clear if the tool is based on Cordova/Phonegap.
Is Evothiongs based on Cordova and are the device APIs b
Github user rakatyal commented on the pull request:
https://github.com/apache/cordova-windows/pull/163#issuecomment-203131675
Also I couldn't understand the reason for creating a new testproj
directory. Couldn't we have used the existing DummyProject repo for this?
---
If your projec
I think it would not be fair to say "submissions now closed", since we had
never initially mentioned such a timeframe for submitting apps. The question
is, if more folks submit apps, what is the policy on accepting them ?
-Original Message-
From: Dmitry Blotsky [mailto:dblot...@microsof
I agree that we should not call these tests yet - they are just
showcases/examples. Let me ask if the folks contributing the example are ok
with contributing them to an Apache repo. The only hesitation they may have is
that some of these examples may include services from a specific company, tha
We do not have platforms that are specific for browser-extensions. Browser
extensions in themselves may not blend well with the "plugin model" or don't
really need a "bridge", two of the key things that Cordova provides.
Also, most modern browsers have "similar" ways to build extensions, so I am
Github user riknoll commented on a diff in the pull request:
https://github.com/apache/cordova-docs/pull/569#discussion_r57806664
--- Diff: www/.htaccess ---
@@ -18,29 +18,31 @@ RewriteEngine on
# pages to new pages.
# 302 (temp):
-# docs -> docs/
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-plugin-contacts/pull/111
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if th
Github user sarangan12 commented on the pull request:
https://github.com/apache/cordova-plugin-media/pull/89#issuecomment-203122183
Locally always...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does n
Github user dblotsky commented on the pull request:
https://github.com/apache/cordova-docs/pull/569#issuecomment-203118863
@rakatyal @riknoll ping.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
GitHub user omefire opened a pull request:
https://github.com/apache/cordova-plugin-contacts/pull/111
CB-10881 Add extra logging to gather more information about tests behavior
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/omef
Hey folks,
Here is the CI status for last week. Sorry that I missed sending it yesterday!
Build Status (# of test failures):
3 - Android on Windows
3 - Android on OS X
13 - iOS
0 - WP 8.1
0 - Windows
JIRAs that need attention:
- CB-10944: NoSuchMethodError in InAppBrowser plugin
- CB-10933: Wind
Github user riknoll commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/198#issuecomment-203109141
So, I've done a bit of testing on Marshmallow and it seems like this works
pretty well. It does have the caveat of returning a `content://` URI, but that
Github user jcesarmobile commented on the pull request:
https://github.com/apache/cordova-plugin-statusbar/pull/53#issuecomment-203104592
LGTM
The bug I told you about on slack was already present, it's not caused by
this code. I'll file a new issue for it.
---
If your pro
Github user rakatyal commented on a diff in the pull request:
https://github.com/apache/cordova-windows/pull/163#discussion_r57799518
--- Diff: template/cordova/lib/PluginHandler.js ---
@@ -85,12 +85,12 @@ var handlers = {
var src = obj.src;
var des
Github user rakatyal commented on a diff in the pull request:
https://github.com/apache/cordova-windows/pull/163#discussion_r57799378
--- Diff: template/cordova/lib/PluginHandler.js ---
@@ -85,12 +85,12 @@ var handlers = {
var src = obj.src;
var des
Github user riknoll commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/199#issuecomment-203098986
I believe we do actually require that permission even in API level 19+. The
current code requires access to the photos directory, which is outside of the
Github user rakatyal commented on a diff in the pull request:
https://github.com/apache/cordova-windows/pull/163#discussion_r57798321
--- Diff: spec/unit/pluginHandler/windows.spec.js ---
@@ -441,40 +451,47 @@ describe('windows project handler', function () {
});
Github user rakatyal commented on a diff in the pull request:
https://github.com/apache/cordova-windows/pull/163#discussion_r57797833
--- Diff: spec/unit/pluginHandler/windows.spec.js ---
@@ -164,6 +164,7 @@ describe('windows project handler', function () {
}
Github user rakatyal commented on a diff in the pull request:
https://github.com/apache/cordova-windows/pull/163#discussion_r57797472
--- Diff: spec/unit/pluginHandler/windows.spec.js ---
@@ -305,17 +306,25 @@ describe('windows project handler', function () {
var fr
Can you merge and include CB-10927 [1] ?
[1]: https://github.com/apache/cordova-windows/pull/163
On Tue, Mar 29, 2016 at 10:47 AM Vladimir Kotikov (Akvelon) <
v-vlk...@microsoft.com> wrote:
> Hi all
>
> We'd like to do a cordova-windows patch release to fix the following
> issues:
> * CB-108
I did, but as my reply said, it wasn't showing up.
Regards
*Rob Posener*
0419 012 627
On 30 March 2016 at 05:01, Jesse wrote:
> Good observations Julio, we should definitely talk to stack-overflow about
> the merged tags.
>
> Robert, you didn't send the pull request back to cordova/cordova-disc
I put apps and tools in the same bucket when it came to adding them to the
site. I interpreted our last discussion as, “we’ve gotten enough; close the
submissions now”. If we’re cool to still add this tool, then let’s just add it.
Kindly,
Dmitry
On Mar 29, 2016, at 7:53 AM, julio cesar sanchez
Good observations Julio, we should definitely talk to stack-overflow about
the merged tags.
Robert, you didn't send the pull request back to cordova/cordova-discuss,
so no one could see it. I have done so here:
https://github.com/cordova/cordova-discuss/pull/35
@purplecabbage
risingj.com
On
Is it possible to create browser extensions with Cordova?
> cordova platform add safari-extension
> cordova platform add chrome-extension
> cordova platform add explorer-extension
Best,
Tim
ᐧ
Github user riknoll commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-media-capture/pull/59#discussion_r57764840
--- Diff: src/android/Capture.java ---
@@ -250,13 +304,17 @@ private static void createWritableFile(File file)
throws IOException {
Calling these 'tests' to me is way out of scope, and very easily broken.
Adding a demo project to a plugin makes sense from both a development
perspective AND a demonstration perspective. When developing, you need
something to actually exercise the api you are writing, so putting this in
the repo
Github user infil00p commented on the pull request:
https://github.com/apache/cordova-plugin-media-capture/pull/59#issuecomment-203012656
LGTM. Don't be afraid to delete conditionals that check for things that are
below the minimum supported API.
---
If your project is set up for it
Github user infil00p commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-media-capture/pull/59#discussion_r57764130
--- Diff: src/android/Capture.java ---
@@ -250,13 +304,17 @@ private static void createWritableFile(File file)
throws IOException {
Github user riknoll commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-file/pull/174#discussion_r57762270
--- Diff: src/android/FileUtils.java ---
@@ -1151,51 +1140,55 @@ private long truncateFile(String srcURLstr, long
size) throws FileNotFoundExcept
Github user jasongin commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-file/pull/174#discussion_r57761716
--- Diff: src/android/FileUtils.java ---
@@ -1151,51 +1140,55 @@ private long truncateFile(String srcURLstr, long
size) throws FileNotFoundExcep
Github user csantanapr commented on the pull request:
https://github.com/apache/cordova-windows/pull/163#issuecomment-202988290
ping @rakatyal can you review this PR and merge if its good
---
If your project is set up for it, you can reply to this email and have your
reply appear on G
GitHub user mehmetcodes opened a pull request:
https://github.com/apache/cordova-plugin-camera/pull/199
Update plugin.xml
In principle Cordova should not use a permission where it is no longer
relevant as it might leave things less secure.
You can see this documentation her
I meant rejecting because it was an old PR and it was rejected now.
But even if there is no button, people can still send PRs. It's less
likely, but still possible. And as most of the topic here was about apps, I
wanted to know if we have an official statement for tools.
So, if I review this too
Hi all
We'd like to do a cordova-windows patch release to fix the following issues:
* CB-10845 Invalidate manifest cache in prepare (a4c673e3)
* CB-10714 Ignore case for --archs (49812d44)
* CB-10138 Adds missing plugin metadata to plugin_list module for Windows
(45e5bd13)
The proposed ver
Please review and vote on this Tools Release by replying to this email (and
keep discussion on the DISCUSS thread)
Release issue: https://issues.apache.org/jira/browse/CB-10980
Both tools have been published to dist/dev:
https://dist.apache.org/repos/dist/dev/cordova/CB-10980
The packages were
Github user mikaelkindborg commented on the pull request:
https://github.com/apache/cordova-docs/pull/410#issuecomment-202922042
@jcesarmobile Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does n
"With great power comes great responsibilities"
Adding this would require responsibilities of maintenance and up to date
working examples backed up with CI.
In other words it's good idea to add docs with more complex examples on how
to use the plugin, some of them already are located in mobilespe
Julio "rejecting" sounds so harsh
Since we removed the "add app" and "add tool" from the webpage, there is no
process to submit something to be accepted or rejected
I think right now my opinion is that a PMC member would need to do the leg
work to review, propose something to be added, and do the
GitHub user daserge opened a pull request:
https://github.com/apache/cordova-plugin-statusbar/pull/53
CB-10884 Inappbrowser breaks UI while Screen orientation changes fromâ¦
⦠landscape to portrait on iOS
[Jira issue](https://issues.apache.org/jira/browse/CB-10884)
You c
Github user jcesarmobile commented on the pull request:
https://github.com/apache/cordova-docs/pull/410#issuecomment-202902395
We are still discussing it, we'll let you know when something is decided.
---
If your project is set up for it, you can reply to this email and have your
repl
I bring the topic back again because recently a tool was rejected and the
author mailed us asking (and we have not answered him yet)
So, are we rejecting tools too?
The original topic was "[DISCUSS] Curating Apps" and all the messages were
about apps, except this one from Steve that mentions remo
The vote has failed. I will start a new VOTE thread soon
-
Best regards, Vladimir
-Original Message-
From: Carlos Santana [mailto:csantan...@gmail.com]
Sent: Friday, March 25, 2016 4:59 PM
To: dev@cordova.apache.org
Subject: Re: [Vote] Tools Release
I vote -1
I think this is a critical
Created a jira for cordova-common removal from lib package:
CB-10981 Cordova-lib should not bundle cordova-common anymore
(https://issues.apache.org/jira/browse/CB-10981)
-
Best regards, Vladimir
-Original Message-
From: Carlos Santana [mailto:csantan...@gmail.com]
Sent: Friday, March
Github user mikaelkindborg commented on the pull request:
https://github.com/apache/cordova-docs/pull/410#issuecomment-202873303
@dblotsky Hi, I emailed the dev list as you suggested, but got no response
as far as I can tell. Note that this pull request is not the app showcase, but
fo
I agree, we can discuss later the release for cordova-commons
- Carlos
@csantanapr
> On Mar 29, 2016, at 7:27 AM, Vladimir Kotikov (Akvelon)
> wrote:
>
> Carlos, I've reviewed and merged these PRs. However the only two PRs that
> need to be included into this release are #415 [1] and #416 [2]
Joe said:
"I also find it interesting that people are hating on Cordova, and not
PhoneGap, Ionic, Taco or the other distributions."
It's curious that Ionic has it's own tag, with about the same number of
questions that Cordova tag, but it's not on any of the lists (and it's not
because all Ionic
Carlos, I've reviewed and merged these PRs. However the only two PRs that need
to be included into this release are #415 [1] and #416 [2]. The other two are
for cordova-common and I guess we have nothing to do with them for now.
Summarizing, the release notes for 6.1.1 will look like this:
###
GitHub user daserge opened a pull request:
https://github.com/apache/cordova-plugin-splashscreen/pull/96
CB-10979 Fix splashscreen ios native tests
Added jshintignore for tests/ios
[Jira issue](https://issues.apache.org/jira/browse/CB-10979)
You can merge this pull request
Github user vladimir-kotikov commented on the pull request:
https://github.com/apache/cordova-lib/pull/416#issuecomment-202818205
@csantanapr, i merged a bit different change, which uses `preparePlatforms`
method instead of `prepare` .It is a subset of `prepare` but doesn't include
th
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-lib/pull/416
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-lib/pull/415
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-lib/pull/418
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-lib/pull/417
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user elsewhat commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/198#issuecomment-202773421
Pull request has been tested by debugging. The cordova-plugin-camera plugin
was added to a local cordova project from my forked repository and the new
c
GitHub user elsewhat opened a pull request:
https://github.com/apache/cordova-plugin-camera/pull/198
CB-10857 android : Camera.getPicture return null for Google Drive (camera
2.1.1)
FileHelper getRealPath will fallback to URI string if no other type of
path has been found
You c
Github user vladimir-kotikov commented on the pull request:
https://github.com/apache/cordova-lib/pull/418#issuecomment-202768180
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this fea
Github user daserge commented on the pull request:
https://github.com/apache/cordova-lib/pull/418#issuecomment-202764912
Addressed, thanks @vladimir-kotikov, please take a look when you have a
moment.
---
If your project is set up for it, you can reply to this email and have your
rep
63 matches
Mail list logo
