[GitHub] cordova-plugin-whitelist pull request: CB-10866: Adding engine inf...

2016-05-12 Thread stewshka
Github user stewshka commented on the pull request: https://github.com/apache/cordova-plugin-whitelist/pull/18#issuecomment-218947372 My visual studio complains that the "engines" item must have an object as its value. But when I paste your code, i get a complain that the

[GitHub] cordova-plugin-camera pull request: [CB-5195][CB-4078]: correctOri...

2016-05-12 Thread swbradshaw
Github user swbradshaw commented on the pull request: https://github.com/apache/cordova-plugin-camera/pull/197#issuecomment-218930850 @riknoll I just removed a big chunk of the whitespace changes that were done by Android Studio. I find myself having to manually copy changes from my

[GitHub] cordova-coho pull request: CB-7904 Built nightly releases using co...

2016-05-12 Thread nikhilkh
Github user nikhilkh commented on the pull request: https://github.com/apache/cordova-coho/pull/116#issuecomment-218924426 LGTM otherwise --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] cordova-plugin-camera pull request: CB-10139 browser: Respect targ...

2016-05-12 Thread kicken
Github user kicken commented on the pull request: https://github.com/apache/cordova-plugin-camera/pull/210#issuecomment-218919902 @nikhilkh Nothing in particular. My main target is a mobile app, but I happen to do a lot of preliminary testing in google chrome's device mode using

[GitHub] cordova-coho pull request: CB-7904 Built nightly releases using co...

2016-05-12 Thread nikhilkh
Github user nikhilkh commented on a diff in the pull request: https://github.com/apache/cordova-coho/pull/116#discussion_r63115159 --- Diff: src/nightly.js --- @@ -66,38 +82,19 @@ module.exports = function*(argv) { yield gitutil.resetFromOrigin(); })

RE: [DISCUSS] Cordova tools release

2016-05-12 Thread Nikhil Khandelwal
We'll need a cordova-ios release to make that happen. However, cordova-ios has a recent regression that needs to be fixed before we make a release: https://github.com/apache/cordova-ios/commit/cab0baa0f7c4d789171b0147da41a85471660c85 -Nikhil -Original Message- From: Carlos Santana

[GitHub] cordova-lib pull request: Improving prepare and build output

2016-05-12 Thread riknoll
Github user riknoll commented on the pull request: https://github.com/apache/cordova-lib/pull/439#issuecomment-218911859 @stevengill done! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] cordova-lib pull request: Improving prepare and build output

2016-05-12 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-lib/pull/439 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cordova-lib pull request: Improving prepare and build output

2016-05-12 Thread stevengill
Github user stevengill commented on the pull request: https://github.com/apache/cordova-lib/pull/439#issuecomment-218910842 Passed! Lets merge this in @riknoll :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] cordova-plugin-camera pull request: [CB-5195][CB-4078]: correctOri...

2016-05-12 Thread riknoll
Github user riknoll commented on the pull request: https://github.com/apache/cordova-plugin-camera/pull/197#issuecomment-218908787 @JEGardner apologies, this is a pretty big change and I haven't had an opportunity to review/test it. I'll try and take a look at it this week. In the

[GitHub] cordova-plugin-camera pull request: [CB-5195][CB-4078]: correctOri...

2016-05-12 Thread JEGardner
Github user JEGardner commented on the pull request: https://github.com/apache/cordova-plugin-camera/pull/197#issuecomment-218907133 @riknoll any chance we could get this merged so we can use the official repo and not a fork? Seems like a pretty important bug to fix? --- If your

[GitHub] cordova-lib pull request: Improving prepare and build output

2016-05-12 Thread stevengill
Github user stevengill commented on the pull request: https://github.com/apache/cordova-lib/pull/439#issuecomment-218906307 Travis taking forever On Thu, May 12, 2016 at 2:34 PM, Richard Knoll wrote: > I'll merge whenever the Travis

[GitHub] cordova-plugin-console pull request: Dummy Entry

2016-05-12 Thread cordova-qa
Github user cordova-qa commented on the pull request: https://github.com/apache/cordova-plugin-console/pull/18#issuecomment-218898614 Cordova CI Build has one or more failures. **Dashboard** - http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-console/93/

[GitHub] cordova-plugin-console pull request: Dummy Entry

2016-05-12 Thread cordova-qa
Github user cordova-qa commented on the pull request: https://github.com/apache/cordova-plugin-console/pull/18#issuecomment-218896610 Let there be tests --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] cordova-plugin-camera pull request: CB-10139 browser: Respect targ...

2016-05-12 Thread nikhilkh
Github user nikhilkh commented on the pull request: https://github.com/apache/cordova-plugin-camera/pull/210#issuecomment-218896661 @kicken These are great changes - I'm curious what are you using the browser platform's camera implementation for? --- If your project is set up for

[GitHub] cordova-plugin-camera pull request: Camera permissions added

2016-05-12 Thread nikhilkh
Github user nikhilkh commented on the pull request: https://github.com/apache/cordova-plugin-camera/pull/98#issuecomment-218894709 WebRTC usage is not related to camera plugin. You should perhaps use a hook to add the permission to your manifest. --- If your project is set up for

[GitHub] cordova-plugin-camera pull request: CB-10370: Added option useGeol...

2016-05-12 Thread nikhilkh
Github user nikhilkh commented on the pull request: https://github.com/apache/cordova-plugin-camera/pull/153#issuecomment-218893492 This code has some merge conflicts. It makes sense to move away from a preference and use an option. Also, now the docs for plugin-camera are generated

[GitHub] cordova-plugin-console pull request: Dummy Entry

2016-05-12 Thread cordova-qa
Github user cordova-qa commented on the pull request: https://github.com/apache/cordova-plugin-console/pull/18#issuecomment-218893182 Cordova CI Build has one or more failures. **Dashboard** - http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-console/92/

[GitHub] cordova-lib pull request: Improving prepare and build output

2016-05-12 Thread riknoll
Github user riknoll commented on the pull request: https://github.com/apache/cordova-lib/pull/439#issuecomment-218892839 I'll merge whenever the Travis build finishes --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] cordova-medic pull request: CB-11232:

2016-05-12 Thread nikhilkh
Github user nikhilkh commented on the pull request: https://github.com/apache/cordova-medic/pull/103#issuecomment-218892354 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] cordova-lib pull request: Improving prepare and build output

2016-05-12 Thread nikhilkh
Github user nikhilkh commented on the pull request: https://github.com/apache/cordova-lib/pull/439#issuecomment-218892010 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] cordova-plugin-console pull request: Dummy Entry

2016-05-12 Thread sarangan12
Github user sarangan12 commented on the pull request: https://github.com/apache/cordova-plugin-console/pull/18#issuecomment-218891497 Let there be tests --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] cordova-windows pull request: Improving Windows build output and v...

2016-05-12 Thread riknoll
Github user riknoll commented on the pull request: https://github.com/apache/cordova-windows/pull/176#issuecomment-21889 @jasongin removed the word please pretty much everywhere --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] cordova-plugin-console pull request: Dummy Entry

2016-05-12 Thread cordova-qa
Github user cordova-qa commented on the pull request: https://github.com/apache/cordova-plugin-console/pull/18#issuecomment-218887906 Cordova CI Build has one or more failures. **Dashboard** - http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-console/91/

[GitHub] cordova-lib pull request: Improving prepare and build output

2016-05-12 Thread jasongin
Github user jasongin commented on the pull request: https://github.com/apache/cordova-lib/pull/439#issuecomment-218885704 :shipit: --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] cordova-plugin-console pull request: Dummy Entry

2016-05-12 Thread sarangan12
Github user sarangan12 commented on the pull request: https://github.com/apache/cordova-plugin-console/pull/18#issuecomment-218885454 Let there be tests --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] cordova-lib pull request: Improving prepare and build output

2016-05-12 Thread riknoll
Github user riknoll commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/439#discussion_r63097000 --- Diff: cordova-lib/src/cordova/plugin.js --- @@ -286,7 +286,7 @@ module.exports = function plugin(command, targets, opts) {

[GitHub] cordova-medic pull request: Reorganized the config files and split...

2016-05-12 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-medic/pull/105 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

Re: [DISCUSS] Cordova tools release

2016-05-12 Thread Carlos Santana
Do we fully support node6 now? If we do might be good to highlight in blog post - Carlos @csantanapr > On May 12, 2016, at 5:00 PM, Steven Gill wrote: > > Excellent! I shall proceed. > > The website will also get updated when I do the release blog post. > > Cheers, >

[GitHub] cordova-medic pull request: Reorganized the config files and split...

2016-05-12 Thread riknoll
Github user riknoll commented on the pull request: https://github.com/apache/cordova-medic/pull/105#issuecomment-218884515 LGTM! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

Re: [DISCUSS] Cordova tools release

2016-05-12 Thread Steven Gill
Excellent! I shall proceed. The website will also get updated when I do the release blog post. Cheers, -Steve On Thu, May 12, 2016 at 12:52 PM, Mefire O. wrote: > Hey Steve, > Telemetry has been merged in! > We can move forward with the release process. > > We'll also

[GitHub] cordova-medic pull request: Reorganized the config files and split...

2016-05-12 Thread nikhilkh
Github user nikhilkh commented on the pull request: https://github.com/apache/cordova-medic/pull/105#issuecomment-218884348 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] cordova-medic pull request: Reorganized the config files and split...

2016-05-12 Thread sarangan12
GitHub user sarangan12 opened a pull request: https://github.com/apache/cordova-medic/pull/105 Reorganized the config files and split them for periodic and pr @rakatyal @riknoll @omefire @nikhilkh Can you please review and merge this PR? You can merge this pull request into a Git

[GitHub] cordova-windows pull request: Improving Windows build output and v...

2016-05-12 Thread jasongin
Github user jasongin commented on the pull request: https://github.com/apache/cordova-windows/pull/176#issuecomment-218882039 :shipit: --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] cordova-windows pull request: Improving Windows build output and v...

2016-05-12 Thread jasongin
Github user jasongin commented on a diff in the pull request: https://github.com/apache/cordova-windows/pull/176#discussion_r63094515 --- Diff: template/cordova/lib/build.js --- @@ -171,11 +171,11 @@ function parseAndValidateArgs(options) { // Validate args

[GitHub] cordova-android pull request: Improving Android build output and v...

2016-05-12 Thread jasongin
Github user jasongin commented on the pull request: https://github.com/apache/cordova-android/pull/305#issuecomment-218880614 :shipit: --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] cordova-lib pull request: Improving prepare and build output

2016-05-12 Thread jasongin
Github user jasongin commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/439#discussion_r63092520 --- Diff: cordova-lib/src/cordova/plugin.js --- @@ -286,7 +286,7 @@ module.exports = function plugin(command, targets, opts) {

RE: [DISCUSS] Cordova tools release

2016-05-12 Thread Mefire O .
Hey Steve, Telemetry has been merged in! We can move forward with the release process. We'll also have to initiate a docs/website release, as they host our privacy policy. Raghav will help with that. Thanks for your patience, All. Thanks, Omar Mefire -Original Message- From: Mefire O.

[GitHub] cordova-cli pull request: Telemetry

2016-05-12 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-cli/pull/247 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cordova-plugin-console pull request: Dummy Entry

2016-05-12 Thread cordova-qa
Github user cordova-qa commented on the pull request: https://github.com/apache/cordova-plugin-console/pull/18#issuecomment-218863809 Cordova CI Build has completed successfully. **Dashboard** - http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-console/90/

[GitHub] cordova-cli pull request: Telemetry

2016-05-12 Thread nikhilkh
Github user nikhilkh commented on the pull request: https://github.com/apache/cordova-cli/pull/247#issuecomment-218861698 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] cordova-plugin-console pull request: Dummy Entry

2016-05-12 Thread sarangan12
Github user sarangan12 commented on the pull request: https://github.com/apache/cordova-plugin-console/pull/18#issuecomment-218861888 Let there be tests --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] cordova-plugin-console pull request: Dummy Entry

2016-05-12 Thread cordova-qa
Github user cordova-qa commented on the pull request: https://github.com/apache/cordova-plugin-console/pull/18#issuecomment-218852418 Cordova CI Build has completed successfully. **Dashboard** - http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-console/88/

[GitHub] cordova-plugin-console pull request: Dummy Entry

2016-05-12 Thread sarangan12
Github user sarangan12 commented on the pull request: https://github.com/apache/cordova-plugin-console/pull/18#issuecomment-218849898 Let there be tests --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] cordova-plugin-console pull request: Dummy Entry

2016-05-12 Thread cordova-qa
Github user cordova-qa commented on the pull request: https://github.com/apache/cordova-plugin-console/pull/18#issuecomment-218849660 Cordova CI Build has completed successfully. **Dashboard** - http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-console/87/

[GitHub] cordova-plugin-console pull request: Dummy Entry

2016-05-12 Thread sarangan12
Github user sarangan12 commented on the pull request: https://github.com/apache/cordova-plugin-console/pull/18#issuecomment-218847802 Let there be tests --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] cordova-plugin-camera pull request: [CB-5195][CB-4078]: correctOri...

2016-05-12 Thread swbradshaw
Github user swbradshaw commented on the pull request: https://github.com/apache/cordova-plugin-camera/pull/197#issuecomment-218847324 @JEGardner Well, that's embarrassing. Check it out now and it should work for you. --- If your project is set up for it, you can reply to this

[GitHub] cordova-plugin-console pull request: Dummy Entry

2016-05-12 Thread cordova-qa
Github user cordova-qa commented on the pull request: https://github.com/apache/cordova-plugin-console/pull/18#issuecomment-218846731 Cordova CI Build has completed successfully. **Dashboard** - http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-console/86/

[GitHub] cordova-plugin-console pull request: Dummy Entry

2016-05-12 Thread sarangan12
Github user sarangan12 commented on the pull request: https://github.com/apache/cordova-plugin-console/pull/18#issuecomment-218844251 Let there be tests --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] cordova-plugin-console pull request: Dummy Entry

2016-05-12 Thread cordova-qa
Github user cordova-qa commented on the pull request: https://github.com/apache/cordova-plugin-console/pull/18#issuecomment-218843937 Cordova CI Build has completed successfully. **Dashboard** - http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-console/85/

[GitHub] cordova-plugin-console pull request: Dummy Entry

2016-05-12 Thread sarangan12
Github user sarangan12 commented on the pull request: https://github.com/apache/cordova-plugin-console/pull/18#issuecomment-218841092 Let there be tests --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] cordova-cli pull request: Telemetry

2016-05-12 Thread omefire
Github user omefire commented on a diff in the pull request: https://github.com/apache/cordova-cli/pull/247#discussion_r63066803 --- Diff: src/telemetry.js --- @@ -0,0 +1,122 @@ +/** +Licensed to the Apache Software Foundation (ASF) under one +or more

[GitHub] cordova-cli pull request: Telemetry

2016-05-12 Thread omefire
Github user omefire commented on a diff in the pull request: https://github.com/apache/cordova-cli/pull/247#discussion_r63066442 --- Diff: doc/cordova.txt --- @@ -5,6 +5,7 @@ Synopsis Global Commands create . Create a project help

[GitHub] cordova-cli pull request: Telemetry

2016-05-12 Thread nikhilkh
Github user nikhilkh commented on a diff in the pull request: https://github.com/apache/cordova-cli/pull/247#discussion_r63066156 --- Diff: doc/cordova.txt --- @@ -5,6 +5,7 @@ Synopsis Global Commands create . Create a project help

[GitHub] cordova-cli pull request: Telemetry

2016-05-12 Thread csantanapr
Github user csantanapr commented on the pull request: https://github.com/apache/cordova-cli/pull/247#issuecomment-218834713 Sounds good to me to proceed then, it was a random idea --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] cordova-cli pull request: Telemetry

2016-05-12 Thread omefire
Github user omefire commented on a diff in the pull request: https://github.com/apache/cordova-cli/pull/247#discussion_r63065751 --- Diff: doc/cordova.txt --- @@ -5,6 +5,7 @@ Synopsis Global Commands create . Create a project help

[GitHub] cordova-plugin-splashscreen pull request: CB-11179 Extend the wind...

2016-05-12 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-splashscreen/pull/101 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or

[GitHub] cordova-docs pull request: Update SQLite plugin details

2016-05-12 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-docs/pull/600 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cordova-windows pull request: Improving Windows build output and v...

2016-05-12 Thread riknoll
GitHub user riknoll opened a pull request: https://github.com/apache/cordova-windows/pull/176 Improving Windows build output and verbose logging Improving grammar, consistency of language, detail, etc. for verbose and regular output. Also made to more closely match the output of

[GitHub] cordova-plugin-splashscreen pull request: CB-11179 Extend the wind...

2016-05-12 Thread rakatyal
Github user rakatyal commented on the pull request: https://github.com/apache/cordova-plugin-splashscreen/pull/101#issuecomment-218829510 LGTM. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] cordova-cli pull request: Telemetry

2016-05-12 Thread omefire
Github user omefire commented on the pull request: https://github.com/apache/cordova-cli/pull/247#issuecomment-218826259 I first wanted to go that route, but I then realized doing it in CLI minimizes polluting LIB for a functionality that's not intended to be used by downstream

[GitHub] cordova-lib pull request: CB-11023 Add attribute through config-fi...

2016-05-12 Thread macdonst
Github user macdonst commented on the pull request: https://github.com/apache/cordova-lib/pull/432#issuecomment-218824969 @stevengill it was working pretty good last I checked. With the config.xml stuff in it should be ready to go. I've earmarked some time tomorrow to do my testing.

[GitHub] cordova-plugin-inappbrowser pull request: Enable thirdparty cookie...

2016-05-12 Thread bradleyjames
Github user bradleyjames commented on the pull request: https://github.com/apache/cordova-plugin-inappbrowser/pull/165#issuecomment-218823372 Looks like this is enabling them by default, right? Being an app owner I'd prefer to be in control of that. --- If your project is set up

[GitHub] cordova-cli pull request: Telemetry

2016-05-12 Thread nikhilkh
Github user nikhilkh commented on a diff in the pull request: https://github.com/apache/cordova-cli/pull/247#discussion_r63056874 --- Diff: src/telemetry.js --- @@ -0,0 +1,122 @@ +/** +Licensed to the Apache Software Foundation (ASF) under one +or more

[GitHub] cordova-cli pull request: Telemetry

2016-05-12 Thread nikhilkh
Github user nikhilkh commented on a diff in the pull request: https://github.com/apache/cordova-cli/pull/247#discussion_r63056532 --- Diff: doc/cordova.txt --- @@ -5,6 +5,7 @@ Synopsis Global Commands create . Create a project help

[GitHub] cordova-plugin-camera pull request: [CB-5195][CB-4078]: correctOri...

2016-05-12 Thread JEGardner
Github user JEGardner commented on the pull request: https://github.com/apache/cordova-plugin-camera/pull/197#issuecomment-218812059 This didn't compile for me. See error:

[GitHub] cordova-cli pull request: Telemetry

2016-05-12 Thread purplecabbage
Github user purplecabbage commented on the pull request: https://github.com/apache/cordova-cli/pull/247#issuecomment-218808479 Other CLIs that use lib (as a lib) would not want this code. Off by default is interesting, but I think this is cleaner, and it's done. > On May 12,

[GitHub] cordova-plugin-inappbrowser pull request: Enable thirdparty cookie...

2016-05-12 Thread cmeredith
Github user cmeredith commented on the pull request: https://github.com/apache/cordova-plugin-inappbrowser/pull/165#issuecomment-218802239 +1 and THANK YOU! Fix works perfectly! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] cordova-plugin-splashscreen pull request: CB-11179 Extend the wind...

2016-05-12 Thread daserge
Github user daserge commented on the pull request: https://github.com/apache/cordova-plugin-splashscreen/pull/101#issuecomment-218784365 @rakatyal, addressed, please take a look. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] cordova-labs pull request: CB-10974 Cordova file transfer Content-...

2016-05-12 Thread daserge
Github user daserge commented on the pull request: https://github.com/apache/cordova-labs/pull/13#issuecomment-218773090 @riknoll, could you please update the server so that https://github.com/apache/cordova-plugin-file-transfer/pull/141 could be merged? --- If your project is set

[GitHub] cordova-labs pull request: CB-10974 Cordova file transfer Content-...

2016-05-12 Thread daserge
Github user daserge commented on the pull request: https://github.com/apache/cordova-labs/pull/13#issuecomment-218772052 Merged in https://github.com/apache/cordova-labs/commit/b10c5dbe731a30eb4f5af93631684eccd18c45f4 --- If your project is set up for it, you can reply to this email

[GitHub] cordova-labs pull request: CB-10974 Cordova file transfer Content-...

2016-05-12 Thread daserge
Github user daserge closed the pull request at: https://github.com/apache/cordova-labs/pull/13 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cordova-plugin-splashscreen pull request: CB-11156 Change default ...

2016-05-12 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-splashscreen/pull/99 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or

[GitHub] cordova-windows pull request: CB-11156 Change default FadeSplashSc...

2016-05-12 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-windows/pull/170 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] cordova-cli pull request: Telemetry

2016-05-12 Thread csantanapr
Github user csantanapr commented on the pull request: https://github.com/apache/cordova-cli/pull/247#issuecomment-218715695 I have one question, maybe I missed it in discussion why is this implemented in CLI and not LIB I think it make more sense to implement in the top level

[GitHub] cordova-cli pull request: CB-11250 Fix CLI tests verifying the ver...

2016-05-12 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-cli/pull/249 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cordova-docs pull request: Update SQLite plugin details

2016-05-12 Thread brodybits
Github user brodybits commented on the pull request: https://github.com/apache/cordova-docs/pull/600#issuecomment-218708663 The updates look good to me, thanks! FYI I dropped the Cordova engine constraint on Cordova-sqlite-storage. --- If your project is set up for it, you

[GitHub] cordova-plugin-battery-status pull request: CB-11256 (was Fix due ...

2016-05-12 Thread david-barth-canonical
Github user david-barth-canonical closed the pull request at: https://github.com/apache/cordova-plugin-battery-status/pull/35 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] cordova-plugin-battery-status pull request: CB-11256 (was Fix due ...

2016-05-12 Thread david-barth-canonical
GitHub user david-barth-canonical opened a pull request: https://github.com/apache/cordova-plugin-battery-status/pull/35 CB-11256 (was Fix due to Qt SystemInfo API updates) You can merge this pull request into a Git repository by running: $ git pull

Re: Cordova Monthly Hangouts

2016-05-12 Thread Shazron
+1 On Wed, May 11, 2016 at 12:50 PM, Steven Gill wrote: > A hangout sounds good. We need to pick a date and time. Should I send out a > doodle? > > For me personally, I won't be able to attend until the first week of June > due to PGDAY EU travels. > > On Tue, May 10,

[GitHub] cordova-plugin-file-transfer pull request: Insert Content-Type to ...

2016-05-12 Thread Belkar
Github user Belkar commented on the pull request: https://github.com/apache/cordova-plugin-file-transfer/pull/139#issuecomment-218685783 Could you please merge this pull request? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] cordova-lib pull request: Improving prepare and build output

2016-05-12 Thread vladimir-kotikov
Github user vladimir-kotikov commented on the pull request: https://github.com/apache/cordova-lib/pull/439#issuecomment-218672448 LGTM :+1: --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have