Nightly build #182 for cordova has failed

2016-10-18 Thread Apache Jenkins Server
Nightly build #182 for cordova has failed. Please check failure details on build details page at https://builds.apache.org/job/cordova-nightly/182/ You can also take a look at build console: https://builds.apache.org/job/cordova-nightly/182/consoleFull - Jenkins for Apache Cordova

Re: Apple rebrands OSX to macOS - should we follow suit?

2016-10-18 Thread Steven Gill
We can also add a alias for cordova platform add macos that adds OSX On Oct 18, 2016 6:10 PM, "Tobias Bocanegra" wrote: > Hi, > > with the sierra update, Apple renamed OS X to macOS. I don't think we > should rename the platform name to macOS, but maybe some prefixes in >

[GitHub] cordova-plugin-media issue #116: CB-11817: (iOS) Fix unused recording settin...

2016-10-18 Thread ghenry22
Github user ghenry22 commented on the issue: https://github.com/apache/cordova-plugin-media/pull/116 @shazron any chance this could get merged? It's a really small change that basically just fixes an oversight in the current version, which makes recording much more efficient and

Apple rebrands OSX to macOS - should we follow suit?

2016-10-18 Thread Tobias Bocanegra
Hi, with the sierra update, Apple renamed OS X to macOS. I don't think we should rename the platform name to macOS, but maybe some prefixes in config.xml ? We could rename the OSX component in jira, though; people repeatedly report build-problems they encounter on a mac. but again. no biggy.

[GitHub] cordova-lib issue #504: CB-11979 added deprecation warning for subdirectorie...

2016-10-18 Thread codecov-io
Github user codecov-io commented on the issue: https://github.com/apache/cordova-lib/pull/504 ## [Current coverage](https://codecov.io/gh/apache/cordova-lib/pull/504?src=pr) is 80.62% (diff: 100%) > Merging [#504](https://codecov.io/gh/apache/cordova-lib/pull/504?src=pr) into

[GitHub] cordova-lib pull request #504: CB-11979 added deprecation warning for subdir...

2016-10-18 Thread stevengill
Github user stevengill commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/504#discussion_r83974505 --- Diff: cordova-lib/src/plugman/fetch.js --- @@ -70,6 +70,10 @@ function fetchPlugin(plugin_src, plugins_dir, options) { //if

[GitHub] cordova-lib pull request #504: CB-11979 added deprecation warning for subdir...

2016-10-18 Thread stevengill
Github user stevengill commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/504#discussion_r83974283 --- Diff: cordova-lib/src/plugman/fetch.js --- @@ -70,6 +70,10 @@ function fetchPlugin(plugin_src, plugins_dir, options) { //if

Re: [ANDROID] [XWalk] Crosswalk Webview Device Ready does not fire on Master

2016-10-18 Thread Steven Gill
Good work guys! On Tue, Oct 18, 2016 at 3:30 PM, Darryl Pogue wrote: > I've opened a PR to add that bridge mode: > https://github.com/crosswalk-project/cordova-plugin- > crosswalk-webview/pull/100 > > On 18 October 2016 at 15:23, Joe Bowser wrote: > >

[GitHub] cordova-lib pull request #504: CB-11979 added deprecation warning for subdir...

2016-10-18 Thread sterlingann
GitHub user sterlingann opened a pull request: https://github.com/apache/cordova-lib/pull/504 CB-11979 added deprecation warning for subdirectories ### Platforms affected all ### What does this PR do? warns of deprecation of subdirectories in

Re: [ANDROID] [XWalk] Crosswalk Webview Device Ready does not fire on Master

2016-10-18 Thread Darryl Pogue
I've opened a PR to add that bridge mode: https://github.com/crosswalk-project/cordova-plugin-crosswalk-webview/pull/100 On 18 October 2016 at 15:23, Joe Bowser wrote: > BTW: I'd send a PR, but I still need Crosswalk to take over the repo from > me, since they're developing

[GitHub] cordova-plugin-inappbrowser issue #101: CB-8467 provide hide method to hide ...

2016-10-18 Thread cordova-qa
Github user cordova-qa commented on the issue: https://github.com/apache/cordova-plugin-inappbrowser/pull/101 Cordova CI Build has one or more failures. **Commit** -

Re: [ANDROID] [XWalk] Crosswalk Webview Device Ready does not fire on Master

2016-10-18 Thread Joe Bowser
BTW: I'd send a PR, but I still need Crosswalk to take over the repo from me, since they're developing off a fork of my repo. https://github.com/crosswalk-project/cordova-plugin-crosswalk-webview On Tue, Oct 18, 2016 at 3:08 PM, Joe Bowser wrote: > Hey > > I just realized

[GitHub] cordova-plugin-inappbrowser issue #101: CB-8467 provide hide method to hide ...

2016-10-18 Thread jcesarmobile
Github user jcesarmobile commented on the issue: https://github.com/apache/cordova-plugin-inappbrowser/pull/101 let there be tests --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] cordova-ios issue #269: CB-12002 - Support LSApplicationQueriesSchemes

2016-10-18 Thread jcesarmobile
Github user jcesarmobile commented on the issue: https://github.com/apache/cordova-ios/pull/269 We where using canOpenURL on inAppBrowser plugin, but I removed it to fix CB-11178 as we weren't really sending any response to the user if canOpenURL was false. I don't think

Re: [ANDROID] [XWalk] Crosswalk Webview Device Ready does not fire on Master

2016-10-18 Thread Joe Bowser
Hey I just realized what the problem is: Crosswalk is missing this method, which adds the bridge mode, since the bridge mode defaults back ONLINE_EVENT in the event that EVAL_BRIDGE isn't supported, this will break every time. We need the following line added to Crosswalk.

Re: [ANDROID] [XWalk] Crosswalk Webview Device Ready does not fire on Master

2016-10-18 Thread Joe Bowser
Correct. Without that method, it won't even compile. On Tue, Oct 18, 2016 at 2:31 PM, Darryl Pogue wrote: > On 18 October 2016 at 14:24, Joe Bowser wrote: > > Recently, we decided to change the default bridge from using OnlineEvent > to > > a JS_Exec

Re: [ANDROID] [XWalk] Crosswalk Webview Device Ready does not fire on Master

2016-10-18 Thread Darryl Pogue
On 18 October 2016 at 14:24, Joe Bowser wrote: > Recently, we decided to change the default bridge from using OnlineEvent to > a JS_Exec bridge so that we can support a multi-webview use case. The > downside of this change is that it breaks on Crosswalk. It's almost >

[GitHub] cordova-ios issue #269: CB-12002 - Support LSApplicationQueriesSchemes

2016-10-18 Thread shazron
Github user shazron commented on the issue: https://github.com/apache/cordova-ios/pull/269 So if they use `canOpenURL` they need this, but if they just use `openURL`, like our whitelist system, we don't. Therefore I believe our whitelist system with `` does not need these keys. ---

[ANDROID] [XWalk] Crosswalk Webview Device Ready does not fire on Master

2016-10-18 Thread Joe Bowser
Hey Recently, we decided to change the default bridge from using OnlineEvent to a JS_Exec bridge so that we can support a multi-webview use case. The downside of this change is that it breaks on Crosswalk. It's almost impossible to debug this since projects that include the Crosswalk Webview

[GitHub] cordova-ios issue #269: CB-12002 - Support LSApplicationQueriesSchemes

2016-10-18 Thread dpogue
Github user dpogue commented on the issue: https://github.com/apache/cordova-ios/pull/269 hmm, I think in our case we were trying to use canOpenURL to see if a partner app was able to launch and redirect to the store otherwise. This also came up in the Slack channel recently, and

[GitHub] cordova-ios issue #269: CB-12002 - Support LSApplicationQueriesSchemes

2016-10-18 Thread shazron
Github user shazron commented on the issue: https://github.com/apache/cordova-ios/pull/269 Yeah looks like openURL does not need the key: https://developer.apple.com/reference/uikit/uiapplication/1622952-canopenurl (see last paragraph -- it has a typo, UIDefaultLaunchStoryboard

Fwd: Help Needed - Cordova Build Issues

2016-10-18 Thread musunuru srideep
Hi We were using Cordova 5.2.2 - Any Help was Appreciated. Running "Cordova Build Android --debug --gradle". Throws below Error. *11:52:37* Incremental java compilation is an incubating feature.*11:52:38* *11:52:38* FAILURE: Build failed with an exception.*11:52:38* *11:52:38* * What went

[GitHub] cordova-plugin-inappbrowser issue #101: CB-8467 provide hide method to hide ...

2016-10-18 Thread cordova-qa
Github user cordova-qa commented on the issue: https://github.com/apache/cordova-plugin-inappbrowser/pull/101 Cordova CI Build has one or more failures. **Commit** -

Re: Help Needed - Cordova Build Issues

2016-10-18 Thread Steven Gill
post your message at https://forums.adobe.com/community/phonegap On Tue, Oct 18, 2016 at 9:52 AM, musunuru srideep wrote: > Hi > > We were using Cordova 5.2.2 - Any Help was Appreciated. > > Running "Cordova Build Android --debug --gradle". Throws below Error. > > >

Help Needed - Cordova Build Issues

2016-10-18 Thread musunuru srideep
Hi We were using Cordova 5.2.2 - Any Help was Appreciated. Running "Cordova Build Android --debug --gradle". Throws below Error. *11:52:37* Incremental java compilation is an incubating feature.*11:52:38* *11:52:38* FAILURE: Build failed with an exception.*11:52:38* *11:52:38* * What went

[GitHub] cordova-plugin-inappbrowser pull request #192: CB-12020 Android and iOS: add...

2016-10-18 Thread sfrank87
Github user sfrank87 closed the pull request at: https://github.com/apache/cordova-plugin-inappbrowser/pull/192 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so,

[GitHub] cordova-plugin-inappbrowser issue #101: CB-8467 provide hide method to hide ...

2016-10-18 Thread herrevilkitten
Github user herrevilkitten commented on the issue: https://github.com/apache/cordova-plugin-inappbrowser/pull/101 @sfrank87 @DigitalSkyline conflicts de-conflicts, checks passed --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] cordova-plugin-inappbrowser issue #101: CB-8467 provide hide method to hide ...

2016-10-18 Thread herrevilkitten
Github user herrevilkitten commented on the issue: https://github.com/apache/cordova-plugin-inappbrowser/pull/101 Sure I can fix the conflicts. It's ... been a while --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] cordova-windows issue #196: Fix setSplashBgColor exception when no splashscr...

2016-10-18 Thread giuseppelt
Github user giuseppelt commented on the issue: https://github.com/apache/cordova-windows/pull/196 This patch doesn't touch nothing, nor alter the manifest. It's just a logic check, because the previous code assumes the node is always found. The code simply is `if (node !=

[DISCUSS] Cordova-Windows Release

2016-10-18 Thread Sergey Shakhnazarov (Akvelon)
Does anyone have any reason to delay a cordova-windows platform release? Any outstanding patches to land? If not, I will start the release tomorrow. Best regards, Sergey Shakhnazarov.

[GitHub] cordova-windows issue #196: Fix setSplashBgColor exception when no splashscr...

2016-10-18 Thread daserge
Github user daserge commented on the issue: https://github.com/apache/cordova-windows/pull/196 That link is for Windows Phone 8 while cordova-windows is for Windows 8.1 / Windows Phone 8.1 and up. In general the patch could be applicable for Windows 10 appxmanifest as

[GitHub] cordova-windows issue #196: Fix setSplashBgColor exception when no splashscr...

2016-10-18 Thread giuseppelt
Github user giuseppelt commented on the issue: https://github.com/apache/cordova-windows/pull/196 Schema is incorrect or old. According to https://msdn.microsoft.com/en-us/library/windows/apps/ff769511(v=vs.105).aspx splashscreen isn't required nor it's provided in the

[GitHub] cordova-windows issue #196: Fix setSplashBgColor exception when no splashscr...

2016-10-18 Thread daserge
Github user daserge commented on the issue: https://github.com/apache/cordova-windows/pull/196 Looks like SplashScreen node is required according to the [schema](https://msdn.microsoft.com/en-us/library/windows/apps/br211471.aspx). --- If your project is set up for it, you can reply

[GitHub] cordova-docs pull request #651: CB-12030: (ios) Replace invalid iOS docs lin...

2016-10-18 Thread pbakondy
GitHub user pbakondy opened a pull request: https://github.com/apache/cordova-docs/pull/651 CB-12030: (ios) Replace invalid iOS docs link ### Platforms affected iOS ### What does this PR do? fixes an invalid link ### What testing has been done on

[GitHub] cordova-plugin-inappbrowser issue #101: CB-8467 provide hide method to hide ...

2016-10-18 Thread sfrank87
Github user sfrank87 commented on the issue: https://github.com/apache/cordova-plugin-inappbrowser/pull/101 Hi, I am interested in this functionality, too. It’s a pity, it never found its way to the upstream repository. :/ Could you please solve the merge conflicts? That

[GitHub] cordova-android issue #342: CB-12028: (android) update distributionUrl , cur...

2016-10-18 Thread codecov-io
Github user codecov-io commented on the issue: https://github.com/apache/cordova-android/pull/342 ## [Current coverage](https://codecov.io/gh/apache/cordova-android/pull/342?src=pr) is 35.21% (diff: 100%) > Merging

[GitHub] cordova-android pull request #342: CB-12028: (android) update distributionUr...

2016-10-18 Thread hye
GitHub user hye opened a pull request: https://github.com/apache/cordova-android/pull/342 CB-12028: (android) update distributionUrl , current return `403` ### Platforms affected cordova-android ### What does this PR do? ### What testing has been done on this