Re: New Android Preference

2018-04-20 Thread Steven Gill
Let's do it. On Fri, Apr 20, 2018, 2:29 PM julio cesar sanchez wrote: > Yeah, having the plugin as dependency should be enough, but as Simon said, > as a lot of plugins will need this, makes sense to add it to the platform > > El viernes, 20 de abril de 2018, Jesse

Nightly build #696 for cordova has succeeded!

2018-04-20 Thread Apache Jenkins Server
Nightly build #696 for cordova has succeeded! The latest nightly has been published and you can try it out with 'npm i -g cordova@nightly' For details check build console at https://builds.apache.org/job/cordova-nightly/696/consoleFull - Jenkins for Apache Cordova

Re: New Android Preference

2018-04-20 Thread julio cesar sanchez
Yeah, having the plugin as dependency should be enough, but as Simon said, as a lot of plugins will need this, makes sense to add it to the platform El viernes, 20 de abril de 2018, Jesse escribió: > So instead of plugin authors including gradle files, they would just

Re: New Android Preference

2018-04-20 Thread Jesse
So instead of plugin authors including gradle files, they would just add the to the plugin.xml and be done? I assume this requires a platform update. Do we miss anything from not including a version as in way? If we just ask plugin authors to add a dependency on cordova-support-google-services

Re: New Android Preference

2018-04-20 Thread Thomas Brian
Wouldn't it be possible to have a more generic solution to handle gradle plugins in general, rather than Google Service specifically ? Perhaps something similar to the tag in config.xml that is used to add libraries? I ran into a somewhat related issue with Firebase Crashlytics where the

Re: New Android Preference

2018-04-20 Thread Simon MacDonald
No, I thought I'd start a discussion first. Simon Mac Donald http://simonmacdonald.com On Fri, Apr 20, 2018 at 3:41 PM, Joe Bowser wrote: > Is there a PR ready for this to land? > > On Fri, Apr 20, 2018 at 12:04 PM, Simon MacDonald < > simon.macdon...@gmail.com > > wrote: >

Re: New Android Preference

2018-04-20 Thread Joe Bowser
Is there a PR ready for this to land? On Fri, Apr 20, 2018 at 12:04 PM, Simon MacDonald wrote: > Hey all, > > I'd like to suggest that we add a new Android preference. It would be a > boolean preference, to control whether or not to run the Google Services > Plugin.

Re: New Android Preference

2018-04-20 Thread julio cesar sanchez
+1 El viernes, 20 de abril de 2018, Simon MacDonald escribió: > Hey all, > > I'd like to suggest that we add a new Android preference. It would be a > boolean preference, to control whether or not to run the Google Services > Plugin. > > A number of plugins need to

New Android Preference

2018-04-20 Thread Simon MacDonald
Hey all, I'd like to suggest that we add a new Android preference. It would be a boolean preference, to control whether or not to run the Google Services Plugin. A number of plugins need to have this gradle plugin run during build time and they are handling it via a gradle file included in their

Re: [DISCUSS] [Play Services Version]

2018-04-20 Thread Simon MacDonald
Yeah, I'm seeing that issue as well. In order to have the change take affect I need to remove the plugin and add it back in using the CLI to pass in the variable. Simon Mac Donald http://simonmacdonald.com On Sun, Apr 15, 2018 at 5:16 PM, julio cesar sanchez wrote: >