I think this PR
https://github.com/apache/cordova-plugin-inappbrowser/pull/271 should
basically do what needs to be done to support both webviews. I haven´t
tested this version yet, but it looks like Dave has done a great job
for supporting WKwebview alongside UIWebview.
The main issues we had
Nightly build #771 for cordova has succeeded!
The latest nightly has been published and you can try it out with 'npm i -g
cordova@nightly'
For details check build console at
https://builds.apache.org/job/cordova-nightly/771/consoleFull
-
Jenkins for Apache Cordova
-
Thanks Niklas,
Since you know what needs to be done or has been done with respect to
InAppBrowser - can you highlight any specific tasks or PRs that need to be
pulled in for IAB? I probably can't focus on getting anything except
WKWebView support for InAppBrowser this week (if I have the bandwidth,
That sounds great. Please don't forget InAppBrowser. I worked in getting
WKwebview running in InAppBrowser a while ago and I happy to help, review and
test these changes . Dave Alden did a good pull request on this.
I flag like this sounds like a good way to test this in our app.
Am 3. Juli 201
I was thinking that the feature flag is just a convenience feature for
setting/removing (depends on if the flag is set/omitted):
in
config.xml
So something like this:
`cordova platform add ios --wkwebview` or something to that effect.
My thinking is -- this would make manual testing easier, and
Thanks Shazron!
Regarding point 3 on your list, does that need to be a feature flag
since the WebView engine is already controlled via a preference in
config.xml? People should be able to opt-in that way just by adding a
preference, and then in a future release we just change the default
value for
Thanks Darryl,
I'll be working on getting the WKWebView plugin up to snuff this week (read
the comment thread in your doc).
1. Review and resolve all existing PRs
2. Integrate the WKWebView plugin into the cordova-ios repo
3. Turn on WKWebView support via a feature flag (eventually this will be
the
The vote has now closed. I would like to thank Jesse MacFadyen and
Shazron Abdullah for taking the time to review and vote. The results
are:
Positive Binding Votes: 3
- Jesse MacFadyen
- Shazron Abdullah
- Christopher Brody
Negative Binding Votes: 0
The vote has passed.
On Fri, Jun 29, 2018 at 1
